logstash-integration-snmp 4.3.0-java → 4.3.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 83e4f7e4d6dbba653ef3de8662d2d8d0c78fa5b690482d39a276061ac9c6889c
-  data.tar.gz: 4454382e046d542df2f34aadc5d41586f5c9e813fe560782e10f7ef42212a4ec
+  metadata.gz: 00b54144b7fb2f7a2504757c195376ea69d30baf878855007afb969f9c6bb372
+  data.tar.gz: 6f8f31cdf110ce9a2b16d632efe00ad888e1145d4dbbce739b885f74a618149a
 SHA512:
-  metadata.gz: 2dcc0cc28a4fad102391877207ff623c49851de0539123e9b9b58fb76449714cb31e655628c63c535089a6c26961be7cf33eb508aa9c80a4214b99a7524bb89f
-  data.tar.gz: a077b38b4357d6882a181ea95df1a87b205e284f7903d8f3b342b7a383b17e5c596a0e060ed9feeba37404f536de436c86d2597e7d7f33faed6217a632e8ca4e
+  metadata.gz: c7262768b0db4a1ccee95e57f979813652860e2ccd3cbc7bde0d3d945216a36d0c6b0a539db5d790be05f0100f9f29713106c1e9acca41be0eebdf0d2d063871
+  data.tar.gz: 94c9a90d25ccf4da3008433c9fb45e001402415a060a26d9d9bb8833bae1a8c29a9303b99eccd26854b743d9680aa8dc7c466fc4b42bc28825dc4a9a4e85d365

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 4.3.1
+  - Fix: generate error events with _snmpfailure tag when all SNMP operations fail and the response data is empty (e.g., timeout) [#92](https://github.com/logstash-plugins/logstash-integration-snmp/pull/92)
+
 ## 4.3.0
   - Handle partial responses and errors gracefully: add `tag_on_failure` (default: `["_snmpfailure"]`) to tag events when SNMP operations fail, and `allow_partial_response` (default: `false`) to preserve partial data from failed `walk`/`table` operations [#91](https://github.com/logstash-plugins/logstash-integration-snmp/pull/91)
 

data/VERSION

@@ -1 +1 @@
-4.3.0
+4.3.1

data/lib/logstash/inputs/snmp.rb

@@ -195,7 +195,7 @@ class LogStash::Inputs::Snmp < LogStash::Inputs::Base
       definition = req[:definition]
       result_consumer = lambda do |request_result|
         result = request_result.data
-        if result&.any?
+        if result&.any? || request_result.has_errors
           event = targeted_event_factory.new_event(result)
           event.set(@host_protocol_field, definition[:host_protocol])
           event.set(@host_address_field, definition[:host_address])

data/lib/logstash-integration-snmp_jars.rb

@@ -4,4 +4,4 @@ require 'jar_dependencies'
 require_jar('org.snmp4j', 'snmp4j-log4j', '2.8.11')
 require_jar('org.snmp4j', 'snmp4j', '3.8.0')
 require_jar('org.snakeyaml', 'snakeyaml-engine', '2.7')
-require_jar('org.logstash.integrations', 'plugin', '4.3.0')
+require_jar('org.logstash.integrations', 'plugin', '4.3.1')

data/spec/unit/inputs/snmp_spec.rb

@@ -342,21 +342,41 @@ describe LogStash::Inputs::Snmp, :ecs_compatibility_support do
         })
       end
 
-      before(:each) do
-        expect(mock_aggregator_request).to receive(:get)
-        expect(mock_aggregator_request).to receive(:get_result_async) do |consumer|
-          consumer.call(RequestResult.new({ 'foo' => 'bar' }, true))
+      context 'when result data is not empty' do
+        before(:each) do
+          expect(mock_aggregator_request).to receive(:get)
+          expect(mock_aggregator_request).to receive(:get_result_async) do |consumer|
+            consumer.call(RequestResult.new({ 'foo' => 'bar' }, true))
+          end
+        end
+
+        it 'should tag event with default failure tag' do
+          plugin.register
+          plugin.poll_clients(queue)
+          event = queue.pop
+
+          expect(event.get("foo")).to eq("bar")
+          expect(event.get("tags")).to include("_snmpfailure")
+          expect(event.get("_snmp_request_errors")).to be_nil
         end
       end
 
-      it 'should tag event with default failure tag' do
-        plugin.register
-        plugin.poll_clients(queue)
-        event = queue.pop
+      context 'when result data is empty' do
+        before(:each) do
+          expect(mock_aggregator_request).to receive(:get)
+          expect(mock_aggregator_request).to receive(:get_result_async) do |consumer|
+            consumer.call(RequestResult.new({}, true))
+          end
+        end
 
-        expect(event.get("foo")).to eq("bar")
-        expect(event.get("tags")).to include("_snmpfailure")
-        expect(event.get("_snmp_request_errors")).to be_nil
+        it 'should generate an event with failure tag when all operations fail' do
+          plugin.register
+          plugin.poll_clients(queue)
+          event = queue.pop
+
+          expect(event).not_to be_nil
+          expect(event.get("tags")).to include("_snmpfailure")
+        end
       end
     end
 
@@ -364,41 +384,32 @@ describe LogStash::Inputs::Snmp, :ecs_compatibility_support do
       let(:config) do
         super().merge({
           'get' => ['1.3.6.1.2.1.1.1.0'],
-          'hosts' => [{ 'host' => 'udp:127.0.0.1/161', 'community' => 'public' }],
-          'allow_partial_response' => allow_partial_response_value
+          'hosts' => [{ 'host' => 'udp:127.0.0.1/161', 'community' => 'public' }]
         })
       end
 
       before(:each) do
-        expect(mock_aggregator_request).to receive(:get)
-        expect(mock_aggregator_request).to receive(:get_result_async) do |consumer|
-          consumer.call(RequestResult.new({ 'partial' => 'data' }, true))
-        end
+        allow(mock_aggregator_request).to receive(:get)
+        allow(mock_aggregator_request).to receive(:get_result_async)
       end
 
       context 'when set to false (default)' do
-        let(:allow_partial_response_value) { false }
+        let(:config) { super().merge('allow_partial_response' => false) }
 
-        it 'tags event and preserves data from successful operations' do
+        it 'uses complete result aggregator' do
+          expect(mock_aggregator).to receive(:create_request_for_complete_result).and_return(mock_aggregator_request)
           plugin.register
           plugin.poll_clients(queue)
-          event = queue.pop
-
-          expect(event.get("partial")).to eq("data")
-          expect(event.get("tags")).to include("_snmpfailure")
         end
       end
 
       context 'when set to true' do
-        let(:allow_partial_response_value) { true }
+        let(:config) { super().merge('allow_partial_response' => true) }
 
-        it 'tags event and preserves data including partial results' do
+        it 'uses partial result aggregator' do
+          expect(mock_aggregator).to receive(:create_request_for_partial_result).and_return(mock_aggregator_request)
           plugin.register
           plugin.poll_clients(queue)
-          event = queue.pop
-
-          expect(event.get("partial")).to eq("data")
-          expect(event.get("tags")).to include("_snmpfailure")
         end
       end
     end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: logstash-integration-snmp
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.3.1
 platform: java
 authors:
 - Elastic
 bindir: bin
 cert_chain: []
-date: 2026-05-19 00:00:00.000000000 Z
+date: 2026-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logstash-core-plugin-api
@@ -468,7 +468,7 @@ files:
 - spec/unit/inputs/common_spec.rb
 - spec/unit/inputs/snmp_spec.rb
 - spec/unit/inputs/snmptrap_spec.rb
-- vendor/jar-dependencies/org/logstash/integrations/plugin/4.3.0/plugin-4.3.0.jar
+- vendor/jar-dependencies/org/logstash/integrations/plugin/4.3.1/plugin-4.3.1.jar
 - vendor/jar-dependencies/org/snakeyaml/snakeyaml-engine/2.7/snakeyaml-engine-2.7.jar
 - vendor/jar-dependencies/org/snmp4j/snmp4j-log4j/2.8.11/snmp4j-log4j-2.8.11.jar
 - vendor/jar-dependencies/org/snmp4j/snmp4j/3.8.0/snmp4j-3.8.0.jar