logstash-integration-logstash 0.0.5-java → 1.0.1-java

data/spec/unit/logstash_output_spec.rb

@@ -9,6 +9,11 @@ describe LogStash::Outputs::Logstash do
   let(:config) {{ "hosts" => "127.0.0.1" }}
 
   subject(:plugin) { LogStash::Outputs::Logstash.new(config) }
+  let(:registered_plugin) { plugin.tap(&:register) }
+
+  let(:event) {
+    LogStash::Event.new({"message" => "Sending my hello to upstream input"})
+  }
 
   describe "a plugin class" do
     subject { described_class }
@@ -16,6 +21,7 @@ describe LogStash::Outputs::Logstash do
     it { is_expected.to be_a_kind_of Class }
     it { is_expected.to be <= LogStash::Outputs::Base }
     it { is_expected.to have_attributes(:config_name => "logstash") }
+    it { is_expected.to have_attributes(:concurrency => :shared) }
   end
 
   describe "a plugin instance with minimal config" do
@@ -28,19 +34,22 @@ describe LogStash::Outputs::Logstash do
   end
 
   describe "plugin register" do
-    let(:registered_plugin) { plugin.tap(&:register) }
 
     describe "construct host URI" do
 
       it "applies default https scheme and 9800 port" do
-        expect(registered_plugin.construct_host_uri.eql?(::LogStash::Util::SafeURI.new("https://127.0.0.1:9800/"))).to be_truthy
+        normalized_hosts = registered_plugin.send(:normalize_host_uris)
+        expect(normalized_hosts).to have_attributes(:size => 1)
+        expect(normalized_hosts.first).to eql("https://127.0.0.1:9800")
       end
 
       describe "SSL disabled" do
         let(:config) { super().merge("ssl_enabled" => false) }
 
         it "causes HTTP scheme" do
-          expect(registered_plugin.construct_host_uri.eql?(::LogStash::Util::SafeURI.new("http://127.0.0.1:9800/"))).to be_truthy
+          normalized_hosts = registered_plugin.send(:normalize_host_uris)
+          expect(normalized_hosts).to have_attributes(:size => 1)
+          expect(normalized_hosts.first).to eql("http://127.0.0.1:9800")
         end
       end
 
@@ -48,7 +57,9 @@ describe LogStash::Outputs::Logstash do
         let(:config) { super().merge("hosts" => "127.0.0.1:9808") }
 
         it "will be applied" do
-          expect(registered_plugin.construct_host_uri.eql?(::LogStash::Util::SafeURI.new("https://127.0.0.1:9808/"))).to be_truthy
+          normalized_hosts = registered_plugin.send(:normalize_host_uris)
+          expect(normalized_hosts).to have_attributes(:size => 1)
+          expect(normalized_hosts.first).to eql("https://127.0.0.1:9808")
         end
       end
     end
@@ -61,7 +72,7 @@ describe LogStash::Outputs::Logstash do
 
         it "requires `password`" do
           expected_message = "`password` is REQUIRED when `username` is provided"
-          expect{ plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
+          expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
         end
       end
 
@@ -95,15 +106,15 @@ describe LogStash::Outputs::Logstash do
         let(:config) { super().merge("ssl_certificate" => cert_fixture!('server_from_root.pem')) }
 
         it "requires `ssl_key`" do
-          expected_message = '`ssl_key` is REQUIRED when `ssl_certificate` is provided'
+          expected_message = "`ssl_key` is REQUIRED when `ssl_certificate` is provided"
           expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
         end
 
         context "with keystore" do
-          let(:config) { super().merge("ssl_keystore_path" => cert_fixture!('client_from_root.jks')) }
+          let(:config) { super().merge("ssl_keystore_path" => cert_fixture!("client_from_root.jks"), "ssl_key" => cert_fixture!("server_from_root.key.pem")) }
 
           it "cannot be used together" do
-            expected_message = 'SSL identity can be configured with EITHER `ssl_certificate` OR `ssl_keystore_*`, but not both'
+            expected_message = "SSL identity can be configured with EITHER `ssl_certificate` OR `ssl_keystore_*`, but not both"
             expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
           end
         end
@@ -122,7 +133,7 @@ describe LogStash::Outputs::Logstash do
         let(:config) { super().merge("ssl_keystore_path" => cert_fixture!('server_from_root.jks')) }
 
         it "requires `ssl_keystore_password`" do
-          expected_message = '`ssl_keystore_password` is REQUIRED when `ssl_keystore_path` is provided'
+          expected_message = "`ssl_keystore_password` is REQUIRED when `ssl_keystore_path` is provided"
           expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
         end
       end
@@ -131,7 +142,7 @@ describe LogStash::Outputs::Logstash do
         let(:config) { super().merge("ssl_keystore_password" => "pa$$w0rd") }
 
         it "requires `ssl_keystore_path`" do
-          expected_message = '`ssl_keystore_password` is not allowed unless `ssl_keystore_path` is configured'
+          expected_message = "`ssl_keystore_password` is not allowed unless `ssl_keystore_path` is configured"
           expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
         end
       end
@@ -141,22 +152,22 @@ describe LogStash::Outputs::Logstash do
       let(:config) { super().merge("ssl_enabled" => true) }
 
       context "with CA" do
-        let(:config) { super().merge("ssl_certificate_authorities" => cert_fixture!('root.pem')) }
+        let(:config) { super().merge("ssl_certificate_authorities" => cert_fixture!("root.pem")) }
 
         context "and `ssl_verification_mode` is 'none'" do
           let(:config) { super().merge("ssl_verification_mode" => "none") }
 
           it "not allowed" do
-            expected_message = 'SSL Certificate Authorities cannot be configured when `ssl_verification_mode => none`'
+            expected_message = "SSL Certificate Authorities cannot be configured when `ssl_verification_mode => none`"
             expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
           end
         end
 
         context "and truststore" do
-          let(:config) { super().merge("ssl_truststore_path" => cert_fixture!('client_self_signed.jks')) }
+          let(:config) { super().merge("ssl_truststore_path" => cert_fixture!("client_self_signed.jks")) }
 
           it "not allowed" do
-            expected_message = 'SSL trust can be configured with EITHER `ssl_certificate_authorities` OR `ssl_truststore_*`, but not both'
+            expected_message = "SSL trust can be configured with EITHER `ssl_certificate_authorities` OR `ssl_truststore_*`, but not both"
             expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
           end
         end
@@ -166,7 +177,7 @@ describe LogStash::Outputs::Logstash do
         let(:config) { super().merge("ssl_truststore_path" => cert_fixture!('client_self_signed.jks')) }
 
         it "requires truststore password" do
-          expected_message = '`ssl_truststore_password` is REQUIRED when `ssl_truststore_path` is provided'
+          expected_message = "`ssl_truststore_password` is REQUIRED when `ssl_truststore_path` is provided"
           expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
         end
 
@@ -174,7 +185,7 @@ describe LogStash::Outputs::Logstash do
           let(:config) { super().merge("ssl_verification_mode" => "none") }
 
           it "not allowed" do
-            expected_message = 'SSL Truststore cannot be configured when `ssl_verification_mode => none`'
+            expected_message = "SSL Truststore cannot be configured when `ssl_verification_mode => none`"
             expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
           end
         end
@@ -184,10 +195,161 @@ describe LogStash::Outputs::Logstash do
         let(:config) { super().merge("ssl_truststore_password" => "pa$$w0rd") }
 
         it "not allowed" do
-          expected_message = '`ssl_truststore_password` not allowed unless `ssl_truststore_path` is configured'
+          expected_message = "`ssl_truststore_password` not allowed unless `ssl_truststore_path` is configured"
           expect{ registered_plugin }.to raise_error(LogStash::ConfigurationError).with_message(expected_message)
         end
       end
     end
   end
+
+  describe "#transmit" do
+    let(:normalized_host_uri) { "https://127.0.0.1:9800" }
+
+    let(:encoded_body) { "[]" }
+    let(:compressed_body) { "\x1F\xC3\xA3\b\x00\xE2\x80\xBA\xE2\x80\x9ACe\x00\x03\xC3\xA3\xC3\xA9\xC3\x82\x02\x00D\xE2\x80\x9Chp\x03\x00\x00\x00".b }
+
+    subject(:transmit_result) { registered_plugin.send(:transmit, encoded_body, compressed_body) }
+
+    context "successful transmission" do
+      before(:each) do
+        registered_plugin.http_client.stub(normalized_host_uri, body: "Response body", code: 200)
+      end
+      it "returns :done" do
+        expect(transmit_result).to eql :done
+      end
+    end
+
+    context "retriable HTTP errors" do
+      [429, 500].each do |retriable_response_code|
+        context "when http client emits #{retriable_response_code} retriable error response" do
+          before(:each) do
+            registered_plugin.http_client.stub(normalized_host_uri, body: "Response body", code: retriable_response_code)
+          end
+          it 'returns :retry' do
+            expect(transmit_result).to eql :retry
+          end
+        end
+      end
+    end
+
+    context "terminal HTTP errors" do
+      [301, 400, 404].each do |terminal_response_code|
+        context "when http client emits #{terminal_response_code} terminal error response" do
+          before(:each) do
+            registered_plugin.http_client.stub(normalized_host_uri, body: "Response body", code: terminal_response_code)
+          end
+          it 'returns :abort' do
+            expect(transmit_result).to eql :abort
+          end
+        end
+      end
+    end
+
+    context "retriable transmission exceptions" do
+      [
+        Manticore::Timeout.new,
+        Manticore::SocketException.new,
+        Manticore::ClientProtocolException.new,
+        Manticore::ResolutionFailure.new,
+        Manticore::SocketTimeout.new,
+        Manticore::UnknownException.new("Connection reset by peer"),
+        Manticore::UnknownException.new("Read Timed out"),
+      ].each do |manticore_exception|
+        context "when http client raises retriable exception `#{manticore_exception}`" do
+          before(:each) do
+            expect(registered_plugin.http_client).to receive(:post).and_raise(manticore_exception)
+          end
+          it "returns :retry" do
+            expect(transmit_result).to eql :retry
+          end
+        end
+      end
+    end
+  end
+
+  describe '#multi_receive' do
+    let(:events) { [event] }
+
+    context "when first transmit succeeds" do
+      before(:each) do
+        allow(registered_plugin).to receive(:transmit).and_return(:abort).once
+      end
+      it "transmits once" do
+        registered_plugin.multi_receive(events)
+        expect(registered_plugin).to have_received(:transmit).once
+      end
+    end
+
+    context "when first transmit gets terminal failure" do
+      before(:each) do
+        allow(registered_plugin).to receive(:transmit).and_return(:abort).once
+      end
+      it "transmits once" do
+        registered_plugin.multi_receive(events)
+        expect(registered_plugin).to have_received(:transmit).once
+      end
+    end
+
+    context "when transmit indicates that a retry is required" do
+      # Configure a _sequence_ of `#transmit` responses
+      # emits :retry `retry_count` times, invoking `limit_met_hook` (if present) before the
+      # LAST normal retry, then emits `limit_met_next_action`.
+      # as a safeguard, this mock can be called AT MOST `retry_count + 1` times
+      let(:retry_count) { 3 }
+      let(:limit_met_hook) { nil }
+      let(:limit_met_next_action) { :retry }
+      before(:each) do
+        attempts_made = 0
+        next_action = :retry
+        allow(registered_plugin).to receive(:transmit).with(any_args) do
+          current_action = next_action
+          attempts_made += 1
+          if attempts_made == retry_count
+            limit_met_hook&.call
+            next_action = limit_met_next_action
+          end
+          current_action
+        end.at_most(retry_count + 1).times
+      end
+
+      context "and transmit eventually succeeds" do
+        let(:limit_met_next_action) { :done }
+        it "stops retrying" do
+          registered_plugin.multi_receive(events)
+
+          expect(registered_plugin).to have_received(:transmit).exactly(retry_count + 1).times
+        end
+      end
+
+      context "and transmit eventually gets terminal failure" do
+        let(:limit_met_next_action) { :abort }
+        it "stops retrying" do
+          registered_plugin.multi_receive(events)
+
+          expect(registered_plugin).to have_received(:transmit).exactly(retry_count + 1).times
+        end
+      end
+
+      context "and the pipeline shutdown is requested before transmission succeeds" do
+        let(:limit_met_hook) do
+          ->() { expect(registered_plugin).to receive(:pipeline_shutdown_requested?).and_return(:true) }
+        end
+        let(:limit_met_next_action) { :retry }
+
+        if ::Gem::Version.create(LOGSTASH_VERSION) >= ::Gem::Version.create('8.8.0')
+          it 'aborts the batch' do
+            expect { registered_plugin.multi_receive(events) }.to raise_exception(org.logstash.execution.AbortedBatchException)
+
+            expect(registered_plugin).to have_received(:transmit).exactly(retry_count).times
+          end
+        else
+          it "stops retrying" do
+            registered_plugin.multi_receive(events)
+
+            expect(registered_plugin).to have_received(:transmit).exactly(retry_count).times
+          end
+        end
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-integration-logstash
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 1.0.1
 platform: java
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-03 00:00:00.000000000 Z
+date: 2023-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -72,6 +72,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7.3'
+  name: logstash-mixin-http_client
+  prerelease: false
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '7.3'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -91,15 +105,15 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.6.0
-  name: logstash-output-http
+        version: '0'
+  name: stud
   prerelease: false
   type: :runtime
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 5.6.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -161,6 +175,7 @@ files:
 - docs/output-logstash.asciidoc
 - lib/logstash/inputs/logstash.rb
 - lib/logstash/outputs/logstash.rb
+- lib/logstash/utils/load_balancer.rb
 - logstash-integration-logstash.gemspec
 - spec/fixtures/certs/generate.sh
 - spec/fixtures/certs/generated/README.txt
@@ -192,6 +207,7 @@ files:
 - spec/fixtures/certs/openssl.cnf
 - spec/spec_helper.rb
 - spec/unit/full_transmission_spec.rb
+- spec/unit/load_balancer_spec.rb
 - spec/unit/logstash_input_spec.rb
 - spec/unit/logstash_output_spec.rb
 homepage: https://www.elastic.co/logstash
@@ -253,5 +269,6 @@ test_files:
 - spec/fixtures/certs/openssl.cnf
 - spec/spec_helper.rb
 - spec/unit/full_transmission_spec.rb
+- spec/unit/load_balancer_spec.rb
 - spec/unit/logstash_input_spec.rb
 - spec/unit/logstash_output_spec.rb