logstash-input-tcp 1.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3dc59dfc788e688f1052d4f083ac4b88d870a211
-  data.tar.gz: a9fd0edd93f5fbb0c41bb0dd7642f991bba73c0d
+  metadata.gz: 9e352517c189ba1a2460edd52b98462fc357b71a
+  data.tar.gz: 74dfb043adfd5d70b171668d053d5391fe6edf2a
 SHA512:
-  metadata.gz: dfdd5824c995dffb97f30d8684190ede32603034d1391b32a7c85ee77b82ace4db54dcc4b022150627d6bd9c672a8aa35714606a7abb37fd4fb41123205044db
-  data.tar.gz: cded34bc083da678f06aa0a327af6b38635f7e7352617971f9cea8fe73d9134802da1afd7f728d87f58254f1ea527d18c486610e2a356a04aa7131d16f3b27cb
+  metadata.gz: 64db2174f3750b2ab0968264f25843e3d791fe7e7439825a669c14a59a07b283472fb8a2fcda747159fac22770d637f65513314f3e94bda2d7b976dd74840249
+  data.tar.gz: 71e3f67d9bf174aa6c38c3a9d30a54a05f395326ca0de6913653ae1d6938c221444d59126341b032c062cb36a77fc51b0f07de857c1de0650c445c06282a94c4

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+## 2.0.0
+ - Plugins were updated to follow the new shutdown semantic, this mainly allows Logstash to instruct input plugins to terminate gracefully, 
+   instead of using Thread.raise on the plugins' threads. Ref: https://github.com/elastic/logstash/pull/3895
+ - Dependency on logstash-core update to 2.0
+

data/README.md

@@ -1,15 +1,15 @@
 # Logstash Plugin
 
-This is a plugin for [Logstash](https://github.com/elasticsearch/logstash).
+This is a plugin for [Logstash](https://github.com/elastic/logstash).
 
 It is fully free and fully open source. The license is Apache 2.0, meaning you are pretty much free to use it however you want in whatever way.
 
 ## Documentation
 
-Logstash provides infrastructure to automatically generate documentation for this plugin. We use the asciidoc format to write documentation so any comments in the source code will be first converted into asciidoc and then into html. All plugin documentation are placed under one [central location](http://www.elasticsearch.org/guide/en/logstash/current/).
+Logstash provides infrastructure to automatically generate documentation for this plugin. We use the asciidoc format to write documentation so any comments in the source code will be first converted into asciidoc and then into html. All plugin documentation are placed under one [central location](http://www.elastic.co/guide/en/logstash/current/).
 
 - For formatting code or config example, you can use the asciidoc `[source,ruby]` directive
-- For more asciidoc formatting tips, see the excellent reference here https://github.com/elasticsearch/docs#asciidoc-guide
+- For more asciidoc formatting tips, see the excellent reference here https://github.com/elastic/docs#asciidoc-guide
 
 ## Need Help?
 
@@ -83,4 +83,4 @@ Programming is not a required skill. Whatever you've seen about open source and
 
 It is more important to the community that you are able to contribute.
 
-For more information about contributing, see the [CONTRIBUTING](https://github.com/elasticsearch/logstash/blob/master/CONTRIBUTING.md) file.
+For more information about contributing, see the [CONTRIBUTING](https://github.com/elastic/logstash/blob/master/CONTRIBUTING.md) file.

data/lib/logstash/inputs/tcp.rb

@@ -1,6 +1,5 @@
 # encoding: utf-8
 require "logstash/inputs/base"
-require "logstash/namespace"
 require "logstash/util/socket_peer"
 
 # Read events over a TCP socket.
@@ -22,11 +21,7 @@ class LogStash::Inputs::Tcp < LogStash::Inputs::Base
   # When mode is `client`, the port to connect to.
   config :port, :validate => :number, :required => true
 
-  # The 'read' timeout in seconds. If a particular tcp connection is idle for
-  # more than this timeout period, we will assume it is dead and close it.
-  #
-  # If you never want to timeout, use -1.
-  config :data_timeout, :validate => :number, :default => -1
+  config :data_timeout, :validate => :number, :default => -1, :deprecated => "This setting is not used by this plugin. It will be removed soon."
 
   # Mode to operate in. `server` listens for client connections,
   # `client` connects to a server.
@@ -53,12 +48,14 @@ class LogStash::Inputs::Tcp < LogStash::Inputs::Base
 
   def initialize(*args)
     super(*args)
-    @interrupted = false
+
+    # threadsafe socket bookkeeping
     @server_socket = nil
     @client_socket = nil
-  end # def initialize
+    @connection_sockets = {}
+    @socket_mutex = Mutex.new
+  end
 
-  public
   def register
     require "socket"
     require "timeout"
@@ -86,49 +83,127 @@ class LogStash::Inputs::Tcp < LogStash::Inputs::Base
         @ssl_context.cert_store = @cert_store
         @ssl_context.verify_mode = OpenSSL::SSL::VERIFY_PEER|OpenSSL::SSL::VERIFY_FAIL_IF_NO_PEER_CERT
       end
-    end # @ssl_enable
+    end
+
+    # note that since we are opening a socket in register, we must also make sure we close it
+    # in the close method even if we also close it in the stop method since we could have
+    # a situation where register is called but not run & stop.
 
     if server?
       @logger.info("Starting tcp input listener", :address => "#{@host}:#{@port}")
       begin
-        @server_socket = TCPServer.new(@host, @port)
+        set_server_socket(TCPServer.new(@host, @port))
       rescue Errno::EADDRINUSE
         @logger.error("Could not start TCP server: Address in use", :host => @host, :port => @port)
         raise
       end
-      if @ssl_enable
-        @server_socket = OpenSSL::SSL::SSLServer.new(@server_socket, @ssl_context)
-      end # @ssl_enable
+
+      set_server_socket(OpenSSL::SSL::SSLServer.new(server_socket, @ssl_context)) if @ssl_enable
+    end
+  end
+
+  def run(output_queue)
+    if server?
+      run_server(output_queue)
+    else
+      run_client(output_queue)
     end
-  end # def register
+  end
+
+  def stop
+    # force close all sockets which will escape any blocking read with a IO exception
+    # and any thread using them will exit.
+    # catch all rescue nil on close to discard any close errors or invalid socket
+    server_socket.close rescue nil
+    client_socket.close rescue nil
+    connection_sockets.each{|socket| socket.close rescue nil}
+  end
+
+  def close
+    # see related comment in register: we must make sure to close the server socket here
+    # because it is created in the register method and we could be in the context of having
+    # register called but never run & stop, only close.
+    # catch all rescue nil on close to discard any close errors or invalid socket
+    server_socket.close rescue nil
+  end
 
   private
-  def handle_socket(socket, client_address, output_queue, codec)
-    while !@interrupted
-      buf = nil
-      # NOTE(petef): the timeout only hits after the line is read or socket dies
-      # TODO(sissel): Why do we have a Timeout here? What's the point?
-      if @data_timeout == -1
-        buf = read(socket)
-      else
-        Timeout::timeout(@data_timeout) do
-          buf = read(socket)
+
+  def run_server(output_queue)
+    while !stop?
+      begin
+        socket = add_connection_socket(server_socket.accept)
+        # start a new thread for each connection.
+        server_connection_thread(output_queue, socket)
+      rescue OpenSSL::SSL::SSLError => e
+        @logger.error("SSL Error", :exception => e, :backtrace => e.backtrace)
+      rescue
+        # if this exception occured while the plugin is stopping
+        # just ignore and exit
+        raise unless stop?
+      end
+    end
+  ensure
+    # catch all rescue nil on close to discard any close errors or invalid socket
+    server_socket.close rescue nil
+  end
+
+  def run_client(output_queue)
+    while !stop?
+      set_client_socket(TCPSocket.new(@host, @port))
+
+      if @ssl_enable
+        set_client_socket(OpenSSL::SSL::SSLSocket.new(client_socket, @ssl_context))
+        begin
+          client_socket.connect
+        rescue OpenSSL::SSL::SSLError => e
+          @logger.error("SSL Error", :exception => e, :backtrace => e.backtrace)
+          sleep(1) # prevent hammering peer
+          next
+        rescue
+          # if this exception occured while the plugin is stopping
+          # just ignore and exit
+          raise unless stop?
         end
       end
-      codec.decode(buf) do |event|
+
+      @logger.debug? && @logger.debug("Opened connection", :client => "#{client_socket.peer}")
+      handle_socket(client_socket, client_socket.peeraddr[3], output_queue, @codec.clone)
+    end
+  ensure
+    # catch all rescue nil on close to discard any close errors or invalid socket
+    client_socket.close rescue nil
+  end
+
+  def server_connection_thread(output_queue, socket)
+    Thread.new(output_queue, socket) do |q, s|
+      begin
+        @logger.debug? && @logger.debug("Accepted connection", :client => s.peer, :server => "#{@host}:#{@port}")
+        handle_socket(s, s.peeraddr[3], q, @codec.clone)
+      ensure
+        delete_connection_socket(s)
+      end
+    end
+  end
+
+  def handle_socket(socket, client_address, output_queue, codec)
+    while !stop?
+      codec.decode(read(socket)) do |event|
         event["host"] ||= client_address
         event["sslsubject"] ||= socket.peer_cert.subject if @ssl_enable && @ssl_verify
         decorate(event)
         output_queue << event
       end
-    end # loop
+    end
   rescue EOFError
     @logger.debug? && @logger.debug("Connection closed", :client => socket.peer)
   rescue Errno::ECONNRESET
     @logger.debug? && @logger.debug("Connection reset by peer", :client => socket.peer)
   rescue => e
-    @logger.error("An error occurred. Closing connection", :client => socket.peer, :exception => e, :backtrace => e.backtrace)
+    # if plugin is stopping, don't bother logging it as an error
+    @logger.error("An error occurred. Closing connection", :client => socket.peer, :exception => e, :backtrace => e.backtrace) unless stop?
   ensure
+    # catch all rescue nil on close to discard any close errors or invalid socket
     socket.close rescue nil
 
     codec.respond_to?(:flush) && codec.flush do |event|
@@ -139,98 +214,42 @@ class LogStash::Inputs::Tcp < LogStash::Inputs::Base
     end
   end
 
-  private
-  def client_thread(output_queue, socket)
-    Thread.new(output_queue, socket) do |q, s|
-      begin
-        @logger.debug? && @logger.debug("Accepted connection", :client => s.peer, :server => "#{@host}:#{@port}")
-        handle_socket(s, s.peeraddr[3], q, @codec.clone)
-      rescue LogStash::ShutdownSignal
-        @interrupted = true
-        s.close rescue nil
-      ensure
-        @client_threads_lock.synchronize{@client_threads.delete(Thread.current)}
-      end
-    end
-  end
-
-  private
   def server?
     @mode == "server"
-  end # def server?
+  end
 
-  private
   def read(socket)
     socket.sysread(16384)
-  end # def readline
+  end
 
-  public
-  def run(output_queue)
-    if server?
-      run_server(output_queue)
-    else
-      run_client(output_queue)
-    end
-  end # def run
+  # threadsafe sockets bookkeeping
 
-  def run_server(output_queue)
-    @client_threads = []
-    @client_threads_lock = Mutex.new
+  def set_client_socket(socket)
+    @socket_mutex.synchronize{@client_socket = socket}
+  end
 
-    while !@interrupted
-      begin
-        socket = @server_socket.accept
-        # start a new thread for each connection.
-        @client_threads_lock.synchronize{@client_threads << client_thread(output_queue, socket)}
-      rescue OpenSSL::SSL::SSLError => ssle
-        # NOTE(mrichar1): This doesn't return a useful error message for some reason
-        @logger.error("SSL Error", :exception => ssle, :backtrace => ssle.backtrace)
-      rescue IOError
-        raise unless @interrupted
-      end
-    end
-  rescue LogStash::ShutdownSignal
-    @interrupted = true
-  ensure
-    @server_socket.close rescue nil
+  def client_socket
+    @socket_mutex.synchronize{@client_socket}
+  end
 
-    threads = @client_threads_lock.synchronize{@client_threads.dup}
-    threads.each do |thread|
-      thread.raise(LogStash::ShutdownSignal) if thread.alive?
-    end
-  end # def run_server
+  def set_server_socket(socket)
+    @socket_mutex.synchronize{@server_socket = socket}
+  end
 
-  def run_client(output_queue)
-    while !@interrupted
-      @client_socket = TCPSocket.new(@host, @port)
-      if @ssl_enable
-        @client_socket = OpenSSL::SSL::SSLSocket.new(@client_socket, @ssl_context)
-        begin
-          @client_socket.connect
-        rescue OpenSSL::SSL::SSLError => ssle
-          @logger.error("SSL Error", :exception => ssle, :backtrace => ssle.backtrace)
-          # NOTE(mrichar1): Hack to prevent hammering peer
-          sleep(5)
-          next
-        end
-      end
-      @logger.debug? && @logger.debug("Opened connection", :client => "#{@client_socket.peer}")
-      handle_socket(@client_socket, @client_socket.peeraddr[3], output_queue, @codec.clone)
-    end # loop
-  ensure
-    @client_socket.close rescue nil
-  end # def run
-
-  public
-  def teardown
-    @interrupted = true
-    if @server_socket
-      @server_socket.close rescue nil
-      @server_socket = nil
-    end
-    if @client_socket
-      @client_socket.close rescue nil
-      @client_socket = nil
-    end
-  end # def teardown
-end # class LogStash::Inputs::Tcp
+  def server_socket
+    @socket_mutex.synchronize{@server_socket}
+  end
+
+  def add_connection_socket(socket)
+    @socket_mutex.synchronize{@connection_sockets[socket] = true}
+    socket
+  end
+
+  def delete_connection_socket(socket)
+    @socket_mutex.synchronize{@connection_sockets.delete(socket)}
+  end
+
+  def connection_sockets
+    @socket_mutex.synchronize{@connection_sockets.keys.dup}
+  end
+end

data/logstash-input-tcp.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-input-tcp'
-  s.version         = '1.0.0'
+  s.version         = '2.0.1'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Read events over a TCP socket."
   s.description     = "This gem is a logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/plugin install gemname. This gem is not a stand-alone program"
@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   # Files
-  s.files = `git ls-files`.split($\)+::Dir.glob('vendor/*')
+  s.files = Dir['lib/**/*','spec/**/*','vendor/**/*','*.gemspec','*.md','CONTRIBUTORS','Gemfile','LICENSE','NOTICE.TXT']
 
   # Tests
   s.test_files = s.files.grep(%r{^(test|spec|features)/})
@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
   s.metadata = { "logstash_plugin" => "true", "logstash_group" => "input" }
 
   # Gem dependencies
-  s.add_runtime_dependency "logstash-core", '>= 1.4.0', '< 2.0.0'
+  s.add_runtime_dependency "logstash-core", ">= 2.0.0.snapshot", "< 3.0.0"
 
   s.add_runtime_dependency 'logstash-codec-plain'
   s.add_runtime_dependency 'logstash-codec-line'

data/spec/inputs/tcp_spec.rb

@@ -5,10 +5,10 @@ require "timeout"
 require "logstash/json"
 require "logstash/inputs/tcp"
 require 'stud/try'
+require_relative "../spec_helper"
 
 describe LogStash::Inputs::Tcp do
 
-
   context "codec (PR #1372)" do
     it "switches from plain to line" do
       require "logstash/codecs/plain"
@@ -16,7 +16,7 @@ describe LogStash::Inputs::Tcp do
       plugin = LogStash::Inputs::Tcp.new("codec" => LogStash::Codecs::Plain.new, "port" => 0)
       plugin.register
       insist { plugin.codec }.is_a?(LogStash::Codecs::Line)
-      plugin.teardown
+      plugin.close
     end
     it "switches from json to json_lines" do
       require "logstash/codecs/json"
@@ -24,7 +24,7 @@ describe LogStash::Inputs::Tcp do
       plugin = LogStash::Inputs::Tcp.new("codec" => LogStash::Codecs::JSON.new, "port" => 0)
       plugin.register
       insist { plugin.codec }.is_a?(LogStash::Codecs::JSONLines)
-      plugin.teardown
+      plugin.close
     end
   end
 
@@ -39,8 +39,6 @@ describe LogStash::Inputs::Tcp do
       }
     CONFIG
 
-
-
     events = input(conf) do |pipeline, queue|
       socket = Stud::try(5.times) { TCPSocket.new("127.0.0.1", port) }
       event_count.times do |i|
@@ -214,35 +212,67 @@ describe LogStash::Inputs::Tcp do
     end
   end
 
-  it "should connection threads are cleaned up when connection is closed" do
-    event_count = 10
-    port = 5517
-    conf = <<-CONFIG
-      input {
-        tcp {
-          port => #{port}
-        }
-      }
-    CONFIG
+  # below are new specs added in the context of the shutdown semantic refactor.
+  # TODO:
+  #   - refactor all specs using this new model
+  #   - pipelineless_input has been basically copied from the udp input specs, it should be DRYied up
+  #   - see if we should miminc the udp input UDPClient helper class instead of directly using TCPSocket
+
+  describe "LogStash::Inputs::Tcp new specs style" do
 
-    input(conf) do |pipeline, queue|
-      inputs = pipeline.instance_variable_get("@inputs")
-      insist { inputs.size } == 1
+    before do
+      srand(RSpec.configuration.seed)
+    end
+
+    let(:port) { rand(1024..65535) }
+    subject { LogStash::Plugin.lookup("input", "tcp").new({ "port" => port }) }
+
+    after :each do
+      subject.close rescue nil
+    end
 
-      sockets = event_count.times.map do |i|
+    describe "register" do
+      it "should register without errors" do
+        expect { subject.register }.to_not raise_error
+      end
+    end
+
+    describe "receive" do
+
+      let(:nevents) { 10 }
+
+      let(:events) do
         socket = Stud::try(5.times) { TCPSocket.new("127.0.0.1", port) }
-        socket.puts("#{i}")
-        socket.flush
-        socket
+
+        result = pipelineless_input(subject, nevents) do
+          nevents.times do |i|
+            socket.puts("msg #{i}")
+            socket.flush
+          end
+        end
+
+        socket.close rescue nil
+
+        result
       end
 
-      client_threads = inputs[0].instance_variable_get("@client_threads")
+      before(:each) do
+        subject.register
+      end
 
-      # close all sockets and make sure there is not more pending threads
-      sockets.each{|socket| socket.close}
+      it "should receive events been generated" do
+        expect(events.size).to be(nevents)
+        messages = events.map { |event| event["message"]}
+        messages.each do |message|
+          expect(message).to match(/msg \d+/)
+        end
+      end
 
-      Timeout.timeout(1) {sleep 0.1 while client_threads.size > 0}
-      insist { client_threads.size } == 0 # this check is actually useless per previous line
+    end
+
+    it_behaves_like "an interruptible input plugin" do
+      let(:config) { { "port" => port } }
     end
   end
+
 end

data/spec/spec_helper.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+require "logstash/devutils/rspec/spec_helper"
+
+# this has been taken from the udp input, it should be DRYed
+
+module TcpHelpers
+
+  def pipelineless_input(plugin, size, &block)
+    queue = Queue.new
+    input_thread = Thread.new do
+      plugin.run(queue)
+    end
+    block.call
+    sleep 0.1 while queue.size != size
+    result = nevents.times.inject([]) do |acc|
+      acc << queue.pop
+    end
+    plugin.do_stop
+    input_thread.join
+    result
+  end
+
+end
+
+RSpec.configure do |c|
+  c.include TcpHelpers
+end

metadata

@@ -1,122 +1,121 @@
 --- !ruby/object:Gem::Specification
 name: logstash-input-tcp
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-06-24 00:00:00.000000000 Z
+date: 2015-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: logstash-core
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 1.4.0
-    - - <
-      - !ruby/object:Gem::Version
-        version: 2.0.0
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 2.0.0.snapshot
     - - <
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: 3.0.0
+  name: logstash-core
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: logstash-codec-plain
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.0.0.snapshot
+    - - <
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: logstash-codec-plain
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: logstash-codec-line
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: logstash-codec-line
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: logstash-codec-json
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: logstash-codec-json
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: logstash-codec-json_lines
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: logstash-codec-json_lines
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: logstash-devutils
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: logstash-devutils
   prerelease: false
   type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This gem is a logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/plugin install gemname. This gem is not a stand-alone program
 email: info@elastic.co
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
 - CHANGELOG.md
 - CONTRIBUTORS
 - Gemfile
 - LICENSE
 - NOTICE.TXT
 - README.md
-- Rakefile
 - lib/logstash/inputs/tcp.rb
 - logstash-input-tcp.gemspec
 - spec/inputs/tcp_spec.rb
+- spec/spec_helper.rb
 homepage: http://www.elastic.co/guide/en/logstash/current/index.html
 licenses:
 - Apache License (2.0)
@@ -139,9 +138,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key:
 specification_version: 4
 summary: Read events over a TCP socket.
 test_files:
 - spec/inputs/tcp_spec.rb
+- spec/spec_helper.rb

data/.gitignore

@@ -1,4 +0,0 @@
-*.gem
-Gemfile.lock
-.bundle
-vendor

data/Rakefile

@@ -1,7 +0,0 @@
-@files=[]
-
-task :default do
-  system("rake -T")
-end
-
-require "logstash/devutils/rake"