logstash-input-meetup 3.0.3 → 3.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d707708edea17fc04c18423a1fb419cc26ee166303252bbbef55c3253ac04cc5
-  data.tar.gz: 04f228ac0f73111fc473501d4c9fe882df071187dfc749a42148acae11ff6adf
+  metadata.gz: 85492b95be62dcfc91d477af8bc8f69b1b925c47e6823163901f57b545adc8c8
+  data.tar.gz: f35a4f5dd80b76d9fcd9b7ef26411c812796efc31ffec2fb3b80ce26d6ca6747
 SHA512:
-  metadata.gz: b00911ff5dc51e0acfb3d77938d32564dc858bdffd48924f18e6833ec0aef35c4536c14c433a0313a8c1d7875c5e3296a1fae83de7bd324d670f7ccb5405b046
-  data.tar.gz: 4acbf1de52e8b3237a6fdae87aadb1c9d254c31946b32fb34553431b32cd0136b1673cca211bd47e0a5f89d579a607c59914d99620ce1b6ddbd102fdc10986fa
+  metadata.gz: d82de4e2e417fa910095ed0103da0fc9cdb91f92faf6ff34dfd6a60631357ffd5ba63aef20d8e46a6d4d0acad53047bc29539882e1a16eecf2929002a4172126
+  data.tar.gz: a30cf11209dccdc9abc577a8cfd08cf3aa318f0566e8a00af1ad6c521f4b411d8e89bafc9c18534b2150d380e2ad6fc5a0eb08fdb193967a6378766bcd2c7aba

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 3.0.4
+  - Fix syntax errors (tylerjl) [#11](https://github.com/logstash-plugins/logstash-input-meetup/pull/11)
+  - Minor logging and validation updates
+
 ## 3.0.3
   - Update gemspec summary
 

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012–2016 Elasticsearch <http://www.elastic.co>
+Copyright (c) 2012-2018 Elasticsearch <http://www.elastic.co>
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/lib/logstash/inputs/meetup.rb

@@ -25,7 +25,7 @@ class LogStash::Inputs::Meetup < LogStash::Inputs::Base
   config :interval, :validate => :number, :required => true
 
   # Meetup Key
-  config :meetupkey, :validate => :string, :required => true
+  config :meetupkey, :validate => :password, :required => true
 
   # Event Status'
   config :eventstatus, :validate => :string, :default => "upcoming,past"
@@ -35,20 +35,21 @@ class LogStash::Inputs::Meetup < LogStash::Inputs::Base
     require "faraday"
     # group_id
     if groupid
-	addon = "group_id=#{ @groupid }"
-    # group_urlname
+      addon = "group_id=#{ @groupid }"
+      # group_urlname
     elsif urlname
-	addon = "group_urlname=#{ @urlname }"
-    # venue_id
+      addon = "group_urlname=#{ @urlname }"
+      # venue_id
     elsif venueid
-	addon = "venue_id=#{ @venueid }"
+      addon = "venue_id=#{ @venueid }"
     else
-    # None Selected, raise an error
-	addon = ""
+      # None Selected, raise an error
+      raise "Configuration error! -  Must have one of `urlname`, `venue_id`, or `group_id` defined"
+      addon = ""
     end
-    @url = "https://api.meetup.com/2/events.json?key=#{ @meetupkey }&status=#{ @eventstatus }&#{ addon }"
-    @logger.info("Registering meetup Input", :url => @url, :interval => @interval)
-  end # def register
+    @url = "https://api.meetup.com/2/events.json?key=#{ @meetupkey.value }&status=#{ @eventstatus }&#{ addon }"
+    @logger.info("Registering meetup Input", :url => @url.gsub(@meetupkey.value, "xxxx"), :interval => @interval)
+  end  # def register
 
   public
   def run(queue)
@@ -58,10 +59,12 @@ class LogStash::Inputs::Meetup < LogStash::Inputs::Base
 
       # Pull down the RSS feed using FTW so we can make use of future cache functions
       response = Faraday.get @url
+      logger.error("Error call meetup API: " + response.body) unless response.status.eql?(200)
       begin
         result = LogStash::Json.load(response.body)
-      rescue LogStash::Json::ParserError
-        # silently ignore json parsing errors
+      rescue LogStash::Json::ParserError => e
+        # ignore json parsing errors
+        logger.debug("Error parsing Json", :message => e.message, :backtrace => e.backtrace)
       end
 
       result["results"].each do |rawevent|
@@ -71,8 +74,8 @@ class LogStash::Inputs::Meetup < LogStash::Inputs::Base
         event.set('time', LogStash::Timestamp.at(event.get('time') / 1000, (event.get('time') % 1000) * 1000))
         event.set('[group][created]', LogStash::Timestamp.at(event.get('group][created]') / 1000, (event.get('group][created]') % 1000) * 1000))
         event.set('updated', LogStash::Timestamp.at(event.get('updated') / 1000, (event.get('updated') % 1000) * 1000))
-        event.set('[venue][lonlat]', [event.get('[venue][lon]'), event.get('[venue][lat]') if rawevent.has_key?('venue'))
-        event.set('[group][lonlat]', [event.get('[group][group_lon]',event'[group][group_lat]') if rawevent.has_key?('group'))
+        event.set('[venue][lonlat]', [event.get('[venue][lon]'), event.get('[venue][lat]')]) if rawevent.has_key?('venue')
+        event.set('[group][lonlat]', [event.get('[group][group_lon]'), event.get('[group][group_lat]')]) if rawevent.has_key?('group')
         decorate(event)
         queue << event
       end

data/logstash-input-meetup.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-input-meetup'
-  s.version         = '3.0.3'
+  s.version         = '3.0.4'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Captures the output of command line tools as an event"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"
@@ -21,7 +21,10 @@ Gem::Specification.new do |s|
 
   # Gem dependencies
   s.add_runtime_dependency "logstash-core-plugin-api", "~> 2.0"
+  s.add_runtime_dependency 'logstash-codec-plain'
+  s.add_runtime_dependency 'faraday'
 
   s.add_development_dependency 'logstash-devutils'
+  s.add_development_dependency 'webmock'
 end
 

data/spec/fixtures/meetup-response.json

@@ -0,0 +1,103 @@
+{
+    "results": [
+        {
+            "utc_offset": -18000000,
+            "venue": {
+                "country": "us",
+                "localized_country_name": "USA",
+                "city": "Durham",
+                "address_1": "4613 University Drive – Bldg 450",
+                "name": "BCBSNC ",
+                "lon": -78.966064,
+                "id": 25003187,
+                "state": "NC",
+                "lat": 35.955414,
+                "repinned": false
+            },
+            "headcount": 0,
+            "visibility": "public",
+            "waitlist_count": 0,
+            "created": 1484960943000,
+            "rating": {
+                "count": 7,
+                "average": 3.859999895095825
+            },
+            "maybe_rsvp_count": 0,
+            "description": "<p><b>Join us for our inaugural meetup on Thursday, February 16. Doors will open at 4pm and we'll start talks around 4:30pm. </b></p> <p><br/><b>Thank you to BCBSNC for hosting us! IBM will be presenting.</b></p> <p>--------</p> <p><b>Kibana Globalization</b></p> <p><br/>Adding globalization support to Kibana is a crucial capability which is necessary in all visualization dashboards. This talk will present the design, the road map of delivered and any pending parts, as well as the integration points for stakeholders. It is an exciting journey not to be missed in the growth of Kibana and the Elastic Stack.</p> <p><br/><b>Shikha</b> is a Senior Technical Staff Member (STSM) and a Master Inventor at IBM. She is a lead Connect to Cloud architect where she brings her expertise in architecture, design, leadership towards collaboratively creating innovative pragmatic solutions that leads to enabling Hybrid solution for the clients.</p> <p>\n\nShikha has won awards in innovation and technical achievement. She enjoys leadership role focussed on making things happen and shipping. Shikha is a strong open source advocate focused on building simple tools.<br/>She has worked with several clients across multiple industries including heath, insurance and finance. She has co-presented with client and BPs at conferences has also been invited as guest speaker at customer conferences</p> <p>Shikha lives in Cary, NC with her husband and two son who manage to take up most of her 'free' time.<br/>You can find her on<br/>Twitter: <a href=\"https://twitter.com/shikhasthoughts\"><a href=\"https://twitter.com/shikhasthoughts\" class=\"linkified\">https://twitter.com/shikhasthoughts</a></a><br/>LinkedIn: <a href=\"https://www.linkedin.com/pub/shikha-srivastava/5/9/64\"><a href=\"https://www.linkedin.com/pub/shikha-srivastava/5/9/64\" class=\"linkified\">https://www.linkedin.com/pub/shikha-srivastava/5/9/64</a></a></p> <p><b>IBM Bluemix platform logging with the Elastic Stack</b></p> <p>IBM Bluemix platform logs to Elastic Stacks. Learn about the flexibility of our logging solutions. We'll also share insights to challenges of offering platform logging in multi-tenant environments.</p> <p>Bluemix platform automatically collects many platform logs- no user configuration necessary. We'll talk about and demo how we do this offering a Log Search experience with the ELK stack. We'll cover scale challenges in the cloud and how we are addressing them today. </p> <p><b>Charlie</b> is a Senior Offering Manager at IBM. He is currently Offering lead for Bluemix Log, Monitoring, and Access Trail services. He passionately brings these collective experiences together drawling on his background, including: logging, analytics, and IT service management offerings. </p> <p>Charlie lives in Cary, NC with his wife and son. You can find him on:<br/>Twitter: <a href=\"https://twitter.com/CharlieComiskey\"><a href=\"https://twitter.com/CharlieComiskey\" class=\"linkified\">https://twitter.com/CharlieComiskey</a></a><br/>LinkedIn: <a href=\"http://www.linkedin.com/in/charlie-c\">www.linkedin.com/in/charlie-c </a></p> <p><br/>--------</p> <p><br/><b>I'm new to Elasticsearch. Will this event be good for me?</b></p> <p>Totally. No matter if you are a novice or an old pro, there’s something for everyone at SEARCH.</p> <p><b>What is Elasticsearch?</b></p> <p>The world is swimming in data. For years we have been simply overwhelmed by the quantity of data flowing through and produced by our systems. Existing technology has focused on how to store and structure warehouses full of data. That’s all well and good—until you actually need to make decisions in real time informed by that data.</p> <p>Elasticsearch is a real-time distributed search and analytics engine. It allows you to explore your data at a speed and at a scale never before possible. It is used for full-text search, structured search, analytics, and all three in combination:</p> <p>Wikipedia uses Elasticsearch to provide full-text search with highlighted search snippets, and search-as-you-type and did-you-mean suggestions.The Guardian uses Elasticsearch to combine visitor logs with social -network data to provide real-time feedback to its editors about the public’s response to new articles.Stack Overflow combines full-text search with geolocation queries and uses more-like-this to find related questions and answers.Netflix uses it for personalized recommendation and search millions of videos.GitHub uses Elasticsearch to query 130 billion lines of code.</p> <p><b>Can I bring a friend?</b></p> <p>Sure... Everyone is welcome! Just make sure you register for all attendees you plan to bring with you before Tuesday, 02/14/17.</p> <p><b>Will there be food?</b></p> <p>Yes! We will have a yummy selection of pizzas and beverages to help keep your energy and focus on the great technology content and networking opportunity.</p> <p><b>What are my transport/parking options getting to the event?</b></p> <p>Parking is available in the open surface parking lot across from building 450. </p> <p>Take I-40 to exit 270. Turn onto US 15/501(Durham-Chapel Hill Blvd.) headed toward Durham. Follow Durham-Chapel Hill Blvd. past Garrett Road. Stay in right two lanes and bear right to US 15/501 North. Immediately stay in right lane and bear right onto Martin Luther King, Jr. Pkwy. Turn right at the first traffic light onto University Drive. Turn left at the second light which is University Place. Building 450 will be the 2nd turn off on your right. </p> <p><b>Where can I contact the organizer with any questions?</b></p> <p>Please contact Nitin Kadam with any questions: <a href=\"mailto:[masked]\">[masked]</a></p> <p>If you're interested in speaking at a future meetup, email us at [masked]. </p>",
+            "how_to_find_us": "450 Auditorium:  CR-450-1870/1880/1890 (1st floor)   You will need to sign in at the security guest in the main lobby when entering building 450.",
+            "event_url": "https://www.meetup.com/Elastic-Triangle-User-Group/events/237083007/",
+            "yes_rsvp_count": 92,
+            "name": "Inaugural Elastic Triangle meetup",
+            "id": "237083007",
+            "time": 1487278800000,
+            "updated": 1492650351000,
+            "group": {
+                "join_mode": "open",
+                "created": 1484762789000,
+                "name": "Elastic Triangle User Group",
+                "group_lon": -78.9000015258789,
+                "id": 21979256,
+                "urlname": "Elastic-Triangle-User-Group",
+                "group_lat": 36,
+                "who": "Elastic Fantastics"
+            },
+            "status": "past"
+        },
+        {
+            "utc_offset": -14400000,
+            "venue": {
+                "country": "us",
+                "localized_country_name": "USA",
+                "city": "Durham",
+                "address_1": "4613 University Drive – Bldg 450",
+                "name": "BCBSNC ",
+                "lon": -78.966064,
+                "id": 25003187,
+                "state": "NC",
+                "lat": 35.955414,
+                "repinned": false
+            },
+            "headcount": 0,
+            "visibility": "public",
+            "waitlist_count": 0,
+            "created": 1492246911000,
+            "rating": {
+                "count": 2,
+                "average": 5
+            },
+            "maybe_rsvp_count": 0,
+            "description": "<p><b>Agenda:</b></p> <p>• 5:30 PM - <b>Pizza and Networking</b></p> <p>• 6:00-6:45 PM - <b>Talk#1: Gather 'round and hear the story of Painless!</b></p> <p>• 6:45-7:30 PM - <b>Talk#2: Learn how Bitly uses ElasticSearch</b></p> <p>• 7:30 PM - <b>Open Discussion</b></p> <p><b>We have a great inaugural meetup back in February and we are excited to be hosting our second meetup for the Elastic Triangle user group on Thursday, April 27.  </b></p> <p><b>Talk#1: Gather 'round and hear the story of Painless!</b></p> <p>Back in the pre-5.0 dark ages, Elasticsearch lacked a secure scripting language. And the people were sad! But our hero Painless came in 5.0, the shining new default, careful, quick, and kind. Ever watchful of its whitelist and loop counters, Painless protects Elasticsearch from malign mandate, inadvertent or iniquitous.</p> <p>Gather and hear of Painless' guiding principles, see the features they represent, and, time permitting, discuss Painless' future.</p> <p><b>Nik Everett</b> is an Elasticsearch Engineer based in North Carolina. Before joining Elastic, Nik worked for the Wikimedia Foundation building on site search for Wikipedia with Elasticsearch.</p> <p><b>Talk#2: Learn how Bitly uses ElasticSearch</b></p> <p>Learn how Bitly uses ElasticSearch to power not just standard search and retrieval of your shortened URLs, but also how we use the aggregations' feature of ElasticSearch to provide up-to-date analytic information on how engaged your target audience is with your content, across the internet at large. We’ll dive into how Bitly uses custom schemas to enable search, and into the details of how Bitly constructs aggregate queries for counting and categorizing. </p> <p><br/><b>Peter Herndon</b> is a Senior Application Engineer at Bitly, where he helps keep links short and smart. Working primarily on back-end systems, he uses an awful lot of open source software and occasionally contributes a bit of working code. Prior to joining Bitly, he worked briefly in the New York startup world, and for a much longer time at Memorial Sloan-Kettering Cancer Center as a developer and systems administrator. His main passion is designing and building distributed systems, and his main extracurricular hobby is learning and teaching martial arts.</p>",
+            "event_url": "https://www.meetup.com/Elastic-Triangle-User-Group/events/239230863/",
+            "yes_rsvp_count": 44,
+            "name": "Painless: Elasticsearch's new scripting language & Learn how Bitly uses Elastic",
+            "id": "239230863",
+            "time": 1493328600000,
+            "updated": 1493382683000,
+            "group": {
+                "join_mode": "open",
+                "created": 1484762789000,
+                "name": "Elastic Triangle User Group",
+                "group_lon": -78.9000015258789,
+                "id": 21979256,
+                "urlname": "Elastic-Triangle-User-Group",
+                "group_lat": 36,
+                "who": "Elastic Fantastics"
+            },
+            "status": "past"
+        }
+    ],
+    "meta": {
+        "next": "",
+        "method": "Events",
+        "total_count": 2,
+        "link": "https://api.meetup.com/2/events.json",
+        "count": 2,
+        "description": "Access Meetup events using a group, member, or event id. Events in private groups are available only to authenticated members of those groups. To search events by topic or location, see [Open Events](/meetup_api/docs/2/open_events).",
+        "lon": "",
+        "title": "Meetup Events v2",
+        "url": "https://api.meetup.com/2/events.json?offset=0&format=json&limited_events=False&group_id=21979256&page=200&fields=&key=551f79233a251a351215671b7a60&order=time&status=upcoming%2Cpast&desc=false",
+        "id": "",
+        "updated": 1493382683000,
+        "lat": ""
+    }
+}

data/spec/logstash/inputs/meetup_spec.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+
+require_relative '../../spec_helper'
+
+describe LogStash::Inputs::Meetup do
+  before do
+    WebMock.disable_net_connect! allow_localhost: true
+  end
+
+  after do
+    WebMock.allow_net_connect!
+  end
+
+  let(:meetupkey) { SecureRandom.hex 14 }
+  let(:groupid) { (1..2).map { rand(10_000_000) }.join(',') }
+  let(:config) do
+    {
+      'meetupkey' => meetupkey,
+      'groupid' => groupid,
+      'interval' => 1
+    }
+  end
+  let(:subject) { described_class.new(config) }
+  let(:queue) { Queue.new }
+
+  it 'fetches JSON from the Meetup API' do
+    api = 'https://api.meetup.com/2/events.json'
+    url = "#{api}?group_id=#{groupid}&key=#{meetupkey}&status=upcoming,past"
+
+    stub_request(:get, url).to_return(body: fixture('meetup-response.json'))
+
+    subject.register
+    Thread.new { subject.run(queue) }
+    sleep 0.01 while queue.size.zero?
+
+    expect(a_request(:get, url)).to have_been_made.at_least_once
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,15 @@
+require 'logstash/devutils/rspec/spec_helper'
+require 'logstash/inputs/meetup'
+require 'logstash/codecs/plain'
+require 'webmock/rspec'
+
+# JSON fixture helper
+module MeetupFixtures
+  def fixture(filename)
+    File.read(File.expand_path(File.join('spec', 'fixtures', filename)))
+  end
+end
+
+RSpec.configure do |c|
+  c.include MeetupFixtures
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-input-meetup
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 3.0.4
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-11-07 00:00:00.000000000 Z
+date: 2018-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -24,6 +24,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  name: logstash-codec-plain
+  prerelease: false
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  name: faraday
+  prerelease: false
+  type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -38,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  name: webmock
+  prerelease: false
+  type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This gem is a Logstash plugin required to be installed on top of the
   Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This
   gem is not a stand-alone program
@@ -55,7 +97,9 @@ files:
 - docs/index.asciidoc
 - lib/logstash/inputs/meetup.rb
 - logstash-input-meetup.gemspec
-- spec/inputs/meetup_spec.rb
+- spec/fixtures/meetup-response.json
+- spec/logstash/inputs/meetup_spec.rb
+- spec/spec_helper.rb
 homepage: http://www.elastic.co/guide/en/logstash/current/index.html
 licenses:
 - Apache License (2.0)
@@ -78,9 +122,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key:
 specification_version: 4
 summary: Captures the output of command line tools as an event
 test_files:
-- spec/inputs/meetup_spec.rb
+- spec/fixtures/meetup-response.json
+- spec/logstash/inputs/meetup_spec.rb
+- spec/spec_helper.rb

data/spec/inputs/meetup_spec.rb

@@ -1 +0,0 @@
-# Empty