logstash-input-http 3.3.5-java → 3.3.6-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d808f555a1bc9473e63bc9960678f4f7b831c4c9492e0785f2c0d2c8bb1abbc2
-  data.tar.gz: 8c0f90dec3c295d0ab0846a22a8b6e063af35d74f23a8b39f2c4f67af28321c0
+  metadata.gz: c16f35c7b0da36b5d3a34ae730e2e9386754b4f770d91ab95c426ea51d6088b6
+  data.tar.gz: b7e6c19a7405151badb060b4342ff5d01d419e70031c0887afba277e0749352e
 SHA512:
-  metadata.gz: b1b5d0afe5761f5de22e94d2cbf905b3822712bc12bdb55762e4e29c8c19ea8945573326c2a2ca4126dcc6f629a8e3015a1f1446c1fa52f58e12895689a845ce
-  data.tar.gz: a03254b131ccabbaca80dd76b01a35e4ab6f6474378516e8ff456eb57419550839d57206e884e271dbb86a843344a9aa79b83bd7af3d00977a6c8d866687a7df
+  metadata.gz: f1b3f4486a8877a4aa4af9bb2f03cee3bd69cf8d66fb5bfb709781a9e9b31376e8118ad8457fcd6bdfc7375e170860e83d16121696b123e923dfe3c25f88980e
+  data.tar.gz: 6e62fb8e3b112b60bcea52db6fb6c09a548c51e2563110bfa80703e5afa4c55a1ae31db921cfdc3dfeb87c9b9f29c3a522d93ab30bbd62b784ef8214a91572af

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 3.3.6
+ - Fixes a regression introduced in 3.1.0's migration to the Netty back-end that broke some users'
+   browser-based workflows. When an instance of this plugin that is configured to require Basic
+   authentication receives a request that does not include authentication, it now appropriately
+   includes an `WWW-Authenticate` header in its `401 Unauthorized` response, allowing the browser
+   to collect credentials before retrying the request.
+
 ## 3.3.5
  - Updated jackson databind and Netty dependencies. Additionally, this release removes the dependency on `tcnative` +
    `boringssl`, using JVM supplied ciphers instead. This may result in fewer ciphers being available if the JCE

data/VERSION

@@ -1 +1 @@
-3.3.5
+3.3.6

data/lib/logstash-input-http_jars.rb

@@ -3,4 +3,4 @@
 require 'jar_dependencies'
 require_jar('io.netty', 'netty-all', '4.1.49.Final')
 require_jar('org.apache.logging.log4j', 'log4j-api', '2.11.1')
-require_jar('org.logstash.plugins.input.http', 'logstash-input-http', '3.3.5')
+require_jar('org.logstash.plugins.input.http', 'logstash-input-http', '3.3.6')

data/lib/logstash/inputs/http/message_handler.rb

@@ -22,6 +22,10 @@ module LogStash module Inputs class Http
       end
     end
 
+    def requires_token
+      !!@auth_token
+    end
+
     def onNewMessage(remote_address, headers, body)
       @input.decode_body(headers, remote_address, body, @default_codec, @additional_codecs)
     end

data/spec/inputs/http_spec.rb

@@ -279,6 +279,11 @@ describe LogStash::Inputs::Http do
         it "should respond with 401" do
           expect(response.code).to eq(401)
         end
+        it 'should include a WWW-Authenticate: Basic header' do
+          expect(response['WWW-Authenticate']).to_not be_nil
+
+          expect(response['WWW-Authenticate']).to start_with('Basic realm=')
+        end
         it "should not generate an event" do
           expect(logstash_queue).to be_empty
         end
@@ -295,6 +300,9 @@ describe LogStash::Inputs::Http do
         it "should respond with 401" do
           expect(response.code).to eq(401)
         end
+        it 'should not include a WWW-Authenticate header' do
+          expect(response['WWW-Authenticate']).to be_nil
+        end
         it "should not generate an event" do
           expect(logstash_queue).to be_empty
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-input-http
 version: !ruby/object:Gem::Version
-  version: 3.3.5
+  version: 3.3.6
 platform: java
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-06-03 00:00:00.000000000 Z
+date: 2020-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -146,7 +146,7 @@ files:
 - spec/inputs/http_spec.rb
 - vendor/jar-dependencies/io/netty/netty-all/4.1.49.Final/netty-all-4.1.49.Final.jar
 - vendor/jar-dependencies/org/apache/logging/log4j/log4j-api/2.11.1/log4j-api-2.11.1.jar
-- vendor/jar-dependencies/org/logstash/plugins/input/http/logstash-input-http/3.3.5/logstash-input-http-3.3.5.jar
+- vendor/jar-dependencies/org/logstash/plugins/input/http/logstash-input-http/3.3.6/logstash-input-http-3.3.6.jar
 homepage: http://www.elastic.co/guide/en/logstash/current/index.html
 licenses:
 - Apache License (2.0)