logstash-input-google_cloud_storage 0.13.0-java → 0.14.0-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8266dd28a3bf6c8ccb71007d44aa08749138300851d2fbe8505fb8354fec414
-  data.tar.gz: 53107f4d0597aa6faa20514dc1bd43cca2d565ddd19212f9c19d7a88c4ce7be4
+  metadata.gz: d5deb7203755cea341c28b9ae42f8e62605c0c4ac3880ae1ecb58fd4f92cda63
+  data.tar.gz: dba78aed232fa56d67341ad5e4e3dd6a7361d42c2df2ae040f4795cc63dbcd90
 SHA512:
-  metadata.gz: a0961a7c380c9b539f2ce5f80055eec6413a0893789dc5db4cf91452f4baed5d04873125a8af4e4a9141bdb1949338606cbad4634276125abdc1a0188522d757
-  data.tar.gz: c01c3314bbb5bf73e905084ec2afb7fdaaf813077e63bf72d2b6f473025ef5c86ae0f4008fcff7e836cf7740ba773d571d0f2f2396b36b29efb91a7df1905e94
+  metadata.gz: 93c2a0b32fea57e63490d67bd3ff6995d58c8f1dcceec472435d073751d5aed8bfd0202a5e42cf872562c3d9d798cc88d0cf6ebdfba3cd6652c53c18654a1786
+  data.tar.gz: f9edbf2e175a54ac412bff1fb6b516381875c8a72188bfbbe2c8039905c64a70238ca7a89432d090edfe09ec2fad86a0261c37da62d66d20f0c354c17cd732b8

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.14.0
+ - Feature, update so that unauthenticated client can access public buckets [#24](https://github.com/logstash-plugins/logstash-input-google_cloud_storage/pull/24)
+
 ## 0.13.0
  - Updated Google Cloud Storage client library, from `1.118.1` to `2.12.0` [#21](https://github.com/logstash-plugins/logstash-output-google_cloud_storage/pull/21)
 

data/README.md

@@ -26,19 +26,29 @@ Need help? Try #logstash on freenode IRC or the https://discuss.elastic.co/c/log
 
 ## Developing
 
-### 1. Plugin Developement and Testing
+### 1. Plugin Development and Testing
 
 #### Code
+
 - To get started, you'll need JRuby with the Bundler gem installed.
+- You'll also need a Logstash installation to build the plugin against.
 
 - Create a new plugin or clone and existing from the GitHub [logstash-plugins](https://github.com/logstash-plugins) organization. We also provide [example plugins](https://github.com/logstash-plugins?query=example).
+- `export LOGSTASH_SOURCE=1` and point `LOGSTASH_PATH` to a local Logstash
+  e.g. `export LOGSTASH_PATH=/opt/local/logstash-8.7.0`
 
-- Install dependencies
+- Install Ruby dependencies
 ```sh
 bundle install
-bundle exec rake vendor
 ```
 
+- Install Java dependencies - regenerates the *lib/logstash-input-google_cloud_storage_jars.rb*
+  script used to load the .jar dependencies when the plugin starts.
+```sh
+./gradlew vendor
+```
+  NOTE: This step is necessary whenever **build.gradle** is updated.
+
 #### Test
 
 - Update your dependencies
@@ -47,7 +57,7 @@ bundle exec rake vendor
 bundle install
 ```
 
-- Run tests
+- Run Ruby tests
 
 ```sh
 bundle exec rspec

data/docs/index.asciidoc

@@ -56,6 +56,8 @@ To manually install the "mimemagic" gem into Logstash use:
 bin/ruby -S gem install mimemagic -v '>= 0.3.7'
 ----------------------------------
 
+The mimemagic gem also requires the `shared-mime-info` package to be present, it can be installed using `apt-get install shared-mime-info` on Debian/Ubuntu or `yum install shared-mime-info` on Red Hat/RockyOS distributions.
+
 Then install the plugin as usual with:
 [source,bash]
 ----------------------------------
@@ -217,8 +219,9 @@ The bucket containing your log files.
   * There is no default value for this setting.
 
 The path to the key to authenticate your user to the bucket.
-This service user _should_ have the `storage.objects.update` permission so it can
-create metadata on the object preventing it from being scanned multiple times.
+This service user _should_ have the `storage.objects.update` permission so it can create metadata on the object preventing it from being scanned multiple times.
+
+If no key is provided the plugin will try to use the https://cloud.google.com/java/docs/reference/google-auth-library/latest/com.google.auth.oauth2.GoogleCredentials#com_google_auth_oauth2_GoogleCredentials_getApplicationDefault__[default application credentials], and if they don't exist, it falls back to unauthenticated mode. 
 
 [id="plugins-{type}s-{plugin}-interval"]
 ===== `interval`

data/lib/logstash/inputs/cloud_storage/client.rb

@@ -27,24 +27,41 @@ module LogStash
         end
 
         private
-
+        
+        
         def initialize_storage(json_key_path)
-          com.google.cloud.storage.StorageOptions.newBuilder()
-             .setCredentials(credentials(json_key_path))
-             .setHeaderProvider(http_headers)
-             .setRetrySettings(retry_settings)
-             .build()
-             .getService()
+          builder = setup_builder_from_credentials(json_key_path)
+          builder.setHeaderProvider(http_headers)
+              .setRetrySettings(retry_settings)
+              .build()
+              .getService()
         end
-
+        
         java_import 'com.google.auth.oauth2.GoogleCredentials'
-        def credentials(json_key_path)
-          return GoogleCredentials.getApplicationDefault() if json_key_path.empty?
+        def setup_builder_from_credentials(json_key_path)
+          # initialize the StorageOptions builder
+          builder = com.google.cloud.storage.StorageOptions.newBuilder()
 
-          key_file = java.io.FileInputStream.new(json_key_path)
-          GoogleCredentials.fromStream(key_file)
+          # initialize it normally if a json_key_path is provided
+          if !json_key_path.empty?
+            key_file = java.io.FileInputStream.new(json_key_path)
+            builder.setCredentials(GoogleCredentials.fromStream(key_file))
+          else
+            # if a json_key_path is not provided, try using the getApplicationDefault, normally 
+            # using GOOGLE_APPLICATION_CREDENTIALS env variable 
+            begin
+              builder.setCredentials(GoogleCredentials.getApplicationDefault())
+            rescue Java::JavaIo::IOException => e
+              # an IOException is generated if no default credentials exist, trying unauthenticated
+              builder = com.google.cloud.storage.StorageOptions.getUnauthenticatedInstance()
+              .toBuilder()
+            end
+          end
+          return builder
         end
 
+        
+
         java_import 'com.google.api.gax.rpc.FixedHeaderProvider'
         def http_headers
           gem_name = 'logstash-input-google_cloud_storage'

data/lib/logstash-input-google_cloud_storage_jars.rb

@@ -35,4 +35,4 @@ require_jar('com.google.protobuf', 'protobuf-java-util', '3.21.6')
 require_jar('org.threeten', 'threetenbp', '1.6.1')
 require_jar('com.fasterxml.jackson.core', 'jackson-core', '2.13.4')
 require_jar('com.google.code.findbugs', 'jsr305', '3.0.2')
-require_jar('org.logstash.inputs', 'plugin', '0.13.0')
+require_jar('org.logstash.inputs', 'plugin', '0.14.0')

data/version

@@ -1 +1 @@
-0.13.0
+0.14.0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: logstash-input-google_cloud_storage
 version: !ruby/object:Gem::Version
-  version: 0.13.0
+  version: 0.14.0
 platform: java
 authors:
 - Elastic
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-11-22 00:00:00.000000000 Z
+date: 2023-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -182,7 +182,7 @@ files:
 - vendor/jar-dependencies/io/opencensus/opencensus-contrib-http-util/0.31.1/opencensus-contrib-http-util-0.31.1.jar
 - vendor/jar-dependencies/javax/annotation/javax.annotation-api/1.3.2/javax.annotation-api-1.3.2.jar
 - vendor/jar-dependencies/org/checkerframework/checker-qual/3.25.0/checker-qual-3.25.0.jar
-- vendor/jar-dependencies/org/logstash/inputs/plugin/0.13.0/plugin-0.13.0.jar
+- vendor/jar-dependencies/org/logstash/inputs/plugin/0.14.0/plugin-0.14.0.jar
 - vendor/jar-dependencies/org/threeten/threetenbp/1.6.1/threetenbp-1.6.1.jar
 - version
 homepage: http://www.elastic.co/guide/en/logstash/current/index.html