logstash-filter-split 3.1.7 → 3.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3356dcc11862987712e4f9052ce4bc58be208f8f92d5cea69b23532e5b6ac603
-  data.tar.gz: af3d58b3f1677c1fe0269673d5e37286cb2947d2ac705bfdfdce94fcc8a0c080
+  metadata.gz: 6319d3b850981cec3a8059fa148c2c1cc1b0d098d999abca2b83aa7f8ad2a237
+  data.tar.gz: cff19eb56064b141a79c88a0ec6e744919e1cc595aec35dec94fa4eccaee1d87
 SHA512:
-  metadata.gz: f62920048aff417db5f8166cad3db2457fe5183b94e22ad9ec240a7c5dc858b5b2230e5b9fe79e25b86b5fc4362566f4265fdbbfe0bf573942e952a5bf8deefb
-  data.tar.gz: a0af9cda51ef388c88d3d1102a3ffa74711559a1e3b53d9616acd550ae294a0b0118874d0c23d90ad0a58ecaa4ac94516d4ae03dcb9a4e39465f85146a0f40da
+  metadata.gz: 69c83c78ea32fbd59e9cea67300cc92e1af1de12a5830dd1a3dfdb3864fb121d4195cd26cb203ee706a2e5ba28b550379958de9d3ed09521c22de4211126ba7e
+  data.tar.gz: ef2435e8916ee8b0b2d6a83ef55b2ba748df259c0245f6bfbfdfd27c9372e76ef27ecf0bc92ff83680fda03ea549701f7b2a4910bed3b1921a83ac1c9b4355f5

data/CHANGELOG.md

@@ -1,5 +1,7 @@
+## 3.1.8 Fixed issue where @target optimization would stop event.remove(@field) from being called, which can be expensive with large split fields. [#40](https://github.com/logstash-plugins/logstash-filter-split/pull/40)
+
 ## 3.1.7
-  - Fixed numeric values, optimized @target verification, cleanups and specs [36](https://github.com/logstash-plugins/logstash-filter-split/pull/36)
+  - Fixed numeric values, optimized @target verification, cleanups and specs [#36](https://github.com/logstash-plugins/logstash-filter-split/pull/36)
 
 ## 3.1.6
   - Fix crash on arrays with null values

data/lib/logstash/filters/split.rb

@@ -59,15 +59,13 @@ class LogStash::Filters::Split < LogStash::Filters::Base
   config :target, :validate => :string
 
   def register
-    # set @target to @field if not configured
-    @target ||= @field
   end
 
   def filter(event)
     original_value = event.get(@field)
 
     if original_value.is_a?(Array)
-      splits = target.nil? ? event.remove(@field) : original_value
+      splits = @target.nil? ? event.remove(@field) : original_value
     elsif original_value.is_a?(String)
       # Using -1 for 'limit' on String#split makes ruby not drop trailing empty
       # splits.
@@ -81,12 +79,15 @@ class LogStash::Filters::Split < LogStash::Filters::Base
     # Skip filtering if splitting this event resulted in only one thing found.
     return if splits.length == 1 && original_value.is_a?(String)
 
+    # set event_target to @field if not configured
+    event_target = @target.nil? ? @field : @target
+
     splits.each do |value|
       next if value.nil? || (value.is_a?(String) && value.empty?)
       @logger.debug? && @logger.debug("Split event", :value => value, :field => @field)
 
       event_split = event.clone
-      event_split.set(@target, value)
+      event_split.set(event_target, value)
       filter_matched(event_split)
 
       # Push this new event onto the stack at the LogStash::FilterWorker

data/logstash-filter-split.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-filter-split'
-  s.version         = '3.1.7'
+  s.version         = '3.1.8'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Splits multi-line messages into distinct events"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/filters/split_spec.rb

@@ -12,6 +12,10 @@ describe LogStash::Filters::Split do
       }
     CONFIG
 
+    sample "big\n" do
+      insist { subject.get("message") } == 'big'
+    end
+
     sample "big\nbird\nsesame street" do
       insist { subject.length } == 3
       insist { subject[0].get("message") } == "big"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-split
 version: !ruby/object:Gem::Version
-  version: 3.1.7
+  version: 3.1.8
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-01-04 00:00:00.000000000 Z
+date: 2020-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement