logstash-filter-split 3.1.6 → 3.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe030f91f29f8ff0430df5dfd10383768f638791b8c0daff31b6c812ee5da2f1
-  data.tar.gz: 1f62b67442999091a356fda0475dfa57c1f1b721050e6ecee1fc388f0315084c
+  metadata.gz: 3356dcc11862987712e4f9052ce4bc58be208f8f92d5cea69b23532e5b6ac603
+  data.tar.gz: af3d58b3f1677c1fe0269673d5e37286cb2947d2ac705bfdfdce94fcc8a0c080
 SHA512:
-  metadata.gz: 1ec5139936cada2b3ae96193e74604ff271f5a7bfda523f39d7309e0fce259dbbec70767d0595c75db9efa1e4a4a6e0b52888e3dc264391b35ed32c45a6e5f53
-  data.tar.gz: dc6a646310aea30b1ddbf0fda097e648063277e53442e0afb9c5daadecc5f78509bc848cf8ecc9f86bbfb9f23afac473dd1d772141b7cae409455022eec5d375
+  metadata.gz: f62920048aff417db5f8166cad3db2457fe5183b94e22ad9ec240a7c5dc858b5b2230e5b9fe79e25b86b5fc4362566f4265fdbbfe0bf573942e952a5bf8deefb
+  data.tar.gz: a0af9cda51ef388c88d3d1102a3ffa74711559a1e3b53d9616acd550ae294a0b0118874d0c23d90ad0a58ecaa4ac94516d4ae03dcb9a4e39465f85146a0f40da

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 3.1.7
+  - Fixed numeric values, optimized @target verification, cleanups and specs [36](https://github.com/logstash-plugins/logstash-filter-split/pull/36)
+
 ## 3.1.6
   - Fix crash on arrays with null values
 

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2012–2016 Elasticsearch <http://www.elastic.co>
+Copyright (c) 2012-2018 Elasticsearch <http://www.elastic.co>
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

data/docs/index.asciidoc

@@ -25,7 +25,7 @@ placing each value resulting from the split into a clone of the original
 event. The field being split can either be a string or an array.
 
 An example use case of this filter is for taking output from the
-<<plugins-inputs-exec,exec input plugin>> which emits one event for
+{logstash-ref}/plugins-inputs-exec.html[exec input plugin] which emits one event for
 the whole output of a command and splitting that output by newline -
 making each line an event.
 
@@ -108,4 +108,4 @@ string. If you are splitting a JSON array into multiple events, you can ignore t
 
 
 [id="plugins-{type}s-{plugin}-common-options"]
-include::{include_path}/{type}.asciidoc[]
+include::{include_path}/{type}.asciidoc[]

data/lib/logstash/filters/split.rb

@@ -58,15 +58,12 @@ class LogStash::Filters::Split < LogStash::Filters::Base
   # If not set, the target field defaults to split field name.
   config :target, :validate => :string
 
-  public
   def register
-    # Nothing to do
-  end # def register
+    # set @target to @field if not configured
+    @target ||= @field
+  end
 
-  public
   def filter(event)
-    
-
     original_value = event.get(@field)
 
     if original_value.is_a?(Array)
@@ -83,18 +80,13 @@ class LogStash::Filters::Split < LogStash::Filters::Base
 
     # Skip filtering if splitting this event resulted in only one thing found.
     return if splits.length == 1 && original_value.is_a?(String)
-    #or splits[1].empty?
 
     splits.each do |value|
-      next if value.nil? || value.empty?
+      next if value.nil? || (value.is_a?(String) && value.empty?)
+      @logger.debug? && @logger.debug("Split event", :value => value, :field => @field)
 
       event_split = event.clone
-      @logger.debug("Split event", :value => value, :field => @field)
-      if @target.nil?
-        event_split.set(@field, value)
-      else
-        event_split.set(@target, value)
-      end
+      event_split.set(@target, value)
       filter_matched(event_split)
 
       # Push this new event onto the stack at the LogStash::FilterWorker
@@ -103,5 +95,5 @@ class LogStash::Filters::Split < LogStash::Filters::Base
 
     # Cancel this event, we'll use the newly generated ones above.
     event.cancel
-  end # def filter
-end # class LogStash::Filters::Split
+  end
+end

data/logstash-filter-split.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-filter-split'
-  s.version         = '3.1.6'
+  s.version         = '3.1.7'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Splits multi-line messages into distinct events"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/filters/split_spec.rb

@@ -122,6 +122,42 @@ describe LogStash::Filters::Split do
     end
   end
 
+  describe "split array of numerics" do
+    config <<-CONFIG
+      filter {
+        split {
+          field => "array"
+          target => "element"
+        }
+      }
+    CONFIG
+
+    sample("array" => [1, 2, 3]) do
+      insist { subject.length } == 3
+      insist { subject[0].get("element") } == 1
+      insist { subject[1].get("element") } == 2
+      insist { subject[2].get("element") } == 3
+    end
+  end
+
+  describe "split array of numerics and strings" do
+    config <<-CONFIG
+      filter {
+        split {
+          field => "array"
+          target => "element"
+        }
+      }
+    CONFIG
+
+    sample("array" => [1, 2, "three", ""]) do
+      insist { subject.length } == 3
+      insist { subject[0].get("element") } == 1
+      insist { subject[1].get("element") } == 2
+      insist { subject[2].get("element") } == "three"
+    end
+  end
+
   context "when invalid type is passed" do
     let(:filter) { LogStash::Filters::Split.new({"field" => "field"}) }
     let(:logger) { filter.logger }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-split
 version: !ruby/object:Gem::Version
-  version: 3.1.6
+  version: 3.1.7
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-12-11 00:00:00.000000000 Z
+date: 2019-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement