logstash-filter-mutate 3.5.0 → 3.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 69f20a428551c3f5ddd1667b08cc5b8138f66f8e966aeb797ccda27684dd4e13
-  data.tar.gz: 0c0875f25f5feb9beba83a08ddb0c1576f11a72c3596c2d0c4fd7acc3ac715ed
+  metadata.gz: 5879507831fc15a821590956915fa601801af67d70636e26b1faf6652a743962
+  data.tar.gz: f387463d9e4ebfe44ce007461d0313ce7e172ab8260ca6775d0a95531b6480a3
 SHA512:
-  metadata.gz: 93692404a440374e0b958222b3ee13dac1d1e54822c3fb119e3fdfc1af328a644aef58cc5f4f92dcf3ee20820c17f773504f4d3ed44f91e7982ab5033829984c
-  data.tar.gz: 73a58d81336dc139c41c1c50e55d90c59a7cadd3016864cfc5affd96766241940e203efb24b1b9cb6d79608997f0492d80be4ffa501bc02242b25c18d5dcd809
+  metadata.gz: 4a2c3817cba6d8f6f02aae7f4c5dcc890dab263db38f7d8fc30e74ac735f20837c663c5c5913cf9c9743a9946f738f7f8b088aef047c606d37773e8cff78df54
+  data.tar.gz: 69a235e0bf9e8434ce8b5fe06c990053ef83649885bce61c375d7a1d5dc42ea54d4a9fdb88fd8de6a4fdb99620b97f9a5de0214a7f12f5ba6373bf77bbae0aae

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+## 3.5.4
+ - DOC: In 'replace' documentation, mention 'add' behavior [#155](https://github.com/logstash-plugins/logstash-filter-mutate/pull/155)
+ - DOC: Add warning about #27 [#101](https://github.com/logstash-plugins/logstash-filter-mutate/pull/101)
+
+## 3.5.3
+ - DOC: Expand description and behaviors for `rename` option [#156](https://github.com/logstash-plugins/logstash-filter-mutate/pull/156)
+
+## 3.5.2
+ - Fix: ensure that when an error occurs during registration, we use the correct i18n key to propagate the error message in a useful manner [#154](https://github.com/logstash-plugins/logstash-filter-mutate/pull/154)
+
+## 3.5.1
+ - Fix: removed a minor optimization in case-conversion helpers that could result in a race condition in very rare and specific situations [#151](https://github.com/logstash-plugins/logstash-filter-mutate/pull/151)
+
+## 3.5.0
+ - Fix: eliminated possible pipeline crashes; when a failure occurs during the application of this mutate filter, the rest of
+the operations are now aborted and a configurable tag is added to the event [#136](https://github.com/logstash-plugins/logstash-filter-mutate/pull/136)
+
 ## 3.4.0
  - Added ability to directly convert from integer and float to boolean [#127](https://github.com/logstash-plugins/logstash-filter-mutate/pull/127)
 

data/LICENSE

@@ -1,13 +1,202 @@
-Copyright (c) 2012-2018 Elasticsearch <http://www.elastic.co>
 
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
 
-    http://www.apache.org/licenses/LICENSE-2.0
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
 
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright 2020 Elastic and contributors
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

data/README.md

@@ -1,6 +1,6 @@
 # Logstash Plugin
 
-[![Travis Build Status](https://travis-ci.org/logstash-plugins/logstash-filter-mutate.svg)](https://travis-ci.org/logstash-plugins/logstash-filter-mutate)
+[![Travis Build Status](https://travis-ci.com/logstash-plugins/logstash-filter-mutate.svg)](https://travis-ci.com/logstash-plugins/logstash-filter-mutate)
 
 This is a plugin for [Logstash](https://github.com/elastic/logstash).
 

data/docs/index.asciidoc

@@ -44,19 +44,19 @@ Mutations in a config file are executed in this order:
 * merge
 * copy
 
-You can control the order by using separate mutate blocks.
+Warning: Each mutation must be in its own code block if the sequence of operations needs to be preserved.
 
 Example:
 [source,ruby]
 -----
 filter {
     mutate {
-        split => ["hostname", "."]
-        add_field => { "shortHostname" => "%{hostname[0]}" }
+        split => { "hostname" => "." }
+        add_field => { "shortHostname" => "%{[hostname][0]}" }
     }
 
     mutate {    
-        rename => ["shortHostname", "hostname" ]
+        rename => {"shortHostname" => "hostname"}
     }
 }
 -----
@@ -111,10 +111,10 @@ Valid conversion targets, and their expected behaviour with different inputs are
    - same as `integer`, except string values support dot-separators and comma-decimals (e.g., `"1.000"` produces an integer with value of one thousand)
  * `float`:
    - integers are converted to floats
-   - strings are parsed; comma-separators and dot-decimals are supported (e.g., `"1,000.5"` produces an integer with value of one thousand and one half)
+   - strings are parsed; comma-separators and dot-decimals are supported (e.g., `"1,000.5"` produces a float with value of one thousand and one half)
    - boolean true and boolean false are converted to `1.0` and `0.0` respectively
  * `float_eu`:
-   - same as `float`, except string values support dot-separators and comma-decimals (e.g., `"1.000,5"` produces an integer with value of one thousand and one half)
+   - same as `float`, except string values support dot-separators and comma-decimals (e.g., `"1.000,5"` produces a float with value of one thousand and one half)
  * `string`:
    - all values are stringified and encoded with UTF-8
  * `boolean`:
@@ -265,6 +265,13 @@ Example:
 
 Rename one or more fields.
 
+If the destination field already exists, its value is replaced.
+
+If one of the source fields doesn't exist, no action is performed for that field.
+(This is not considered an error; the `tag_on_failure` tag is not applied.)
+
+When renaming multiple fields, the order of operations is not guaranteed.
+
 Example:
 [source,ruby]
     filter {
@@ -280,7 +287,8 @@ Example:
   * Value type is <<hash,hash>>
   * There is no default value for this setting.
 
-Replace the value of a field with a new value. The new value can include `%{foo}` strings
+Replace the value of a field with a new value, or add the field if it
+doesn't already exist. The new value can include `%{foo}` strings
 to help you build a new value from other parts of the event.
 
 Example:

data/lib/logstash/filters/mutate.rb

@@ -220,7 +220,7 @@ class LogStash::Filters::Mutate < LogStash::Filters::Base
     @convert.nil? or @convert.each do |field, type|
       if !valid_conversions.include?(type)
         raise LogStash::ConfigurationError, I18n.t(
-          "logstash.agent.configuration.invalid_plugin_register",
+          "logstash.runner.configuration.invalid_plugin_register",
           :plugin => "filter",
           :type => "mutate",
           :error => "Invalid conversion type '#{type}', expected one of '#{valid_conversions.join(',')}'"
@@ -232,7 +232,7 @@ class LogStash::Filters::Mutate < LogStash::Filters::Base
     @gsub.nil? or @gsub.each_slice(3) do |field, needle, replacement|
       if [field, needle, replacement].any? {|n| n.nil?}
         raise LogStash::ConfigurationError, I18n.t(
-          "logstash.agent.configuration.invalid_plugin_register",
+          "logstash.runner.configuration.invalid_plugin_register",
           :plugin => "filter",
           :type => "mutate",
           :error => "Invalid gsub configuration #{[field, needle, replacement]}. gsub requires 3 non-nil elements per config entry"
@@ -424,8 +424,7 @@ class LogStash::Filters::Mutate < LogStash::Filters::Base
             (elem.is_a?(String) ? elem.upcase : elem)
           end
         when String
-          # nil means no change was made to the String
-          original.upcase! || original
+          original.upcase
         else
           @logger.debug? && @logger.debug("Can't uppercase something that isn't a string", :field => field, :value => original)
           original
@@ -445,7 +444,7 @@ class LogStash::Filters::Mutate < LogStash::Filters::Base
           (elem.is_a?(String) ? elem.downcase : elem)
         end
       when String
-        original.downcase! || original
+        original.downcase
       else
         @logger.debug? && @logger.debug("Can't lowercase something that isn't a string", :field => field, :value => original)
         original
@@ -465,7 +464,7 @@ class LogStash::Filters::Mutate < LogStash::Filters::Base
           (elem.is_a?(String) ? elem.capitalize : elem)
         end
       when String
-        original.capitalize! || original
+        original.capitalize
       else
         @logger.debug? && @logger.debug("Can't capitalize something that isn't a string", :field => field, :value => original)
         original

data/logstash-filter-mutate.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-filter-mutate'
-  s.version         = '3.5.0'
+  s.version         = '3.5.4'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Performs mutations on fields"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"
@@ -23,5 +23,6 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "logstash-core-plugin-api", ">= 1.60", "<= 2.99"
   s.add_development_dependency "logstash-patterns-core"
   s.add_development_dependency "logstash-filter-grok"
+  s.add_development_dependency "logstash-codec-plain"
   s.add_development_dependency "logstash-devutils"
 end

data/spec/filters/integration/multi_stage_spec.rb

@@ -1,71 +1,43 @@
 # encoding: utf-8
 require "logstash/devutils/rspec/spec_helper"
-require "logstash/filters/mutate"
 
-# running mutate which depends on grok  outside a logstash package means
-# LOGSTASH_HOME will not be defined, so let's set it here
-# before requiring the grok filter
-unless LogStash::Environment.const_defined?(:LOGSTASH_HOME)
-  LogStash::Environment::LOGSTASH_HOME = File.expand_path("../../../", __FILE__)
-end
-
-describe LogStash::Filters::Mutate do
-  let(:pipeline) do
-    new_pipeline_from_string(config)
-  end
-
-  let(:events) do
-    arr = event.is_a?(Array) ? event : [event]
-    arr.map do |evt|
-      LogStash::Event.new(evt.is_a?(String) ? LogStash::Json.load(evt) : evt)
-    end
+module LogStash::Environment
+  # running mutate which depends on grok  outside a logstash package means
+  # LOGSTASH_HOME will not be defined, so let's set it here
+  # before requiring the grok filter
+  unless self.const_defined?(:LOGSTASH_HOME)
+    LOGSTASH_HOME = File.expand_path("../../../", __FILE__)
   end
 
-  let(:results) do
-    pipeline.instance_eval { @filters.each(&:register) }
-    results  = []
-    events.each do |evt|
-      # filter call the block on all filtered events, included new events added by the filter
-      pipeline.filter(evt) do |filtered_event|
-        results.push(filtered_event)
-      end
+  # also :pattern_path method must exist (due grok filter)
+  unless self.method_defined?(:pattern_path)
+    def pattern_path(path)
+      ::File.join(LOGSTASH_HOME, "patterns", path)
     end
-    pipeline.flush_filters(:final => true) { |flushed_event| results << flushed_event }
-
-    results.select { |e| !e.cancelled? }
   end
+end
 
-  describe 'MUTATE-33: multi stage with json, grok and mutate, Case mutation' do
-    let(:event) do
-      "{\"message\":\"hello WORLD\",\"lower1\":\"PPQQRRSS\",\"lower2\":\"pppqqq\"}"
-    end
+describe 'LogStash::Filters::Mutate' do
 
+  context 'MUTATE-33: multi stage with json, grok and mutate, Case mutation' do
     let(:config) do
       <<-CONFIG
-filter {
-    grok {
+    filter {
+      grok {
         match => { "message" => "(?:hello) %{WORD:bar}" }
         break_on_match => false
+      }
+      mutate {
+        lowercase => [ "bar", "lower1", "lower2" ]
+      }
     }
-    mutate {
-      lowercase => [ "bar", "lower1", "lower2" ]
-    }
-}
 CONFIG
     end
 
-    it 'change case of the target, bar value is lowercase' do
+    sample("message" => "hello WORLD", "lower1" => "PPQQRRSS", "lower2" => "pppqqq") do
       result = results.first
       expect(result.get("bar")).to eq('world')
-    end
-
-    it 'change case of the target, lower1 value is lowercase' do
-      result = results.first
       expect(result.get("lower1")).to eq("ppqqrrss")
-    end
-
-    it 'change case of the target, lower2 value is lowercase' do
-      result = results.first
       expect(result.get("lower2")).to eq("pppqqq")
     end
 

data/spec/filters/mutate_spec.rb

@@ -153,6 +153,21 @@ describe LogStash::Filters::Mutate do
         expect(event).not_to include("fake_field")
       end
     end
+    context "avoid mutating contents of field, as they may be shared" do
+      let(:original_value) { "oRiGiNaL vAlUe".freeze }
+      let(:shared_value) { original_value.dup }
+      let(:attrs) { {"field" => shared_value } }
+      let(:config) do
+        {
+          operation => "field"
+        }
+      end
+
+      it 'should not mutate the value' do
+        subject.filter(event)
+        expect(shared_value).to eq(original_value)
+      end
+    end
   end
 end
 
@@ -306,7 +321,7 @@ describe LogStash::Filters::Mutate do
       CONFIG
 
       sample "not_really_important" do
-        expect {subject}.to raise_error LogStash::ConfigurationError
+        expect {subject}.to raise_error(LogStash::ConfigurationError, /Invalid conversion type/)
       end
     end
     describe "invalid gsub triad should raise a configuration error" do
@@ -319,7 +334,7 @@ describe LogStash::Filters::Mutate do
       CONFIG
 
       sample "not_really_important" do
-        expect {subject}.to raise_error LogStash::ConfigurationError
+        expect {subject}.to raise_error(LogStash::ConfigurationError, /Invalid gsub configuration/)
       end
     end
   end
@@ -399,10 +414,9 @@ describe LogStash::Filters::Mutate do
     }
 
     sample event do
-      # ATM, only the ASCII characters will case change
-      expect(subject.get("lowerme")).to eq [ "АБВГД\0mmm", "こにちわ", "xyzółć", "nÎcË gÛŸ"]
-      expect(subject.get("upperme")).to eq [ "аБвгд\0MMM", "こにちわ", "XYZółć", "NîCë Gûÿ"]
-      expect(subject.get("capitalizeme")).to eq [ "АБВГД\u0000mmm", "こにちわ", "Xyzółć", "NÎcË gÛŸ"]
+      expect(subject.get("lowerme")).to eq [ "абвгд\0mmm", "こにちわ", "xyzółć", "nîcë gûÿ"]
+      expect(subject.get("upperme")).to eq [ "АБВГД\0MMM", "こにちわ", "XYZÓŁĆ", "NÎCË GÛŸ"]
+      expect(subject.get("capitalizeme")).to eq [ "Абвгд\0mmm", "こにちわ", "Xyzółć", "Nîcë gûÿ"]
     end
   end
 
@@ -570,7 +584,7 @@ describe LogStash::Filters::Mutate do
       end
     end
   end
-  
+
 
   describe "convert to float_eu" do
     config <<-CONFIG
@@ -745,8 +759,8 @@ describe LogStash::Filters::Mutate do
     CONFIG
 
     sample("field_one" => "value", "x" => "one") do
-      reject { subject }.include?("field_one")
-      insist { subject }.include?("destination")
+      expect(subject).to_not include("field_one")
+      expect(subject).to include("destination")
     end
   end
 
@@ -760,8 +774,8 @@ describe LogStash::Filters::Mutate do
     CONFIG
 
     sample("field_one" => "value", "x" => "one") do
-      reject { subject }.include?("origin")
-      insist { subject }.include?("field_one")
+      expect(subject).to_not include("origin")
+      expect(subject).to include("field_one")
     end
   end
 
@@ -776,7 +790,7 @@ describe LogStash::Filters::Mutate do
 
     sample({ "foo" => { "bar" => "1000" } }) do
       expect(subject.get("[foo][bar]")).to eq 1000
-      expect(subject.get("[foo][bar]")).to be_a(Fixnum)
+      expect(subject.get("[foo][bar]")).to be_a(Integer)
     end
  end
 
@@ -791,7 +805,7 @@ describe LogStash::Filters::Mutate do
 
     sample({ "foo" => ["100", "200"] }) do
       expect(subject.get("[foo][0]")).to eq 100
-      expect(subject.get("[foo][0]")).to be_a(Fixnum)
+      expect(subject.get("[foo][0]")).to be_a(Integer)
     end
   end
 
@@ -812,15 +826,15 @@ describe LogStash::Filters::Mutate do
 
     sample({ "foo" => [false, true, "0", "1", "2"] }) do
       expect(subject.get("[foo][0]")).to eq 0
-      expect(subject.get("[foo][0]")).to be_a(Fixnum)
+      expect(subject.get("[foo][0]")).to be_a(Integer)
       expect(subject.get("[foo][1]")).to eq 1
-      expect(subject.get("[foo][1]")).to be_a(Fixnum)
+      expect(subject.get("[foo][1]")).to be_a(Integer)
       expect(subject.get("[foo][2]")).to eq 0
-      expect(subject.get("[foo][2]")).to be_a(Fixnum)
+      expect(subject.get("[foo][2]")).to be_a(Integer)
       expect(subject.get("[foo][3]")).to eq 1
-      expect(subject.get("[foo][3]")).to be_a(Fixnum)
+      expect(subject.get("[foo][3]")).to be_a(Integer)
       expect(subject.get("[foo][4]")).to eq 2
-      expect(subject.get("[foo][4]")).to be_a(Fixnum)
+      expect(subject.get("[foo][4]")).to be_a(Integer)
     end
   end
 
@@ -840,11 +854,11 @@ describe LogStash::Filters::Mutate do
 
       sample({ "foo" => ["1,000", "1,234,567.8", "123.4"] }) do
         expect(subject.get("[foo][0]")).to eq 1000
-        expect(subject.get("[foo][0]")).to be_a(Fixnum)
+        expect(subject.get("[foo][0]")).to be_a(Integer)
         expect(subject.get("[foo][1]")).to eq 1234567
-        expect(subject.get("[foo][1]")).to be_a(Fixnum)
+        expect(subject.get("[foo][1]")).to be_a(Integer)
         expect(subject.get("[foo][2]")).to eq 123
-        expect(subject.get("[foo][2]")).to be_a(Fixnum)
+        expect(subject.get("[foo][2]")).to be_a(Integer)
       end
     end
 
@@ -888,11 +902,11 @@ describe LogStash::Filters::Mutate do
 
       sample({ "foo" => ["1.000", "1.234.567,8", "123,4"] }) do
         expect(subject.get("[foo][0]")).to eq 1000
-        expect(subject.get("[foo][0]")).to be_a(Fixnum)
+        expect(subject.get("[foo][0]")).to be_a(Integer)
         expect(subject.get("[foo][1]")).to eq 1234567
-        expect(subject.get("[foo][1]")).to be_a(Fixnum)
+        expect(subject.get("[foo][1]")).to be_a(Integer)
         expect(subject.get("[foo][2]")).to eq 123
-        expect(subject.get("[foo][2]")).to be_a(Fixnum)
+        expect(subject.get("[foo][2]")).to be_a(Integer)
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-mutate
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.4
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-06-17 00:00:00.000000000 Z
+date: 2021-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -58,6 +58,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  name: logstash-codec-plain
+  prerelease: false
+  type: :development
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -112,8 +126,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.6.13
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Performs mutations on fields