logstash-filter-memcached 1.0.2 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8a2da94f92a0b08f29f431c88ed75c5f02c821a09032d50e1cc625e6ead02f1c
-  data.tar.gz: 7e32b399397bc8b2d7a6a11ee52221c1041618c8b59bcc3feb039cccf0e126b1
+  metadata.gz: 0f1f2515f5a21a93db4453ea7bb592250857b47cd96e8932ea413bea82c23f6a
+  data.tar.gz: 8712fd59ba85e32b97e6148595a83961208ed3bc2fc4a79a6e74b47c711594a8
 SHA512:
-  metadata.gz: 4820947ea301a4e3624a3420d5d442b318489d718ee026a765e3a6c66c3d8131fcfe33435db26bf915e7a5f56aa2508579f72b93c6a18eb1641698d352c9bfaa
-  data.tar.gz: 6bc21afd7b8d650565896ef9fa43356984feb7eb807d45c83e31aff18d24540477514fd18e560ddb91f3c4d807c31a347b289aa835813dfbe114bb11d9976438
+  metadata.gz: 7c827e902ee464b47b90ec977b3bc08542c0344aeeab4310ba036ec765c43e224f355cc0a198e284adf96cad228e30f1ce14a4181eb80d3b327b022811eec294
+  data.tar.gz: 92b386d854d7ec592fbe4ec3edb764b08c109f26131245a95438ce4776558b7b082a8f89140f604633dc403073430e42fb0c47abf46687037a7d95196666f4fe

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.2.0
+ - Upgrade Dalli to 3.x [#33](https://github.com/logstash-plugins/logstash-filter-memcached/pull/33)
+
+## 1.1.0
+ - Added better exception handling [#25](https://github.com/logstash-plugins/logstash-filter-memcached/pull/25)
+
 ## 1.0.2
  - Fixed issue with ttl not being set [#13](https://github.com/logstash-plugins/logstash-filter-memcached/pull/13)
 

data/CONTRIBUTORS

@@ -2,7 +2,8 @@ The following is a list of people who have contributed ideas, code, bug
 reports, or in general have helped logstash along its way.
 
 Contributors:
-* Ry Biesemeyer - ry.biesemeyer@elastic.co
+* Ry Biesemeyer (yaauie)
+* Colin Surprenant (colinsurprenant)
 
 Note: If you've sent us patches, bug reports, or otherwise contributed to
 Logstash, and you aren't on the list above and want to be, please let us know

data/LICENSE

@@ -1,11 +1,202 @@
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
 
-    http://www.apache.org/licenses/LICENSE-2.0
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
 
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright 2020 Elastic and contributors
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

data/README.md

@@ -1,6 +1,6 @@
 # Logstash Plugin
 
-[![Travis Build Status](https://travis-ci.org/logstash-plugins/logstash-filter-memcached.svg)](https://travis-ci.org/logstash-plugins/logstash-filter-memcached)
+[![Travis Build Status](https://travis-ci.com/logstash-plugins/logstash-filter-memcached.svg)](https://travis-ci.com/logstash-plugins/logstash-filter-memcached)
 
 This is a plugin for [Logstash](https://github.com/elastic/logstash).
 

data/lib/logstash/filters/memcached.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 require "logstash/filters/base"
 require "logstash/namespace"
+require 'dalli'
 
 # This filter provides facilities to interact with Memcached.
 class LogStash::Filters::Memcached < LogStash::Filters::Base
@@ -67,28 +68,59 @@ class LogStash::Filters::Memcached < LogStash::Filters::Base
   # NOTE: in Memcached, a value of 0 (default) means "never expire"
   config :ttl, :validate => :number, :default => 0
 
+  # Tags the event on failure. This can be used in later analysis.
+  config :tag_on_failure, :validate => :string, :default => "_memcached_failure"
+
   public
 
   attr_reader :cache
 
   def register
-    if @ttl < 0
-      logger.error("ttl cannot be negative")
-      fail("invalid ttl: cannot be negative")
+    raise(LogStash::ConfigurationError, "'ttl' option cannot be negative") if @ttl < 0
+
+    @memcached_hosts = validate_connection_hosts
+    @memcached_options = validate_connection_options
+    begin
+      @cache = new_connection(@memcached_hosts, @memcached_options)
+    rescue => e
+      logger.error("failed to connect to memcached", hosts: @memcached_hosts, options: @memcached_options, message: e.message)
+      fail("failed to connect to memcached")
     end
-
-    @cache = establish_connection
-  end # def register
+    @connected = Concurrent::AtomicBoolean.new(true)
+    @connection_mutex = Mutex.new
+  end
 
   def filter(event)
-    set_success = do_set(event)
-    get_success = do_get(event)
+    unless connection_available?
+      event.tag(@tag_on_failure)
+      return
+    end
 
-    filter_matched(event) if (set_success || get_success)
-  end # def filter
+    begin
+      set_success = do_set(event)
+      get_success = do_get(event)
+      filter_matched(event) if (set_success || get_success)
+    rescue Dalli::NetworkError, Dalli::RingError => e
+      event.tag(@tag_on_failure)
+      logger.error("memcached communication error",  hosts: @memcached_hosts, options: @memcached_options, message: e.message)
+      close
+    rescue => e
+      meta = { :message => e.message }
+      meta[:backtrace] = e.backtrace if logger.debug?
+      logger.error("unexpected error", meta)
+      event.tag(@tag_on_failure)
+    end
+  end
 
   def close
-    cache.close
+    @connection_mutex.synchronize do
+      @connected.make_false
+      cache.close
+    end
+  rescue => e
+    # we basically ignore any error here as we may be trying to close an invalid
+    # connection or if we close on shutdown we can also ignore any error
+    logger.debug("error closing memcached connection", :message => e.message)
   end
 
   private
@@ -141,19 +173,33 @@ class LogStash::Filters::Memcached < LogStash::Filters::Base
     return true
   end
 
-  def establish_connection
-    require 'dalli'
-
-    hosts = validate_connection_hosts
-    options = validate_connection_options
+  def new_connection(hosts, options)
     logger.debug('connecting to memcached', context(hosts: hosts, options: options))
-    Dalli::Client.new(@hosts, options).tap do |client|
-      begin
-        client.alive!
-      rescue Dalli::RingError
-        logger.error("failed to connect", context(hosts: hosts, options: options))
-        fail("cannot connect to memcached")
-      end
+    Dalli::Client.new(hosts, options).tap { |client| client.alive! }
+  end
+
+  # reconnect is not thread safe
+  def reconnect(hosts, options)
+    begin
+      @cache = new_connection(hosts, options)
+      @connected.make_true
+    rescue => e
+      logger.error("failed to reconnect to memcached", hosts: hosts, options: options, message: e.message)
+      @connected.make_false
+    end
+    return @connected.value
+  end
+
+  def connection_available?
+    # this method is called at every #filter method invocation and to minimize synchronization cost
+    # only @connected if fist check. The tradeoff is that another worker connection could be in the
+    # process of failing and @connected will not yet reflect that but this is acceptable for performance reason.
+    return true if @connected.true?
+
+    @connection_mutex.synchronize do
+      # the reconnection process is exclusive and will not be be concurrently performed in another worker
+      # by re-verifying the state of @connected from the exclusive code.
+      return @connected.true? ? true : reconnect(@memcached_hosts, @memcached_options)
     end
   end
 
@@ -165,8 +211,7 @@ class LogStash::Filters::Memcached < LogStash::Filters::Base
   end
 
   def validate_connection_hosts
-    logger.error("configuration: hosts empty!") && fail if @hosts.empty?
-
+    raise(LogStash::ConfigurationError, "'hosts' cannot be empty") if @hosts.empty?
     @hosts.map(&:to_s)
   end
 
@@ -178,4 +223,4 @@ class LogStash::Filters::Memcached < LogStash::Filters::Base
 
     @plugin_context.merge(hash)
   end
-end # class LogStash::Filters::Memcached
+end

data/logstash-filter-memcached.gemspec

@@ -1,11 +1,11 @@
 Gem::Specification.new do |s|
   s.name          = 'logstash-filter-memcached'
-  s.version       = '1.0.2'
+  s.version       = '1.2.0'
   s.licenses      = ['Apache-2.0']
   s.summary       = 'A Logstash filter plugin for interacting with memcached'
-  s.homepage      = 'https://github.com/yaauie/logstash-filter-memcached'
-  s.authors       = ['Ry Biesemeyer']
-  s.email         = 'ry.biesemeyer@elastic.co'
+  s.authors       = ["Elastic"]
+  s.email         = 'info@elastic.co'
+  s.homepage      = "http://www.elastic.co/guide/en/logstash/current/index.html"
   s.require_paths = ['lib']
 
   # Files
@@ -18,6 +18,6 @@ Gem::Specification.new do |s|
 
   # Gem dependencies
   s.add_runtime_dependency "logstash-core-plugin-api", "~> 2.0"
-  s.add_runtime_dependency "dalli", "~> 2.7"
+  s.add_runtime_dependency "dalli", "~> 3"
   s.add_development_dependency 'logstash-devutils'
 end

data/spec/filters/memcached_spec.rb

@@ -7,87 +7,150 @@ LogStash::Logging::Logger::configure_logging("TRACE")
 describe LogStash::Filters::Memcached do
   subject(:memcached_filter) { described_class.new(config) }
   let(:cache) { double('memcached') }
-  before(:each) do
-    allow(memcached_filter).to receive(:establish_connection).and_return(cache)
-    allow(memcached_filter).to receive(:close)
-    memcached_filter.register
-  end
-
-  after(:each) do
-    memcached_filter.close
-  end
 
-  describe "#get" do
-    let(:event) { ::LogStash::Event.new(data) }
-    let(:config) do
-      {
-        "hosts" => ["localhost:11211"],
-        "get" => { "success/%{success}/answer" => "[ultimate][answer]" }
-      }
+  describe "a well behaved memcached server" do
+    before(:each) do
+      allow(memcached_filter).to receive(:new_connection).and_return(cache)
+      allow(memcached_filter).to receive(:close)
+      memcached_filter.register
     end
-    let(:data) { { "success" => "true" } }
 
-    it "retrieves data from memcache" do
-      expect(cache).to receive(:get_multi).with(["success/true/answer"]).and_return({"success/true/answer" => "42"})
-      expect(memcached_filter).to receive(:filter_matched)
-      memcached_filter.filter(event)
-      expect(event.get("ultimate")).to eq("answer" => "42")
+    after(:each) do
+      memcached_filter.close
     end
 
-    context 'when memcached does not hold the value' do
-      before do
-        expect(cache).to receive(:get_multi).with(["success/true/answer"]).and_return({"success/true/answer" => nil})
+    describe "#get" do
+      let(:event) { ::LogStash::Event.new(data) }
+      let(:config) do
+        {
+          "hosts" => ["localhost:11211"],
+          "get" => { "success/%{success}/answer" => "[ultimate][answer]" }
+        }
       end
+      let(:data) { { "success" => "true" } }
 
-      it 'does not invoke `filter_matched`' do
-        expect(memcached_filter).to_not receive(:filter_matched)
+      it "retrieves data from memcache" do
+        expect(cache).to receive(:get_multi).with(["success/true/answer"]).and_return({"success/true/answer" => "42"})
+        expect(memcached_filter).to receive(:filter_matched)
         memcached_filter.filter(event)
+        expect(event.get("ultimate")).to eq("answer" => "42")
       end
 
-      it 'does not populate the value' do
-        memcached_filter.filter(event)
-        expect(event.include?("ultimate")).to be false
+      context 'when memcached does not hold the value' do
+        before do
+          expect(cache).to receive(:get_multi).with(["success/true/answer"]).and_return({"success/true/answer" => nil})
+        end
+
+        it 'does not invoke `filter_matched`' do
+          expect(memcached_filter).to_not receive(:filter_matched)
+          memcached_filter.filter(event)
+        end
+
+        it 'does not populate the value' do
+          memcached_filter.filter(event)
+          expect(event.include?("ultimate")).to be false
+        end
+      end
+    end
+
+    describe "#set" do
+      let(:event) { ::LogStash::Event.new(data) }
+      let(:config) do
+        {
+          "hosts" => ["localhost:11211"],
+          "set" => { "[answer]" => "success/%{success}/answer" },
+        }
+      end
+      before(:each) do
+        allow(cache).to receive(:multi) {|&b| b.call }
+        allow(cache).to receive(:set)
+      end
+
+      context 'when the event includes the value to set' do
+        let(:data) { { "answer" => "42", "success" => "true" } }
+
+        it "sets data on memcached" do
+          expect(cache).to receive(:set).with("success/true/answer", "42")
+          memcached_filter.filter(event)
+        end
+
+        it 'invokes `filter_matched`' do
+          expect(memcached_filter).to receive(:filter_matched)
+          memcached_filter.filter(event)
+        end
+      end
+
+      context 'when the event does not include the value being set' do
+        let(:data) { { "success" => "true" } }
+
+        it 'does not set data on memcached' do
+          expect(cache).to_not receive(:set)
+          memcached_filter.filter(event)
+        end
+
+        it 'does not invoke `filter_matched`' do
+          expect(memcached_filter).to_not receive(:filter_matched)
+          memcached_filter.filter(event)
+        end
       end
     end
   end
 
-  describe "#set" do
-    let(:event) { ::LogStash::Event.new(data) }
+  describe "a misbehaved memcached server" do
     let(:config) do
       {
         "hosts" => ["localhost:11211"],
+        "get" => { "success/%{success}/answer" => "[ultimate][answer]" },
         "set" => { "[answer]" => "success/%{success}/answer" },
       }
     end
-    before(:each) do
-      allow(cache).to receive(:multi) {|&b| b.call }
-      allow(cache).to receive(:set)
+
+    context "#register" do
+      it "raises error upon new connection error" do
+        allow(memcached_filter).to receive(:new_connection).and_raise("some error")
+        expect{memcached_filter.register}.to raise_error(RuntimeError)
+      end
     end
 
-    context 'when the event includes the value to set' do
+    context "#get and #set" do
+      let(:event) { ::LogStash::Event.new(data) }
       let(:data) { { "answer" => "42", "success" => "true" } }
 
-      it "sets data on memcached" do
-        expect(cache).to receive(:set).with("success/true/answer", "42")
-        memcached_filter.filter(event)
+      before(:each) do
+        allow(memcached_filter).to receive(:new_connection).and_return(cache)
+        allow(cache).to receive(:close).and_raise("some error")
+
+        memcached_filter.register
       end
 
-      it 'invokes `filter_matched`' do
-        expect(memcached_filter).to receive(:filter_matched)
-        memcached_filter.filter(event)
+      after(:each) do
+        memcached_filter.close
       end
-    end
 
-    context 'when the event does not include the value being set' do
-      let(:data) { { "success" => "true" } }
+      it "fails #get and tag" do
+        allow(cache).to receive(:multi) { |&b| b.call }
+        allow(cache).to receive(:set).with("success/true/answer", "42")
+        expect(cache).to receive(:get_multi).with(["success/true/answer"]).and_raise(Dalli::RingError.new("foo"))
+        expect(memcached_filter).not_to receive(:filter_matched)
+        memcached_filter.filter(event)
+        expect(event.get("tags")).to eq(["_memcached_failure"])
+      end
 
-      it 'does not set data on memcached' do
-        expect(cache).to_not receive(:set)
+      it "fails #set and tag" do
+        allow(cache).to receive(:get_multi).with(["success/true/answer"]).and_return({"success/true/answer" => "42"})
+        allow(cache).to receive(:multi) { |&b| b.call }
+        expect(cache).to receive(:set).with("success/true/answer", "42").and_raise(Dalli::RingError.new("foo"))
+        expect(memcached_filter).not_to receive(:filter_matched)
         memcached_filter.filter(event)
+        expect(event.get("tags")).to eq(["_memcached_failure"])
       end
 
-      it 'does not invoke `filter_matched`' do
-        expect(memcached_filter).to_not receive(:filter_matched)
+      it "reconnects after a failure" do
+        allow(memcached_filter).to receive(:do_get).and_raise(Dalli::RingError.new("foo"))
+        allow(memcached_filter).to receive(:do_set).and_raise(Dalli::RingError.new("foo"))
+
+        expect(memcached_filter).to receive(:new_connection).once.and_raise("foo")
+        memcached_filter.filter(event)
         memcached_filter.filter(event)
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-memcached
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.2.0
 platform: ruby
 authors:
-- Ry Biesemeyer
+- Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-01-24 00:00:00.000000000 Z
+date: 2023-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3'
   name: dalli
   prerelease: false
   type: :runtime
@@ -37,7 +37,7 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description:
-email: ry.biesemeyer@elastic.co
+email: info@elastic.co
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -68,7 +68,7 @@ files:
 - logstash-filter-memcached.gemspec
 - spec/filters/memcached_spec.rb
 - spec/spec_helper.rb
-homepage: https://github.com/yaauie/logstash-filter-memcached
+homepage: http://www.elastic.co/guide/en/logstash/current/index.html
 licenses:
 - Apache-2.0
 metadata:
@@ -89,8 +89,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project:
-rubygems_version: 2.6.13
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: A Logstash filter plugin for interacting with memcached