logstash-filter-jdbc_static 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14fbe648ee79593894c1735cc82823cc34dc423db0eb36e7d8f400e00290fbed
-  data.tar.gz: e8d9c13670e105dea7c59544d92e8eed15fb7bdcb7a0d2fc8e4069c4b139e20d
+  metadata.gz: cb24eb800c3a6892758e80502333948872a5a2c95ee3c0e0999c17477391449b
+  data.tar.gz: f114952a1f694bc161d2715efa6f20002c1f3d4ed8751cf4b476bed994b60718
 SHA512:
-  metadata.gz: 89fbedbb6c4258964e1a947830b95e3551118e04262637a5807d16b1dc8063517351d84ffc7ce31d72ed4eb16f352d20496f9f009bd570c70024d51827b84740
-  data.tar.gz: a132cdb916d82f0ea1eed798363bf50c092b1713a68df623ded472538e2bc5310c3b07a6de89c71223e20eeae99add66a6b413fecfa53518614dc0aa54bcdc64
+  metadata.gz: ab35006f966c8b29f1c6389821ada1c2817883159710bb63cb106c4710445cc2af175835986cb9f5e5e76c686774c200f4d6b054f4f3cff85565a3b379635190
+  data.tar.gz: bf40037a0d5c43c87808fbbb6ec2468a36c87b2ff1b1753150e6bc1952c468b92ba043fcd4c1e06f1d13b2c53f14ec3294144beb27b7eb2cb5e643e20d1aaf9a

data/CHANGELOG.md

@@ -1,5 +1,8 @@
+## 1.0.3
+ - Fix [jdbc_static filter - #25](https://github.com/logstash-plugins/logstash-filter-jdbc_static/issues/25) When index_columns is not specified, the create table statement has a syntax error.
+
 ## 1.0.2
- - Fix Fix [jdbc_static filter - #22](https://github.com/logstash-plugins/logstash-filter-jdbc_static/issues/22) Support multiple driver libraries.
+ - Fix [jdbc_static filter - #22](https://github.com/logstash-plugins/logstash-filter-jdbc_static/issues/22) Support multiple driver libraries.
  - Fixes for [jdbc_static filter - #18](https://github.com/logstash-plugins/logstash-filter-jdbc_static/issues/18), [jdbc_static filter - #17](https://github.com/logstash-plugins/logstash-filter-jdbc_static/issues/17), [jdbc_static filter - #12](https://github.com/logstash-plugins/logstash-filter-jdbc_static/issues/12) Use Java classloader to load driver jar. Use system import from file to loader local database. Prevent locking errors when no records returned.
  - Fix [jdbc_static filter - #8](https://github.com/logstash-plugins/logstash-filter-jdbc_static/issues/8) loader_schedule now works as designed.
 

data/lib/logstash/filters/jdbc/db_object.rb

@@ -16,7 +16,7 @@ module LogStash module Filters module Jdbc
       end
       schema_gen = db.create_table_generator()
       @columns.each {|col| schema_gen.column(col.name, col.datatype)}
-      schema_gen.index(@index_columns)
+      schema_gen.index(@index_columns) unless @index_columns.empty?
       options = {:generator => schema_gen}
       if @preserve_existing
         db.create_table?(@name, options)

data/lib/logstash/filters/jdbc/read_write_database.rb

@@ -31,6 +31,9 @@ module LogStash module Filters module Jdbc
       begin
         @rwlock.writeLock().lock()
         db_object.build(@db)
+        if db_object.index_columns.empty?
+          logger.warn("local_db_object '#{db_object.name}': `index_columns` is optional but on larger datasets consider adding an index on the lookup column, it will improve performance")
+        end
       rescue *CONNECTION_ERRORS => err
         # we do not raise an error when there is a connection error, we hope that the connection works next time
         logger.error("Connection error when initialising lookup db", :db_object => db_object.inspect, :exception => err.message, :backtrace => err.backtrace.take(8))

data/logstash-filter-jdbc_static.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name            = 'logstash-filter-jdbc_static'
-  s.version         = '1.0.2'
+  s.version         = '1.0.3'
   s.licenses        = ['Apache-2.0']
   s.summary         = "This filter executes a SQL query to fetch a SQL query result, store it locally then use a second SQL query to update an event."
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/filters/jdbc_static_spec.rb

@@ -6,7 +6,7 @@ require "sequel/adapters/jdbc"
 require "stud/temporary"
 require "timecop"
 
-LogStash::Logging::Logger::configure_logging("ERROR")
+# LogStash::Logging::Logger::configure_logging("WARN")
 
 module LogStash module Filters
   describe JdbcStatic do
@@ -123,6 +123,19 @@ module LogStash module Filters
           expect(event.get("server")).to eq([{"ip"=>ipaddr, "name"=>"server-254-255", "location"=>"MV-10-254-255"}])
         end
       end
+
+      context "under normal conditions when index_columns is not specified" do
+        let(:local_db_objects) do
+          [
+            {"name" => "servers", "columns" => [["ip", "varchar(64)"], ["name", "varchar(64)"], ["location", "varchar(64)"]]},
+          ]
+        end
+        it "enhances an event" do
+          plugin.register
+          plugin.filter(event)
+          expect(event.get("server")).to eq([{"ip"=>"10.3.1.1", "name"=>"mv-serv'r-1", "location"=>"MV-9-6-4"}])
+        end
+      end
     end
 
     describe "scheduled operation" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-jdbc_static
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-04-20 00:00:00.000000000 Z
+date: 2018-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement