logstash-filter-geoip 7.2.8-java → 7.2.9-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 558655d301e05d109880a34f424852c523f072f0653e1f475bf03e6fa07d7abc
-  data.tar.gz: 7dcb70f279c7fa5478f2c53c17dd7619bcc22b5d5c10f2c65f60ed67a0e70e05
+  metadata.gz: 8ecdee3ba977a4923a88d89927163eb43a2b737d9af69e2b24bfbaeaa1287d0b
+  data.tar.gz: c10294af62a93666ba5d625c9c616aaad9567abfeb43947cfbadf87e499715c5
 SHA512:
-  metadata.gz: 0e20c0b76759000330911cb9af9678313206225f4ea3033f24902d82522a0e1a7d8c54bd63e4dab5ac0d9abf8bb89985aa1924165763f9ba805add6d68d010a4
-  data.tar.gz: 4f61eec7adc06e1a8e5538c36b74a4d74aa5cb107c1cb057c11088662b6a7702d950de9c501500b22e0af759bd65d76a969c9e601485d099e272866286105923
+  metadata.gz: 892a4be2007c2627465150171d0888d4b42fe2c68d2ecc3030ffeade4332bbcc5a4660c17f834a7c5961700295f6c87e873fb44e0ed4995a9503b536809e166b
+  data.tar.gz: d8a405d1edb7970e7558d9c9679a9d18b4fe8539ea3bf53f84d28ce4e1bd0683ebabe631ef002c7214664b6b9657b98cacc3744673a0058048dba74f000866d8

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 7.2.9
+  - Fix: red CI in Logstash 8.0 [#201](https://github.com/logstash-plugins/logstash-filter-geoip/pull/201)
+  - Update Log4j dependency to 2.17.1
+
 ## 7.2.8
   - Update Log4j dependency to 2.17.0
 

data/logstash-filter-geoip.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-filter-geoip'
-  s.version         = '7.2.8'
+  s.version         = '7.2.9'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Adds geographical information about an IP address"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

data/spec/filters/geoip_ecs_spec.rb

@@ -48,7 +48,6 @@ describe LogStash::Filters::GeoIP do
           end
         end
 
-
         context "with ASN database" do
           let(:options) { common_options.merge({"database" => ASNDB}) }
 
@@ -59,27 +58,96 @@ describe LogStash::Filters::GeoIP do
             expect( event.get ecs_select[disabled: "[#{target}][asn]", v1: "[#{target}][as][number]"] ).to eq 15169
             expect( event.get ecs_select[disabled: "[#{target}][as_org]", v1: "[#{target}][as][organization][name]"] ).to eq "Google LLC"
           end
+
+          context "with customize fields" do
+            let(:fields) { ["AUTONOMOUS_SYSTEM_NUMBER"] }
+            let(:options) { common_options.merge({"database" => ASNDB, "fields" => fields}) }
+
+            it "should give asn field" do
+              plugin.filter(event)
+
+              expect( event.get ecs_select[disabled: "[#{target}][ip]", v1: "[#{target}][ip]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][as_org]", v1: "[#{target}][as][organization][name]"] ).to be_nil
+
+              expect( event.get ecs_select[disabled: "[#{target}][asn]", v1: "[#{target}][as][number]"] ).to eq 15169
+            end
+          end
         end
 
         context "with customize fields" do
-          let(:fields) { ["continent_name", "timezone"] }
-          let(:options) { common_options.merge({"fields" => fields}) }
+          context "continent_name and timezone" do
+            let(:fields) { ["continent_name", "timezone"] }
+            let(:options) { common_options.merge({"fields" => fields}) }
 
-          it "should return fields" do
-            plugin.filter(event)
+            it "should return fields in UTF8" do
+              plugin.filter(event)
 
-            expect( event.get ecs_select[disabled: "[#{target}][ip]", v1: "[#{target}][ip]"] ).to be_nil
-            expect( event.get ecs_select[disabled: "[#{target}][country_code2]", v1: "[#{target}][geo][country_iso_code]"] ).to be_nil
-            expect( event.get ecs_select[disabled: "[#{target}][country_name]", v1: "[#{target}][geo][country_name]"] ).to be_nil
-            expect( event.get ecs_select[disabled: "[#{target}][continent_code]", v1: "[#{target}][geo][continent_code]"] ).to be_nil
-            expect( event.get ecs_select[disabled: "[#{target}][location][lat]", v1: "[#{target}][geo][location][lat]"] ).to be_nil
-            expect( event.get ecs_select[disabled: "[#{target}][location][lon]", v1: "[#{target}][geo][location][lon]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][ip]", v1: "[#{target}][ip]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][country_code2]", v1: "[#{target}][geo][country_iso_code]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][country_name]", v1: "[#{target}][geo][country_name]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][continent_code]", v1: "[#{target}][geo][continent_code]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][location][lat]", v1: "[#{target}][geo][location][lat]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][location][lon]", v1: "[#{target}][geo][location][lon]"] ).to be_nil
+
+              continent_name = event.get ecs_select[disabled: "[#{target}][continent_name]", v1: "[#{target}][geo][continent_name]"]
+              timezone = event.get ecs_select[disabled: "[#{target}][timezone]", v1: "[#{target}][geo][timezone]"]
+              expect( continent_name ).to eq "North America"
+              expect( timezone ).to eq "America/Chicago"
+              expect( continent_name.encoding ).to eq Encoding::UTF_8
+              expect( timezone.encoding ).to eq Encoding::UTF_8
+            end
+          end
 
-            expect( event.get ecs_select[disabled: "[#{target}][continent_name]", v1: "[#{target}][geo][continent_name]"] ).to eq "North America"
-            expect( event.get ecs_select[disabled: "[#{target}][timezone]", v1: "[#{target}][geo][timezone]"] ).to eq "America/Chicago"
+          context "location" do
+            shared_examples "provide location, lat and lon" do
+              it "should return location, lat and lon" do
+                plugin.filter(event)
+
+                expect( event.get ecs_select[disabled: "[#{target}][ip]", v1: "[#{target}][ip]"] ).to be_nil
+                expect( event.get ecs_select[disabled: "[#{target}][country_code2]", v1: "[#{target}][geo][country_iso_code]"] ).to be_nil
+                expect( event.get ecs_select[disabled: "[#{target}][country_name]", v1: "[#{target}][geo][country_name]"] ).to be_nil
+                expect( event.get ecs_select[disabled: "[#{target}][continent_code]", v1: "[#{target}][geo][continent_code]"] ).to be_nil
+                expect( event.get ecs_select[disabled: "[#{target}][continent_name]", v1: "[#{target}][geo][continent_name]"] ).to be_nil
+                expect( event.get ecs_select[disabled: "[#{target}][timezone]", v1: "[#{target}][geo][timezone]"] ).to be_nil
+
+                expect( event.get ecs_select[disabled: "[#{target}][location][lat]", v1: "[#{target}][geo][location][lat]"] ).not_to be_nil
+                expect( event.get ecs_select[disabled: "[#{target}][location][lon]", v1: "[#{target}][geo][location][lon]"] ).not_to be_nil
+              end
+            end
+
+            context "location and longitude" do
+              let(:fields) { ["location", "longitude"] }
+              let(:options) { common_options.merge({"fields" => fields}) }
+              it_behaves_like "provide location, lat and lon"
+            end
+
+            context "location and latitude" do
+              let(:fields) { ["location", "latitude"] }
+              let(:options) { common_options.merge({"fields" => fields}) }
+              it_behaves_like "provide location, lat and lon"
+            end
           end
-        end
 
+          context "continent_code and IP is IPv6 format" do
+            let(:ip) { "2607:f0d0:1002:51::4" }
+            let(:fields) { ["continent_code", "ip"] }
+            let(:options) { common_options.merge({"fields" => fields}) }
+
+            it "should return fields" do
+              plugin.filter(event)
+
+              expect( event.get ecs_select[disabled: "[#{target}][country_code2]", v1: "[#{target}][geo][country_iso_code]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][country_name]", v1: "[#{target}][geo][country_name]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][continent_name]", v1: "[#{target}][geo][continent_name]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][location][lat]", v1: "[#{target}][geo][location][lat]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][location][lon]", v1: "[#{target}][geo][location][lon]"] ).to be_nil
+              expect( event.get ecs_select[disabled: "[#{target}][timezone]", v1: "[#{target}][geo][timezone]"] ).to be_nil
+
+              expect( event.get ecs_select[disabled: "[#{target}][ip]", v1: "[#{target}][ip]"] ).to eq("2607:f0d0:1002:51:0:0:0:4")
+              expect( event.get ecs_select[disabled: "[#{target}][continent_code]", v1: "[#{target}][geo][continent_code]"] ).to eq("NA")
+            end
+          end
+        end
       end
     end
 

data/spec/filters/geoip_offline_spec.rb

@@ -6,78 +6,33 @@ require "logstash/filters/geoip"
 CITYDB = ::Dir.glob(::File.expand_path(::File.join("..", "..", "..", "vendor", "GeoLite2-City.mmdb"), __FILE__)).first
 ASNDB = ::Dir.glob(::File.expand_path(::File.join("..", "..", "..", "vendor", "GeoLite2-ASN.mmdb"), __FILE__)).first
 
-describe LogStash::Filters::GeoIP do
-  describe "defaults" do
-    config <<-CONFIG
-      filter {
-        geoip {
-          source => "ip"
-          database => "#{CITYDB}"
-        }
-      }
-    CONFIG
-
-    sample("ip" => "8.8.8.8") do
-      insist { subject }.include?("geoip")
-
-      expected_fields = %w(ip country_code2 country_code3 country_name
-                           continent_code latitude longitude location)
-      expected_fields.each do |f|
-        insist { subject.get("geoip") }.include?(f)
-      end
-    end
 
-    sample("ip" => "127.0.0.1") do
-      # assume geoip fails on localhost lookups
-      expect(subject.get("geoip")).to eq({})
+describe LogStash::Filters::GeoIP do
+  shared_examples "invalid empty IP" do
+    it "should not give target field" do
+      expect(event.get(target)).to be_nil
+      expect(event.get("tags")).to include("_geoip_lookup_failure")
     end
   end
 
-  describe "normal operations" do
-    config <<-CONFIG
-      filter {
-        geoip {
-          source => "ip"
-          database => "#{CITYDB}"
-          target => src_ip
-          add_tag => "done"
-        }
-      }
-    CONFIG
-
-    context "when specifying the target" do
-
-      sample("ip" => "8.8.8.8") do
-        expect(subject).to include("src_ip")
-
-        expected_fields = %w(ip country_code2 country_code3 country_name
-                             continent_code latitude longitude location)
-        expected_fields.each do |f|
-          expect(subject.get("src_ip")).to include(f)
-        end
-      end
-
-      sample("ip" => "127.0.0.1") do
-        # assume geoip fails on localhost lookups
-        expect(subject.get("src_ip")).to eq({})
-      end
-    end
-
-    context "when specifying add_tag" do
-      sample("ip" => "8.8.8.8") do
-        expect(subject.get("tags")).to include("done")
-      end
+  shared_examples "invalid string IP" do
+    it "should give empty hash in target field" do
+      expect(event.get(target)).to eq({})
+      expect(event.get("tags")).to include("_geoip_lookup_failure")
     end
   end
 
-  describe "source is derived from target" do
-    subject(:event) { LogStash::Event.new("target" => { "ip" => "173.9.34.107" } ) }
+  let(:target) { "server" }
+
+  describe "invalid IP" do
+    let(:ip) { "173.9.34.107" }
+    let(:event) { LogStash::Event.new("client" => { "ip" => ip } ) }
     let(:plugin) {
       LogStash::Filters::GeoIP.new(
-        "source" => "[target][ip]",
-        "target" => "target",
-        "fields" => [ "city_name", "region_name" ],
-        "add_tag" => "done", "database" => CITYDB
+        "source" => "[client][ip]",
+        "target" => target,
+        "fields" => %w[country_name continent_code],
+        "database" => CITYDB
       )
     }
 
@@ -86,200 +41,71 @@ describe LogStash::Filters::GeoIP do
       plugin.filter(event)
     end
 
-    context "when source field 'ip' is a subfield of 'target'" do
-
-      it "should preserve value in [target][ip]" do
-        expect(event.get("[target][ip]")).to eq("173.9.34.107")
+    context "when ip is 127.0.0.1" do
+      let(:ip) { "127.0.0.1" }
+      it "should give empty hash" do
+        expect(event.get(target)).to eq({})
       end
-
-      it "should set other subfields of 'target' properly" do
-        expect(event.get("target").to_hash.keys.sort).to eq(["city_name", "ip", "region_name"])
-        expect(event.get("[target][city_name]")).to eq("Malden")
-        expect(event.get("[target][region_name]")).to eq("Massachusetts")
-      end
-
     end
 
-  end
-
-  describe "correct encodings with default db" do
-    config <<-CONFIG
-      filter {
-        geoip {
-          source => "ip"
-          database => "#{CITYDB}"
-        }
-      }
-    CONFIG
-    expected_fields = %w(ip country_code2 country_code3 country_name
-                           continent_code region_name city_name postal_code
-                           dma_code timezone)
-
-    sample("ip" => "1.1.1.1") do
-      checked = 0
-      expected_fields.each do |f|
-        next unless subject.get("geoip")[f]
-        checked += 1
-        insist { subject.get("geoip")[f].encoding } == Encoding::UTF_8
-      end
-      insist { checked } > 0
+    context "when ip is empty string" do
+      let(:ip) { "" }
+      it_behaves_like "invalid empty IP"
     end
 
-    sample("ip" => "189.2.0.0") do
-      checked = 0
-      expected_fields.each do |f|
-        next unless subject.get("geoip")[f]
-        checked += 1
-        insist { subject.get("geoip")[f].encoding } == Encoding::UTF_8
-      end
-      insist { checked } > 0
+    context "when ip is space" do
+      let(:ip) { "      " }
+      it_behaves_like "invalid empty IP"
     end
 
-  end
-
-  describe "location field" do
-    shared_examples_for "an event with a [geoip][location] field" do
-      subject(:event) { LogStash::Event.new("message" => "8.8.8.8") }
-      let(:plugin) { LogStash::Filters::GeoIP.new("source" => "message", "fields" => fields, "database" => CITYDB) }
-
-      before do
-        plugin.register
-        plugin.filter(event)
-      end
-
-      it "should have a location field" do
-        expect(event.get("[geoip][location]")).not_to(be_nil)
-      end
+    context "when ip is dash" do
+      let(:ip) { "-" }
+      it_behaves_like "invalid string IP"
     end
 
-    context "when latitude field is excluded" do
-      let(:fields) { ["country_name", "location", "longitude"] }
-      it_behaves_like "an event with a [geoip][location] field"
+    context "when ip is N/A" do
+      let(:ip) { "N/A" }
+      it_behaves_like "invalid string IP"
     end
 
-    context "when longitude field is excluded" do
-      let(:fields) { ["country_name", "location", "latitude"] }
-      it_behaves_like "an event with a [geoip][location] field"
+    context "when ip is two ip comma separated" do
+      let(:ip) { "123.45.67.89,61.160.232.222" }
+      it_behaves_like "invalid string IP"
     end
 
-    context "when both latitude and longitude field are excluded" do
-      let(:fields) { ["country_name", "location"] }
-      it_behaves_like "an event with a [geoip][location] field"
+    context "when ip is not found in the DB" do
+      let(:ip) { "0.0.0.0" }
+      it_behaves_like "invalid string IP"
     end
-  end
-
-  describe "an invalid IP" do
-    config <<-CONFIG
-          filter {
-            geoip {
-              source => "ip"
-              database => "#{CITYDB}"
-            }
-          }
-        CONFIG
-    describe "should not raise an error" do
-      sample("ip" => "-") do
-        expect{ subject }.to_not raise_error
-      end
 
-      sample("ip" => "~") do
-        expect{ subject }.to_not raise_error
-      end
-
-      sample("ip" => "") do
-        expect{ subject }.to_not raise_error
-      end
-
-      sample("ip" => "      ") do
-        expect{ subject }.to_not raise_error
-      end
+    context "when ip is IPv6 format for localhost" do
+      let(:ip) { "::1" }
+      it_behaves_like "invalid string IP"
     end
+  end
 
-    describe "empty database path" do
-      let(:plugin) { LogStash::Filters::GeoIP.new("source" => "message") }
-      let(:event) { LogStash::Event.new("message" => "8.8.8.8") }
-
-      context "when database manager give nil database path" do
-        it "should tag expired database" do
-          expect(plugin).to receive(:select_database_path).and_return(nil)
-
-          plugin.register
-          plugin.filter(event)
-
-          expect(event.get("tags")).to include("_geoip_expired_database")
-        end
-      end
-    end
+  describe "database path is empty" do
+    let(:plugin) { LogStash::Filters::GeoIP.new("source" => "message", "target" => target) }
+    let(:event) { LogStash::Event.new("message" => "8.8.8.8") }
 
-    describe "filter method outcomes" do
-      let(:plugin) { LogStash::Filters::GeoIP.new("source" => "message", "add_tag" => "done", "database" => CITYDB) }
-      let(:event) { LogStash::Event.new("message" => ipstring) }
+    context "when database manager give nil database path" do
+      it "should tag expired database" do
+        expect(plugin).to receive(:select_database_path).and_return(nil)
 
-      before do
         plugin.register
         plugin.filter(event)
-      end
-
-      context "when the bad IP is N/A" do
-        # regression test for issue https://github.com/logstash-plugins/logstash-filter-geoip/issues/50
-        let(:ipstring) { "N/A" }
-
-        it "should set the target field to an empty hash" do
-          expect(event.get("geoip")).to eq({})
-        end
-
-        it "should add failure tags" do
-          expect(event.get("tags")).to include("_geoip_lookup_failure")
-        end
-      end
-
-      context "when the bad IP is two ip comma separated" do
-        # regression test for issue https://github.com/logstash-plugins/logstash-filter-geoip/issues/51
-        let(:ipstring) { "123.45.67.89,61.160.232.222" }
 
-        it "should set the target field to an empty hash" do
-          expect(event.get("geoip")).to eq({})
-        end
+        expect(event.get("tags")).to include("_geoip_expired_database")
       end
-
-      context "when a IP is not found in the DB" do
-        let(:ipstring) { "0.0.0.0" }
-
-        it "should set the target field to an empty hash" do
-          expect(event.get("geoip")).to eq({})
-          expect(event.get("tags")).to include("_geoip_lookup_failure")
-        end
-      end
-
-      context "when IP is IPv6 format for localhost" do
-        let(:ipstring) { "::1" }
-
-        it "should set the target field to an empty hash" do
-          expect(event.get("geoip")).to eq({})
-        end
-      end
-
-      context "when IP is valid IPv6 format" do
-        let(:ipstring) { "2607:f0d0:1002:51::4" }
-
-        it "should set the target fields properly" do
-          expect(event.get("geoip")).not_to be_empty
-          expect(event.get("geoip")["ip"]).to eq("2607:f0d0:1002:51:0:0:0:4")
-          expect(event.get("geoip").to_hash.keys.sort).to eq(
-              ["continent_code", "country_code2", "country_code3", "country_name", "ip", "latitude", "location", "longitude", "timezone"]
-                                                          )
-        end
-      end
-
     end
-
   end
 
-  describe "an invalid database" do
+  describe "database path is an invalid database file" do
     config <<-CONFIG
           filter {
             geoip {
               source => "ip"
+              target => "geo"
               database => "./Gemfile"
             }
           }
@@ -292,40 +118,4 @@ describe LogStash::Filters::GeoIP do
     end
   end
 
-  describe "GeoIP2-ASN database" do
-    config <<-CONFIG
-      filter {
-        geoip {
-          source => "ip"
-          database => "#{ASNDB}"
-          default_database_type => "ASN"
-        }
-      }
-    CONFIG
-
-    sample("ip" => "8.8.8.8") do
-      expect(subject.get("geoip")).not_to be_empty
-      expect(subject.get("geoip")["asn"]).to eq(15169)
-      expect(subject.get("geoip")["as_org"]).to eq("Google LLC")
-    end
-  end
-
-  describe "GeoIP2-ASN database with fields" do
-    config <<-CONFIG
-      filter {
-        geoip {
-          source => "ip"
-          database => "#{ASNDB}"
-          default_database_type => "ASN"
-          fields => [ "AUTONOMOUS_SYSTEM_NUMBER" ]
-        }
-      }
-    CONFIG
-
-    sample("ip" => "8.8.8.8") do
-      expect(subject.get("geoip")).not_to be_empty
-      expect(subject.get("geoip")["asn"]).to eq(15169)
-    end
-  end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-filter-geoip
 version: !ruby/object:Gem::Version
-  version: 7.2.8
+  version: 7.2.9
 platform: java
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-18 00:00:00.000000000 Z
+date: 2022-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement