logstash-core-event-java 5.0.0.pre.rc1-java → 5.0.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1862bc126c2b8b9e79027171d795afc984a9ce95
-  data.tar.gz: e5aab94f01286183da58e2c6656cd9faaf1b8aeb
+  metadata.gz: 986d77995ad435e6e83f4447a41d689f8a8c90bd
+  data.tar.gz: 6e300dfb3c4566e1b9d4c3c321666263d921292e
 SHA512:
-  metadata.gz: 53bfbee786ddc17019a8ea0ced44b163974a78ffce9c0591ddc7cc74a7978cc6ac28e9ac16a8665e2fcc307edcd4c2bf70378c55512ca59d8bf5de4f8cf6ac55
-  data.tar.gz: 71fb3625e10777fa073f8cec5688c0b5bf9fd5bf3759ffea13afaeb5382084416b3c08bf87d1e540d28097247c5fe1d8b9404c49d1215ba0d459f20362f34ee3
+  metadata.gz: 1695d0c9434307108f5847691197d1629ff819b4363869fa9259d3a915557e34495cdf317d64116239f3c4f8b424399709f99e59fad91ed79bd9bb4e33dff269
+  data.tar.gz: f94f47617eb3dad580fe8a99badb6c23dade0bf80130868e0f81ecba2b2983f305dad827d1c5d8799c83d3558ef71cfed804f80d0e354386764ac3c396590e24

data/lib/logstash-core-event-java/logstash-core-event-java.rb

@@ -25,4 +25,4 @@ end
 require "jruby_event_ext"
 require "jruby_timestamp_ext"
 require "logstash/event"
-require "logstash/timestamp"
+require "logstash/timestamp"

data/lib/logstash-core-event-java/version.rb

@@ -5,4 +5,4 @@
 # Note to authors: this should not include dashes because 'gem' barfs if
 # you include a dash in the version string.
 
-LOGSTASH_CORE_EVENT_JAVA_VERSION = "5.0.0-rc1"
+LOGSTASH_CORE_EVENT_JAVA_VERSION = "5.0.1"

data/lib/logstash/event.rb

@@ -29,9 +29,26 @@ module LogStash
 
   # LogStash::SHUTDOWN is used by plugins
   SHUTDOWN = ShutdownEvent.new
+
+  class Event
+    MSG_BRACKETS_METHOD_MISSING = "Direct event field references (i.e. event['field']) have been disabled in favor of using event get and set methods (e.g. event.get('field')). Please consult the Logstash 5.0 breaking changes documentation for more details.".freeze
+    MSG_BRACKETS_EQUALS_METHOD_MISSING = "Direct event field references (i.e. event['field'] = 'value') have been disabled in favor of using event get and set methods (e.g. event.set('field', 'value')). Please consult the Logstash 5.0 breaking changes documentation for more details.".freeze
+    RE_BRACKETS_METHOD = /^\[\]$/.freeze
+    RE_BRACKETS_EQUALS_METHOD = /^\[\]=$/.freeze
+
+    def method_missing(method_name, *arguments, &block)
+      if RE_BRACKETS_METHOD.match(method_name.to_s)
+        raise NoMethodError.new(MSG_BRACKETS_METHOD_MISSING)
+      end
+      if RE_BRACKETS_EQUALS_METHOD.match(method_name.to_s)
+        raise NoMethodError.new(MSG_BRACKETS_EQUALS_METHOD_MISSING)
+      end
+      super
+    end
+  end
 end
 
 # for backward compatibility, require "logstash/event" is used a lots of places so let's bootstrap the
 # Java code loading from here.
 # TODO: (colin) I think we should mass replace require "logstash/event" with require "logstash-core-event"
-require "logstash-core-event"
+require "logstash-core-event"

data/spec/event_spec.rb

@@ -35,7 +35,7 @@ describe LogStash::Event do
     end
   end
 
-  context "[]" do
+  context "#get" do
     it "should get simple values" do
       e = LogStash::Event.new({"foo" => "bar", "bar" => 1, "baz" => 1.0, TIMESTAMP => "2015-05-28T23:02:05.350Z"})
       expect(e.get("foo")).to eq("bar")
@@ -63,7 +63,7 @@ describe LogStash::Event do
     end
   end
 
-  context "[]=" do
+  context "#set" do
     it "should set simple values" do
       e = LogStash::Event.new()
       expect(e.set("foo", "bar")).to eq("bar")
@@ -306,4 +306,20 @@ describe LogStash::Event do
     end
 
   end
+
+  context "method missing exception messages" do
+    subject { LogStash::Event.new({"foo" => "bar"}) }
+
+    it "#[] method raises a better exception message" do
+      expect { subject["foo"] }.to raise_error(NoMethodError, /Direct event field references \(i\.e\. event\['field'\]\)/)
+    end
+
+    it "#[]= method raises a better exception message" do
+      expect { subject["foo"] = "baz" }.to raise_error(NoMethodError, /Direct event field references \(i\.e\. event\['field'\] = 'value'\)/)
+    end
+
+    it "other missing method raises normal exception message" do
+      expect { subject.baz() }.to raise_error(NoMethodError, /undefined method `baz' for/)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logstash-core-event-java
 version: !ruby/object:Gem::Version
-  version: 5.0.0.pre.rc1
+  version: 5.0.1
 platform: java
 authors:
 - Elastic
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-10-07 00:00:00.000000000 Z
+date: 2016-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
@@ -75,9 +75,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements:
 - jar com.fasterxml.jackson.core:jackson-core, 2.7.3
 - jar com.fasterxml.jackson.core:jackson-databind, 2.7.3