logstash-codec-netflow 4.3.2 → 4.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 25aee1405937eb3d007e9c41fc86295eea44c81ca8f4559168fa892a3a37925c
-  data.tar.gz: 151a0535226ecff1c22013a847156f8f4ff4fe3e7f2abae74f2ec49719f0c844
+  metadata.gz: 1077f3fabf491578e56f3bdf62833fcc57fa84e7a45339a86041d0d3cab20ea9
+  data.tar.gz: 483b793cab3301353f7631cba07eb82e6a560b62c9656cc0e718ef0286cc61ab
 SHA512:
-  metadata.gz: 61aaf20a488e709118f96620414c16c5440cf17f1a3bd2d8a51aea3bd435ade159e13f774573d2e8f016f3bafa0e2ec213b259c085d44138dd44b1fdc9aa70c7
-  data.tar.gz: b76dc8fd387086eef2c476ca79b116f6b541dd41a9947c4341941d9eba1d0874d937d5c558b29d2a56d03db790805be12b0aa0f4a0f8b1789a3646f0e98b5cc8
+  metadata.gz: 67390c9542344deb69f6d862de01458e06d11932ecad4afc6ad824bc4d22abf22188786d309738294d7b311e688acebe0735d6ab8a5007f52cf8852acc5745cd
+  data.tar.gz: b0ef1675c310fec9dd98ac6db3e8088c62feaa230a6a368d640b67c8ee25f2970edba1d52c49d8d3d619be38894a27f141f7c9c15cf554584210c7c3ffe2b44e

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## 4.3.3
+  - Fix NoMethodError when decode fails. [214](https://github.com/logstash-plugins/logstash-codec-netflow/pull/214)
+
 ## 4.3.2
   - Updates the milliseconds rounding for IPFIX start/end milliseconds fields. 
   - Fix the test to run on Logstash 8 with microseconds precision. [#206](https://github.com/logstash-plugins/logstash-codec-netflow/pull/206)

data/lib/logstash/codecs/netflow.rb

@@ -88,16 +88,32 @@ class LogStash::Codecs::Netflow < LogStash::Codecs::Base
     if header.version == 5
       flowset = Netflow5PDU.read(payload)
       flowset.records.each do |record|
-        yield(decode_netflow5(flowset, record))
+        begin
+          yield(decode_netflow5(flowset, record))
+        rescue BinData::ValidityError, IOError => e
+          @logger.warn("Invalid Netflow v5 record (#{e})")
+          if @logger.debug?
+            @logger.debug("Netflow v5 decode error", :flow_seq_num => flowset.flow_seq_num)
+          end
+        end
       end
     elsif header.version == 9
 #     BinData::trace_reading do
       flowset = Netflow9PDU.read(payload)
       flowset.records.each do |record|
-        if metadata != nil
-          decode_netflow9(flowset, record, metadata).each{|event| yield(event)}
-        else
-          decode_netflow9(flowset, record).each{|event| yield(event)}
+        begin
+          if metadata != nil
+            decode_netflow9(flowset, record, metadata).each{|event| yield(event)}
+          else
+            decode_netflow9(flowset, record).each{|event| yield(event)}
+          end
+        rescue BinData::ValidityError, IOError => e
+          @logger.warn("Invalid Netflow v9 record (#{e})")
+          if @logger.debug?
+            host = metadata ? metadata["host"] : nil
+            port = metadata ? metadata["port"] : nil
+            @logger.debug("Netflow v9 decode error", :source_id => flowset.source_id, :flowset_id => record.flowset_id, :host => host, :port => port)
+          end
         end
 #      end
      end
@@ -105,7 +121,14 @@ class LogStash::Codecs::Netflow < LogStash::Codecs::Base
 #     BinData::trace_reading do
       flowset = IpfixPDU.read(payload)
       flowset.records.each do |record|
-        decode_ipfix(flowset, record).each { |event| yield(event) }
+        begin
+          decode_ipfix(flowset, record).each { |event| yield(event) }
+        rescue BinData::ValidityError, IOError => e
+          @logger.warn("Invalid IPFIX record (#{e})")
+          if @logger.debug?
+            @logger.debug("IPFIX decode error", :observation_domain_id => flowset.observation_domain_id, :flowset_id => record.flowset_id)
+          end
+        end
       end
 #     end
     else
@@ -151,8 +174,6 @@ class LogStash::Codecs::Netflow < LogStash::Codecs::Base
     end
 
     event_factory.new_event(event)
-  rescue BinData::ValidityError, IOError => e
-    @logger.warn("Invalid netflow packet received (#{e})")
   end
 
   def decode_netflow9(flowset, record, metadata = nil)
@@ -280,8 +301,6 @@ class LogStash::Codecs::Netflow < LogStash::Codecs::Base
     end
 
     events
-  rescue BinData::ValidityError, IOError => e
-    @logger.warn("Invalid netflow packet received (#{e})")
   end
 
   def decode_ipfix(flowset, record)
@@ -371,8 +390,6 @@ class LogStash::Codecs::Netflow < LogStash::Codecs::Base
     end
 
     events
-  rescue BinData::ValidityError => e
-    @logger.warn("Invalid IPFIX packet received (#{e})")
   end
 
   def load_definitions(defaults, extra)

data/logstash-codec-netflow.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
 
   s.name            = 'logstash-codec-netflow'
-  s.version         = '4.3.2'
+  s.version         = '4.3.3'
   s.licenses        = ['Apache License (2.0)']
   s.summary         = "Reads Netflow v5, Netflow v9 and IPFIX data"
   s.description     = "This gem is a Logstash plugin required to be installed on top of the Logstash core pipeline using $LS_HOME/bin/logstash-plugin install gemname. This gem is not a stand-alone program"

metadata

@@ -1,66 +1,65 @@
 --- !ruby/object:Gem::Specification
 name: logstash-codec-netflow
 version: !ruby/object:Gem::Version
-  version: 4.3.2
+  version: 4.3.3
 platform: ruby
 authors:
 - Elastic
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-22 00:00:00.000000000 Z
+date: 2026-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
+  name: logstash-core-plugin-api
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
-  name: logstash-core-plugin-api
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
+  name: logstash-mixin-event_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-  name: logstash-mixin-event_support
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
+  name: bindata
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.0
-  name: bindata
-  prerelease: false
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.0
 - !ruby/object:Gem::Dependency
+  name: logstash-devutils
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.0
-  name: logstash-devutils
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -200,7 +199,6 @@ licenses:
 metadata:
   logstash_plugin: 'true'
   logstash_group: codec
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -215,8 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key:
+rubygems_version: 3.6.3
 specification_version: 4
 summary: Reads Netflow v5, Netflow v9 and IPFIX data
 test_files: