logjam_agent 0.32.3 → 0.33.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '001856dce13e72d273c32137e0cbe7d4c004aa22c788e511b9c409065394de77'
-  data.tar.gz: d6b17a001250b7739ce3fe0e5096bbc57fea7f0632eca09859d28af53b94e368
+  metadata.gz: 29e2045e24e8a76d6cd8d13c4521562f237849880f39eec65c6be243b275cd06
+  data.tar.gz: 264a22f43eafaca127977d689ede51a657c4aa9403f5339528c56647f0a502c7
 SHA512:
-  metadata.gz: 29bec994d20a63997d4b43757cc9a88703cd31208c8146bada5aada8d6bfb7de831bb262ad798441ff42423c59d4aa8acdaf8f730295d15fce98eb3da39e173f
-  data.tar.gz: a27dfebcf4c233fe99b603179cf28a0edc39233b9baca0b3d9df5606e4f3629cd40f8bd832229378cf08c21c51b01963b31474299d6bc5af5289dbb96a11a9af
+  metadata.gz: 4fb90fd911820483409d59f8b0d8f272fe06b55460127899edbfc77da57cf064b32c633dee61bd1bf113acbf205487689bfdc43d623c6d8faaea4bbff9523bd5
+  data.tar.gz: 86470089e012dbf3462725708e65e0deb3a5d8d9cb1268452fb051948d80f55ce6c2361ffde3064aff41f8c9049a5d3452cfad4cbb8c7e87e455142289aed8f2

data/README.md

@@ -10,7 +10,8 @@ Has experimental support for Sinatra.
 Currently only one mechanism is available for data transport:
 ZeroMQ. Support for AMQP has been dropped.
 
-[![Travis](https://travis-ci.org/skaes/logjam_agent.svg?branch=master)](https://travis-ci.org/github/skaes/logjam_agent)
+
+![Build](https://github.com/skaes/logjam_agent/actions/workflows/run-tests.yml/badge.svg)
 
 
 ## Usage

data/lib/logjam_agent/middleware.rb

@@ -50,9 +50,11 @@ module LogjamAgent
       env_name      = env["logjam_agent.environment_name"] || LogjamAgent.environment_name
       caller_id     = env["HTTP_X_LOGJAM_CALLER_ID"] || ""
       caller_action = env["HTTP_X_LOGJAM_ACTION"] || ""
+      trace_id      = env["HTTP_X_LOGJAM_TRACE_ID"] || ""
       extra_fields = {}
       extra_fields[:caller_id] = caller_id if caller_id.present?
       extra_fields[:caller_action] = caller_action if caller_action.present?
+      extra_fields[:trace_id] = trace_id if trace_id.present?
       LogjamAgent.start_request(app_name, env_name, extra_fields)
     end
 

data/lib/logjam_agent/rack/logger.rb

@@ -32,23 +32,16 @@ module LogjamAgent
 
       def call_app(request, env)
         start_time = Time.now
-        start_time_header = env['HTTP_X_STARTTIME']
-        if start_time_header
-          if start_time_header =~ /\At=(\d+)\z/
-            # HTTP_X_STARTTIME is microseconds since the epoch (UTC)
-            http_start_time = Time.at($1.to_f / 1_000_000.0)
-          elsif start_time_header =~ /\Ats=(\d+)(?:\.(\d+))?\z/
-            # HTTP_X_STARTTIME is seconds since the epoch (UTC) with a milliseconds resolution
-            http_start_time = Time.at($1.to_f + $2.to_f / 1000)
-          end
-
-          if http_start_time && (wait_time_ms = (start_time - http_start_time) * 1000) > 0
+        wait_time_ms = 0.0
+        if http_start_time = extract_http_start_time(env)
+          wait_time_ms = (start_time - http_start_time) * 1000
+          if wait_time_ms > 0
             start_time = http_start_time
+          else
+            wait_time_ms = 0.0
           end
-        else
-          wait_time_ms = 0.0
         end
-        before_dispatch(request, env, start_time)
+        before_dispatch(request, env, start_time, wait_time_ms)
         result = @app.call(env)
       rescue ActionDispatch::RemoteIp::IpSpoofAttackError
         result = [403, {}, ['Forbidden']]
@@ -57,6 +50,20 @@ module LogjamAgent
         after_dispatch(env, result, run_time_ms, wait_time_ms)
       end
 
+      def extract_http_start_time(env)
+        start_time_header = env['HTTP_X_STARTTIME']
+        if start_time_header
+          if start_time_header =~ /\At=(\d+)\z/
+            # HTTP_X_STARTTIME is microseconds since the epoch (UTC)
+            return Time.at($1.to_f / 1_000_000.0)
+          elsif start_time_header =~ /\Ats=(\d+)(?:\.(\d+))?\z/
+            # HTTP_X_STARTTIME is seconds since the epoch (UTC) with a milliseconds resolution
+            return Time.at($1.to_f + $2.to_f / 1000)
+          end
+        end
+        return nil
+      end
+
       def compute_tags(request)
         @taggers.collect do |tag|
           case tag
@@ -78,7 +85,7 @@ module LogjamAgent
         false
       end
 
-      def before_dispatch(request, env, start_time)
+      def before_dispatch(request, env, start_time, wait_time_ms)
         logger.formatter.reset_attributes if logger.formatter.respond_to?(:reset_attributes)
         TimeBandits.reset
         Thread.current.thread_variable_set(:time_bandits_completed_info, nil)
@@ -90,6 +97,7 @@ module LogjamAgent
 
         logjam_request.start_time = start_time
         logjam_fields = logjam_request.fields
+        logjam_fields[:wait_time] = wait_time_ms if wait_time_ms > 0.0
         spoofed = nil
         ip = nil
         begin
@@ -125,7 +133,6 @@ module LogjamAgent
 
         if wait_time_ms < 0
           warn LogjamAgent::NegativeWaitTime.new("#{wait_time_ms} ms")
-          wait_time_ms = 0.0
         end
 
         message = "Completed #{status} #{::Rack::Utils::HTTP_STATUS_CODES[status]} in %.1fms" % run_time_ms
@@ -135,7 +142,6 @@ module LogjamAgent
         ActiveSupport::LogSubscriber.flush_all!
         request_info = { :total_time => run_time_ms, :code => status }
         request_info[:view_time] = view_time if view_time
-        request_info[:wait_time] = wait_time_ms if wait_time_ms > 0
         logjam_request.fields.merge!(request_info)
 
         env["time_bandits.metrics"] = TimeBandits.metrics

data/lib/logjam_agent/railtie.rb

@@ -90,9 +90,9 @@ module LogjamAgent
           # Rails 5 fires on_load events multiple times, so we need to protect against endless recursion
           next if ActionController::TestCase::Behavior.instance_methods.include?(:process_without_logjam)
           module ActionController::TestCase::Behavior
-            def process_with_logjam(*args)
+            def process_with_logjam(action, **opts)
               LogjamAgent.start_request
-              process_without_logjam(*args)
+              process_without_logjam(action, **opts)
             ensure
               LogjamAgent.finish_request
             end

data/lib/logjam_agent/request.rb

@@ -17,6 +17,7 @@ module LogjamAgent
       @uuid = LogjamAgent.generate_uuid
       @fields = initial_fields.merge(:request_id => @uuid, :host => LogjamAgent.hostname,
                                      :process_id => Process.pid, :lines => @lines)
+      @fields[:trace_id] ||= @uuid
       unless (revision = LogjamAgent.application_revision).blank?
         @fields[:revision] = revision
       end
@@ -70,6 +71,10 @@ module LogjamAgent
       @fields[:caller_action]
     end
 
+    def trace_id
+      @fields[:trace_id]
+    end
+
     def add_line(severity, timestamp, message)
       @mutex.synchronize do
         if @bytes_all_lines > @max_bytes_all_lines

data/lib/logjam_agent/version.rb

@@ -1,3 +1,3 @@
 module LogjamAgent
-  VERSION = "0.32.3"
+  VERSION = "0.33.1"
 end

data/test/request_test.rb

@@ -44,6 +44,16 @@ module LogjamAgent
       assert_equal TRUNCATED_LINE, lines(@request)[1][2]
     end
 
+    def test_sets_trace_id_to_request_id_if_not_passed_in
+      assert_equal @request.uuid, @request.fields[:trace_id]
+    end
+
+    def test_sets_trace_id_to_passed_in_field_value
+      trace_id = "murks"
+      request = Request.new("app", "env", {trace_id: trace_id})
+      assert_equal trace_id, request.fields[:trace_id]
+    end
+
     private
 
     def lines(request)

data/test/sinatra_test.rb

@@ -37,6 +37,7 @@ module LogjamAgent
       assert_kind_of String, payload["started_at"]
       assert_kind_of Integer, payload["started_ms"]
       assert_kind_of String, payload["ip"]
+      assert_nil payload["wait_time"]
       # assert_kind_of Float, payload["view_time"]
       lines = payload["lines"]
       assert_match(/Started GET.*password=\[FILTERED\]/, lines[0][2])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logjam_agent
 version: !ruby/object:Gem::Version
-  version: 0.32.3
+  version: 0.33.1
 platform: ruby
 authors:
 - Stefan Kaes
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-19 00:00:00.000000000 Z
+date: 2022-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -275,16 +275,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.7
+rubygems_version: 3.3.4
 signing_key:
 specification_version: 4
 summary: Logjam client library to be used with logjam
 test_files:
+- test/request_test.rb
 - test/sinatra_app.rb
-- test/sinatra_classic_test.rb
 - test/sinatra_classic_app.rb
-- test/request_test.rb
-- test/zmq_forwarder_test.rb
-- test/util_test.rb
-- test/test_helper.rb
+- test/sinatra_classic_test.rb
 - test/sinatra_test.rb
+- test/test_helper.rb
+- test/util_test.rb
+- test/zmq_forwarder_test.rb