loggregator_emitter 5.1.2 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ea729ed5d5e68b64496129d6efbde3e3485dacd
-  data.tar.gz: 19c63bbb1c7094d934446b440db65988ec92a9ea
+  metadata.gz: 588d56d832f366916e69f02a18d729dc56380661
+  data.tar.gz: b03beb2af10129ab6dd0d99db3da532038457441
 SHA512:
-  metadata.gz: 74bf3ea2ef16d396b33a6bb1d8550178d5050948349c34e9cb82851bd0333d66a77155af113a2f3a65df85668dd97649f6356296766d9ee631878c37b88280d8
-  data.tar.gz: afe8c77b9b85ba829d36be69f122947eabf5586ce88bcd493cb8642d1cd4f48c1f05876bcce56f29376de47ed7b9cd0f6a2012036e639ec0d6aeca58531280c2
+  metadata.gz: a009d14ede8e246230d02943bab941ab1c782f758a0b0f6fde6847ba9846ddd6d2f716e16c651c37e0a718ae9700bc530272c5065bf6373eeacb6b19b44015e1
+  data.tar.gz: 43aeced8dd382681a66e5be85aa678ce70669acd0b3ab2d7890ee5d896e1932c47e5c9351531e4cf1a2535dcf4023e48e040b5bae474253eac3997f88bff4ba7

data/lib/loggregator_emitter/emit.rb

@@ -11,6 +11,8 @@ module LoggregatorEmitter
 
     MAX_MESSAGE_BYTE_SIZE = (9 * 1024) - 512
     TRUNCATED_STRING = "TRUNCATED"
+    MAX_TAG_LENGTH = 256
+    MAX_TAGS = 10
 
     def initialize(loggregator_server, origin, source_type, source_instance = nil)
       @host, @port = loggregator_server.split(/:([^:]*$)/)
@@ -71,10 +73,13 @@ module LoggregatorEmitter
     end
 
     def set_tags(tags)
+      if tags.length > MAX_TAGS
+        raise ArgumentError, "Too many tags. Max is #{MAX_TAGS}"
+      end
       envelope_tags = []
       tags.each do |k, v|
-        raise ArgumentError, "Tag key is too long: #{k.length} (max 256 characters)" unless k.length <= 256
-        raise ArgumentError, "Tag value is too long #{v.length} (max 256 characters)" unless v.length <= 256
+        raise ArgumentError, "Tag key is too long: #{k.length} (max #{MAX_TAG_LENGTH} characters)" unless k.length <= MAX_TAG_LENGTH
+        raise ArgumentError, "Tag value is too long #{v.length} (max #{MAX_TAG_LENGTH} characters)" unless v.length <= MAX_TAG_LENGTH
         envelope_tags << ::Sonde::Envelope::TagsEntry.new(:key => k, :value => v)
       end
       envelope_tags

data/loggregator_emitter.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "loggregator_emitter"
-  spec.version       = '5.1.2'
+  spec.version       = '5.2.0'
   spec.authors       = ["Pivotal"]
   spec.email         = ["cf-eng@pivotallabs.com"]
   spec.description   = "Library to emit data to Loggregator"

data/spec/loggregator_emitter/emit_spec.rb

@@ -4,18 +4,17 @@ require "support/fake_loggregator_server"
 require "loggregator_emitter"
 
 describe LoggregatorEmitter do
-
-  before :all do
+  before do
     @free_port = test_port
     @server = FakeLoggregatorServer.new(@free_port)
-    @server.start
   end
 
-  after :all do
-    @server.stop
+  before :each do
+    @server.start
   end
 
-  before do
+  after :each do
+    @server.stop
     @server.reset
   end
 
@@ -85,6 +84,22 @@ describe LoggregatorEmitter do
     expected_tags
   end
 
+  describe "max_tags" do
+    it "throws an exception when there are more than 10 tags" do
+      tags = {}
+      for i in 0..10
+        tags["tag#{i}"] = "value#{i}"
+      end
+
+      emitter = LoggregatorEmitter::Emitter.new("0.0.0.0:#{@free_port}", "origin", "API", 42)
+
+      Timecop.freeze timestamp do
+        expect { emitter.emit("my_app_id", "Hello there!", tags) }.to raise_error(ArgumentError)
+      end
+    end
+  end
+
+
   describe "max_tag_length" do
     it "throws an exception when the key is too long" do
       too_long = "x" * 257

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: loggregator_emitter
 version: !ruby/object:Gem::Version
-  version: 5.1.2
+  version: 5.2.0
 platform: ruby
 authors:
 - Pivotal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-20 00:00:00.000000000 Z
+date: 2016-09-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: beefcake