loggregator_emitter 5.1.1 → 5.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce623535025497b97a8f11adcae61e83d3da8f97
-  data.tar.gz: edaff20710aef2d52d43ea383c808cbd21f86349
+  metadata.gz: 7ea729ed5d5e68b64496129d6efbde3e3485dacd
+  data.tar.gz: 19c63bbb1c7094d934446b440db65988ec92a9ea
 SHA512:
-  metadata.gz: 2a19fe40d7843694e3e12c35e0928355ab56f83703838766460ec573533980445a4e4270e2db5e0f81e07ec64091b6572d1f2d84fafdde868b5f98c233b607df
-  data.tar.gz: c037d51137815da7e2c1d6b0a541d9c5f1ef4524b35d87df326dbe578c96aeb7f47dd88ea78f4fda86aa3a17ed66a8898ae352f44c6883e9323f8d9709b4fd39
+  metadata.gz: 74bf3ea2ef16d396b33a6bb1d8550178d5050948349c34e9cb82851bd0333d66a77155af113a2f3a65df85668dd97649f6356296766d9ee631878c37b88280d8
+  data.tar.gz: afe8c77b9b85ba829d36be69f122947eabf5586ce88bcd493cb8642d1cd4f48c1f05876bcce56f29376de47ed7b9cd0f6a2012036e639ec0d6aeca58531280c2

data/lib/loggregator_emitter/emit.rb

@@ -73,6 +73,8 @@ module LoggregatorEmitter
     def set_tags(tags)
       envelope_tags = []
       tags.each do |k, v|
+        raise ArgumentError, "Tag key is too long: #{k.length} (max 256 characters)" unless k.length <= 256
+        raise ArgumentError, "Tag value is too long #{v.length} (max 256 characters)" unless v.length <= 256
         envelope_tags << ::Sonde::Envelope::TagsEntry.new(:key => k, :value => v)
       end
       envelope_tags

data/loggregator_emitter.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |spec|
   spec.name          = "loggregator_emitter"
-  spec.version       = '5.1.1'
+  spec.version       = '5.1.2'
   spec.authors       = ["Pivotal"]
   spec.email         = ["cf-eng@pivotallabs.com"]
   spec.description   = "Library to emit data to Loggregator"

data/spec/loggregator_emitter/emit_spec.rb

@@ -85,6 +85,52 @@ describe LoggregatorEmitter do
     expected_tags
   end
 
+  describe "max_tag_length" do
+    it "throws an exception when the key is too long" do
+      too_long = "x" * 257
+      tag = {too_long => "a"}
+
+      emitter = LoggregatorEmitter::Emitter.new("0.0.0.0:#{@free_port}", "origin", "API", 42)
+
+      Timecop.freeze timestamp do
+        expect { emitter.emit("my_app_id", "Hello there!", tag) }.to raise_error(ArgumentError)
+      end
+    end
+
+    it "throws an exception when the value is too long" do
+      too_long = "x" * 257
+      tag = {"a" => too_long}
+
+      emitter = LoggregatorEmitter::Emitter.new("0.0.0.0:#{@free_port}", "origin", "API", 42)
+
+      Timecop.freeze timestamp do
+        expect { emitter.emit("my_app_id", "Hello there!", tag) }.to raise_error(ArgumentError)
+      end
+    end
+
+    it "counts multi-byte unicode characters as single characters when checking key length" do
+      just_right = "x" * 255 + "Ω"
+      tag = {just_right => "a"}
+
+      emitter = LoggregatorEmitter::Emitter.new("0.0.0.0:#{@free_port}", "origin", "API", 42)
+
+      Timecop.freeze timestamp do
+        expect { emitter.emit("my_app_id", "Hello there!", tag) }.not_to raise_error
+      end
+    end
+
+    it "counts multi-byte unicode characters as single characters when checking value length" do
+      just_right = "x" * 255 + "Ω"
+      tag = {"a" => just_right}
+
+      emitter = LoggregatorEmitter::Emitter.new("0.0.0.0:#{@free_port}", "origin", "API", 42)
+
+      Timecop.freeze timestamp do
+        expect { emitter.emit("my_app_id", "Hello there!", tag) }.not_to raise_error
+      end
+    end
+  end
+
   let(:timestamp) {Time.now}
   describe "emit_log_envelope" do
     def make_emitter(host)
@@ -350,7 +396,7 @@ describe LoggregatorEmitter do
         messages = @server.messages
         expect(messages.length).to eq 1
         logMessage = messages[0].logMessage
-        expect(logMessage.message.bytesize <= LoggregatorEmitter::Emitter::MAX_MESSAGE_BYTE_SIZE).to be_true
+        expect(logMessage.message.bytesize <= LoggregatorEmitter::Emitter::MAX_MESSAGE_BYTE_SIZE).to be true
         expect(logMessage.message.slice(-9..-1)).to eq("TRUNCATED")
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: loggregator_emitter
 version: !ruby/object:Gem::Version
-  version: 5.1.1
+  version: 5.1.2
 platform: ruby
 authors:
 - Pivotal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-08 00:00:00.000000000 Z
+date: 2016-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: beefcake