logging 1.7.1 → 1.7.2

data/History.txt

@@ -1,3 +1,10 @@
+== 1.7.2 / 2012-04-03
+
+Bug Fixes
+- Fixed segmentation fault on exit [issue #30]
+- Fixed syswrite warning when IO contains unflushed data in buffer [issue #31]
+- Added "mingw" to the list of Windows host versions
+
 == 1.7.1 / 2012-03-05
 
 Bug Fixes

data/a.rb

@@ -0,0 +1,10 @@
+
+File.open('tmp.txt', 'w') { |io|
+  # io.sync = true
+  io.syswrite io.sync
+  io.syswrite "\n"
+
+  io.puts "Sync is => #{io.sync}"
+
+  io.syswrite "test line\n"
+}

data/lib/logging.rb

@@ -181,6 +181,7 @@ module Logging
     def reopen
       log_internal {'re-opening all appenders'}
       ::Logging::Appenders.each {|appender| appender.reopen}
+      self
     end
 
     # call-seq:
@@ -208,6 +209,7 @@ module Logging
     #
     def consolidate( *args )
       ::Logging::Repository.instance.add_master(*args)
+      self
     end
 
     # call-seq:
@@ -258,7 +260,7 @@ module Logging
     # level to this value will disable all log messages except this highest
     # level.
     #
-    # This method should only be invoked once to configure the logging
+    # This method should be invoked only once to configure the logging
     # levels. It is automatically invoked with the default logging levels
     # when the first logger is created.
     #
@@ -329,6 +331,7 @@ module Logging
       end
 
       module_eval "OBJ_FORMAT = :#{f}", __FILE__, __LINE__
+      self
     end
 
     # call-seq:
@@ -466,7 +469,7 @@ module Logging
         ::Logging.show_configuration(io, child, indent)
       end
 
-      nil
+      self
     end
 
     # :stopdoc:
@@ -494,11 +497,13 @@ module Logging
 
     # Close all appenders
     def shutdown( *args )
+      return unless initialized?
       log_internal {'shutdown called - closing all appenders'}
       ::Logging::Appenders.each {|appender| appender.close}
+      nil
     end
 
-    # Reset the logging framework to it's uninitialized state
+    # Reset the Logging framework to it's uninitialized state
     def reset
       ::Logging::Repository.reset
       ::Logging::Appenders.reset
@@ -508,6 +513,12 @@ module Logging
       remove_instance_variable :@backtrace if defined? @backtrace
       remove_const :MAX_LEVEL_LENGTH if const_defined? :MAX_LEVEL_LENGTH
       remove_const :OBJ_FORMAT if const_defined? :OBJ_FORMAT
+      self
+    end
+
+    # Return +true+ if the Logging framework is initialized.
+    def initialized?
+      const_defined? :MAX_LEVEL_LENGTH
     end
     # :startdoc:
   end

data/lib/logging/appender.rb

@@ -33,7 +33,7 @@ class Appender
   #    :level    => the level at which to log
   #
   def initialize( name, opts = {} )
-    ::Logging.init unless ::Logging.const_defined? :MAX_LEVEL_LENGTH
+    ::Logging.init unless ::Logging.initialized?
 
     @name = name.to_s
     @closed = false

data/lib/logging/appenders/buffering.rb

@@ -203,7 +203,7 @@ module Logging::Appenders
     # options.
     #
     def configure_buffering( opts )
-      ::Logging.init unless ::Logging.const_defined? :MAX_LEVEL_LENGTH
+      ::Logging.init unless ::Logging.initialized?
 
       self.immediate_at = opts.getopt(:immediate_at, '')
       self.auto_flushing = opts.getopt(:auto_flushing, true)

data/lib/logging/appenders/io.rb

@@ -34,6 +34,7 @@ module Logging::Appenders
 
       @io = io
       @io.sync = true if io.respond_to? :sync=    # syswrite complains if the IO stream is buffered
+      @io.flush rescue nil                        # syswrite also complains if in unbuffered mode and buffer isn't empty
       @close_method = :close
 
       super(name, opts)

data/lib/logging/config/configurator.rb

@@ -42,7 +42,7 @@ module Logging::Config
     #
     def pre_config( config )
       if config.nil?
-        ::Logging.init unless ::Logging.const_defined? 'MAX_LEVEL_LENGTH'
+        ::Logging.init unless ::Logging.initialized?
         return
       end
 

data/lib/logging/layout.rb

@@ -28,7 +28,7 @@ class Layout
   # then <tt>:string</tt> is used.
   #
   def initialize( opts = {} )
-    ::Logging.init unless ::Logging.const_defined? :MAX_LEVEL_LENGTH
+    ::Logging.init unless ::Logging.initialized?
 
     default = ::Logging.const_defined?('OBJ_FORMAT') ?
               ::Logging::OBJ_FORMAT : nil

data/lib/logging/root_logger.rb

@@ -21,7 +21,7 @@ module Logging
     # once when the +Repository+ singleton instance is created.
     #
     def initialize( )
-      ::Logging.init unless ::Logging.const_defined? 'MAX_LEVEL_LENGTH'
+      ::Logging.init unless ::Logging.initialized?
 
       @name = 'root'
       @appenders = []

data/lib/logging/utils.rb

@@ -167,7 +167,7 @@ class File
 
   # :stopdoc:
   conf = defined?(RbConfig) ? RbConfig::CONFIG : Config::CONFIG
-  if conf['host_os'] =~ /mswin|windows|cygwin/i
+  if conf['host_os'] =~ /mswin|windows|cygwin|mingw/i
     # don't lock files on windows
     undef :flock?, :flock_sh
     def flock?() yield; end

data/test/test_logging.rb

@@ -141,7 +141,7 @@ module TestLogging
     def test_init_default
       assert_equal({}, @levels)
       assert_equal([], @lnames)
-      assert_same false, ::Logging.const_defined?(:MAX_LEVEL_LENGTH)
+      assert_same false, ::Logging.initialized?
 
       ::Logging::Repository.instance
 
@@ -165,7 +165,7 @@ module TestLogging
     def test_init_special
       assert_equal({}, @levels)
       assert_equal([], @lnames)
-      assert_same false, ::Logging.const_defined?(:MAX_LEVEL_LENGTH)
+      assert_same false, ::Logging.initialized?
 
       assert_raise(ArgumentError) {::Logging.init(1, 2, 3, 4)}
 
@@ -191,7 +191,7 @@ module TestLogging
     def test_init_all_off
       assert_equal({}, @levels)
       assert_equal([], @lnames)
-      assert_same false, ::Logging.const_defined?(:MAX_LEVEL_LENGTH)
+      assert_same false, ::Logging.initialized?
 
       ::Logging.init %w(a b all c off d)
 

data/tmp.txt

@@ -0,0 +1,3 @@
+false
+test line
+Sync is => false

data/version.txt

@@ -1 +1 @@
-1.7.1
+1.7.2

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: logging
 version: !ruby/object:Gem::Version
-  version: 1.7.1
+  version: 1.7.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-05 00:00:00.000000000Z
+date: 2012-04-04 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: little-plugger
-  requirement: &2154814600 !ruby/object:Gem::Requirement
+  requirement: &2155744060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 1.1.3
   type: :runtime
   prerelease: false
-  version_requirements: *2154814600
+  version_requirements: *2155744060
 - !ruby/object:Gem::Dependency
   name: flexmock
-  requirement: &2154814120 !ruby/object:Gem::Requirement
+  requirement: &2155743520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 0.9.0
   type: :development
   prerelease: false
-  version_requirements: *2154814120
+  version_requirements: *2155743520
 - !ruby/object:Gem::Dependency
   name: bones-git
-  requirement: &2154813700 !ruby/object:Gem::Requirement
+  requirement: &2155743060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: 1.2.4
   type: :development
   prerelease: false
-  version_requirements: *2154813700
+  version_requirements: *2155743060
 - !ruby/object:Gem::Dependency
   name: bones
-  requirement: &2154813280 !ruby/object:Gem::Requirement
+  requirement: &2155742640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: 3.7.2
   type: :development
   prerelease: false
-  version_requirements: *2154813280
+  version_requirements: *2155742640
 description: ! 'Logging is a flexible logging library for use in Ruby programs based
   on the
 
@@ -69,6 +69,7 @@ extensions: []
 extra_rdoc_files:
 - History.txt
 - README.rdoc
+- tmp.txt
 files:
 - .gitignore
 - .rvmrc
@@ -76,6 +77,7 @@ files:
 - History.txt
 - README.rdoc
 - Rakefile
+- a.rb
 - data/bad_logging_1.rb
 - data/bad_logging_2.rb
 - data/logging.rb
@@ -153,6 +155,7 @@ files:
 - test/test_root_logger.rb
 - test/test_stats.rb
 - test/test_utils.rb
+- tmp.txt
 - version.txt
 homepage: http://rubygems.org/gems/logging
 licenses: []