logger_facade 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 579ce5afc470c007f26871a90e6b724509ee4b4c
-  data.tar.gz: 60f2891a92be6f1aaca17042ce0f6f45cb5c7630
+  metadata.gz: 8392ff8e0a6863d4601fe9931cdb6145aed932c9
+  data.tar.gz: 12791d5fb124bbe9f0bbbee15ad913aea775d6b0
 SHA512:
-  metadata.gz: 24d1422909da0796ed46700eb1169d4adb9bc5b2dce5b67885a62e059919895819c5e68571ca222ed0574b98ec6313fa73b8ee395adc10094a651ffc27aa7999
-  data.tar.gz: 65f744d6763a185ee232e654ad40c6189c5b9a3781e6913a6ce6072318e97ba7c09e61c50e54954e0e8c0650819445f58c4e15947cfd9e6092657d157e95b17e
+  metadata.gz: e376cd8a463bc43047d154dbf487842876f64acf6f3db9a2c7ccd79e12d8a255cbab8dda4bb29f88019cba6faaee40b8f2c74d8f9e75107de7ae0858aec24e4a
+  data.tar.gz: 45d4bcefb121a1e68f5cbacc36b97a7e2392958f68297367a01e6eabc09ec2699a515c8695a205c2dba1b19227c915e94deb0e1f0a2ef9c12612cab38b36ff37

data/Gemfile.lock

@@ -1,11 +1,10 @@
 PATH
   remote: .
   specs:
-    logger_facade (0.4.0)
+    logger_facade (0.4.1)
       airbrake (~> 4.0)
       hashie (~> 3.2)
       sucker_punch (~> 1.1)
-      yajl-ruby (~> 1.2)
 
 GEM
   remote: https://rubygems.org/
@@ -55,7 +54,6 @@ GEM
       celluloid (~> 0.16.0)
     timers (4.0.1)
       hitimes
-    yajl-ruby (1.2.1)
 
 PLATFORMS
   ruby

data/lib/logger_facade/plugins/airbrake.rb

@@ -22,12 +22,17 @@ module LoggerFacade::Plugins
 
     def log(log_level, message, logger, metadata)
       return unless is_level_active(log_level)
+      return if is_dev_env?
 
       notify(logger, message, metadata)
     end
 
     private
 
+    def is_dev_env?
+      ::Airbrake.configuration.development_environments.include? environment
+    end
+
     def notify(logger, message, metadata)
       return unless valid_config
 

data/lib/logger_facade/plugins/logstash.rb

@@ -1,5 +1,5 @@
 require 'logger'
-require 'yajl'
+require 'json'
 
 module LoggerFacade::Plugins
   class Logstash < Base
@@ -38,7 +38,7 @@ module LoggerFacade::Plugins
        '@fields'    => metadata
       }
 
-      logdevice.write("#{Yajl::Encoder.encode(json)}\n")
+      logdevice.write("#{JSON.generate(json)}\n")
     end
 
     class LogDeviceWithRotation < ::Logger::LogDevice

data/lib/logger_facade/version.rb

@@ -1,3 +1,3 @@
 module LoggerFacade
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/logger_facade.gemspec

@@ -35,6 +35,4 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'airbrake', '~> 4.0'
   # sucker punch is used to use airbrake async
   spec.add_dependency 'sucker_punch', '~> 1.1'
-  # used by logstash plugin, for better performance
-  spec.add_dependency 'yajl-ruby', '~> 1.2'
 end

data/spec/unit/plugins/airbrake_spec.rb

@@ -11,6 +11,7 @@ describe LoggerFacade::Plugins::Airbrake do
     subject.configure do |c|
       c.host = "host.test"
       c.api_key = "key.test"
+      c.development_environments = %w()
     end
 
   end
@@ -58,13 +59,21 @@ describe LoggerFacade::Plugins::Airbrake do
 
   end
 
-  %w(trace debug info warn error).each do |level|
-
+  context("logging in error level") do
 
+    context 'on development environment' do
+      before :each do
+        subject.configure do |c|
+          c.development_environments = %w(test)
+        end
+      end
 
-  end
+      it("doesn't notify") do
+        expect(::Airbrake).not_to receive(:notify_or_ignore)
+        subject.error("name", message)
+      end
 
-  context("logging in error level") do
+    end
 
     context('with message') do
 

data/spec/unit/plugins/logstash_spec.rb

@@ -1,3 +1,5 @@
+require 'json'
+
 describe LoggerFacade::Plugins::Logstash do
   include LevelTestHelper
 
@@ -76,7 +78,7 @@ describe LoggerFacade::Plugins::Logstash do
           it("writes a valid json") do
             expect(file).to receive(:write) do |msg|
               data = nil
-              expect { data = Yajl::Parser.new.parse(msg) }.not_to raise_exception
+              expect { data = JSON.parse(msg) }.not_to raise_exception
               expect(data).to be
             end
             subject.send(severity, logger, message)
@@ -96,7 +98,7 @@ describe LoggerFacade::Plugins::Logstash do
 
             it("writes logstash timestamp format") do
               expect(file).to receive(:write) do |msg|
-                data = Yajl::Parser.new.parse(msg)
+                data = JSON.parse(msg)
                 expect(data["@timestamp"]).to eq(time.iso8601)
               end
               subject.send(severity, logger, message)
@@ -104,7 +106,7 @@ describe LoggerFacade::Plugins::Logstash do
 
             it("uses metadata timestamp") do
               expect(file).to receive(:write) do |msg|
-                data = Yajl::Parser.new.parse(msg)
+                data = JSON.parse(msg)
                 expect(data["@timestamp"]).to eq(ts.iso8601)
               end
               subject.send(severity, logger, message, metadata: metadata)
@@ -112,7 +114,7 @@ describe LoggerFacade::Plugins::Logstash do
 
             it("doesn't write field timestamp") do
               expect(file).to receive(:write) do |msg|
-                data = Yajl::Parser.new.parse(msg)["@fields"]
+                data = JSON.parse(msg)["@fields"]
                 expect(data["timestamp"]).to be_nil
               end
               subject.send(severity, logger, message, metadata: metadata)
@@ -121,7 +123,7 @@ describe LoggerFacade::Plugins::Logstash do
 
           it("writes fields") do
             expect(file).to receive(:write) do |msg|
-              data = Yajl::Parser.new.parse(msg)
+              data = JSON.parse(msg)
               expect(data["@fields"]).to be
             end
             subject.send(severity, logger, message)
@@ -129,7 +131,7 @@ describe LoggerFacade::Plugins::Logstash do
 
           it("writes severity") do
             expect(file).to receive(:write) do |msg|
-              data = Yajl::Parser.new.parse(msg)["@fields"]
+              data = JSON.parse(msg)["@fields"]
               expect(data["severity"]).to eq(severity.to_s)
             end
             subject.send(severity, logger, message)
@@ -137,7 +139,7 @@ describe LoggerFacade::Plugins::Logstash do
 
           it("writes logger") do
             expect(file).to receive(:write) do |msg|
-              data = Yajl::Parser.new.parse(msg)["@fields"]
+              data = JSON.parse(msg)["@fields"]
               expect(data["logger"]).to eq(logger)
             end
             subject.send(severity, logger, message)
@@ -145,7 +147,7 @@ describe LoggerFacade::Plugins::Logstash do
 
           it("writes message") do
             expect(file).to receive(:write) do |msg|
-              data = Yajl::Parser.new.parse(msg)["@fields"]
+              data = JSON.parse(msg)["@fields"]
               expect(data["message"]).to eq(message)
             end
             subject.send(severity, logger, message)
@@ -154,7 +156,7 @@ describe LoggerFacade::Plugins::Logstash do
           it("writes other metadata fields") do
             metadata = { context: true }
             expect(file).to receive(:write) do |msg|
-              data = Yajl::Parser.new.parse(msg)["@fields"]
+              data = JSON.parse(msg)["@fields"]
               expect(data["context"]).to eq(true)
             end
             subject.send(severity, logger, message, metadata: metadata)
@@ -165,7 +167,7 @@ describe LoggerFacade::Plugins::Logstash do
             it('writes the exception message') do
               error = Exception.new('test log')
               expect(file).to receive(:write) do |msg|
-                data = Yajl::Parser.new.parse(msg)["@fields"]
+                data = JSON.parse(msg)["@fields"]
                 expect(data["message"]).to eq("test log")
               end
               subject.send(severity, logger, error)
@@ -175,7 +177,7 @@ describe LoggerFacade::Plugins::Logstash do
               error = Exception.new('test log')
               error.set_backtrace "stacktrace"
               expect(file).to receive(:write) do |msg|
-                data = Yajl::Parser.new.parse(msg)["@fields"]
+                data = JSON.parse(msg)["@fields"]
                 expect(data["backtrace"]).to eq(error.backtrace)
               end
               subject.send(severity, logger, error)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: logger_facade
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Pedro Januário
@@ -164,20 +164,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
-- !ruby/object:Gem::Dependency
-  name: yajl-ruby
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.2'
 description: |-
   Simple class library to work as logger facade.
                           This simple logger facade allows you to hook plugins to execute logging.