logan 0.0.9 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6693a0249ee8419b0677c7eb5aeed071f775dfca
-  data.tar.gz: 1f91aa04d498e44f07fca9f3eb12820e4c48a415
+  metadata.gz: dd4e95b42c7d708e8d8b11a93afe0c65aedc1e12
+  data.tar.gz: aa891ac5706e4d2cb58543ea4f33ee67a891512d
 SHA512:
-  metadata.gz: a49cc959c5bd8247ee7658be881789c1b4c3fbec3ccc96c991759856c86de2e34f8e788ca03872610a20ebf3755011fb0c5bec7e4c34e1c9dd543300ff0c1fb1
-  data.tar.gz: 0e7d6419b8c64962eb9fb06610a0546d05e52a0558958467c1b0d9e80454dc27ed1d518e0481a7324625d9227b6ae60395a42cfbb63379ecc9e2d54c0621b389
+  metadata.gz: 19c3d366443abf9573cfa8def7ae49dca190ef345585fedd4391061aa97a8e0e871b7121d6313d9dd396aca517837b7a828cf17038f80a7f655517ccf4eda635
+  data.tar.gz: 018fdb52e55f5606d2e281d9a7efa942999b02d19f0ca5e4848aa5a1d46fc8a33c51511eb8cfe4c2d48b0a5203683638a862213f7a32aa0b75a083134923e7bd

data/lib/logan/client.rb

@@ -1,9 +1,10 @@
 require 'logan/project'
-
+require 'logan/response_handler'
 module Logan
   class Client
     include HTTParty
-    
+    include ResponseHandler
+
     # Initializes the Logan shared client with information required to communicate with Basecamp
     #
     # @param basecamp_id [String] the Basecamp company ID
@@ -14,68 +15,67 @@ module Logan
       self.class.headers 'User-Agent' => user_agent
       self.auth = auth_hash
     end
-    
+
     # Updates authorization information for Logan shared client
-    # 
+    #
     # @param auth_hash [Hash] authorization hash consisting of a username and password combination (:username, :password) or an access_token (:access_token)
     def auth=(auth_hash)
       # symbolize the keys
       new_auth_hash = {}
       auth_hash.each {|k, v| new_auth_hash[k.to_sym] = v}
       auth_hash = new_auth_hash
-      
+
       if auth_hash.has_key? :access_token
         # clear the basic_auth, if it's set
         self.class.default_options.reject!{ |k| k == :basic_auth }
-                
+
         # set the Authorization headers
         self.class.headers.merge!("Authorization" => "Bearer #{auth_hash[:access_token]}")
       elsif auth_hash.has_key?(:username) && auth_hash.has_key?(:password)
         self.class.basic_auth auth_hash[:username], auth_hash[:password]
-        
+
         # remove the access_token from the headers, if it exists
         self.class.headers.reject!{ |k, v| k == "Authorization" }
       else
         raise """
-        Incomplete authorization information passed in authorization hash. 
+        Incomplete authorization information passed in authorization hash.
         You must have either an :access_token or a username password combination (:username, :password).
         """
       end
     end
-    
+
     # get projects from Basecamp API
-    # 
+    #
     # @return [Array<Logan::Project>] array of {Logan::Project} instances
     def projects
       response = self.class.get '/projects.json'
-      response.parsed_response.map { |h| p = Logan::Project.new(h) }
+      handle_response(response, Proc.new {|h| Logan::Project.new(h) })
     end
-    
+
     # get active Todo lists for all projects from Basecamp API
-    # 
+    #
     # @return [Array<Logan::TodoList>] array of {Logan::TodoList} instances
     def todolists
       response = self.class.get '/todolists.json'
-      
-      response.parsed_response.map do |h| 
-        list = Logan::TodoList.new(h)
-        
-        # grab the project ID for this list from the url
-        list.project_id = list.url.scan( /projects\/(\d+)/).last.first
-        
-        # return the list so this method returns an array of lists
-        list
-      end
+      handle_response(response,
+        Proc.new { |h|
+          list = Logan::TodoList.new(h)
+          # grab the project ID for this list from the url
+          list.project_id = list.url.scan( /projects\/(\d+)/).last.first
+          # return the list so this method returns an array of lists
+          return list
+        }
+      )
     end
-    
+
     def events(since_time, page = 1)
       response = self.class.get "/events.json?since=#{since_time.to_s}&page=#{page}"
-      response.map { |h| e = Logan::Event.new(h) }
+      handle_response(response, Proc.new {|h| Logan::Event.new(h) })
     end
 
     def people
       response = self.class.get "/people.json"
-      response.parsed_response.map { |h| p = Logan::Person.new(h)}
+      handle_response(response, Proc.new {|h| Logan::Person.new(h) })
     end
   end
 end

data/lib/logan/errors.rb

@@ -0,0 +1,28 @@
+module Logan
+  class Error < StandardError
+    attr_reader :code
+    attr_reader :message
+
+    def initialize(code, message)
+      @code = code.to_sym
+      @message = message
+    end
+
+    def to_json
+      JSON.generate({error: @code.to_s, error_description: @message})
+    end
+
+  end
+
+  class AccessDeniedError < Error
+    def initialize
+      super :access_denied, "You are not allowed to access this resource."
+    end
+  end
+
+  class InvalidRequestError < Error
+    def initialize
+      super :invalid_request, "The request has wrong parameters."
+    end
+  end
+end

data/lib/logan/response_handler.rb

@@ -0,0 +1,23 @@
+module Logan
+  module ResponseHandler
+    def handle_response(response, block)
+      if success?(response.response)
+        response.parsed_response.map { |h| block.call(h) }
+      else
+        handle_error(response.response)
+      end
+    end
+
+    def handle_error(response)
+      if response.kind_of? Net::HTTPUnauthorized
+        raise Logan::AccessDeniedError
+      else
+        raise Logan::InvalidRequestError
+      end
+    end
+
+    def success?(response)
+      response.kind_of? Net::HTTPSuccess
+    end
+  end
+end

data/lib/logan.rb

@@ -7,4 +7,6 @@ require 'logan/event'
 require 'logan/person'
 require 'logan/project'
 require 'logan/todo'
-require 'logan/todolist'
+require 'logan/todolist'
+require 'logan/errors'
+require 'logan/response_handler'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: logan
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.1.0
 platform: ruby
 authors:
 - Stephen Birarda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-03 00:00:00.000000000 Z
+date: 2014-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -76,9 +76,11 @@ files:
 - lib/logan/HashConstructed.rb
 - lib/logan/client.rb
 - lib/logan/comment.rb
+- lib/logan/errors.rb
 - lib/logan/event.rb
 - lib/logan/person.rb
 - lib/logan/project.rb
+- lib/logan/response_handler.rb
 - lib/logan/todo.rb
 - lib/logan/todolist.rb
 homepage: https://github.com/birarda/logan
@@ -93,7 +95,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.8.7
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="