loga 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b861a3c084a6aee96710b7de7e863dc5a6167a189ff99975805500c7d1c66596
-  data.tar.gz: 15190282eedb92b8d18ab65b3e27b7ea5a73de754ddd6f80b2e0bbaf24bf8ec5
+  metadata.gz: 2edeb506c587fc55a4a3569aa4fa50af23c0080d0409da3de8aaf4f8f9df60f1
+  data.tar.gz: 98ef790dd9c26f71d3a5f6c656d1a1663db56a90da28fa49f03da239bbc57d80
 SHA512:
-  metadata.gz: ab122312cd675226c261250c65b90d900246c52471937450eafe767cc143f94954128d72c67803a418e05599b515272e95255eddd688b8f4fffe511ee46cae23
-  data.tar.gz: 4af4ebe2bfb678a3cc45ec9a7b48bb768490313d85f5983135f57b83448171411ca262dea277f67093a26559a4de7e4ecbc309158d92f25fefc45429554984bf
+  metadata.gz: 62a82d5f31b3b4a1d29464d51e15ef1346ee9a7cc0fddc8047703fbdd0d041c089fc9423ed02fcdf81f0a5be6f329893d5081003ef347fbf5c8f032bd4f7dabe
+  data.tar.gz: a70770e9de89a0357a25c1290bafff87b0422efc1b9dd7a6861004bacceb6acc9db67f10bd9c41e1bc5ff0178a63b1142ab5efe3cca4cb18745808deb550b1d4

data/CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.5.1] - 2020-01-02
+### Fixed
+- Fixed a long standing bug that would mask exceptions raised by the host application when serving requests. The original exception would be replaced with a `TypeError` one due to a HTTP status code not being available within `Loga::Rack::Logger`.
+
 ## [2.5.0] - 2019-11-12
 ### Added
 - Add support for rails 6

data/gemfiles/rails60.gemfile

@@ -0,0 +1,11 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 6.0.0"
+
+group :test do
+  gem "simplecov"
+end
+
+gemspec path: "../"

data/lib/loga/rack/logger.rb

@@ -44,6 +44,9 @@ module Loga
         data['user_agent'] = request.user_agent
         data['controller'] = request.controller_action_name if request.controller_action_name
         data['duration']   = duration_in_ms(started_at, Time.now)
+
+        # If data['status'] is nil we assume an exception was raised when calling the application
+        data['status']     ||= 500
       end
       # rubocop:enable Metrics/LineLength
 

data/lib/loga/version.rb

@@ -1,3 +1,3 @@
 module Loga
-  VERSION = '2.5.0'.freeze
+  VERSION = '2.5.1'.freeze
 end

data/spec/unit/loga/rack/logger_spec.rb

@@ -65,12 +65,13 @@ describe Loga::Rack::Logger do
     let(:exception)        { StandardError.new }
     let(:logged_exception) { nil }
     let(:response_status)  { 200 }
+    let(:exception_class)  { Class.new(StandardError) }
 
     context 'when an exception is raised' do
-      let(:app) {  ->(_env) { raise exception } }
+      let(:app) {  ->(_env) { raise exception_class } }
 
       it 'does not rescue the exception' do
-        expect { subject.call(env) }.to raise_error(StandardError)
+        expect { subject.call(env) }.to raise_error(exception_class)
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: loga
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Funding Circle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-13 00:00:00.000000000 Z
+date: 2020-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -259,6 +259,7 @@ files:
 - gemfiles/rails42.gemfile
 - gemfiles/rails50.gemfile
 - gemfiles/rails52.gemfile
+- gemfiles/rails60.gemfile
 - gemfiles/sidekiq51.gemfile
 - gemfiles/sinatra14.gemfile
 - gemfiles/unit.gemfile