loga 2.4.0 → 2.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b069a9b029cfb82d0a179ebb76738b71506eb717c49e0053c135204225f7d4f
-  data.tar.gz: e62a39b1e52025dc1bcd7a8c69b1d8e260f73e954de16f7c9fbfb42529154363
+  metadata.gz: b0e5af261daf89f7f7e4b80be296a8f19307a33f187a501e23eb5295fbedd8f2
+  data.tar.gz: ed0d0281f4d40078051363434600bdd9a8f843ba70a85fde3b110d56a58e2ca3
 SHA512:
-  metadata.gz: 9aae956e2b49cc519590cca3be9d32d6d268871b4d8bc97fb568b66003d3fd7913f04debf445b6cee2ced3a04d1d3af610eb256c48411b3f92fc76b3120c8d51
-  data.tar.gz: 16f42b6af8af4479ae5dfec57f47c27db4b41d9e4b7e58491e289cb5d487316d115fe47723bbf8690c30d692da59bb134a29f2b9eb964b9ff7477a3a5b2fd1f0
+  metadata.gz: 64128d6a8442ce7006629f3056c94487e9316f7c07cd284b3f96f3bb01fd5daccd3a7e4372dfb746376e8e91e2ccb52e015e381bd1c2fdc1774b86e5a5a78f43
+  data.tar.gz: bf0393ec37a4f9f8a023d031b5823ad94151fc98b9f1d2ce1ee2bea8b580c88db3013b35b73c68636dfb482dbabd1019771b0b0542ec11c8b2ab0baad290a022

data/.circleci/config.yml

@@ -74,6 +74,10 @@ jobs:
     docker:
       - image: circleci/ruby:2.6
     <<: *test_build
+  ruby-2.7:
+    docker:
+      - image: circleci/ruby:2.7
+    <<: *test_build
   rubocop:
     <<: *basic_build
     steps:
@@ -135,6 +139,12 @@ workflows:
               only: /.*/
           requires:
             - build
+      - ruby-2.7:
+          filters:
+            tags:
+              only: /.*/
+          requires:
+            - build
       - upload-coverage:
           filters:
             tags:
@@ -144,6 +154,7 @@ workflows:
             - ruby-2.4
             - ruby-2.5
             - ruby-2.6
+            - ruby-2.7
       - push-to-rubygems:
           filters:
             tags:
@@ -156,3 +167,4 @@ workflows:
             - ruby-2.4
             - ruby-2.5
             - ruby-2.6
+            - ruby-2.7

data/Appraisals

@@ -8,20 +8,32 @@ if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.4.0')
   end
 end
 
-appraise 'rails42' do
-  gem 'rails', '~> 4.2.0'
+if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.7.0')
+  appraise 'rails42' do
+    gem 'rails', '~> 4.2.0'
+  end
+
+  appraise 'rails50' do
+    gem 'rails', '~> 5.0.0'
+  end
+
+  appraise 'rails52' do
+    gem 'rails', '~> 5.2.0'
+  end
 end
 
 appraise 'sinatra14' do
   gem 'sinatra', '~> 1.4.0'
 end
 
-appraise 'rails50' do
-  gem 'rails', '~> 5.0.0'
-end
+if Gem::Version.new(RUBY_VERSION) > Gem::Version.new('2.5.0')
+  appraise 'rails60' do
+    gem 'rails', '~> 6.0.0'
+  end
 
-appraise 'rails52' do
-  gem 'rails', '~> 5.2.0'
+  appraise 'sidekiq6' do
+    gem 'sidekiq', '~> 6.0'
+  end
 end
 
 appraise 'sidekiq51' do

data/CHANGELOG.md

@@ -4,6 +4,26 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.5.4] - 2021-03-24
+### Fixed
+- Remove state from Rack middleware, to prevent race conditions where one request would overwrite the state of another
+
+## [2.5.3] - 2020-10-27
+### Fixed
+- Support for sidekiq 6 - previous versions were causing sidekiq to crash with `Internal exception!`
+
+## [2.5.2] - 2020-10-21
+### Fixed
+- Support for sidekiq 6
+
+## [2.5.1] - 2020-01-02
+### Fixed
+- Fixed a long standing bug that would mask exceptions raised by the host application when serving requests. The original exception would be replaced with a `TypeError` one due to a HTTP status code not being available within `Loga::Rack::Logger`.
+
+## [2.5.0] - 2019-11-12
+### Added
+- Add support for rails 6
+
 ## [2.4.0] - 2019-09-03
 ### Fixed
 - `duration` in the `sidekiq` integration is now calculated correctly

data/Gemfile

@@ -4,5 +4,5 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
-  gem 'simplecov'
+  gem 'simplecov', '~> 0.17.0'
 end

data/README.md

@@ -4,7 +4,7 @@
 [![Build Status](https://circleci.com/gh/FundingCircle/loga/tree/master.svg?style=shield&circle-token=9b81c3cf8468a8c3dc760f4c0398cf8914cb27d4)](https://circleci.com/gh/FundingCircle/loga/tree/master)
 [![Code Quality](https://codeclimate.com/repos/5563694f6956805723005d2f/badges/8eecb9144730614fb39e/gpa.svg)](https://codeclimate.com/repos/5563694f6956805723005d2f/feed)
 [![Test Coverage](https://codeclimate.com/repos/5563694f6956805723005d2f/badges/8eecb9144730614fb39e/coverage.svg)](https://codeclimate.com/repos/5563694f6956805723005d2f/coverage)
-[![Dependency Status](https://gemnasium.com/badges/github.com/FundingCircle/loga.svg)](https://gemnasium.com/github.com/FundingCircle/loga)
+[![Dependency Status](https://img.shields.io/librariesio/release/rubygems/loga)](https://libraries.io/rubygems/loga)
 
 ## Description
 

data/gemfiles/rails60.gemfile

@@ -0,0 +1,11 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 6.0.0"
+
+group :test do
+  gem "simplecov", "~> 0.17.0"
+end
+
+gemspec path: "../"

data/gemfiles/sidekiq51.gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "sidekiq", "~> 5.1.0"
 
 group :test do
-  gem "simplecov"
+  gem "simplecov", "~> 0.17.0"
 end
 
 gemspec path: "../"

data/gemfiles/sidekiq6.gemfile

@@ -0,0 +1,11 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "sidekiq", "~> 6.0"
+
+group :test do
+  gem "simplecov", "~> 0.17.0"
+end
+
+gemspec path: "../"

data/gemfiles/sinatra14.gemfile

@@ -5,7 +5,7 @@ source "https://rubygems.org"
 gem "sinatra", "~> 1.4.0"
 
 group :test do
-  gem "simplecov"
+  gem "simplecov", "~> 0.17.0"
 end
 
 gemspec path: "../"

data/gemfiles/unit.gemfile

@@ -3,7 +3,7 @@
 source "https://rubygems.org"
 
 group :test do
-  gem "simplecov"
+  gem "simplecov", "~> 0.17.0"
 end
 
 gemspec path: "../"

data/lib/loga/configuration.rb

@@ -79,6 +79,7 @@ module Loga
       { format: ENV['LOGA_FORMAT'].presence }.reject { |_, v| v.nil? }
     end
 
+    # Note: sidekiq 6 will extend the logger -> https://github.com/mperham/sidekiq/blob/v6.1.2/lib/sidekiq.rb#L210
     def initialize_logger
       device.sync      = sync
       logger           = Logger.new(device)

data/lib/loga/formatters/gelf_formatter.rb

@@ -47,7 +47,8 @@ module Loga
                 end
 
         event.timestamp ||= time
-        event.data ||= {}
+        # Overwrite sidekiq_context data anything manually specified
+        event.data = sidekiq_context.merge!(event.data || {})
         event.data.tap do |hash|
           hash.merge! compute_exception(event.exception)
           hash.merge! compute_type(event.type)
@@ -101,6 +102,20 @@ module Loga
           tags: current_tags.join(' '),
         }
       end
+
+      def sidekiq_context
+        return {} unless defined?(::Sidekiq::Context)
+
+        c = ::Sidekiq::Context.current
+
+        # The context usually holds :class and :jid. :elapsed is added when the job ends
+        data = c.dup
+        if data.key?(:elapsed)
+          data[:duration] = data[:elapsed].to_f
+          data.delete(:elapsed)
+        end
+        data
+      end
     end
   end
 end

data/lib/loga/rack/logger.rb

@@ -7,62 +7,57 @@ module Loga
         @app = app
       end
 
-      def call(env)
+      def call(env, started_at = Time.now)
         request = Loga::Rack::Request.new(env)
         env['loga.request.original_path'] = request.path
 
         if logger.respond_to?(:tagged)
-          logger.tagged(compute_tags(request)) { call_app(request, env) }
+          logger.tagged(compute_tags(request)) { call_app(request, env, started_at) }
         else
-          call_app(request, env)
+          call_app(request, env, started_at)
         end
       end
 
       private
 
-      attr_reader :data, :env, :request, :started_at
-
-      def call_app(request, env)
-        @data       = {}
-        @env        = env
-        @request    = request
-        @started_at = Time.now
-
-        @app.call(env).tap { |status, _headers, _body| data['status'] = status.to_i }
+      def call_app(request, env, started_at)
+        status, _headers, _body = @app.call(env)
       ensure
-        set_data
-        send_message
-      end
+        data = generate_data(request, status, started_at)
 
-      # rubocop:disable Metrics/LineLength
-      def set_data
-        data['method']     = request.request_method
-        data['path']       = request.original_path
-        data['params']     = request.filtered_parameters
-        data['request_id'] = request.uuid
-        data['request_ip'] = request.ip
-        data['user_agent'] = request.user_agent
-        data['controller'] = request.controller_action_name if request.controller_action_name
-        data['duration']   = duration_in_ms(started_at, Time.now)
-      end
-      # rubocop:enable Metrics/LineLength
+        exception = compute_exception(env)
 
-      def send_message
         event = Loga::Event.new(
           data:       { request: data },
-          exception:  compute_exception,
-          message:    compute_message,
+          exception:  exception,
+          message:    compute_message(request, data),
           timestamp:  started_at,
           type:       'request',
         )
-        logger.public_send(compute_level, event)
+
+        exception ? logger.error(event) : logger.info(event)
+      end
+
+      def generate_data(request, status, started_at)
+        controller = request.controller_action_name
+        status ||= 500
+        {
+          'method' => request.request_method,
+          'path' => request.original_path,
+          'params' => request.filtered_parameters,
+          'request_id' => request.uuid,
+          'request_ip' => request.ip,
+          'user_agent' => request.user_agent,
+          'duration' => duration_in_ms(started_at, Time.now),
+          'status' => status.to_i,
+        }.tap { |d| d['controller'] = controller if controller }
       end
 
       def logger
         Loga.logger
       end
 
-      def compute_message
+      def compute_message(request, data)
         '%<method>s %<filtered_full_path>s %<status>d in %<duration>dms' % {
           method:             request.request_method,
           filtered_full_path: request.filtered_full_path,
@@ -71,19 +66,14 @@ module Loga
         }
       end
 
-      def compute_level
-        compute_exception ? :error : :info
-      end
+      def compute_exception(env)
+        exception =
+          env['loga.exception'] || env['action_dispatch.exception'] ||
+          env['sinatra.error'] || env['rack.exception']
 
-      def compute_exception
         filter_exceptions.include?(exception.class.to_s) ? nil : exception
       end
 
-      def exception
-        env['loga.exception'] || env['action_dispatch.exception'] ||
-          env['sinatra.error'] || env['rack.exception']
-      end
-
       def filter_exceptions
         Loga.configuration.filter_exceptions
       end

data/lib/loga/railtie.rb

@@ -125,7 +125,7 @@ module Loga
       def silence_rails_rack_logger
         case Rails::VERSION::MAJOR
         when 3    then require 'loga/ext/rails/rack/logger3.rb'
-        when 4..5 then require 'loga/ext/rails/rack/logger.rb'
+        when 4..6 then require 'loga/ext/rails/rack/logger.rb'
         else
           raise Loga::ConfigurationError,
                 "Rails #{Rails::VERSION::MAJOR} is unsupported"

data/lib/loga/sidekiq.rb

@@ -1,16 +1,24 @@
-require 'loga/sidekiq/job_logger'
-
 module Loga
   module Sidekiq
     def self.configure_logging
       return unless defined?(::Sidekiq)
       return if Gem::Version.new(::Sidekiq::VERSION) < Gem::Version.new('5.0')
 
-      ::Sidekiq.configure_server do |config|
-        config.options[:job_logger] = Loga::Sidekiq::JobLogger
+      if Gem::Version.new(::Sidekiq::VERSION) < Gem::Version.new('6.0')
+        require 'loga/sidekiq5/job_logger'
+
+        ::Sidekiq.configure_server do |config|
+          config.options[:job_logger] = Loga::Sidekiq5::JobLogger
+        end
+      elsif Gem::Version.new(::Sidekiq::VERSION) < Gem::Version.new('7.0')
+        require 'loga/sidekiq6/job_logger'
+
+        ::Sidekiq.configure_server do |config|
+          config.options[:job_logger] = Loga::Sidekiq6::JobLogger
+        end
       end
 
-      ::Sidekiq::Logging.logger = Loga.configuration.logger
+      ::Sidekiq.logger = Loga.configuration.logger
     end
   end
 end

data/lib/loga/{sidekiq → sidekiq5}/job_logger.rb

@@ -1,9 +1,7 @@
 module Loga
-  module Sidekiq
+  module Sidekiq5
     # The approach of using a custom job logger in sidekiq was introduced
     # in v5.0: https://github.com/mperham/sidekiq/pull/3235
-    # This job logger does not support logging for Sidekiq versions
-    # that are before 5.0
     class JobLogger
       include Loga::Utilities
 

data/lib/loga/sidekiq6/job_logger.rb

@@ -0,0 +1,50 @@
+require 'sidekiq/job_logger'
+
+module Loga
+  module Sidekiq6
+    class JobLogger < ::Sidekiq::JobLogger
+      EVENT_TYPE = 'sidekiq'.freeze
+
+      def call(item, _queue)
+        start = ::Process.clock_gettime(::Process::CLOCK_MONOTONIC)
+
+        yield
+
+        with_elapsed_time_context(start) do
+          loga_log(
+            message: "#{item['class']} with jid: '#{item['jid']}' done", item: item,
+          )
+        end
+      rescue Exception => e # rubocop:disable Lint/RescueException
+        with_elapsed_time_context(start) do
+          loga_log(
+            message: "#{item['class']} with jid: '#{item['jid']}' fail", item: item,
+            exception: e
+          )
+        end
+
+        raise
+      end
+
+      private
+
+      def loga_log(message:, item:, exception: nil)
+        data = {
+          'created_at'  => item['created_at'],
+          'enqueued_at' => item['enqueued_at'],
+          'jid'         => item['jid'],
+          'queue'       => item['queue'],
+          'retry'       => item['retry'],
+          'params'      => item['args'],
+          'class'       => item['class'],
+        }
+        if exception
+          data['exception'] = exception
+          @logger.warn(Event.new(type: EVENT_TYPE, message: message, data: data))
+        else
+          @logger.info(Event.new(type: EVENT_TYPE, message: message, data: data))
+        end
+      end
+    end
+  end
+end