log_parser_notifier 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95449b6a9352c49727c2c98767ae726617704bec
-  data.tar.gz: 505d4e48911465e389179ffc76ab43ce29f95f2a
+  metadata.gz: 25e36655772d7de5a40f8243990da5d7c29e12a7
+  data.tar.gz: a5c8fb09ca8fd942526cb5a257ce62362bf34b67
 SHA512:
-  metadata.gz: 9750ed89f239f2f4ad67372f9aaecbc07271c87a8e17df2bdc78e2370c8bcbc1eebf0e917849b67ed31e05d3edcfc0f021de036747f61e50d3c73a529a229e43
-  data.tar.gz: 7369783bce6d5c012ee6d804fc598a7e46ad3c9da424fc938b0b1b0dd8d5e41963a9ce91ccd8ee2ea080623b0f7191659307d642e818047fdbff352d3a5c530b
+  metadata.gz: cc09fc1488a2bd4b266f5c60df9fa34d7a1412dbbb94e92e7e1e6aa6fff26de29522b90acd385acc601804860c225bfff2e793c03032b315074a64328323bd80
+  data.tar.gz: cf332ab19457b39caea0a5e79d3092fd28531c13e43d18a48d60f629ce4135f9ae2660de76e92783978f1ff16d61f17fa573325b7ff5c29de9cce799c2e593c5

data/bin/log_parser_notifier

@@ -9,6 +9,7 @@ end
 opts = Slop.parse! do |o|
   o.banner = 'usage: lib_parser_notifier [options] file_name'
   o.on :c, :check_interval=, 'check interval (in minutes)', default: 5, as: Integer
+  o.on :t, :slow_request_threshold=, 'How long does a request need to create an event? (in ms)', default: 500, as: Integer
   o.on :verbose, 'enable verbose mode'
   # o.integer '--check_interval', 'check interval (in minutes)', default: 5
   # o.bool '-v', '--verbose', 'enable verbose mode'
@@ -32,9 +33,7 @@ end
 
 require File.join(File.dirname(__FILE__), '..', 'lib', 'log_parser_notifier')
 
-puts ARGV.inspect
-
-request_notifier = LogParserNotifier::RailsRequestNotifier.new(ARGV.first)
+request_notifier = LogParserNotifier::RailsRequestNotifier.new(ARGV.first, opts[:slow_request_threshold])
 
 while true
   LogParserNotifier.logger.debug('waking up and checking log')

data/lib/log_parser_notifier/rails_request_notifier.rb

@@ -1,9 +1,12 @@
 require 'statsd'
+require 'time'
 
 module LogParserNotifier
   class RailsRequestNotifier
-    def initialize(log_file)
+    def initialize(log_file, slow_request_threshold = 500)
       @log_reader = LogReader.new log_file
+      @slow_request_threshold = slow_request_threshold
+      puts @slow_request_threshold
     end
 
     def parser
@@ -20,13 +23,44 @@ module LogParserNotifier
 
         LogParserNotifier.logger.debug("processing request for #{request[:controller]}##{request[:action]} with status: #{request[:status]} it is complete: #{request.completed?}")
         if request.completed? && request[:status] >= 200 && request[:status] < 400
-
           statsd.increment 'rails.requests', tags: tags
           statsd.timing 'rails.load_time', request[:duration] * 1000, tags: tags
+
+          if request[:duration] * 1000 >= @slow_request_threshold
+            log = request.lines.collect { |line_hash| RailsRequestNotifier.render_line(line_hash) }.join("\n")
+            statsd.event(
+              "#{request[:controller]}##{request[:action]} #{request[:method]} slow request #{request[:duration]} sec",
+              log,
+              {
+                date_happened: Time.parse(request[:timestamp].to_s).to_i,
+                aggregation_key: 'slow_request_rails',
+                source_type_name: 'rails_log',
+                alert_type: 'warning',
+                tags: tags
+              }
+            )
+          end
         else
           statsd.increment 'rails.failed_requests', tags: tags
         end
       end
     end
+
+    def self.render_line(line_hash)
+      case line_hash[:line_type]
+      when :started
+        %Q(Started #{line_hash[:method]} "#{line_hash[:path]}" for #{line_hash[:ip]} at #{Time.parse(line_hash[:timestamp].to_s)})
+      when :processing
+        %Q(Processing by #{line_hash[:controller]}##{line_hash[:action]} as #{line_hash[:format]})
+      when :parameters
+        %Q(Parameters: #{line_hash[:params].inspect})
+      when :rendered
+        "  Rendered #{line_hash[:rendered_file]} (#{line_hash[:partial_duration]}ms)"
+      when :completed
+        "Completed #{line_hash[:status]} OK in #{(line_hash[:duration] * 1000).to_i}ms (Views: #{line_hash[:view] * 1000}ms | ActiveRecord: #{line_hash[:db] * 1000}ms)"
+      else
+        line_hash.inspect
+      end
+    end
   end
 end

data/lib/log_parser_notifier/version.rb

@@ -1,3 +1,3 @@
 module LogParserNotifier
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/log_parser_notifier.gemspec

@@ -26,4 +26,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.3.0'
+  spec.add_development_dependency 'pry'
 end

data/spec/rails_request_notifier_spec.rb

@@ -8,10 +8,9 @@ module LogParserNotifier
       RailsRequestNotifier.new(@logs)
     end
 
-    after { rails_request_notifier.parse_and_trigger_notifications }
-
     describe 'successful requests' do
       before { @logs = RailsLogRequests.normal_request_1 }
+      after { rails_request_notifier.parse_and_trigger_notifications }
 
       it 'should record the number of successful requests' do
         expect_any_instance_of(Statsd).to receive(:increment).with('rails.requests', tags: %w(controller:DashboardController action:show con_act:DashboardController#show))
@@ -24,10 +23,31 @@ module LogParserNotifier
       it 'should not record the number of failed requests' do
         expect_any_instance_of(Statsd).to_not receive(:increment).with('rails.failed_requests', anything)
       end
+
+      it 'should not create an event for short requests' do
+        expect_any_instance_of(Statsd).to_not receive('event')
+      end
+
+      describe 'slow requests' do
+        before { @logs = RailsLogRequests.slow_request }
+
+        it 'should create an event for the slow requests' do
+          expect_any_instance_of(Statsd).to receive('event').with(
+            'DocumentsController#new GET slow request 0.8 sec',
+            "Started GET \"/documents/new?template_id=30000&state=AK\" for 123.193.169.96 at 2015-09-17 03:19:58 +0800\nProcessing by DocumentsController#new as HTML\nParameters: {:template_id=>\"30000\", :state=>\"AK\"}\n  Rendered documents/_preview.html.erb (0.0ms)\n  Rendered shared/_contact_number.erb (0.0ms)\n  Rendered shared/_disclaimer.html.erb (0.001ms)\nCompleted 200 OK in 800ms (Views: 34.0ms | ActiveRecord: 4.0ms)",
+            date_happened: 1442431198,
+            aggregation_key: 'slow_request_rails',
+            source_type_name: 'rails_log',
+            alert_type: 'warning',
+            tags: %w(controller:DocumentsController action:new con_act:DocumentsController#new)
+          )
+        end
+      end
     end
 
     describe 'failed request' do
       before { @logs = RailsLogRequests.failed_request }
+      after { rails_request_notifier.parse_and_trigger_notifications }
 
       it 'should record the number of failed requests' do
         expect_any_instance_of(Statsd).to receive(:increment).with('rails.failed_requests', tags: %w(controller:DocumentsController action:preview con_act:DocumentsController#preview))
@@ -47,6 +67,41 @@ module LogParserNotifier
         @logs = RailsLogRequests.partial_request
         expect_any_instance_of(Statsd).to_not receive(:increment).with('rails.requests', tags: %w(controller:DashboardController action:index con_act:DashboardController#index))
         expect_any_instance_of(Statsd).to_not receive(:timing).with('rails.load_time', anything, tags: %w(controller:DashboardController action:index con_act:DashboardController#index))
+
+        rails_request_notifier.parse_and_trigger_notifications
+      end
+    end
+
+    describe '.render_line' do
+      subject do
+        RailsRequestNotifier.render_line @line_hash
+      end
+      it 'should render start line' do
+        @line_hash = { method: 'GET', path: '/documents/new?template_id=30000&state=AK', ip: '123.193.169.96', timestamp: 20_150_917_031_958, line_type: :started, lineno: 1, source: nil, compound: [] }
+        expect(subject).to eq 'Started GET "/documents/new?template_id=30000&state=AK" for 123.193.169.96 at 2015-09-17 03:19:58 +0800'
+      end
+
+      it 'should render the process line' do
+        @line_hash = { controller: 'DocumentsController', action: 'new', format: 'HTML', line_type: :processing, lineno: 2, source: nil, compound: [] }
+        expect(subject).to eq 'Processing by DocumentsController#new as HTML'
+      end
+
+      it 'should render the params line' do
+        @line_hash = { params: { template_id: '30000', state: 'AK' }, line_type: :parameters, lineno: 3, source: nil, compound: [] }
+
+        expect(subject).to eq 'Parameters: {:template_id=>"30000", :state=>"AK"}'
+      end
+
+      it 'should render the render line' do
+        @line_hash = { rendered_file: 'documents/_preview.html.erb', partial_duration: 0.0, line_type: :rendered, lineno: 4, source: nil, compound: [:partial_duration] }
+
+        expect(subject).to eq '  Rendered documents/_preview.html.erb (0.0ms)'
+      end
+
+      it 'should render the completed line' do
+        @line_hash = { status: 200, duration: 0.8, view: 0.034, db: 0.004, line_type: :completed, lineno: 7, source: nil, compound: [] }
+
+        expect(subject).to eq 'Completed 200 OK in 800ms (Views: 34.0ms | ActiveRecord: 4.0ms)'
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'bundler/setup'
 require 'logger'
+require 'pry'
 
 Bundler.setup
 

data/spec/support/rails_log_requests.rb

@@ -19,6 +19,17 @@ I, [2015-08-24T07:36:43.695000 #19020]  INFO -- : Completed 200 OK in 91ms (View
 )
     end
 
+    def self.slow_request
+StringIO.new %Q(I, [2015-09-17T03:19:58.989000 #12393]  INFO -- : Started GET "/documents/new?template_id=30000&state=AK" for 123.193.169.96 at 2015-09-17 03:19:58 +0000
+I, [2015-09-17T03:19:58.994000 #12393]  INFO -- : Processing by DocumentsController#new as HTML
+I, [2015-09-17T03:19:58.994000 #12393]  INFO -- :   Parameters: {"template_id"=>"30000", "state"=>"AK"}
+I, [2015-08-24T07:36:43.688000 #19020]  INFO -- :   Rendered documents/_preview.html.erb (0.0ms)
+I, [2015-08-24T07:36:43.692000 #19020]  INFO -- :   Rendered shared/_contact_number.erb (0.0ms)
+I, [2015-08-24T07:36:43.694000 #19020]  INFO -- :   Rendered shared/_disclaimer.html.erb (1.0ms)
+I, [2015-08-24T07:36:43.695000 #19020]  INFO -- : Completed 200 OK in 800ms (Views: 34.0ms | ActiveRecord: 4.0ms)
+)
+    end
+
     def self.failed_request
 StringIO.new %Q(I, [2015-08-24T07:35:11.541000 #19020]  INFO -- : Started GET "/documents/9293/preview/?page=0" for 50.31.29.217 at 2015-08-24 07:35:11 +0000
 I, [2015-08-24T07:35:11.549000 #19020]  INFO -- : Processing by DocumentsController#preview as JSON

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: log_parser_notifier
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Josh Moore
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.3.0
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Write a longer description. Optional.
 email:
 - joshsmoore@gmail.com