log4r-exceptionable 0.5.3 → 0.5.4

data/CHANGELOG

@@ -1,3 +1,9 @@
+0.5.4 (06/15/2012)
+------------------
+
+fix header <8e2164b>
+leave formatting up to log4r <e9a7baf>
+
 0.5.3 (06/15/2012)
 ------------------
 

data/README.md

@@ -1,5 +1,5 @@
-graylog2-resque
-===============
+log4r-exceptionable
+===================
 
 This gem provides failure handlers for [Resque][0] and [Rack][1] that logs all failures using [log4r][2].  It is expected that these logs will get sent elsewhere (e.g. [graylog][3]) by using log4r outputters (e.g. [log4r-gelf][4]).  It adds contextual information to the log message using Log4r::MDC, which is useful if you are using log4r-gelf since it sends all of those to graylog as custom attributes. 
 

data/lib/log4r-exceptionable/rack_failure_handler.rb

@@ -44,7 +44,7 @@ module Log4rExceptionable
           if env and env.size > 0
             env.each do |k, v|
               begin
-                mdc.put("rack_env_#{k}", v.inspect)
+                mdc.put("rack_env_#{k}", v)
               rescue
                 puts "Log4r Exceptionable could not extract a rack env item: " + e.message
               end
@@ -55,8 +55,8 @@ module Log4rExceptionable
           if controller && controller.respond_to?(:logger) && controller.logger.instance_of?(Log4r::Logger)
             error_logger = controller.logger 
             begin
-              mdc.put("rack_controller_name", controller.controller_name.to_s)
-              mdc.put("rack_action_name", controller.action_name.to_s)
+              mdc.put("rack_controller_name", controller.controller_name)
+              mdc.put("rack_action_name", controller.action_name)
             rescue => e
               puts "Log4r Exceptionable could not extract controller names: " + e.message
             end

data/lib/log4r-exceptionable/resque_failure_handler.rb

@@ -12,17 +12,19 @@ module Log4rExceptionable
         original_mdc = mdc.get_context
         
         begin
-             
+          
           data = payload.clone
-          mdc.put("resque_worker", worker.to_s)
-          mdc.put("resque_queue", queue.to_s)
-          mdc.put("resque_class", data.delete('class').to_s)
-          mdc.put("resque_args", data.delete('args').inspect.to_s)
+          payload_class_name = data.delete('class')
+          payload_class = Resque.constantize(payload_class_name) rescue payload_class_name
+          mdc.put("resque_worker", worker)
+          mdc.put("resque_queue", queue)
+          mdc.put("resque_class", payload_class)
+          mdc.put("resque_args", data.delete('args'))
           
           # add in any extra payload data, in case resque plugins have
           # added to it (e.g. resque-lifecycle)
           data.each do |k, v|
-            mdc.put("resque_payload_#{k}", v.inspect.to_s)
+            mdc.put("resque_payload_#{k}", v)
           end
 
           payload_class = Resque.constantize(payload['class']) rescue nil

data/lib/log4r-exceptionable/version.rb

@@ -1,3 +1,3 @@
 module Log4rExceptionable
-  VERSION = "0.5.3"
+  VERSION = "0.5.4"
 end

data/spec/rack_failure_handler_spec.rb

@@ -74,7 +74,7 @@ describe Log4rExceptionable::RackFailureHandler do
         msg.should be_instance_of RuntimeError
         msg.message.should == "I failed"
         msg.backtrace.first.should =~ /rack_failure_handler_spec.rb/
-        Log4r::MDC.get('rack_env_PATH_INFO').should == '"/error"'
+        Log4r::MDC.get('rack_env_PATH_INFO').should == '/error'
       end
       
       lambda {

data/spec/resque_failure_handler_spec.rb

@@ -55,10 +55,10 @@ describe Log4rExceptionable::ResqueFailureHandler do
         msg.should be_instance_of RuntimeError
         msg.message.should == "I failed"
         msg.backtrace.first.should =~ /resque_failure_handler_spec.rb/
-        Log4r::MDC.get('resque_worker').should == ""
+        Log4r::MDC.get('resque_worker').should == nil
         Log4r::MDC.get('resque_queue').should == "somequeue"
-        Log4r::MDC.get('resque_class').should == "SomeJob"
-        Log4r::MDC.get('resque_args').should == "[\"foo\"]"
+        Log4r::MDC.get('resque_class').should == SomeJob
+        Log4r::MDC.get('resque_args').should == ["foo"]
       end
       
       run_resque_job(SomeJob, 'foo', :queue => :somequeue, :inline => true)
@@ -69,7 +69,7 @@ describe Log4rExceptionable::ResqueFailureHandler do
       Log4r::Logger['resquelogger'].should_receive(:error) do |msg|
         msg.should be_instance_of RuntimeError
         msg.message.should == "I failed"
-        Log4r::MDC.get('resque_class').should == "SomeJobWithNilLogger"
+        Log4r::MDC.get('resque_class').should == SomeJobWithNilLogger
       end
       
       run_resque_job(SomeJobWithNilLogger, 'foo', :queue => :somequeue, :inline => true)
@@ -80,7 +80,7 @@ describe Log4rExceptionable::ResqueFailureHandler do
       Log4r::Logger['resquelogger'].should_receive(:error) do |msg|
         msg.should be_instance_of RuntimeError
         msg.message.should == "I failed"
-        Log4r::MDC.get('resque_class').should == "SomeJobWithOtherLogger"
+        Log4r::MDC.get('resque_class').should == SomeJobWithOtherLogger
       end
       
       run_resque_job(SomeJobWithOtherLogger, 'foo', :queue => :somequeue, :inline => true)
@@ -92,7 +92,7 @@ describe Log4rExceptionable::ResqueFailureHandler do
       Log4r::Logger['SomeJobWithLogger'].should_receive(:error) do |msg|
         msg.should be_instance_of RuntimeError
         msg.message.should == "I failed"
-        Log4r::MDC.get('resque_class').should == "SomeJobWithLogger"
+        Log4r::MDC.get('resque_class').should == SomeJobWithLogger
       end
       
       run_resque_job(SomeJobWithLogger, 'foo', :queue => :somequeue, :inline => true)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: log4r-exceptionable
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.4
   prerelease: 
 platform: ruby
 authors: