log2mail 0.0.1.pre3 → 0.0.1.pre4

data/lib/log2mail/console/commands.rb

@@ -42,7 +42,7 @@ module Log2mail
     desc "show configuration"
     def config
       config_path = ask('configuration path? ').chomp
-      config = Log2mail::Config.parse_config config_path
+      config = Log2mail::Config::ConfigFileHandler.parse_config config_path
       puts "Defaults:"
       puts config.defaults
       puts "Settings:"

data/lib/log2mail/main.rb

@@ -81,7 +81,7 @@ Main {
     option('maxbufsize') { argument_required; cast :int; default 65536 }
     def run
       fail "Not starting. Daemon running." if daemon_running? and !params['nofork'].value
-      config = Log2mail::Config.parse_config @config_path
+      config = Log2mail::Config::ConfigFileHandler.parse_config @config_path
       unless params['nofork'].value
         Process.daemon
         $PROGRAM_NAME = Log2mail::PROGNAME
@@ -133,7 +133,7 @@ Main {
   mode 'configtest' do
     option('effective', 'e') { description 'show effective settings' }
     def run
-      config = Log2mail::Config.parse_config @config_path
+      config = Log2mail::Config::ConfigFileHandler.parse_config @config_path
       puts config.formatted(params['effective'].value)
     end
   end

data/lib/log2mail/version.rb

@@ -1,6 +1,6 @@
 module Log2mail
   PROGNAME    = 'log2mail.rb'
-  VERSION     = "0.0.1.pre3"
+  VERSION     = "0.0.1.pre4"
   AUTHOR      = "Markus Strauss"
   AUTHOR_MAIL = "log2mail@dev.sieb.mx"
 end

data/lib/log2mail/watcher.rb

@@ -9,7 +9,7 @@ module Log2mail
     # end
 
     def initialize( config, sleeptime )
-      fail Error, 'Invalid configuration.' unless config.instance_of?(Log2mail::Config)
+      fail Error, 'Invalid configuration.' unless config.instance_of?(Config::ConfigFileHandler)
       @file_patterns = config.file_patterns
       @files = @file_patterns.keys.map {|f| Log2mail::File.new(f, @file_patterns[f] ) }
       @sleeptime = sleeptime

data/log2mail.gemspec

@@ -32,4 +32,5 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'gem-man', '~> 0.3', '>= 0.3.0'
   spec.add_runtime_dependency 'main', '~> 6.1.0'
   spec.add_runtime_dependency 'terminal-table'
+  spec.add_runtime_dependency 'parslet'
 end

data/man/log2mail.1

@@ -13,7 +13,7 @@
 \fBlog2mail\.rb\fR helps having an eye on your systems\' log files\. It efficiently monitors multiple files and reports as soon as specified (regular expression) patterns match\.
 .
 .P
-On startup, \fBlog2mail\.rb\fR opens all files on the \'watch list\' and seeks to EOF\. All new data are parsed about once a minute (see \fB\-\-sleeptime\fR)\.  Matched patterns are reported to the configured mail address(es) (see \fBmailto\fR configuration option)\.
+On startup, \fBlog2mail\.rb\fR opens all files on the \'watch list\' and seeks to EOF\. All new data are parsed about once a minute (see \fB\-\-sleeptime\fR)\. Matched patterns are reported to the configured mail address(es) (see \fBmailto\fR configuration option)\.
 .
 .P
 Log files are reopened automatically when rotated\.

data/man/log2mail.1.ronn

@@ -9,7 +9,7 @@ log2mail.rb(1) -- monitors (log) files for patterns and reports hits by mail
 
 `log2mail.rb` helps having an eye on your systems' log files.  It efficiently monitors multiple files and reports as soon as specified (regular expression) patterns match.
 
-On startup, `log2mail.rb` opens all files on the 'watch list' and seeks to EOF.  All new data are parsed about once a minute (see `--sleeptime`). <!-- If necessary, i.e. when multiline patterns are set for the file, every new data is put into a fixed-size buffer.  The buffer is rolled over when it gets full. --> Matched patterns are reported to the configured mail address(es) (see `mailto` configuration option).
+On startup, `log2mail.rb` opens all files on the 'watch list' and seeks to EOF.  All new data are parsed about once a minute (see `--sleeptime`). Matched patterns are reported to the configured mail address(es) (see `mailto` configuration option).
 
 Log files are reopened automatically when rotated.
 

data/spec/factories.rb

@@ -1,51 +1,101 @@
 require 'tempfile'
 
 FactoryGirl.define do
-  factory :config, class: Log2mail::Config do
 
+  factory :raw_config, class: String do
     trait :valid do
+      initialize_with{ new <<-CONFIG }
+# sample config file for log2mail
+# comments start with '#'
+# see source code doc/Configuration for additional information
+
+defaults
+  sendtime   = 20
+  resendtime = 50
+  maxlines   = 7
+  template   = /tmp/mail_template
+  fromaddr   = log2mail
+  sendmail   = /usr/sbin/sendmail -oi -t
+  mailto     = global_default_recipient@example.org  # new in log2mail.rb
+file = test.log
+  pattern = /any/
+  pattern = string match
+    mailto = special@recipient
+      maxlines = 99
+      CONFIG
+    end
+
+    trait :valid_without_defaults do
+      initialize_with{ new <<-CONFIG }
+file = test.log
+  pattern = /any/
+  pattern = string match
+    mailto = special@recipient
+      CONFIG
+    end
+
+    trait :valid_global_mailto_attributes do
+      initialize_with{ new <<-CONFIG }
+defaults
+  mailto   = recipient@test.itstrauss.eu
+  fromaddr = log2mail
+file = test.log
+  pattern = string pattern
+  pattern = /regexp pattern/
+      CONFIG
+    end
+
+    trait :valid_global_pattern_attributes do
+      initialize_with{ new <<-CONFIG }
+defaults
+  pattern = recipient@test.itstrauss.eu
+  mailto  = special recipient for pattern
+file = test.log
+      CONFIG
+    end
+
+    factory :valid_raw_config, traits: [:valid]
+    factory :valid_raw_config_without_defaults, traits: [:valid_without_defaults]
+    factory :valid_raw_config_with_defaults_with_global_mailto_attributes, traits: [:valid_global_mailto_attributes]
+    factory :valid_raw_config_with_defaults_with_global_pattern_attributes, traits: [:valid_global_pattern_attributes]
+  end
+
+  factory :config, class: Log2mail::Config::ConfigFileHandler do
+
+    factory :valid_config do
       initialize_with do
         tmp = Tempfile.new('valid_config')
-        tmp.write <<-CONFIG
-          # sample config file for log2mail
-          # comments start with '#'
-          # see source code doc/Configuration for additional information
-
-          defaults
-            sendtime   = 20
-            resendtime = 50
-            maxlines   = 7
-            template   = /tmp/mail_template
-            fromaddr   = log2mail
-            sendmail   = /usr/sbin/sendmail -oi -t
-            mailto     = global_default_recipient@example.org  # new in log2mail.rb
-          file = test.log
-            pattern = /any/
-            pattern = string match
-              mailto = special@recipient
-                maxlines = 99
-        CONFIG
+        tmp.write build(:valid_raw_config)
         tmp.close
         new(tmp.path)
       end
     end
 
-    trait :valid_without_defaults do
+    factory :valid_config_without_defaults do
+      initialize_with do
+        tmp = Tempfile.new('valid_config')
+        tmp.write build(:valid_raw_config_without_defaults)
+        tmp.close
+        new(tmp.path)
+      end
+    end
+    factory :valid_config_with_defaults_with_global_mailto_attributes do
+      initialize_with do
+        tmp = Tempfile.new('valid_config')
+        tmp.write build(:valid_raw_config_with_defaults_with_global_mailto_attributes)
+        tmp.close
+        new(tmp.path)
+      end
+    end
+    factory :valid_config_with_defaults_with_global_pattern_attributes do
       initialize_with do
         tmp = Tempfile.new('valid_config')
-        tmp.write <<-CONFIG
-          file = test.log
-            pattern = /any/
-            pattern = string match
-              mailto = special@recipient
-        CONFIG
+        tmp.write build(:valid_raw_config_with_defaults_with_global_pattern_attributes)
         tmp.close
         new(tmp.path)
       end
     end
 
-    factory :valid_config, traits: [:valid]
-    factory :valid_config_without_defaults, traits: [:valid_without_defaults]
   end
 
   factory :hit, class: Log2mail::Hit do
@@ -98,4 +148,51 @@ culpa qui officia deserunt mollit anim id est laborum.
     end
   end
 
+  sequence :snippet do |n|
+    <<-TEXT
+# this is file file#{n}
+file = file#{n}
+  pattern = for file#{n}
+    mailto = for pattern for file#{n}
+    TEXT
+  end
+
+  sequence :filename do |n|
+    "config file #{n}"
+  end
+
+
+  factory :defaults_snippet, class: Log2mail::Config::ConfigFileSnippet do
+    filename = '/config/defaults'
+    snippet = <<-TEXT
+# comment
+defaults
+mailto = global_default_recipient@example.org
+    TEXT
+    initialize_with do
+      new(snippet, filename)
+    end
+  end
+
+  factory :just_comments_snippet, class: Log2mail::Config::ConfigFileSnippet do
+    filename = '/config/comments'
+    snippet = <<-TEXT
+# comment
+# other comment
+# even more important comment
+    TEXT
+    initialize_with do
+      new(snippet, filename)
+    end
+  end
+
+  factory :config_file_snippet, class: Log2mail::Config::ConfigFileSnippet do
+    snippet
+    filename
+    initialize_with do
+      new(snippet, filename)
+    end
+
+  end
+
 end

data/spec/log2mail/{config_spec.rb → config/config_file_handler_spec.rb}

@@ -1,9 +1,9 @@
 require 'spec_helper'
 require 'tempfile'
 
-module Log2mail
+module Log2mail::Config
 
-  describe Config do
+  describe ConfigFileHandler do
 
     subject { build(:valid_config) }
 
@@ -24,7 +24,7 @@ module Log2mail
             :template   => "/tmp/mail_template",
             :fromaddr   => "log2mail",
             :sendmail   => "/usr/sbin/sendmail -oi -t",
-            :mailtos    => ["global_default_recipient@example.org"],
+            :mailtos    => {"global_default_recipient@example.org"=>{}},
           })
           expect(subject.patterns_for_file('test.log')).to eql(["/any/", "string match"])
           expect(subject.mailtos_for_pattern('test.log', 'string match')).to eql(["special@recipient"])
@@ -47,6 +47,22 @@ module Log2mail
         end
       end
 
+      context 'with defaults with attributes after a global mailto' do
+        subject { build(:valid_config_with_defaults_with_global_mailto_attributes) }
+        it 'should log a warning' do
+          expect($logger).to receive(:warn).with(/Attributes for a global default recipient specified/)
+          subject
+        end
+      end
+
+      context 'with defaults with attributes after a global pattern' do
+        subject { build(:valid_config_with_defaults_with_global_pattern_attributes) }
+        it 'should log a warning' do
+          expect($logger).to receive(:warn).with(/Attributes for a global default pattern specified/)
+          subject
+        end
+      end
+
       # it { is_expected.to eql build(:config) }
     end
 
@@ -98,6 +114,36 @@ module Log2mail
       end
     end
 
+    describe '#raw.join' do
+      it 'should return the original cat-together config files' do
+        expect(subject.raw.join).to eql(<<-EOF)
+# sample config file for log2mail
+# comments start with '#'
+# see source code doc/Configuration for additional information
+
+defaults
+  sendtime   = 20
+  resendtime = 50
+  maxlines   = 7
+  template   = /tmp/mail_template
+  fromaddr   = log2mail
+  sendmail   = /usr/sbin/sendmail -oi -t
+  mailto     = global_default_recipient@example.org  # new in log2mail.rb
+file = test.log
+  pattern = /any/
+  pattern = string match
+    mailto = special@recipient
+      maxlines = 99
+        EOF
+      end
+    end
+
+    describe '#formatted' do
+      it 'should return a formatted output of the configuration' do
+        expect( subject.formatted ).to be_instance_of(Terminal::Table)
+      end
+    end
+
   end
 
 end

data/spec/log2mail/config/parser_spec.rb

@@ -0,0 +1,467 @@
+require 'spec_helper'
+require 'log2mail/config/parser'
+require 'parslet/rig/rspec'
+
+module Log2mail::Config
+
+  describe Parser do
+
+    describe 'parse_snippets' do
+      it 'should merge the results from multiple files' do
+        expect( subject.parse_snippets([
+          build(:defaults_snippet),
+          build(:config_file_snippet),
+          build(:just_comments_snippet),
+          build(:config_file_snippet)
+        ]).tree ).to eq({
+          :defaults=>{:mailtos=>{"global_default_recipient@example.org"=>{}}},
+          :files=>{
+            "file1"=>{:patterns=>{"for file1"=>{:mailtos=>{"for pattern for file1"=>{}}}}},
+            "file2"=>{:patterns=>{"for file2"=>{:mailtos=>{"for pattern for file2"=>{}}}}},
+          }
+        })
+      end
+
+      it 'should correctly merge configurations for THE SAME file', :focus do
+        expect( subject.parse_snippets([
+          ConfigFileSnippet.new(<<-TEXT, 'configfile1'),
+file = /file/path
+  pattern = pattern1
+    mailto = for pattern1
+          TEXT
+          ConfigFileSnippet.new(<<-TEXT, 'configfile2'),
+file = /file/path
+  pattern = pattern2
+    mailto = for pattern2
+          TEXT
+          build(:config_file_snippet)
+        ]).tree ).to eq({
+          :files=>{
+            "/file/path"=>{:patterns=>{
+              "pattern1"=>{:mailtos=>{"for pattern1"=>{}}},
+              "pattern2"=>{:mailtos=>{"for pattern2"=>{}}} }},
+            "file1"=>{:patterns=>{"for file1"=>{:mailtos=>{"for pattern for file1"=>{}}}}},
+          }
+        })
+      end
+
+      it 'should correctly merge configurations for THE SAME file' do
+        expect( subject.parse_snippets([
+          ConfigFileSnippet.new(<<-TEXT, 'configfile'),
+file = /file/path
+  pattern = pattern1
+    mailto = for pattern1
+# file = /file/path
+  pattern = pattern2
+    mailto = for pattern2
+          TEXT
+          build(:config_file_snippet)
+        ]).tree ).to eq({
+          :files=>{
+            "/file/path"=>{:patterns=>{
+              "pattern1"=>{:mailtos=>{"for pattern1"=>{}}},
+              "pattern2"=>{:mailtos=>{"for pattern2"=>{}}} }},
+            "file1"=>{:patterns=>{"for file1"=>{:mailtos=>{"for pattern for file1"=>{}}}}},
+          }
+        })
+      end
+
+    end
+
+    describe 'invalid configurations should fail' do
+      it{ expect{ subject.parse_and_transform("defaults") }.to raise_error(Parslet::ParseFailed) }
+      it{ expect{ subject.parse_and_transform("file\n") }.to raise_error(Parslet::ParseFailed)}
+      it{ expect{ subject.parse_and_transform("invalid_attribute = some value\n") }.to raise_error(Parslet::ParseFailed)}
+      it{ expect{ subject.parse_and_transform("defaults\n  invalid_attribute = some value\n") }.to raise_error(Parslet::ParseFailed)}
+      it{ expect{ subject.parse_and_transform("pattern = string pattern\n") }.to raise_error(Parslet::ParseFailed)}
+      it{ expect{ subject.parse_and_transform("pattern = /regexp pattern/\n") }.to raise_error(Parslet::ParseFailed)}
+    end
+
+    describe '#tree should build hash trees' do
+      it{ expect( subject.parse_and_transform("").tree ).to eq({}) }
+      it{ expect( subject.parse_and_transform("defaults\n").tree ).to eq(defaults: {}) }
+      it{ expect( subject.parse_and_transform("file = /some/where/on/the/path\n").tree ).to eq(files:{'/some/where/on/the/path'=>{}}) }
+      it{ expect( subject.parse_and_transform("file = /some/where/on/the/path\npattern = test pattern\n").tree ).to eq \
+        files:{'/some/where/on/the/path' => {patterns:{'test pattern'=>{}}}} }
+      it{ expect( subject.parse_and_transform("defaults\n  fromaddr = some value\n").tree ).to eq(defaults:{fromaddr: 'some value'}) }
+      it{ expect( subject.parse_and_transform("defaults\n  pattern = string pattern\n").tree ).to eq(defaults:{patterns:{'string pattern'=>{}}}) }
+      it{ expect( subject.parse_and_transform("defaults\n  pattern = string pattern\n  pattern = another pattern\n").tree ).to eq(defaults:{patterns:{'string pattern'=>{}, 'another pattern'=>{}}}) }
+      it{ expect( subject.parse_and_transform("defaults\n  pattern = \"quoted string pattern \" # with comment\n").tree ).to eq(defaults:{patterns:{'quoted string pattern '=>{}}}) }
+      it{ expect( subject.parse_and_transform("defaults\n  pattern = \"multiline\n\nquoted string pattern\"\n").tree ).to eq(defaults:{patterns:{"multiline\n\nquoted string pattern"=>{}}}) }
+      it{ expect( subject.parse_and_transform(['defaults', "\n", 'pattern = "escaped \\"quoted\\" string pattern"', "\n"].join('') ).tree ).to eq \
+        defaults:{patterns:{'escaped "quoted" string pattern'=>{}}} }
+      it{ expect( subject.parse_and_transform("defaults\n  pattern = /regexp pattern/\n").tree ).to eq(defaults:{patterns:{'/regexp pattern/'=>{}}}) }
+      it{ expect( subject.parse_and_transform("defaults\nfile = bla\n").tree ).to eq(defaults: {}, files:{'bla'=>{}})}
+
+      it{ expect( subject.parse_and_transform("file = file one\npattern = pattern for file one\npattern = second pattern for file one\nfile = file two\npattern = pattern for file two\n").tree ).to eq ({
+        files:{
+          'file one' => { patterns:{'pattern for file one'=>{}, 'second pattern for file one'=>{}} },
+          'file two' => { patterns:{'pattern for file two'=>{}} },
+        }
+      })}
+
+      it{ expect( subject.parse_and_transform(build(:valid_raw_config)).tree ).to eq({
+        defaults:{
+          sendtime: 20,
+          resendtime: 50,
+          maxlines: 7,
+          template: '/tmp/mail_template',
+          fromaddr: 'log2mail',
+          sendmail: '/usr/sbin/sendmail -oi -t',
+          mailtos: {'global_default_recipient@example.org'=>{}}},
+        files:{
+          'test.log' => {
+            patterns:{
+              '/any/'=>{},
+              'string match'=>{ mailtos:{'special@recipient'=>{ maxlines: 99} } }
+            }
+          }
+        }
+      }) }
+
+      it{ expect( subject.parse_and_transform(build(:valid_raw_config_without_defaults)).tree ).to \
+        eq( files:{'test.log'=>{ patterns:{'/any/'=>{}, 'string match'=>{mailtos:{'special@recipient'=>{}}}} }} )}
+    end
+
+    it{ expect( subject.parse_and_transform("") ).to eq(Config.new) }
+
+    it{ expect( subject.parse_and_transform("#\n") ).to eq(Config.new) }
+
+    it{ expect{ subject.parse_and_transform("file = a file\n  pattern = a pattern\n  \# a comment\n") }.not_to raise_error }
+    it{ expect{ subject.parse_and_transform("defaults\n  pattern = a pattern\n  \# a comment\n") }.not_to raise_error }
+
+    it 'disallows file -> mailto' do
+      expect{ subject.parse_and_transform("file = a file\nmailto = a recipient\n")}.to \
+        raise_error Parslet::ParseFailed, /Extra input after last repetition at line 2 char 1/
+    end
+
+    it 'allows file -> pattern' do
+      expect{ subject.parse_and_transform("file = a file\npattern = a pattern\n")}.not_to raise_error
+    end
+
+    it 'allows file -> pattern -> mailto' do
+      expect{ subject.parse_and_transform("file = a file\npattern = a pattern\nmailto = a mailto\n")}.not_to raise_error
+    end
+
+    it 'allows file -> #comment -> pattern -> mailto' do
+      expect{ subject.parse_and_transform("file = a file\n\# a comment\npattern = a pattern\nmailto = a mailto\n")}.not_to raise_error
+    end
+
+    it 'allows file -> pattern -> #comment -> mailto' do
+      expect{ subject.parse_and_transform("file = a file\npattern = a pattern\n\# a comment\nmailto = a mailto\n")}.not_to raise_error
+    end
+
+    it 'allows defaults -> mailto' do
+      expect{ subject.parse_and_transform("defaults\nmailto = a global mailto\n")}.not_to raise_error
+    end
+
+    it 'allows defaults -> mailto' do
+      expect{ subject.parse_and_transform("defaults\nmailto = a global mailto\n")}.not_to raise_error
+    end
+
+    it 'disallows mailto' do
+      expect{ subject.parse_and_transform("mailto = a recipient\n")}.to \
+        raise_error Parslet::ParseFailed, /Extra input after last repetition at line 1 char 1/
+    end
+
+    it 'allows defaults -> #command -> mailto' do
+      expect{ subject.parse_and_transform("defaults\n\# a comment\nmailto = a global mailto\n")}.not_to raise_error
+    end
+
+
+    describe 'defaults -> mailto -> attribute' do
+      it{ expect{ subject.parse_and_transform("defaults\nmailto = a global mailto\nsendtime = a mailto setting\n")}.not_to raise_error }
+      it 'assigns attribute to the global mailto' do
+        expect( subject.parse_and_transform("defaults\nmailto = a global mailto\nsendtime = a mailto setting\n").tree).to eq(
+          {:defaults=>{:mailtos=>{"a global mailto"=>{:sendtime=>"a mailto setting"}} }})
+      end
+    end
+
+
+    describe 'defaults -> pattern -> attribute' do
+      it{ expect{ subject.parse_and_transform("defaults\npattern = a global pattern\nsendtime = a pattern setting\n")}.not_to raise_error }
+      it 'assigns attribute to the global pattern' do
+        expect( subject.parse_and_transform("defaults\npattern = a global pattern\nsendtime = a pattern setting\n").tree).to eq(
+          {:defaults=>{:patterns=>{"a global pattern"=>{:sendtime=>"a pattern setting"}} }})
+      end
+    end
+
+    it{ expect( subject.parse_and_transform("\n") ).to eq(Config.new) }
+
+    it{ expect( subject.parse_and_transform("defaults\n") ).to eq(Config.new([Section.new(:defaults)])) }
+
+    it{ expect( subject.parse_and_transform(" defaults \n") ).to eq(Config.new([Section.new(:defaults)])) }
+
+    it{ expect( subject.parse_and_transform("\# comment\n") ).to eq(Config.new) }
+
+    it{ expect( subject.parse_and_transform("defaults \# with comment\n") ).to eq(Config.new([Section.new(:defaults)])) }
+
+    it{ expect( subject.parse_and_transform("file = /some/where/on/the/path\n") ).to eq \
+      Config.new [ Section.new(:file, '/some/where/on/the/path') ] }
+
+    it{ expect( subject.parse_and_transform("file = /some/where/on/the/path\npattern = test pattern\n") ).to eq \
+      Config.new [ Section.new(:file, '/some/where/on/the/path', [Section.new(:pattern,'test pattern')]) ] }
+
+    it{ expect( subject.parse_and_transform("defaults\n  fromaddr = some value\n") ).to eq \
+      Config.new [ Section.new(:defaults, nil, [Attribute.new(:fromaddr,'some value')]) ] }
+
+    it 'should collapse multiple default sections' do
+      expect( subject.parse_and_transform("defaults\n  mailto=recipient@anywhere.com\ndefaults\n") ).to eq \
+        Config.new [ Section.new(:defaults, nil, [Section.new(:mailto,'recipient@anywhere.com')]) ]
+    end
+
+    it{ expect( subject.parse_and_transform("defaults\nfile = bla\n") ).to eq \
+      Config.new [ Section.new(:defaults,nil), Section.new(:file, 'bla') ] }
+
+  end
+
+  describe Transform do
+    it 'transforms quoted strings' do
+      expect( subject.apply( {:quoted_string=>"multiline\n\nquoted string pattern"} ) ).to eq("multiline\n\nquoted string pattern")
+    end
+
+    it 'transforms unquoted strings' do
+      expect( subject.apply( {:unquoted_string=>"a string with spaces at the end  "} ) ).to eq('a string with spaces at the end')
+    end
+
+    it 'transforms integers' do
+      expect( subject.apply( {:integer=>"123"} ) ).to eq(123)
+    end
+
+    it 'transforms attribute names' do
+      INT_OPTIONS.each do |opt|
+        rnd_int = rand(2**31)
+        expect( subject.apply( {:attribute_name=>opt, :attribute_value=>{:integer=>rnd_int} } ) ).to eq(Attribute.new(opt, rnd_int))
+      end
+      STR_OPTIONS.each do |opt|
+        rnd_string = rand(36**10).to_s(36)
+        expect( subject.apply( {:attribute_name=>opt, :attribute_value=>rnd_string } ) ).to eq(Attribute.new(opt, rnd_string))
+      end
+      PATH_OPTIONS.each do |opt|
+        expect( subject.apply( {:attribute_name=>opt, :attribute_value=>'/a/path/string' } ) ).to eq(Attribute.new(opt, '/a/path/string'))
+      end
+    end
+
+    it 'transforms section names' do
+      expect( subject.apply( {:section_name=>'file', :section_value=>'/a/file/path' } ) ).to eq(Section.new('file', '/a/file/path'))
+      expect( subject.apply( {:section_name=>'defaults' } ) ).to eq(Section.new('defaults'))
+    end
+
+    it 'transforms single file section without attributes' do
+      expect( subject.apply({
+        section:[
+          {section_name: 'file', section_value: '/file/path'},
+        ]
+      } ) ).to eq(
+        Section.new(:file, '/file/path' )
+      )
+    end
+
+    it 'transforms single file section with attributes' do
+      expect( subject.apply({
+        section:[
+          {section_name: 'file', section_value: '/file/path'},
+          {attribute_name: 'sendtime', attribute_value: '123'},
+          {attribute_name: 'fromaddr', attribute_value: 'sender@address'},
+        ]
+      } ) ).to eq(
+        Section.new(:file, '/file/path', [Attribute.new(:sendtime,'123'), Attribute.new(:fromaddr,'sender@address')] )
+      )
+    end
+
+    it 'transforms simple (non-array) sections' do
+      expect( subject.apply(
+        {:section=>
+          {:section_name=>"pattern",
+           :section_value=>{:unquoted_string=>"pattern for file one"}}}
+      ) ).to eq(
+        Section.new(:pattern, 'pattern for file one' )
+      )
+    end
+
+    it 'transforms single file section with subsections' do
+      transform = subject.apply(
+         {:section=>
+           [{:section_name=>"file",
+             :section_value=>{:unquoted_string=>"file one"}},
+            {:section=>
+              {:section_name=>"pattern",
+               :section_value=>{:unquoted_string=>"pattern for file one"}}},
+            {:section=>
+              {:section_name=>"pattern",
+               :section_value=>
+                {:unquoted_string=>"second pattern for file one"}}}]},
+      )
+      expect(transform).to eq(
+        Section.new(:file, 'file one', [
+          Section.new(:pattern, 'pattern for file one'),
+          Section.new(:pattern, 'second pattern for file one')] )
+      )
+    end
+
+    ### undecided case
+    # it 'transforms multiple file sections' do
+    #   expect( subject.apply({
+    #     section:[
+    #       {section_name: 'file', section_value: '/file/path1'},
+    #       {section_name: 'file', section_value: '/file/path2'},
+    #     ]
+    #   } ) ).to eq({
+    #     files: ['/file/path1', '/file/path2']
+    #   })
+    # end
+    #
+
+    it 'transforms single defaults section' do
+      expect( subject.apply({
+        section:[
+          {section_name: 'defaults'},
+        ]
+      } ) ).to eq( Section.new(:defaults) )
+    end
+
+    it 'transforms defaults section with attributes' do
+      expect( subject.apply({
+        section:[
+          {section_name: 'defaults'},
+          {attribute_name: 'sendtime', attribute_value: '123'},
+          {attribute_name: 'fromaddr', attribute_value: 'sender@address'},
+        ]
+      } ) ).to eq(
+        Section.new(:defaults, nil, [Attribute.new(:sendtime,'123'), Attribute.new(:fromaddr, 'sender@address')])
+      )
+    end
+
+
+    it 'transforms trivial config' do
+      expect( subject.apply({
+        config:[1,2,3]
+      } ) ).to eq(
+        Log2mail::Config::Config.new([1,2,3])
+      )
+    end
+
+    it 'transforms defaults only config' do
+      expect( subject.apply({
+        config:[
+          section:[
+            {section_name: 'defaults'},
+            {attribute_name: 'sendtime', attribute_value: '123'},
+            {attribute_name: 'fromaddr', attribute_value: 'sender@address'},
+          ]
+        ]
+      } ) ).to eq(Config.new([
+        Section.new(:defaults, nil, [Attribute.new(:sendtime,'123'), Attribute.new(:fromaddr, 'sender@address')])
+      ]))
+    end
+
+    it 'transforms file only config' do
+      expect( subject.apply({
+        config:[
+          section:[
+            {section_name: 'file', section_value: '/file/path1'},
+            {attribute_name: 'sendtime', attribute_value: '888'},
+            {attribute_name: 'fromaddr', attribute_value: 'other@address'},
+          ],
+        ]
+      } ) ).to eq(Config.new([
+        Section.new(:file, '/file/path1', [Attribute.new(:sendtime,'888'), Attribute.new(:fromaddr,'other@address')]),
+      ]))
+    end
+
+    it 'transforms combined config' do
+      expect( subject.apply(
+      {:config=>
+        [{:section=>
+           [{:section_name=>"defaults"},
+            {:attribute_name=>"sendtime",
+             :attribute_value=>{:integer=>"20"}},
+            {:attribute_name=>"resendtime",
+             :attribute_value=>{:integer=>"50"}},
+            {:attribute_name=>"maxlines", :attribute_value=>{:integer=>"7"}},
+            {:attribute_name=>"template",
+             :attribute_value=>{:unquoted_string=>"/tmp/mail_template"}},
+            {:attribute_name=>"fromaddr",
+             :attribute_value=>{:unquoted_string=>"log2mail"}},
+            {:attribute_name=>"sendmail",
+             :attribute_value=>{:unquoted_string=>"/usr/sbin/sendmail -oi -t"}},
+            {:attribute_name=>"mailto",
+             :attribute_value=>
+              {:unquoted_string=>"global_default_recipient@example.org  "}}]},
+         {:section=>
+           [{:section_name=>"file",
+             :section_value=>{:unquoted_string=>"test.log"}},
+            {:section=>
+              {:section_name=>"pattern",
+               :section_value=>{:unquoted_string=>"/any/"}}},
+            {:section=>
+              [{:section_name=>"pattern",
+                :section_value=>{:unquoted_string=>"string match"}},
+               {:section=>
+                 [{:section_name=>"mailto",
+                   :section_value=>{:unquoted_string=>"special@recipient"}},
+                  {:attribute_name=>"maxlines",
+                   :attribute_value=>{:integer=>"99"}}]}]}]}]}
+      )).to eq(
+        Log2mail::Config::Config.new([
+          Section.new(:defaults, nil, [
+            Attribute.new(:sendtime,20),
+            Attribute.new(:resendtime, 50),
+            Attribute.new(:maxlines, 7),
+            Attribute.new(:template, '/tmp/mail_template'),
+            Attribute.new(:fromaddr, 'log2mail'),
+            Attribute.new(:sendmail, '/usr/sbin/sendmail -oi -t'),
+            Attribute.new(:mailto, 'global_default_recipient@example.org')]),
+          Section.new(:file, 'test.log', [
+            Section.new(:pattern,'/any/'),
+            Section.new(:pattern, 'string match', [Section.new(:mailto, 'special@recipient', [Attribute.new(:maxlines, 99)])])])
+        ])
+      )
+    end
+
+    it 'transforms combined config' do
+      expect( subject.apply({
+        config:[
+          {section:[
+            {section_name: 'defaults'},
+            {attribute_name: 'sendtime', attribute_value: '123'},
+            {attribute_name: 'fromaddr', attribute_value: 'sender@address'},
+          ]},
+          {section:[
+            {section_name: 'file', section_value: '/file/path1'},
+            {attribute_name: 'sendtime', attribute_value: '888'},
+            {attribute_name: 'fromaddr', attribute_value: 'other@address'},
+          ]},
+          {section:[
+            {section_name: 'file', section_value: '/file/path2'},
+          ]}
+        ]
+      } ) ).to eq(
+        Log2mail::Config::Config.new([
+          Section.new(:defaults, nil, [Attribute.new(:sendtime,'123'), Attribute.new(:fromaddr, 'sender@address')]),
+          Section.new(:file, '/file/path1', [Attribute.new(:sendtime,'888'), Attribute.new(:fromaddr,'other@address')]),
+          Section.new(:file, '/file/path2' )
+        ])
+      )
+    end
+
+    it 'transforms combined SAME FILE config' do
+      expect( subject.apply({
+        config:[
+          {section:[
+            {section_name: 'file', section_value: '/the/file/path'},
+            {attribute_name: 'sendtime', attribute_value: '888'},
+            {attribute_name: 'fromaddr', attribute_value: 'other@address'},
+          ]},
+          {section:[
+            {section_name: 'file', section_value: '/the/file/path'},
+            {attribute_name: 'sendtime', attribute_value: '111'},
+          ]},
+        ]
+      } ) ).to eq( #{:files => {"/the/file/path"=>{:sendtime=>"111", :fromaddr=>'other@address'}}})
+      Config.new([Section.new(:file, '/the/file/path', [Attribute.new(:sendtime,'111'), Attribute.new(:fromaddr,'other@address')]) ]))
+    end
+
+  end
+
+end