locotimezone 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bd7dc723d1a198a388a711383691f9629a46ae0d
-  data.tar.gz: d501c8461f8d85e4fc4db8808c188b55edff8de5
+  metadata.gz: 337171fec57c496eedd9e382daeba4613d28d119
+  data.tar.gz: 5e2f61e63b6e3cc818a781fe5f29fce5b7542043
 SHA512:
-  metadata.gz: f897687fbc608439471c68bd9cde30d95b0acd477a1ea67f02a5a397ab35ad609c2becd826f81fe9a8ba7e528bd3b78fe4ede60736f8acadadea4c000986c6b8
-  data.tar.gz: a25779c2d79993c22e645cde4bbd11fb3c0f18f53ba00840e585e2cb8b12b4818eeb1613a3952cbe72b64579c871b50e1dff5ceef5dbce248486beacbc993159
+  metadata.gz: 37ac2f7f62e90c0b9d27426e0f6cbbfcec54904e33f4f3005aaef66105ed17ca9bf003e4987eca89643e783c34b55932107a05d14aba8945c45278a6b8249517
+  data.tar.gz: 5e07f8f7c83cc98d304a74ae92fe50d62e45444c68f0108b02af12db93f6305609a906dd57c5a9111a7e42016c95b35a093de8b630122470037254f2ff14020e

data/.gitignore

@@ -9,3 +9,4 @@
 /spec/reports/
 /tmp/
 /rails_locotimezone
+memory

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/README.md

@@ -1,12 +1,10 @@
-[![Code Triagers Badge](https://www.codetriage.com/apmiller108/locotimezone/badges/users.svg)](https://www.codetriage.com/apmiller108/locotimezone)
-
 [![Build Status](https://travis-ci.org/apmiller108/locotimezone.svg?branch=active-model-integration)](https://travis-ci.org/apmiller108/locotimezone)
 
 # Locotimezone
 Transform a street address into geoloction and timezone data. Essentially, this
 is an adapter for the [Google Maps Time Zone API](https://developers.google.com/maps/documentation/timezone/intro) and the [The Google Maps Geolocation API](https://developers.google.com/maps/documentation/geolocation/intro).
 
-All requests to the Google APIs are done over SSL.
+All requests to the Google APIs are done over HTTPS.
 
 ## Installation
 Add this line to your application's Gemfile:
@@ -146,7 +144,9 @@ Locotimezone.locotime location: { lat: 0, lng: 0 }
 
 `Locotimezone.configuration` takes a block where the following can be setup:
 * `google_api_key`. Create an API key and enable APIs in your [Google
-  Developer Console](https://console.developers.google.com).
+  Developer Console](https://console.developers.google.com). You will also need to enable 
+  Google Maps Geocoding API and Google Maps Time Zone API. While using an API key is optional,
+  it's recommended since you will get larger request quota.
 * `attributes`.  For overriding the default attribute names used for Rails models.
   The defaults are `:latitude`, `:longitude`, and `:timezone_id`. See example
   above under [Rails usage](#rails-usage)

data/Rakefile

@@ -1,15 +1,11 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
-Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList['test/**/*_test.rb']
-end
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec
 
 task :run do
   exec 'pry -r locotimezone -I ./lib -e '\
     '"Locotimezone.configure { |c| c.google_api_key = ENV[\'GOOGLE_API_KEY\'] }"'
 end
-
-task :default => :test

data/lib/locotimezone.rb

@@ -1,5 +1,5 @@
 require 'locotimezone/version'
-require 'locotimezone/loco_time'
+require 'locotimezone/locotime'
 require 'locotimezone/geolocate'
 require 'locotimezone/timezone'
 require 'locotimezone/configuration'
@@ -7,35 +7,29 @@ require 'locotimezone/active_record_helper'
 require 'locotimezone/railtie' if defined?(Rails)
 
 module Locotimezone
-
   class << self
     attr_accessor :configuration
   end
 
   def self.locotime(options = {})
-    set_default_configuration
-    LocoTime.new(
-      location: options.fetch(:location, nil),
-      address: options.fetch(:address, nil), 
-      skip: options.fetch(:skip, nil)
-    ).transform
+    set_default_configuration if configuration.nil?
+    Locotime.new(location: options.fetch(:location, nil),
+                 address: options.fetch(:address, nil),
+                 skip: options.fetch(:skip, nil)).call
   end
 
   def self.configure
-    self.configuration ||= Configuration.new 
+    self.configuration ||= Configuration.new
     yield configuration if block_given?
     self
   end
 
   def self.reset_configuration
     self.configuration = Configuration.new
+    set_default_configuration
   end
 
   def self.set_default_configuration
-    if Locotimezone.configuration.nil?
-      Locotimezone.configure do |config|
-        config.google_api_key = ''
-      end
-    end
+    Locotimezone.configure { |config| config.google_api_key = '' }
   end
 end

data/lib/locotimezone/geolocate.rb

@@ -6,7 +6,7 @@ module Locotimezone
       @address = address
     end
 
-    def get_geo
+    def call
       response = open(geolocation_query_url) { |f| JSON.parse f.read }
     rescue OpenURI::HTTPError
       {}
@@ -14,11 +14,11 @@ module Locotimezone
       format_results response
     end
 
-    private 
+    private
 
     def geolocation_query_url
-      'https://maps.googleapis.com/maps/api/geocode/json' + '?address=' + 
-        address.to_s + '&key=' + Locotimezone.configuration.google_api_key
+      "https://maps.googleapis.com/maps/api/geocode/json?address="\
+      "#{address}&key=#{Locotimezone.configuration.google_api_key}"
     end
 
     def format_results(response)
@@ -30,8 +30,7 @@ module Locotimezone
     end
 
     def symbolize_keys(response)
-      response.map { |k,v| [k.to_sym, v] }.to_h
+      response.map { |k, v| [k.to_sym, v] }.to_h
     end
-
   end
 end

data/lib/locotimezone/{loco_time.rb → locotime.rb}

@@ -2,7 +2,7 @@ require 'open-uri'
 require 'json'
 
 module Locotimezone
-  class LocoTime
+  class Locotime
     attr_reader :skip, :address
     attr_accessor :location
 
@@ -12,7 +12,7 @@ module Locotimezone
       @skip          = location ? :location : skip
     end
 
-    def transform
+    def call
       validate_options
       location_data = get_location unless skip == :location
       timezone_data = get_timezone unless skip == :timezone
@@ -25,16 +25,16 @@ module Locotimezone
       if address.nil? && (skip == :timezone || skip.nil?)
         raise ArgumentError, 'locotimezone is missing address or location.'
       end
-    end 
+    end
 
     def get_location
-      results = Geolocate.new(address).get_geo
+      results = Geolocate.new(address).call
       self.location = results[:location] || {}
       results
     end
 
     def get_timezone
-      Timezone.new(location).timezone
+      Timezone.new(location).call
     end
 
     def build_hash(location_data, timezone_data)

data/lib/locotimezone/timezone.rb

@@ -6,7 +6,7 @@ module Locotimezone
       @location = location
     end
 
-    def timezone
+    def call
       return {} if location_invalid?
       response = open(timezone_query_url) { |f| JSON.parse f.read }
     rescue OpenURI::HTTPError

data/lib/locotimezone/version.rb

@@ -1,3 +1,3 @@
 module Locotimezone
-  VERSION = "1.0.1"
+  VERSION = '1.0.2'.freeze
 end

data/locotimezone.gemspec

@@ -1,35 +1,37 @@
-# coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'locotimezone/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "locotimezone"
+  spec.name          = 'locotimezone'
   spec.version       = Locotimezone::VERSION
-  spec.authors       = ["Alex Miller"]
-  spec.email         = ["apmiller108@yahoo.com"]
+  spec.authors       = ['Alex Miller']
+  spec.email         = ['apmiller108@yahoo.com']
 
   spec.summary       = %q{Get timezone and gelocation data for a street address.}
   spec.description   = %q{Transform a street address into geoloction and timezone data.}
-  spec.homepage      = "https://github.com/apmiller108/locotimezone"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/apmiller108/locotimezone'
+  spec.license       = 'MIT'
   spec.required_ruby_version = '>= 2.2.1'
 
   # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
   # delete this section to allow pushing this gem to any host.
   if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = "https://rubygems.org"
+    spec.metadata['allowed_push_host'] = 'https://rubygems.org'
   else
-    raise "RubyGems 2.0 or newer is required to protect against public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.'
   end
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.bindir        = "bin"
+  spec.bindir        = 'bin'
   spec.executables   = ['locotimezone']
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.11"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest", "~> 5.0"
-  spec.add_development_dependency "pry", "~> 0.10.4"
+  spec.add_development_dependency 'activerecord', '~> 5.1', '>= 5.1.3'
+  spec.add_development_dependency 'bundler', '~> 1.11'
+  spec.add_development_dependency 'pry', '~> 0.10.4'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.6'
+  spec.add_development_dependency 'sqlite3', '~> 1.3', '>= 1.3.11'
+  spec.add_development_dependency 'webmock', '~> 3.0', '>= 3.0.1'
 end

metadata

@@ -1,15 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: locotimezone
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Alex Miller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-17 00:00:00.000000000 Z
+date: 2017-08-20 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.1.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.1.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -24,6 +44,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.11'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -39,33 +73,59 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '3.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '3.6'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.4
+        version: '1.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.10.4
+        version: '1.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.3.11
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.0.1
 description: Transform a street address into geoloction and timezone data.
 email:
 - apmiller108@yahoo.com
@@ -75,6 +135,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -87,7 +148,7 @@ files:
 - lib/locotimezone/active_record_helper.rb
 - lib/locotimezone/configuration.rb
 - lib/locotimezone/geolocate.rb
-- lib/locotimezone/loco_time.rb
+- lib/locotimezone/locotime.rb
 - lib/locotimezone/railtie.rb
 - lib/locotimezone/timezone.rb
 - lib/locotimezone/version.rb
@@ -113,7 +174,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Get timezone and gelocation data for a street address.