locotimezone 0.1.2 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 28cb02568726beb3990d3f2db77c6798eeda2a50
-  data.tar.gz: ad80389e97773612905352c1eb75a25f359698f1
+  metadata.gz: b87b061e997bc3ae7a367d1765c501b30422075a
+  data.tar.gz: a47d4a027ab9e915d07be5c4e5a23ebd1e50bf3b
 SHA512:
-  metadata.gz: c210abb22926a9ce7a3e05aaa632d78455a29529e60c89cf6a62de0b8b19902cfc116af9b94ea0b86f5d4ac7d3969114bc30d94b012d0dfa42fb8cdf6914bc75
-  data.tar.gz: 3aa7871ebb8951d63df6642c043e85bae40e82f58fc30c8d712141a7e3f5c54ebc6d2742709291a447f9cfb11f9f07b4dd4d444c9603ea470cde42f6a67bda4f
+  metadata.gz: 475227bb475696f5964b56ff35fc93ed7e7b27666563064ca209c3dca90734c185f44fa5f6b1a42e4da69ee5a9cf24372b4423ef1a8d27fdd3786c0534ebda87
+  data.tar.gz: 890d77907597f2a0275f2f8f92a6a5df1864fe8e3d0fe7ea3554b64974b0d026e6662638f9296c0e0c08c22bd3c843eb56e292ae4c639952e4da031e2771344e

data/README.md

@@ -1,3 +1,5 @@
+[![Code Triagers Badge](https://www.codetriage.com/apmiller108/locotimezone/badges/users.svg)](https://www.codetriage.com/apmiller108/locotimezone)
+
 # Locotimezone
 
 Transform a street address into geoloction and timezone data. Essentially, this
@@ -60,6 +62,15 @@ Locotimezone.locotime location: location, timezone_only: true
 # {:timezone=>
 #   {:timezone_id=>"America/New_York", :timezone_name=>"Eastern Daylight Time"}}
 ```
+
+If the address or location cannot be resolved, an empty hash will be returned.
+
+```ruby
+Locotimezone.locotime address: '1234 Fake Address'
+# => 
+# {:geo=>{}, :timezone=>{}}
+```
+
 ## Options and Setup
 
 `Locotimezone.locotime` can take the following option hash keys:

data/lib/locotimezone/location.rb

@@ -8,6 +8,9 @@ class Location
 
   def geolocate
     response = open(geolocation_query_url) { |f| JSON.parse f.read }
+  rescue OpenURI::HTTPError
+    {}
+  else
     format_results response
   end
 
@@ -19,6 +22,7 @@ class Location
   end
 
   def format_results(response)
+    return {} if response['results'].empty?
     Hash[
       formatted_address: response['results'][0]['formatted_address'],
       location: symbolize_keys(response['results'][0]['geometry']['location'])
@@ -28,4 +32,5 @@ class Location
   def symbolize_keys(response)
     response.map { |k,v| [k.to_sym, v] }.to_h
   end
+
 end

data/lib/locotimezone/loco_time.rb

@@ -1,5 +1,6 @@
 require 'open-uri'
 require 'json'
+require 'pry'
 
 class LocoTime
   attr_reader :location_only, :timezone_only, :address, :key
@@ -14,7 +15,7 @@ class LocoTime
   end
 
   def transform
-    return nil if location_only && timezone_only
+    validate_options
     location_data = get_location unless timezone_only 
     timezone_data = get_timezone unless location_only
     build_hash(location_data, timezone_data)
@@ -22,9 +23,19 @@ class LocoTime
 
   private
 
+  def validate_options
+    if address.nil? && !timezone_only
+      raise ArgumentError, 
+        'locotimezone: address is required unless timezone_only'
+    elsif location.nil? && timezone_only
+      raise ArgumentError, 
+        'locotimezone: location is required when timezone_only'
+    end
+  end 
+
   def get_location
     results = Location.new(address, key).geolocate
-    self.location = results[:location]
+    self.location = results[:location] || {}
     results
   end
 
@@ -34,7 +45,7 @@ class LocoTime
 
   def build_hash(location_data, timezone_data)
     data = Hash.new
-    data[:geo] = location_data unless location_data.nil?
+    data[:geo]      = location_data unless location_data.nil?
     data[:timezone] = timezone_data unless timezone_data.nil?
     data
   end

data/lib/locotimezone/timezone.rb

@@ -7,21 +7,29 @@ class Timezone
   end
 
   def timezone
+    return {} if location_invalid?
     response = open(timezone_query_url) { |f| JSON.parse f.read }
-    format_results response
+    rescue OpenURI::HTTPError
+      {}
+    else
+      format_results response
   end
 
   private
 
+  def location_invalid?
+    location.empty? || !location.respond_to?(:has_key?)
+  end
+
   def timezone_query_url
     'https://maps.googleapis.com/maps/api/timezone/json' + '?key=' + key + 
       '&location=' + latitude_longitude + '&timestamp=' + timestamp
   end
 
   def latitude_longitude
-    lat_lng = Array.new
-    location.each { |k, v| lat_lng.push v.to_s }
-    lat_lng.join(',')
+      lat_lng = Array.new
+      location.each { |k, v| lat_lng.push v.to_s }
+      lat_lng.join(',')
   end
 
   def timestamp

data/lib/locotimezone/version.rb

@@ -1,3 +1,3 @@
 module Locotimezone
-  VERSION = "0.1.2"
+  VERSION = "0.2.2"
 end

data/locotimezone.gemspec

@@ -13,6 +13,7 @@ Gem::Specification.new do |spec|
   spec.description   = %q{Transform a street address into geoloction and timezone data.}
   spec.homepage      = "https://github.com/apmiller108/locotimezone"
   spec.license       = "MIT"
+  spec.required_ruby_version = '>= 2.2.1'
 
   # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
   # delete this section to allow pushing this gem to any host.
@@ -30,4 +31,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.11"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency "pry", "~> 0.10.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: locotimezone
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.2
 platform: ruby
 authors:
 - Alex Miller
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-17 00:00:00.000000000 Z
+date: 2016-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.10.4
 description: Transform a street address into geoloction and timezone data.
 email:
 - apmiller108@yahoo.com
@@ -86,7 +100,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="