locomotivecms_steam 1.5.0.rc0 → 1.5.0.rc1

data/spec/unit/liquid/filters/misc_spec.rb

@@ -21,6 +21,24 @@ describe Locomotive::Steam::Liquid::Filters::Misc do
     expect(default(nil, 42)).to eq 42
   end
 
+  describe 'blank?' do
+
+    let(:array) { [0, "foobar", Object.new, nil, "", " ", "\n"] }
+    subject { array.map { |x| blank?(x) } }
+
+    it { is_expected.to eq [false, false, false, true, true, true, true] }
+
+  end
+
+  describe 'present?' do
+
+    let(:array) { [0, "foobar", Object.new, nil, "", " ", "\n"] }
+    subject { array.map { |x| present?(x) } }
+
+    it { is_expected.to eq [true, true, true, false, false, false, false] }
+
+  end
+
   describe 'index' do
 
     let(:array)     { [1, 2, 3, 4] }
@@ -123,11 +141,11 @@ describe Locomotive::Steam::Liquid::Filters::Misc do
 
     let(:array) { [1, 2, 3, 4] }
 
-    subject { shuffle(array) }
+    subject { 5.times.map { shuffle(array) } }
 
     it 'returns an array in a random order' do
-      expect(subject.size).to eq 4
-      expect(subject).not_to eq([1, 2, 3, 4])
+      expect(subject.all? { |x| x == array }).to eq(false)
+      expect(subject.all? { |x| x.sort == array }).to eq(true)
     end
 
   end

data/spec/unit/liquid/filters/number_spec.rb

@@ -39,7 +39,7 @@ describe Locomotive::Steam::Liquid::Filters::Number do
     context 'with options' do
 
       let(:input) { 42.01 }
-      let(:options) { ['unit: "€"', 'format: "%n %u"', 'precision: 1'] }
+      let(:options) { { 'unit' => "€", 'format' => "%n %u", 'precision' => 1 } }
 
       it { expect(subject).to eq '42.0 €' }
 
@@ -50,7 +50,7 @@ describe Locomotive::Steam::Liquid::Filters::Number do
       let(:environments)  { { 'my_unit' => 'Franc' } }
 
       let(:input) { 42.01 }
-      let(:options) { ['unit: my_unit', 'format: "%n %u"'] }
+      let(:options) { { 'unit' => 'my_unit', 'format' => "%n %u" } }
 
       it { expect(subject).to eq '42.01 Franc' }
 
@@ -79,7 +79,7 @@ describe Locomotive::Steam::Liquid::Filters::Number do
     context 'with options' do
 
       let(:input) { '42.01' }
-      let(:options) { ['precision: 0'] }
+      let(:options) { { 'precision' => 0 } }
 
       it { expect(subject).to eq '42%' }
 
@@ -108,7 +108,7 @@ describe Locomotive::Steam::Liquid::Filters::Number do
     context 'with options' do
 
       let(:input) { '1234567' }
-      let(:options) { ['precision: 2'] }
+      let(:options) { { 'precision' => 2 } }
 
       it { expect(subject).to eq '1.2 MB' }
 

data/spec/unit/liquid/filters/text_spec.rb

@@ -41,6 +41,10 @@ describe Locomotive::Steam::Liquid::Filters::Text do
     expect(encode('http:://www.example.com?key=hello world')).to eq 'http%3A%3A%2F%2Fwww.example.com%3Fkey%3Dhello+world'
   end
 
+  it 'parameterizes an input' do
+    expect(parameterize('séjourner & dormir')).to eq 'sejourner-dormir'
+  end
+
   it 'replaces \n by <br/>' do
     expect(multi_line("hello\nworld")).to eq 'hello<br/>world'
   end

data/spec/unit/liquid/tags/alt_page_links_spec.rb

@@ -30,7 +30,7 @@ describe Locomotive::Steam::Liquid::Tags::AltPageLinks do
 
       it { is_expected.to eq((<<-HTML
 <link rel="alternate" hreflang="x-default" href="https://www.example.com/" />
-<link rel="alternate" hreflang="en" href="https://www.example.com/en" />
+<link rel="alternate" hreflang="en" href="https://www.example.com/" />
 <link rel="alternate" hreflang="fr" href="https://www.example.com/fr" />
         HTML
         ).strip)
@@ -43,7 +43,7 @@ describe Locomotive::Steam::Liquid::Tags::AltPageLinks do
         it 'has to be the same links' do
           is_expected.to eq((<<-HTML
 <link rel="alternate" hreflang="x-default" href="https://www.example.com/" />
-<link rel="alternate" hreflang="en" href="https://www.example.com/en" />
+<link rel="alternate" hreflang="en" href="https://www.example.com/" />
 <link rel="alternate" hreflang="fr" href="https://www.example.com/fr" />
         HTML
           ).strip)
@@ -51,6 +51,23 @@ describe Locomotive::Steam::Liquid::Tags::AltPageLinks do
 
       end
 
+      context 'the developer wants to pass an ending path (dynamic routing)' do
+
+        let(:locale)  { 'fr' }
+        let(:page)    { liquid_instance_double('News', index?: false, localized_attributes: { title: true, fullpath: true }, title: { en: 'News', fr: 'Actualités' }, fullpath: { en: 'news', fr: 'actualites' }, templatized?: false) }
+        let(:assigns) { { 'page' => drop, 'base_url' => 'https://www.example.com', 'alt_page_links_ending_path' => '/2019/06' } }
+
+        it 'has to be the same links' do
+          is_expected.to eq((<<-HTML
+<link rel="alternate" hreflang="x-default" href="https://www.example.com/news/2019/06" />
+<link rel="alternate" hreflang="en" href="https://www.example.com/news/2019/06" />
+<link rel="alternate" hreflang="fr" href="https://www.example.com/fr/actualites/2019/06" />
+        HTML
+          ).strip)
+        end
+
+      end
+
     end
 
   end

data/spec/unit/liquid/tags/authorize_spec.rb

@@ -31,7 +31,7 @@ describe Locomotive::Steam::Liquid::Tags::Authorize do
     context 'unauthenticated account' do
 
       it 'redirects to the sign in page' do
-        expect { subject }.to raise_error(Locomotive::Steam::RedirectionException, 'Redirect to /me/sign_in')
+        expect { subject }.to raise_error(Locomotive::Steam::RedirectionException, 'Redirect to /me/sign_in (302)')
       end
 
     end

data/spec/unit/liquid/tags/editable/text_spec.rb

@@ -93,11 +93,13 @@ describe Locomotive::Steam::Liquid::Tags::Editable::Text do
 
     let(:live_editing)    { false }
     let(:element_editing) { true }
+    let(:wagon)           { false }
 
-    let(:child_page)  { instance_double('Page', fullpath: 'child-page') }
-    let(:element)     { instance_double('EditableText', _id: 42, id: 42, content: nil, inline_editing?: element_editing, inline_editing: element_editing, format: 'html') }
-    let(:services)    { Locomotive::Steam::Services.build_instance(nil) }
-    let(:context)     { ::Liquid::Context.new({}, {}, { page: child_page, services: services, live_editing: live_editing }) }
+    let(:child_page)    { instance_double('Page', fullpath: 'child-page') }
+    let(:element)       { instance_double('EditableText', _id: 42, id: 42, content: nil, inline_editing?: element_editing, inline_editing: element_editing, format: 'html') }
+    let(:services)      { Locomotive::Steam::Services.build_instance(nil) }
+    let(:repositories)  { instance_double('Repositories') }
+    let(:context)       { ::Liquid::Context.new({ 'wagon' => wagon }, {}, { page: child_page, services: services, repositories: repositories, live_editing: live_editing }) }
 
     before { allow(services.editable_element).to receive(:find).and_return(element) }
 
@@ -193,6 +195,32 @@ describe Locomotive::Steam::Liquid::Tags::Editable::Text do
 
     end
 
+    context 'site with sections' do
+
+      let(:repositories) { instance_double('Repositories', section: instance_double('SectionRepository', count: 1)) }
+
+      context 'in production' do
+
+        it "doesn't display the warning message" do
+          expect(Locomotive::Common::Logger).not_to receive(:error).with("[child-page] You can't use editable elements whereas you declared section(s)".colorize(:red))
+          subject
+        end
+
+      end
+
+      context 'in Wagon' do
+
+        let(:wagon) { true }
+
+        it "displays a warning message (because we don't allow editable elements and sections to be used together in the same site)" do
+          expect(Locomotive::Common::Logger).to receive(:error).with("[child-page] You can't use editable elements whereas you declared section(s)".colorize(:red))
+          subject
+        end
+
+      end
+
+    end
+
   end
 
 end

data/spec/unit/liquid/tags/extends_spec.rb

@@ -2,50 +2,137 @@ require 'spec_helper'
 
 describe Locomotive::Steam::Liquid::Tags::Extends do
 
-  let(:source)      { '{% extends parent %} ' }
-  let(:page)        { instance_double('Page', title: 'About us') }
-  let(:site)        { instance_double('Site', default_locale: :en) }
-  let!(:listener)   { Liquid::SimpleEventsListener.new }
-  let(:finder)      { Locomotive::Steam::ParentFinderService.new(instance_double('PageRepository', site: site, locale: :en)) }
-  let(:parser)      { Locomotive::Steam::LiquidParserService.new(nil, nil) }
-  let(:options)     { { parent_finder: finder, page: page, parser: parser } }
-
-  before do
-    expect(finder.repository).to receive(:parent_of).with(page).and_return(parent)
-  end
+  describe 'unit bevahiors' do
+
+    before { Liquid::Template.file_system = ::Liquid::LayoutFileSystem.new }
+
+    before do
+      allow_any_instance_of(described_class).to receive(:parse_parent_template) do |instance|
+        ::Liquid::Template.parse(
+          ::Liquid::Template.file_system.read_template_file(
+            instance.instance_variable_get(:@template_name), {}
+          ),
+          instance.parse_context
+        )
+      end
+    end
+
+    let(:assigns) { {} }
+    subject { render_template(source, ::Liquid::Context.new(assigns)) }
+
+    context 'the template uses a wrong syntax of extends' do
+      let(:source) { '{% extends %}' }
+      it { expect { subject }.to raise_exception("Liquid syntax error (line 1): Syntax Error in 'extends' - Valid syntax: extends <page_handle_or_parent_keyword>") }
+    end
+
+    context 'the template uses a endtag' do
+      let(:source) { '{% extends base %}{% endextends %}' }
+      it { is_expected.to eq '<body>base</body>' }
+    end
+
+    context 'the template has a block' do
+      let(:source) { Liquid::Template.file_system.read_template_file('page_with_title', nil) }
+      it { is_expected.to eq '<body><h1>Hello</h1><p>Lorem ipsum</p></body>' }
+    end
 
-  describe 'no parent page found' do
+    context 'the template extends another template' do
+      let(:source) { '{% extends base %}' }
+      it { is_expected.to eq '<body>base</body>' }
+    end
 
-    let(:parent)    { nil }
-    let(:template)  { parse_template(source, options) }
+    context 'the template extends an inherited template' do
+      let(:source) { '{% extends inherited %}' }
+      it { is_expected.to eq '<body>base</body>' }
+    end
 
-    it { expect { template }.to raise_exception Locomotive::Steam::Liquid::PageNotFound }
+    context 'the template can pass variables to the parent template' do
+      let(:assigns) { { 'name' => 'Macbook' } }
+      let(:source) { '{% extends product %}' }
+      it { is_expected.to eq '<body><h1>Our product: Macbook</h1></body>' }
+    end
+
+    context 'the template can pass variables to the inherited parent template' do
+      let(:assigns) { { 'name' => 'PC' } }
+      let(:source) { '{% extends product_with_warranty %}' }
+      it { is_expected.to eq '<body><h1>Our product: PC</h1><p>mandatory warranty</p></body>' }
+    end
+
+    context 'the template does not render statements outside blocks' do
+      let(:source) { '{% extends base %} Hello world' }
+      it { is_expected.to eq '<body>base</body>' }
+    end
+
+    context 'the template extends another template with a single block' do
+      let(:source) { '{% extends page_with_title %}' }
+      it { is_expected.to eq '<body><h1>Hello</h1><p>Lorem ipsum</p></body>' }
+    end
+
+    context 'the template overrides a block' do
+      let(:source) { '{% extends page_with_title %}{% block title %}Sweet{% endblock %}' }
+      it { is_expected.to eq '<body><h1>Sweet</h1><p>Lorem ipsum</p></body>' }
+    end
+
+    context 'the template has access to the content of the overriden_block' do
+      let(:source) { '{% extends page_with_title %}{% block title %}{{ block.super }} world{% endblock %}' }
+      it { is_expected.to eq '<body><h1>Hello world</h1><p>Lorem ipsum</p></body>' }
+    end
+
+    context 'the template accepts nested blocks' do
+      let(:assigns) { { 'name' => 'iPhone' } }
+      let(:source) { '{% extends product_with_static_price %}{% block info/price %}{{ block.super }}<p>(not on sale)</p>{% endblock %}' }
+      it { is_expected.to eq '<body><h1>Our product: iPhone</h1><h2>Some info</h2><p>$42.00</p><p>(not on sale)</p></body>' }
+    end
 
   end
 
-  describe 'parent page exists' do
+  describe 'in Steam' do
+
+    let(:source)      { '{% extends parent %} ' }
+    let(:page)        { instance_double('Page', title: 'About us') }
+    let(:site)        { instance_double('Site', default_locale: :en) }
+    let!(:listener)   { Liquid::SimpleEventsListener.new }
+    let(:finder)      { Locomotive::Steam::ParentFinderService.new(instance_double('PageRepository', site: site, locale: :en)) }
+    let(:parser)      { Locomotive::Steam::LiquidParserService.new(nil, nil) }
+    let(:options)     { { parent_finder: finder, page: page, parser: parser } }
+
+    before do
+      expect(finder.repository).to receive(:parent_of).with(page).and_return(parent)
+    end
+
+    describe 'no parent page found' do
+
+      let(:parent)    { nil }
+      let(:template)  { parse_template(source, options) }
+
+      it { expect { template }.to raise_exception Locomotive::Steam::Liquid::PageNotFound }
+
+    end
+
+    describe 'parent page exists' do
+
+      let!(:template) { parse_template(source, options) }
 
-    let!(:template) { parse_template(source, options) }
+      let(:parent) { instance_double('Index', handle: nil, slug: nil, localized_attributes: { source: true, template: true }, source: { en: 'Hello world!' }, template: { en: nil }) }
 
-    let(:parent) { instance_double('Index', handle: nil, slug: nil, localized_attributes: { source: true, template: true }, source: { en: 'Hello world!' }, template: { en: nil }) }
+      it { expect(listener.event_names.first).to eq 'steam.parse.extends' }
+      it { expect(template.render).to eq 'Hello world!' }
+      it { expect(options[:page]).to eq page }
 
-    it { expect(listener.event_names.first).to eq 'steam.parse.extends' }
-    it { expect(template.render).to eq 'Hello world!' }
-    it { expect(options[:page]).to eq page }
+      describe 'set the layout name' do
 
-    describe 'set the layout name' do
+        let(:source) { '{% extends parent %}{% block message %}My layout: {{ layout_name }}{% endblock %}' }
 
-      let(:source) { '{% extends parent %}{% block message %}My layout: {{ layout_name }}{% endblock %}' }
+        let(:parent) { instance_double('Index', handle: nil, slug: 'index', localized_attributes: { source: true, template: true }, source: { en: 'Hello world! {% block message %}{% endblock %}' }, template: { en: nil }) }
 
-      let(:parent) { instance_double('Index', handle: nil, slug: 'index', localized_attributes: { source: true, template: true }, source: { en: 'Hello world! {% block message %}{% endblock %}' }, template: { en: nil }) }
+        it { expect(template.render).to eq 'Hello world! My layout: index' }
 
-      it { expect(template.render).to eq 'Hello world! My layout: index' }
+        context 'the handle of the parent page exists' do
 
-      context 'the handle of the parent page exists' do
+          let(:parent) { instance_double('Index', handle: 'home', slug: 'index', localized_attributes: { source: true, template: true }, source: { en: 'Hello world! {% block message %}{% endblock %}' }, template: { en: nil }) }
 
-        let(:parent) { instance_double('Index', handle: 'home', slug: 'index', localized_attributes: { source: true, template: true }, source: { en: 'Hello world! {% block message %}{% endblock %}' }, template: { en: nil }) }
+          it { expect(template.render).to eq 'Hello world! My layout: home' }
 
-        it { expect(template.render).to eq 'Hello world! My layout: home' }
+        end
 
       end
 

data/spec/unit/liquid/tags/global_section_spec.rb

@@ -8,9 +8,10 @@ describe Locomotive::Steam::Liquid::Tags::GlobalSection do
   let(:source)        { 'Locomotive {% global_section header %}' }
   let(:live_editing)  { true }
   let(:content)       { {} }
+  let(:file_system)   { Locomotive::Steam::Liquid::FileSystem.new(section_finder: finder) }
   let(:site)          { liquid_instance_double('Site', sections_content: content) }
   let(:assigns)       { { 'site' => site } }
-  let(:context)       { ::Liquid::Context.new(assigns, {}, { services: services, live_editing: live_editing }) }
+  let(:context)       { ::Liquid::Context.new(assigns, {}, { services: services, live_editing: live_editing, file_system: file_system }) }
 
   before do
     allow(finder).to receive(:find).and_return(section)
@@ -121,8 +122,8 @@ describe Locomotive::Steam::Liquid::Tags::GlobalSection do
         definition:     { settings: [], blocks: [] }
       )}
 
-      it 'raises ParsingRenderingError' do
-        expect { subject }.to raise_exception(Locomotive::Steam::ParsingRenderingError)
+      it 'raises an TemplateError' do
+        expect { subject }.to raise_exception(Locomotive::Steam::TemplateError)
       end
     end
 

data/spec/unit/liquid/tags/google_analytics_spec.rb

@@ -2,13 +2,32 @@ require 'spec_helper'
 
 describe Locomotive::Steam::Liquid::Tags::GoogleAnalytics do
 
-  let(:source) { "{% google_analytics 42 %}" }
+  let(:context) { ::Liquid::Context.new({ 'ga_id' => '42' })}
+  let(:source)  { "{% google_analytics 42 %}" }
 
-  subject { render_template(source) }
+  subject { render_template(source, context) }
 
   it { is_expected.to include %{<script async src="https://www.googletagmanager.com/gtag/js?id=42"></script>} }
   it { is_expected.to include "gtag('config', '42');" }
 
+  describe 'passing a string' do
+
+    let(:source) { "{% google_analytics 'ga-42' %}" }
+
+    it { is_expected.to include %{<script async src="https://www.googletagmanager.com/gtag/js?id=ga-42"></script>} }
+    it { is_expected.to include "gtag('config', 'ga-42');" }
+
+  end
+
+  describe 'passing a variable' do
+
+    let(:source) { "{% google_analytics ga_id %}" }
+
+    it { is_expected.to include %{<script async src="https://www.googletagmanager.com/gtag/js?id=42"></script>} }
+    it { is_expected.to include "gtag('config', '42');" }
+
+  end
+
   describe 'raises an error if the syntax is incorrect' do
     let(:source) { '{% google_analytics %}' }
     it { expect { subject }.to raise_exception(::Liquid::SyntaxError) }

data/spec/unit/liquid/tags/inherited_block_spec.rb

@@ -11,27 +11,39 @@ describe Locomotive::Steam::Liquid::Tags::InheritedBlock do
   let(:finder)        { instance_double('Finder', find: parent) }
   let(:options)       { { page: page, parent_finder: finder, parser: Locomotive::Steam::LiquidParserService.new(nil, nil) } }
 
-  let!(:template)     { parse_template(source, options) }
+  subject { parse_template(source, options) }
+
+  describe 'wrong syntax' do
+
+    let(:source) { '{% extends parent %}{% block %}Hello world{% endblock %}' }
+    it { expect { subject }.to raise_exception(Liquid::SyntaxError) }
+  end
 
   describe 'without a super block' do
 
+    before { subject }
+
     it { expect(listener.events.size).to eq 3 }
     it { expect(listener.events.first.last[:found_super]).to eq false }
-    it { expect(template.render).to eq 'My product: Skis' }
+    it { expect(subject.render).to eq 'My product: Skis' }
 
   end
 
   describe 'with a super block' do
 
+    before { subject }
+
     let(:source) { '{% extends parent %}{% block product %}Skis (previous: {{ block.super }}){% endblock %}' }
 
     it { expect(listener.events.first.last[:found_super]).to eq true }
-    it { expect(template.render).to eq 'My product: Skis (previous: Random)' }
+    it { expect(subject.render).to eq 'My product: Skis (previous: Random)' }
 
   end
 
   describe 'passing options' do
 
+    before { subject }
+
     let(:source) { '{% extends parent %}{% block product, short_name: true, priority: 10 %}Skis{% endblock %}' }
 
     it { expect(listener.events.size).to eq 3 }
@@ -45,9 +57,11 @@ describe Locomotive::Steam::Liquid::Tags::InheritedBlock do
 
   describe 'live editing on' do
 
+    before { subject }
+
     let(:context) { ::Liquid::Context.new({}, {}, { live_editing: true }) }
 
-    it { expect(template.render(context)).to eq 'My product: <span class="locomotive-block-anchor" data-element-id="product" style="visibility: hidden"></span>Skis' }
+    it { expect(subject.render(context)).to eq 'My product: <span class="locomotive-block-anchor" data-element-id="product" style="visibility: hidden"></span>Skis' }
 
   end
 

data/spec/unit/liquid/tags/inline_editor_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Locomotive::Steam::Liquid::Tags::InlineEditor do
+
+  let(:source)  { "{% inline_editor %}" }
+
+  subject { render_template(source) }
+
+  it { is_expected.to eq '' }
+
+end

data/spec/unit/liquid/tags/link_to_spec.rb

@@ -20,7 +20,7 @@ describe Locomotive::Steam::Liquid::Tags::PathTo do
     context 'unknown tag' do
 
       let(:source) { '{% link_to index %}{% endbar %}{% endlink_to %}' }
-      it { expect { subject }.to raise_error("Liquid syntax error (line 1): Unknown tag 'endbar'") }
+      it { expect { subject }.to raise_error("Liquid syntax error (line 1): 'endbar' is not a valid delimiter for link_to tags. use endlink_to") }
 
     end
 

data/spec/unit/liquid/tags/model_form_spec.rb

@@ -19,6 +19,13 @@ describe Locomotive::Steam::Liquid::Tags::ModelForm do
 
   it { is_expected.to eq %(<form method="POST" enctype="multipart/form-data"><input type="hidden" name="content_type_slug" value="newsletter_addresses" /><input type="hidden" name="token" value="42" />Newsletter Form</form>) }
 
+  describe 'invalid syntax' do
+
+    let(:source) { "{% model_form %}Hello world{% endmodel_form %}" }
+    it { expect { subject }.to raise_error("Liquid syntax error (line 1): Syntax Error in 'model_form' - Valid syntax: model_form <content_type_slug>(, <attributes>)") }
+
+  end
+
   describe 'with a different dom id and css class' do
 
     let(:source) { "{% model_form 'newsletter_addresses', id: 'my-form', class: 'col-md-12' %}Newsletter Form{% endmodel_form %}" }

data/spec/unit/liquid/tags/page_not_found_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Locomotive::Steam::Liquid::Tags::PageNotFound do
+
+  let(:template)  { '{% render_page_not_found %}' }
+  let(:context)   { ::Liquid::Context.new({}, {}, {}) }
+
+  subject { render_template(template, context) }
+
+  it 'raises an exception' do
+    expect { subject }.to raise_error(Locomotive::Steam::PageNotFoundException)
+  end
+
+end