locomotivecms_steam 1.4.1 → 1.5.0.beta1

data/spec/unit/liquid/filters/json_spec.rb

@@ -54,6 +54,13 @@ describe Locomotive::Steam::Liquid::Filters::Json do
 
   end
 
+  describe '#Render Hash' do
+
+    let(:input) { [{'foo': 'bar'}] }
+    it { expect(subject).to eq %({"foo":"bar"}) }
+
+  end
+
   describe '#open_json' do
 
     let(:input) { '' }

data/spec/unit/liquid/tags/action_spec.rb

@@ -5,8 +5,9 @@ describe Locomotive::Steam::Liquid::Tags::Action do
   let(:site)      { instance_double('Site', default_locale: 'en') }
   let(:source)    { '{% action "random Javascript action" %}var foo = 42; setProp("foo", foo);{% endaction %}' }
   let(:assigns)   { {} }
+  let(:registers) { { services: services } }
   let(:services)  { Locomotive::Steam::Services.build_instance }
-  let(:context)   { ::Liquid::Context.new(assigns, {}, { services: services }) }
+  let(:context)   { ::Liquid::Context.new(assigns, {}, registers) }
 
   before { allow(services).to receive(:current_site).and_return(site) }
 
@@ -27,9 +28,18 @@ describe Locomotive::Steam::Liquid::Tags::Action do
 
     it { subject; expect(context['foo']).to eq 42.0 }
 
+    describe 'accessing params through props' do
+
+      let(:assigns) { { 'params' => Locomotive::Steam::Liquid::Drops::Params.new({ foo: 'bar' }) } }
+      let(:source)  { '{% action "getProps" %}var params = getProp("params");setProp("result", params.foo);{% endaction %}' }
+
+      it { subject; expect(context['result']).to eq('bar') }
+
+    end
+
     describe 'uploaded file' do
 
-      let(:assigns) { { 'params' => { 'my_file' => { 'tempfile' => Tempfile.new('my_file') } } } }
+      let(:registers) { { services: services, params: { 'my_file' => { 'tempfile' => Tempfile.new('my_file') } } } }
       let(:source)  { '{% action "uploaded file" %}setProp("path", params.my_file.tempfile);{% endaction %}' }
 
       it { subject; expect(context['path']).to match /\/my_file/ }

data/spec/unit/liquid/tags/alt_page_links_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe Locomotive::Steam::Liquid::Tags::AltPageLinks do
+
+  let(:locale)          { 'en' }
+  let(:assigns)         { { 'page' => drop, 'base_url' => 'https://www.example.com' } }
+  let(:prefix_default)  { false }
+  let(:services)        { Locomotive::Steam::Services.build_instance }
+  let(:locales)         { %w(en) }
+  let(:site)            { instance_double('Site', locales: locales, default_locale: 'en', prefix_default_locale: prefix_default) }
+  let(:drop)            { Locomotive::Steam::Liquid::Drops::Page.new(page) }
+  let(:page)            { liquid_instance_double('Index', index?: true, localized_attributes: { title: true, fullpath: true }, title: { en: 'Home', fr: 'Accueil' }, fullpath: { en: 'index', fr: 'index' }, templatized?: false) }
+  let(:context)         { ::Liquid::Context.new(assigns, {}, { services: services, site: site, locale: locale }) }
+
+  subject { render_template(source, context) }
+
+  before { allow(services).to receive(:current_site).and_return(site) }
+
+  describe 'default rendering' do
+
+    let(:source) { '{% alt_page_links %}' }
+
+    it 'renders an empty string if one single locale' do
+      is_expected.to eq('')
+    end
+
+    context 'multilingual site' do
+
+      let(:locales) { %w(en fr) }
+
+      it { is_expected.to eq((<<-HTML
+<link rel="alternate" hreflang="x-default" href="https://www.example.com/" />
+<link rel="alternate" hreflang="en" href="https://www.example.com/en" />
+<link rel="alternate" hreflang="fr" href="https://www.example.com/fr" />
+        HTML
+        ).strip)
+      }
+
+      context 'the current locale is different from the default one' do
+
+        let(:locale) { 'fr' }
+
+        it 'has to be the same links' do
+          is_expected.to eq((<<-HTML
+<link rel="alternate" hreflang="x-default" href="https://www.example.com/" />
+<link rel="alternate" hreflang="en" href="https://www.example.com/en" />
+<link rel="alternate" hreflang="fr" href="https://www.example.com/fr" />
+        HTML
+          ).strip)
+        end
+
+      end
+
+    end
+
+  end
+
+end

data/spec/unit/liquid/tags/global_section_spec.rb

@@ -0,0 +1,130 @@
+require 'spec_helper'
+
+describe Locomotive::Steam::Liquid::Tags::GlobalSection do
+
+  let(:services)      { Locomotive::Steam::Services.build_instance(nil) }
+  let(:finder)        { services.section_finder }
+  let(:source)        { 'Locomotive {% global_section header %}' }
+  let(:live_editing)  { true }
+  let(:content)       { {} }
+  let(:site)          { liquid_instance_double('Site', sections_content: content) }
+  let(:assigns)       { { 'site' => site } }
+  let(:context)       { ::Liquid::Context.new(assigns, {}, { services: services, live_editing: live_editing }) }
+
+  before do
+    allow(finder).to receive(:find).and_return(section)
+  end
+
+  describe 'rendering' do
+
+    let(:definition) { {
+      type:  'header',
+      class: 'my-awesome-header',
+      settings: [
+        { id: 'brand', type: 'text', label: 'Brand' },
+        { id: 'image', type: 'image_picker' }
+      ],
+      blocks: [
+        { type: 'menu_item', settings: [
+          { id: 'title', type: 'text' },
+          { id: 'image', type: 'image_picker' }
+        ]}
+      ],
+      default: {
+        settings: { brand: 'NoCoffee', image: 'foo.png' },
+        blocks: [{ id: 42, type: 'menu_item', settings: { title: 'Home', image: 'foo.png' } }] }
+    }.deep_stringify_keys }
+
+    let(:section) { instance_double(
+      'Header',
+      slug:           'header',
+      type:           'header',
+      liquid_source:  liquid_source,
+      definition:     definition,
+    )}
+
+    subject { render_template(source, context) }
+
+    context 'no block' do
+
+      let(:liquid_source) { %(built by <a>\n\t<strong>{{ section.settings.brand }}</strong></a>) }
+
+      it { is_expected.to eq %(Locomotive <div id="locomotive-section-site-header" class="locomotive-section my-awesome-header" data-locomotive-section-type="header">built by <a>\n\t<strong data-locomotive-editor-setting="section-site-header.brand">NoCoffee</strong></a></div>) }
+
+      context 'capturing the setting in a liquid variable' do
+
+        let(:liquid_source) { %({% capture brand %}<strong class="bold">{{ section.settings.brand }}</strong>{% endcapture %}built by <a>\n\t{{ brand }}</a>) }
+
+        it { is_expected.to eq %(Locomotive <div id="locomotive-section-site-header" class="locomotive-section my-awesome-header" data-locomotive-section-type="header">built by <a>\n\t<strong class="bold" data-locomotive-editor-setting="section-site-header.brand">NoCoffee</strong></a></div>) }
+
+      end
+
+
+      context 'with a non string type input' do
+
+        let(:liquid_source) { 'built by <strong>{{ section.settings.image }}</strong>' }
+
+        it { is_expected.to eq 'Locomotive <div id="locomotive-section-site-header" class="locomotive-section my-awesome-header" data-locomotive-section-type="header">built by <strong>foo.png</strong></div>' }
+
+      end
+
+      context 'without the live editing feature enabled' do
+
+        let(:live_editing) { false }
+
+        it { is_expected.to eq %(Locomotive <div id="locomotive-section-site-header" class="locomotive-section my-awesome-header" data-locomotive-section-type="header">built by <a>\n\t<strong>NoCoffee</strong></a></div>) }
+
+      end
+
+    end
+
+    context 'with blocks' do
+
+      let(:liquid_source) { '{% for foo in section.blocks %}<a href="/">{{ foo.settings.title }}</a>{% endfor %}' }
+
+      it { is_expected.to eq 'Locomotive <div id="locomotive-section-site-header" class="locomotive-section my-awesome-header" data-locomotive-section-type="header"><a href="/" data-locomotive-editor-setting="section-site-header-block.42.title">Home</a></div>' }
+
+      context 'with a non text type input' do
+
+        let(:liquid_source) { '{% for foo in section.blocks %}<a>{{ foo.settings.image }}</a>{% endfor %}' }
+
+        it { is_expected.to eq 'Locomotive <div id="locomotive-section-site-header" class="locomotive-section my-awesome-header" data-locomotive-section-type="header"><a>foo.png</a></div>' }
+
+      end
+
+    end
+
+    context 'with site value' do
+      let(:content) {
+        {
+          header: {
+            settings: { brand: 'Locomotive' },
+            blocks:   []
+          }
+        }.deep_stringify_keys
+      }
+
+      let(:liquid_source) { 'built by <strong>{{ section.settings.brand }}</strong>' }
+
+      it { is_expected.to eq 'Locomotive <div id="locomotive-section-site-header" class="locomotive-section my-awesome-header" data-locomotive-section-type="header">built by <strong data-locomotive-editor-setting="section-site-header.brand">Locomotive</strong></div>' }
+
+    end
+
+    context 'rendering error (action) found in the section' do
+
+      let(:live_editing)  { false }
+      let(:liquid_source) { '{% action "Hello world" %}a.b(+}{% endaction %}' }
+      let(:section)       { instance_double('section',
+        name:           'Hero',
+        liquid_source:  liquid_source,
+        definition:     { settings: [], blocks: [] }
+      )}
+
+      it 'raises ParsingRenderingError' do
+        expect { subject }.to raise_exception(Locomotive::Steam::ParsingRenderingError)
+      end
+    end
+
+  end
+
+end

data/spec/unit/liquid/tags/link_to_spec.rb

@@ -71,7 +71,7 @@ describe Locomotive::Steam::Liquid::Tags::PathTo do
       context 'prefix_default_locale is true' do
 
         let(:prefix_default) { true }
-        it { is_expected.to eq 'My link: <a href="/en/">Home</a>!' }
+        it { is_expected.to eq 'My link: <a href="/en">Home</a>!' }
 
       end
 

data/spec/unit/liquid/tags/locale_switcher_spec.rb

@@ -30,7 +30,7 @@ describe Locomotive::Steam::Liquid::Tags::LocaleSwitcher do
     context 'prefix_default_locale is true' do
 
       let(:prefix_default) { true }
-      it { is_expected.to eq '<div id="locale-switcher"><a href="/en/" class="en current">en</a> | <a href="/fr" class="fr">fr</a></div>' }
+      it { is_expected.to eq '<div id="locale-switcher"><a href="/en" class="en current">en</a> | <a href="/fr" class="fr">fr</a></div>' }
 
     end
 

data/spec/unit/liquid/tags/model_form_spec.rb

@@ -47,6 +47,14 @@ describe Locomotive::Steam::Liquid::Tags::ModelForm do
 
     end
 
+    context 'rendered at /_app/foo/preview/contact' do
+
+      let(:path)  { '/_app/foo/preview/contact' }
+      let(:env)   { { 'steam.mounted_on' => '/_app/foo/preview/' } }
+      it { is_expected.to eq %(<form method="POST" enctype="multipart/form-data" action="/_app/foo/preview/contact.json"><input type="hidden" name="content_type_slug" value="newsletter_addresses" /><input type="hidden" name="token" value="42" />Newsletter Form</form>) }
+
+    end
+
   end
 
   describe 'specifying an action' do

data/spec/unit/liquid/tags/path_to_spec.rb

@@ -4,9 +4,11 @@ describe Locomotive::Steam::Liquid::Tags::PathTo do
 
   let(:prefix_default)  { false }
   let(:assigns)         { {} }
+  let(:current_locale)  { 'en' }
+  let(:locales)         { ['en'] }
   let(:services)        { Locomotive::Steam::Services.build_instance }
-  let(:site)            { instance_double('Site', locales: ['en'], default_locale: 'en', prefix_default_locale: prefix_default) }
-  let(:context)         { ::Liquid::Context.new(assigns, {}, { services: services, site: site, locale: 'en' }) }
+  let(:site)            { instance_double('Site', locales: locales, default_locale: 'en', prefix_default_locale: prefix_default) }
+  let(:context)         { ::Liquid::Context.new(assigns, {}, { services: services, site: site, locale: current_locale }) }
 
   subject { render_template(source, context) }
 
@@ -52,10 +54,31 @@ describe Locomotive::Steam::Liquid::Tags::PathTo do
 
     end
 
+    context 'the current locale in session is different from the requested locale' do
+
+      let(:current_locale)  { 'fr' }
+      let(:locales)         { ['en', 'fr'] }
+      let(:source)          { "{% path_to index, locale: 'en' %}" }
+
+      before do
+        services.url_builder.current_locale = current_locale
+      end
+
+      it { is_expected.to eq '/en' }
+
+      context 'prefix_default_locale is true' do
+
+        let(:prefix_default) { true }
+        it { is_expected.to eq '/en' }
+
+      end
+
+    end
+
     context 'prefix_default_locale is true' do
 
       let(:prefix_default) { true }
-      it { is_expected.to eq '/en/' }
+      it { is_expected.to eq '/en' }
 
     end
 

data/spec/unit/liquid/tags/section_spec.rb

@@ -0,0 +1,231 @@
+require 'spec_helper'
+
+describe Locomotive::Steam::Liquid::Tags::Section do
+
+  let(:services)      { Locomotive::Steam::Services.build_instance(nil) }
+  let(:finder)        { services.section_finder }
+  let(:source)        { 'Locomotive {% section header %}' }
+  let(:live_editing)  { true }
+  let(:content)       { {} }
+  let(:alt_content)   { nil }
+  let(:page)          { liquid_instance_double('Page', sections_content: content)}
+  let(:assigns)       { { 'page' => page } }
+  let(:context)       { ::Liquid::Context.new(assigns, {}, { services: services, live_editing: live_editing, _section_content: alt_content }) }
+
+  describe 'parsing' do
+
+    subject { parse_template(source) }
+
+    describe 'raises an error if the syntax is incorrect' do
+      let(:source) { 'Locomotive {% section %}' }
+      it { expect { subject }.to raise_exception(Liquid::SyntaxError) }
+    end
+
+  end
+
+  describe 'rendering' do
+
+    before do
+      allow(finder).to receive(:find).and_return(section)
+    end
+
+    subject { render_template(source, context) }
+
+    let(:definition) { {
+      type:  'header',
+      class: 'my-awesome-header',
+      settings: [
+        { id: 'brand', type: 'text', label: 'Brand' },
+        { id: 'image', type: 'image_picker' }
+      ],
+      blocks: [
+        { type: 'menu_item', settings: [
+          { id: 'title', type: 'text' },
+          { id: 'image', type: 'image_picker' }
+        ]}
+      ],
+      default: {
+        settings: { brand: 'NoCoffee', image: 'foo.png' },
+        blocks: [{ id: 42, type: 'menu_item', settings: { title: 'Home', image: 'foo.png' } }] }
+    }.deep_stringify_keys }
+
+    let(:section) { instance_double(
+      'Header',
+      slug:           'header',
+      type:           'header',
+      liquid_source:  liquid_source,
+      definition:     definition,
+    )}
+
+    context 'no block' do
+
+      let(:liquid_source) { %(built by <a>\n\t<strong>{{ section.settings.brand }}</strong></a>) }
+
+      it { is_expected.to eq 'Locomotive'\
+        ' <div id="locomotive-section-page-header"'\
+        ' class="locomotive-section my-awesome-header"'\
+        ' data-locomotive-section-type="header">'\
+          'built by <a>' + %(\n\t) + '<strong data-locomotive-editor-setting="section-page-header.brand">NoCoffee</strong></a>'\
+        '</div>' }
+
+      context 'capturing the setting in a liquid variable' do
+
+        let(:liquid_source) { %({% capture brand %}<strong class="bold">{{ section.settings.brand }}</strong>{% endcapture %}built by <a>\n\t{{ brand }}</a>) }
+
+        it { is_expected.to eq 'Locomotive'\
+          ' <div id="locomotive-section-page-header"'\
+          ' class="locomotive-section my-awesome-header"'\
+          ' data-locomotive-section-type="header">'\
+            'built by <a>' + %(\n\t) + '<strong class="bold" data-locomotive-editor-setting="section-page-header.brand">NoCoffee</strong></a>'\
+          '</div>' }
+
+      end
+
+      context 'with a non string type input' do
+
+        let(:liquid_source) { 'built by <strong>{{ section.settings.image }}</strong>' }
+
+        it { is_expected.to eq 'Locomotive'\
+          ' <div id="locomotive-section-page-header"'\
+          ' class="locomotive-section my-awesome-header"'\
+          ' data-locomotive-section-type="header">'\
+            'built by <strong>foo.png</strong>'\
+          '</div>' }
+
+      end
+
+      context 'without the live editing feature enabled' do
+
+        let(:live_editing) { false }
+
+        it { is_expected.to eq 'Locomotive '\
+          '<div id="locomotive-section-page-header"'\
+          ' class="locomotive-section my-awesome-header"'\
+          ' data-locomotive-section-type="header">'\
+            'built by <a>' + %(\n\t) + '<strong>NoCoffee</strong></a>'\
+          '</div>' }
+
+      end
+
+    end
+
+    context 'with blocks' do
+
+      let(:liquid_source) { '{% for foo in section.blocks %}<a href="/">{{ foo.settings.title }}</a>{% endfor %}' }
+
+      it { is_expected.to eq 'Locomotive'\
+        ' <div id="locomotive-section-page-header"'\
+        ' class="locomotive-section my-awesome-header"'\
+        ' data-locomotive-section-type="header">'\
+          '<a href="/" data-locomotive-editor-setting="section-page-header-block.42.title">Home</a>'\
+        '</div>' }
+
+      context 'with a non text type input' do
+
+        let(:liquid_source) { '{% for foo in section.blocks %}<a>{{ foo.settings.image }}</a>{% endfor %}' }
+
+        it { is_expected.to eq 'Locomotive'\
+          ' <div id="locomotive-section-page-header"'\
+          ' class="locomotive-section my-awesome-header"'\
+          ' data-locomotive-section-type="header">'\
+            '<a>foo.png</a>'\
+          '</div>' }
+
+      end
+
+    end
+
+    context 'with page content' do
+      let(:liquid_source) { 'built by <strong>{{ section.settings.brand }}</strong>' }
+
+      context 'with on section' do
+
+        context 'with simple type' do
+          let(:content) {
+            {
+              header: {
+                settings: { brand: 'Locomotive' },
+                blocks:   []
+              }
+            }.deep_stringify_keys
+          }
+
+          it { is_expected.to eq 'Locomotive '\
+            '<div id="locomotive-section-page-header"'\
+            ' class="locomotive-section my-awesome-header"'\
+            ' data-locomotive-section-type="header">'\
+              'built by '\
+              '<strong data-locomotive-editor-setting="section-page-header.brand">'\
+                'Locomotive'\
+              '</strong>'\
+            '</div>' }
+        end
+
+        context 'with an id passed as an option' do
+
+          let(:source) { 'Locomotive {% section header, id: "my_header" %}'}
+          let(:content) {
+            {
+              'my_header': {
+                settings: { brand: 'Locomotive' },
+                blocks:   []
+              }
+            }.deep_stringify_keys
+          }
+
+          it { is_expected.to eq 'Locomotive '\
+            '<div id="locomotive-section-page-my_header" '\
+            'class="locomotive-section my-awesome-header" '\
+            'data-locomotive-section-type="header">'\
+              'built by '\
+              '<strong data-locomotive-editor-setting="section-page-my_header.brand">'\
+                'Locomotive'\
+              '</strong>'\
+            '</div>' }
+        end
+
+        context 'with an id within the content' do
+          let(:source)      { 'Locomotive {% section header %}'}
+          let(:alt_content) {
+            {
+              id: 'site-header',
+              settings: { brand: 'Locomotive' },
+              blocks:   []
+            }.deep_stringify_keys
+          }
+
+          it { is_expected.to eq 'Locomotive '\
+            '<div id="locomotive-section-site-header" '\
+            'class="locomotive-section my-awesome-header" '\
+            'data-locomotive-section-type="header">'\
+              'built by '\
+              '<strong data-locomotive-editor-setting="section-site-header.brand">'\
+                'Locomotive'\
+              '</strong>'\
+            '</div>' }
+
+        end
+
+      end
+    end
+
+
+    context 'rendering error (action) found in the section' do
+
+      let(:live_editing)  { false }
+      let(:liquid_source) { '{% action "Hello world" %}a.b(+}{% endaction %}' }
+      let(:section)       { instance_double('section',
+        name:           'Hero',
+        liquid_source:  liquid_source,
+        definition:     { settings: [], blocks: [] }
+      )}
+
+      it 'raises ParsingRenderingError' do
+        expect { subject }.to raise_exception(Locomotive::Steam::ParsingRenderingError)
+      end
+    end
+
+  end
+
+end
+