locomotivecms_steam 1.2.0.beta1 → 1.2.0.rc1

data/spec/unit/decorators/page_decorator_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Locomotive::Steam::Decorators::PageDecorator do
+
+  let(:redirect)        { nil }
+  let(:redirect_url)    { nil }
+  let(:page)            { instance_double('Page', localized_attributes: [], redirect: redirect, redirect_url: redirect_url) }
+  let(:locale)          { 'fr' }
+  let(:default_locale)  { 'en' }
+  let(:decorated)       { described_class.new(page, locale, default_locale) }
+
+  describe '#redirect?' do
+
+    subject { decorated.redirect? }
+
+    it { is_expected.to eq false }
+
+    context 'redirect_url has been set' do
+
+      let(:redirect_url) { 'http://www.google.fr' }
+
+      it { is_expected.to eq true }
+
+      context 'but redirect is set to false' do
+
+        let(:redirect) { false }
+
+        it { is_expected.to eq false }
+
+      end
+
+    end
+
+  end
+
+end

data/spec/unit/decorators/template_decorator_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'haml'
 
 describe Locomotive::Steam::Decorators::TemplateDecorator do
 

data/spec/unit/entities/content_type_spec.rb

@@ -30,6 +30,40 @@ describe Locomotive::Steam::ContentType do
 
   end
 
+  describe '#localized_names' do
+
+    subject { content_type.localized_names }
+
+    before {
+      expect(repository).to receive(:localized_names).and_return([])
+      expect(repository).to receive(:selects).and_return([instance_double('CategoryField', name: 'category')])
+    }
+
+    it { expect(subject).to eq ['category'] }
+
+  end
+
+
+  describe '#localized?' do
+
+    let(:names) { [] }
+
+    before { expect(repository).to receive(:localized_names).and_return(names) }
+
+    subject { content_type.localized? }
+
+    it { is_expected.to eq false }
+
+    context 'with one localized field' do
+
+      let(:names) { ['title'] }
+
+      it { is_expected.to eq true }
+
+    end
+
+  end
+
   describe '#default' do
 
     subject { content_type.fields_with_default }

data/spec/unit/entities/page_spec.rb

@@ -72,30 +72,6 @@ describe Locomotive::Steam::Page do
     end
   end
 
-  describe '#redirect?' do
-
-    subject { page.redirect? }
-
-    it { is_expected.to eq false }
-
-    context 'redirect_url has been set' do
-
-      let(:attributes) { { redirect: nil, redirect_url: 'http://www.google.fr' } }
-
-      it { is_expected.to eq true }
-
-      context 'but redirect is set to false' do
-
-        let(:attributes) { { redirect: false, redirect_url: 'http://www.google.fr' } }
-
-        it { is_expected.to eq false }
-
-      end
-
-    end
-
-  end
-
   describe '#source' do
 
     let(:attributes) { { 'raw_template' => 'template code here' } }

data/spec/unit/liquid/drops/content_entry_spec.rb

@@ -70,14 +70,22 @@ describe Locomotive::Steam::Liquid::Drops::ContentEntry do
 
   describe '#errors' do
 
-    let(:errors) { instance_double('Errors', messages: { title: ['not_blank'] }) }
+    let(:errors) { instance_double('Errors', messages: { title: ['not_blank'] }, blank?: false) }
 
     before do
-      expect(entry).to receive(:errors).and_return(errors)
+      allow(entry).to receive(:errors).and_return(errors)
     end
 
     it { expect(subject.errors).to eq('title' => ['not_blank']) }
 
+    context 'no errors' do
+
+      let(:errors) { instance_double('Errors', blank?: true) }
+
+      it { expect(subject.errors).to eq(false) }
+
+    end
+
   end
 
   describe 'i18n' do

data/spec/unit/liquid/drops/metafields_spec.rb

@@ -2,8 +2,8 @@ require 'spec_helper'
 
 describe Locomotive::Steam::Liquid::Drops::Metafields do
 
-  let(:metafields)  { { 'my_namespace' => { 'analytics_id' => { 'default' => '42' }, 'street' => { 'en' => '7 Albert Camus Alley', 'fr' => '7 allée Albert Camus' } } } }
-  let(:schema)      { [ { 'name' => 'my_namespace', fields: [{ name: 'analytics_id', position: 1 }, { name: 'street', localized: true, position: 0 }, { name: 'country', :position => 2 }] }].as_json }
+  let(:metafields)  { { 'my_namespace' => { 'visible' => { 'default' => '1' }, 'analytics_id' => { 'default' => '42' }, 'street' => { 'en' => '7 Albert Camus Alley', 'fr' => '7 allée Albert Camus' } } } }
+  let(:schema)      { [ { 'name' => 'my_namespace', fields: [{ name: 'analytics_id', position: 1 }, { name: 'street', localized: true, position: 0 }, { name: 'country', :position => 2 }, { name: 'visible', type: 'boolean', position: 3 }] }].as_json }
   let(:site)        { instance_double('Site', metafields: metafields, metafields_schema: schema) }
   let(:context)     { ::Liquid::Context.new({}, {}, { locale: 'en' }) }
   let(:drop)        { described_class.new(site).tap { |d| d.context = context } }
@@ -13,13 +13,13 @@ describe Locomotive::Steam::Liquid::Drops::Metafields do
     let(:namespace) { drop.before_method(:my_namespace).tap { |d| d.context = context } }
 
     it 'gives the number of the fields' do
-      expect(namespace.size).to eq 3
+      expect(namespace.size).to eq 4
     end
 
     it 'iterates over the fields and keeps the order' do
       list = []
       namespace.each { |el| list << el['name'] }
-      expect(list).to eq(['street', 'analytics_id', 'country'])
+      expect(list).to eq(['street', 'analytics_id', 'country', 'visible'])
     end
 
   end
@@ -46,6 +46,37 @@ describe Locomotive::Steam::Liquid::Drops::Metafields do
 
       end
 
+      context 'the field is a boolean' do
+
+        let(:boolean) { true }
+        let(:metafields) { { 'my_namespace' => { 'visible' => { 'default' => boolean } } } }
+
+        subject { namespace.before_method(:visible) }
+
+        it { is_expected.to eq true }
+
+        context '"true" is considered as true' do
+          let(:boolean) { 'true' }
+          it { is_expected.to eq true }
+        end
+
+        context '"1" is considered as true' do
+          let(:boolean) { '1' }
+          it { is_expected.to eq true }
+        end
+
+        context '"false" is considered as false' do
+          let(:boolean) { 'false' }
+          it { is_expected.to eq false }
+        end
+
+        context '"0" is considered as false' do
+          let(:boolean) { '0' }
+          it { is_expected.to eq false }
+        end
+
+      end
+
       context 'not a localized field' do
 
         context 'the value exists' do
@@ -63,8 +94,6 @@ describe Locomotive::Steam::Liquid::Drops::Metafields do
 
         end
 
-
-
         context "the value doesn't exist" do
 
           subject { namespace.before_method(:country) }

data/spec/unit/liquid/filters/resize_spec.rb

@@ -29,6 +29,23 @@ describe Locomotive::Steam::Liquid::Filters::Resize do
 
       it { is_expected.to match /\/steam\/dynamic\/.*\/240px-Metropolitan_railway_steam_locomotive_2781022036.png/ }
 
+      describe 'when imagemagick is not available' do
+
+        let(:input) {
+          double('image from liquid', url: 'http://upload.wikimedia.org/wikipedia/en/thumb/b/b5/Metropolitan_railway_steam_locomotive_2781022036.png/240px-Metropolitan_railway_steam_locomotive_2781022036.png')
+        }
+
+        before do
+          image_resizer = @context.registers[:services].image_resizer
+          allow(image_resizer).to receive(:disabled?).and_return(true)
+        end
+
+        it 'returns the original url without resizing' do
+          is_expected.to eq 'http://upload.wikimedia.org/wikipedia/en/thumb/b/b5/Metropolitan_railway_steam_locomotive_2781022036.png/240px-Metropolitan_railway_steam_locomotive_2781022036.png'
+        end
+
+      end
+
     end
 
   end

data/spec/unit/liquid/tags/with_scope_spec.rb

@@ -34,6 +34,13 @@ describe Locomotive::Steam::Liquid::Tags::WithScope do
 
   end
 
+  describe 'decode regexps with case-insensitive' do
+
+    let(:source) { "{% with_scope title: /like this/ix %}{% assign conditions = with_scope %}{% endwith_scope %}" }
+    it { expect(conditions['title']).to eq(/like this/ix) }
+
+  end
+
   describe 'decode content entry' do
 
     let(:entry) {
@@ -71,6 +78,14 @@ describe Locomotive::Steam::Liquid::Tags::WithScope do
 
   end
 
+  describe 'decode a regexp stored in a context variable, with case-insensitive' do
+
+    let(:assigns) { { 'my_regexp' => '/^hello world/ix' } }
+    let(:source) { "{% with_scope title: my_regexp %}{% assign conditions = with_scope %}{% endwith_scope %}" }
+    it { expect(conditions['title']).to eq(/^hello world/ix) }
+
+  end
+
   describe 'allow order_by option' do
 
     let(:source) { "{% with_scope order_by:\'name DESC\' %}{% assign conditions = with_scope %}{% endwith_scope %}" }

data/spec/unit/middlewares/page_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+require_relative '../../../lib/locomotive/steam/middlewares/thread_safe'
+require_relative '../../../lib/locomotive/steam/middlewares/helpers'
+require_relative '../../../lib/locomotive/steam/middlewares/page'
+
+describe Locomotive::Steam::Middlewares::Page do
+
+  let(:live_editing)    { nil }
+  let(:published)       { true }
+  let(:page_not_found)  { instance_double('PageNotFound', not_found?: true) }
+  let(:page)            { instance_double('Page', title: 'Hello world', fullpath: 'hello-world', not_found?: false, published?: published) }
+  let(:pages)           { [page] }
+  let(:site)            { instance_double('Site', default_locale: 'en') }
+  let(:service)         { instance_double('PageFinder', match: pages) }
+  let(:url)             { 'http://models.example.com' }
+  let(:app)             { ->(env) { [200, env, 'app'] } }
+  let(:middleware)      { described_class.new(app) }
+
+  subject do
+    env = env_for(url, 'steam.site' => site)
+    env['steam.path']         = 'hello-world'
+    env['steam.locale']       = 'en'
+    env['steam.request']      = Rack::Request.new(env)
+    env['steam.live_editing'] = live_editing
+    code, env = middleware.call(env)
+    env['steam.page']
+  end
+
+  before do
+    allow_any_instance_of(described_class).to receive(:page_finder).and_return(service)
+    allow(service).to receive(:find).with('404').and_return(page_not_found)
+  end
+
+  it { is_expected.to eq page }
+
+  context "page doesn't exist" do
+
+    let(:pages) { [] }
+
+    it { is_expected.to eq page_not_found }
+
+  end
+
+  context 'page is unpublished' do
+
+    let(:published) { false }
+
+    it { is_expected.to eq page_not_found }
+
+    context 'the live editing mode is on' do
+
+      let(:live_editing) { true }
+
+      it 'has to display it' do
+        is_expected.to eq page
+      end
+
+    end
+
+  end
+
+end

data/spec/unit/middlewares/renderer_spec.rb

@@ -8,9 +8,7 @@ describe Locomotive::Steam::Middlewares::Renderer do
 
   let(:app) { ->(env) { [200, env, 'app'] }}
 
-  let :middleware do
-    Locomotive::Steam::Middlewares::Renderer.new(app)
-  end
+  let(:middleware) { described_class.new(app) }
 
   describe 'missing 404 page' do
 
@@ -21,7 +19,7 @@ describe Locomotive::Steam::Middlewares::Renderer do
       middleware.call env_for('http://www.example.com', { 'steam.page' => nil, 'steam.locale' => locale, 'steam.site' => site })
     end
 
-    specify 'return 200' do
+    specify 'return 404' do
       code, headers, response = subject
       expect(code).to eq(404)
       expect(response).to eq(["Your 404 page is missing. Please create it."])

data/spec/unit/middlewares/sitemap_spec.rb

@@ -6,19 +6,21 @@ require_relative '../../../lib/locomotive/steam/middlewares/sitemap'
 
 describe Locomotive::Steam::Middlewares::Sitemap do
 
+  let(:site)            { instance_double('Site', locales: ['en', 'fr'], default_locale: 'en') }
   let(:pages)           { [] }
   let(:page_repository) { instance_double('PageRepository', published: pages) }
   let(:app)             { ->(env) { [200, env, 'app'] }}
   let(:middleware)      { described_class.new(app) }
 
   before do
+    allow_any_instance_of(described_class).to receive(:site).and_return(site)
     allow_any_instance_of(described_class).to receive(:base_url).and_return('http://localhost/')
     allow_any_instance_of(described_class).to receive(:page_repository).and_return(page_repository)
   end
 
   describe '#call' do
 
-    let(:env) { { 'PATH_INFO' => '/sitemap.xml', 'steam.page' => nil } }
+    let(:env) { { 'PATH_INFO' => '/sitemap.xml', 'steam.page' => nil, 'steam.site' => site } }
     subject { middleware.call(env) }
 
     describe 'no pages' do
@@ -39,6 +41,44 @@ describe Locomotive::Steam::Middlewares::Sitemap do
 
     end
 
+    describe '#build_templatized_page_xml?' do
+
+      let(:localized)     { true }
+      let(:source)        { '<h1>{{ post.title }}</h1>' }
+      let(:page)          { instance_double('TemplatePage', source: source) }
+      let(:content_type)  { instance_double('Post', localized?: localized) }
+      let(:locale)        { 'fr' }
+
+      subject { middleware.send(:build_templatized_page_xml?, page, content_type, locale) }
+
+      it { is_expected.to eq true }
+
+      context 'current locale is equals to the site default locale' do
+
+        let(:locale) { 'en' }
+
+        it { is_expected.to eq true }
+
+      end
+
+      context 'the content type is not localized' do
+
+        let(:localized) { false }
+
+        it { is_expected.to eq true }
+
+        context 'the page has the same liquid template in all the locales' do
+
+          let(:source) { '' }
+
+          it { is_expected.to eq false }
+
+        end
+
+      end
+
+    end
+
   end
 
 end

data/spec/unit/services/external_api_service_spec.rb

@@ -75,6 +75,16 @@ describe Locomotive::Steam::ExternalAPIService do
       end
     end
 
+    describe 'sets authorization header' do
+
+      let(:url)     { 'http://blog.locomotiveapp.org' }
+      let(:options) { { header_auth: 'letmein' } }
+      it do
+        expect(service.class).to receive(:get).with('/', { base_uri: 'http://blog.locomotiveapp.org', headers: { 'Authorization' => 'letmein' } }).and_return(response)
+        subject
+      end
+    end
+
   end
 
 end

data/spec/unit/services/image_resizer_service_spec.rb

@@ -14,7 +14,7 @@ describe Locomotive::Steam::ImageResizerService do
     subject { service.resize(input, geometry) }
 
     describe 'no resizer' do
-      it { is_expected.to eq nil }
+      it { is_expected.to eq 'http://upload.wikimedia.org/wikipedia/en/thumb/b/b5/Metropolitan_railway_steam_locomotive_2781022036.png/240px-Metropolitan_railway_steam_locomotive_2781022036.png' }
     end
 
     describe 'DragonFly' do
@@ -23,12 +23,12 @@ describe Locomotive::Steam::ImageResizerService do
 
       describe 'no imagemagick' do
         before { expect(resizer.plugins).to receive(:[]).with(:imagemagick).and_return(nil) }
-        it { is_expected.to eq nil }
+        it { is_expected.to eq 'http://upload.wikimedia.org/wikipedia/en/thumb/b/b5/Metropolitan_railway_steam_locomotive_2781022036.png/240px-Metropolitan_railway_steam_locomotive_2781022036.png' }
       end
 
       describe 'no geometry' do
         let(:geometry) { '' }
-        it { is_expected.to eq nil }
+        it { is_expected.to eq 'http://upload.wikimedia.org/wikipedia/en/thumb/b/b5/Metropolitan_railway_steam_locomotive_2781022036.png/240px-Metropolitan_railway_steam_locomotive_2781022036.png' }
       end
 
       it { is_expected.to match /\/steam\/dynamic\/.*\/240px-Metropolitan_railway_steam_locomotive_2781022036.png/ }