lockup 1.1.0 → 1.2.0

data/README.md

@@ -17,12 +17,10 @@ _“…what's the codeword?”_
 1. Add this line to your application's Gemfile:
 
         gem 'lockup'
-        
-2. Define a codeword (see Usage below).
 
-3. That's it!**
+2. Define a codeword (see Usage below).
 
-  **If you're passing parameters right at your root (i.e. somedomain.com/:parameter), you'll want to place this mount statement in your routes.rb file, _before_ your other route statements:
+3. Mount the engine in your application's routes file (usually first, for best results):
 
         mount Lockup::Engine, at: '/lockup'
 
@@ -39,19 +37,19 @@ If you think you might need a hint:
 If you're using [Figaro](https://github.com/laserlemon/figaro), set your lockup codeword and hint (optional) in your application.yml file:
 
     LOCKUP_CODEWORD: "love"
-    
+
     LOCKUP_HINT: "Pepé Le Pew"
-    
+
 **Codewords are not case-sensitive, by design. Keep it simple.**
 
 ### Link it with no typing:
 
     http://somedomain.com/or_path/?lockup_codeword=love
-    
+
 The visitor is redirected and the cookie is set without them ever seeing the Lockup splash page.
 
 (Lockup also makes a rudimentary attempt based on user agent to **block major search engine bots/crawlers** from following this link and indexing the site, just in case it ever gets out into the wild.)
 
 ## Contribute
 
-Pull requests are welcome, but please make the to the _development_ branch.
+Pull requests are welcome, but please make them to the _development_ branch.

data/config/routes.rb

@@ -1,7 +1,3 @@
-Rails.application.routes.draw do
-  mount Lockup::Engine, at: '/lockup', :as => 'lockup'
-end
-
 Lockup::Engine.routes.draw do
   get   'unlock' => 'lockup#unlock', :as => 'unlock'
   post  'unlock' => 'lockup#unlock'

data/lib/lockup/version.rb

@@ -1,3 +1,3 @@
 module Lockup
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/dummy/app/controllers/application_controller.rb

@@ -2,4 +2,8 @@ class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.
   protect_from_forgery with: :exception
+
+  def render_404
+    render :file => Rails.root.join('public', '404.html'), :status => 404
+  end
 end

data/spec/dummy/config/routes.rb

@@ -1,3 +1,10 @@
 Rails.application.routes.draw do
+
+  mount Lockup::Engine, :at => '/lockup', :as => 'lockup'
+
   resources :posts, :only => [:index, :show]
+
+  # this makes tests fail with endless redirect loop b/c it is before lockup routes
+  # catch all route b/c Rails `rescue_from` doesn't catch ActionController::RoutingError
+  match '*path', :via => :all, :to => 'application#render_404'
 end

data/spec/features/access_restricted_spec.rb

@@ -94,6 +94,12 @@ describe "Accessing a page in the application" do
       reset_user_agent
     end
 
+    it "works with a catch all route" do
+      visit '/this-does-not-exist?lockup_codeword=omgponies'
+
+      page.status_code.should == 404
+    end
+
     context "with a configured hint" do
       it "displays the hint to the user" do
         ENV['LOCKUP_HINT'] = 'Cute 4-legged animals'
@@ -108,4 +114,4 @@ describe "Accessing a page in the application" do
 
   end
 
-end
+end

metadata

@@ -1,95 +1,94 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: lockup
-version: !ruby/object:Gem::Version
-  version: 1.1.0
+version: !ruby/object:Gem::Version 
+  hash: 31
   prerelease: 
+  segments: 
+  - 1
+  - 2
+  - 0
+  version: 1.2.0
 platform: ruby
-authors:
+authors: 
 - gb Studio
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-27 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2014-01-15 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: rails
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '3'
-    - - <
-      - !ruby/object:Gem::Version
-        version: '5'
-  type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '3'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 5
+        segments: 
+        - 3
+        version: "3"
     - - <
-      - !ruby/object:Gem::Version
-        version: '5'
-- !ruby/object:Gem::Dependency
+      - !ruby/object:Gem::Version 
+        hash: 9
+        segments: 
+        - 5
+        version: "5"
+  type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
   name: rspec-rails
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: capybara
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: capybara
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: launchy
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
   type: :development
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: launchy
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-description: A simple gem to more elegantly place a staging server or other in-progress
-  application behind a basic codeword. It’s easy to implement, share with clients/collaborators,
-  and more beautiful than the typical password-protection sheet.
-email:
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id004
+description: "A simple gem to more elegantly place a staging server or other in-progress application behind a basic codeword. It\xE2\x80\x99s easy to implement, share with clients/collaborators, and more beautiful than the typical password-protection sheet."
+email: 
 - hello@grantblakeman.com
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - app/controllers/lockup/application_controller.rb
 - app/controllers/lockup/lockup_controller.rb
 - app/helpers/lockup/application_helper.rb
@@ -143,31 +142,39 @@ files:
 - spec/spec_helper.rb
 - spec/support/features/user_agent_helper.rb
 homepage: http://lockupgem.com
-licenses:
+licenses: 
 - MIT
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Lock staging servers from search engines and prying eyes.
-test_files:
+test_files: 
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb