locked-rb 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5d1a936962c0223393a99583955e69cac3f18cc732c381dca238f51c1ca72ce2
-  data.tar.gz: 1771ea97e75d13fe632bf35a98375e0bdbc3ed2d9b2574eef9ae29d5fcac9aaf
+  metadata.gz: c468766b7bf778b3bf456ba923360e9f29d1d5b571f8cbf6defc9b374c516441
+  data.tar.gz: 7345cb67528704b8b44ff18a0f44c48673f2e5664dc0ac169a437df6549e7e3f
 SHA512:
-  metadata.gz: 3df5d04b16da50679ebc5a0f8d435a847ad8b03afb0908f333cae35495e309372a9f8540edb54aa9497305c07746a81c9d78b1afe338143bf9613c77354a3531
-  data.tar.gz: be335f2c1691a91748e1f38073d71f7ce9c3f92e14d47a522c930aa80a06c4cc101434a4cffaaba8e2eba858d359c5c12362c26d05ced1d082e728b40a2af643
+  metadata.gz: 1f7573d7bcb2a5aa50415caf9b5feecb1c9b2a03c01c724b6ae189706c01ec7e23a9b5e0524785cf2a87230a16dbf99ddc5e4373d93f0415f536f40a14bc7a9e
+  data.tar.gz: 929805546fd45e31a74034eaba79f6ee7a683fec8f0d4364018d8911590debdc5068627591247e726c8a986c275f7302e3ea09315fdf32d73640cebe674751f8

data/README.md

@@ -115,7 +115,7 @@ And a possible response
   status: 200,
   data: {
     action: verify,
-    verify_token: 'f7e11d023c78'
+    verify_token: 'f7e11d023c78XXX'
   }
 }
 ```

data/lib/locked.rb

@@ -37,7 +37,6 @@
   locked/api/request/build
   locked/review
   locked/api
-  locked/configurations/merger
 ].each(&method(:require))
 
 # main sdk module

data/lib/locked/commands/authenticate.rb

@@ -11,11 +11,10 @@ module Locked
         Locked::Validators::Present.call(options, %i[event])
         context = Locked::Context::Merger.call(@context, options[:context])
         context = Locked::Context::Sanitizer.call(context)
-        options_with_config = Locked::Configurations::Merger.call(options)
 
         Locked::Command.new(
           'authenticate',
-          options_with_config.merge(context: context),
+          options.merge(context: context),
           :post
         )
       end

data/lib/locked/configuration.rb

@@ -31,10 +31,9 @@ module Locked
       'CF_CONNECTING_IP'
     ].freeze
     BLACKLISTED = ['HTTP_COOKIE'].freeze
-    CUSTOM_VERIFICATION = %i[email].freeze
 
     attr_accessor :host, :port, :request_timeout, :url_prefix, :basic_auth
-    attr_reader :api_key, :whitelisted, :blacklisted, :failover_strategy, :custom_verification
+    attr_reader :api_key, :whitelisted, :blacklisted, :failover_strategy
 
     def initialize
       @formatter = Locked::HeaderFormatter.new
@@ -46,7 +45,6 @@ module Locked
       self.whitelisted = WHITELISTED
       self.blacklisted = BLACKLISTED
       self.api_key = ''
-      self.custom_verification = []
       self.basic_auth = {}
     end
 
@@ -71,14 +69,6 @@ module Locked
       raise Locked::ConfigurationError, 'unrecognized failover strategy' if @failover_strategy.nil?
     end
 
-    def custom_verification=(values)
-      return @custom_verification = [] if values.empty?
-      @custom_verification = values.each_with_object([]) do |value, array|
-        raise Locked::ConfigurationError, 'unrecognized custom verification' unless CUSTOM_VERIFICATION.include?(value)
-        array << value
-      end
-    end
-
     def basic_auth=(value)
       return @basic_auth = {} unless value.has_key?(:username) && value.has_key?(:password)
       @basic_auth = value

data/lib/locked/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Locked
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'
 end

data/spec/lib/Locked/configuration_spec.rb

@@ -144,27 +144,4 @@ describe Locked::Configuration do
     end
   end
 
-  describe 'custom_verification' do
-    it do
-      expect(config.custom_verification).to be_eql([])
-    end
-
-    context 'with setter' do
-      before do
-        config.custom_verification = [:email]
-      end
-
-      it do
-        expect(config.custom_verification).to be_eql([:email])
-      end
-    end
-
-    context 'when broken' do
-      it do
-        expect do
-          config.custom_verification = [:unknown]
-        end.to raise_error(Locked::ConfigurationError)
-      end
-    end
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: locked-rb
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Yoshiki Takeda
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-11 00:00:00.000000000 Z
+date: 2020-02-12 00:00:00.000000000 Z
 dependencies: []
 description: locked protects your users from account compromise
 email: takeda@locked.jp
@@ -30,7 +30,6 @@ files:
 - lib/locked/commands/review.rb
 - lib/locked/commands/verify.rb
 - lib/locked/configuration.rb
-- lib/locked/configurations/merger.rb
 - lib/locked/context/default.rb
 - lib/locked/context/merger.rb
 - lib/locked/context/sanitizer.rb
@@ -64,7 +63,6 @@ files:
 - spec/lib/Locked/commands/review_spec.rb
 - spec/lib/Locked/commands/verify_spec.rb
 - spec/lib/Locked/configuration_spec.rb
-- spec/lib/Locked/configurations/merger_spec.rb
 - spec/lib/Locked/context/default_spec.rb
 - spec/lib/Locked/context/merger_spec.rb
 - spec/lib/Locked/context/sanitizer_spec.rb
@@ -108,7 +106,6 @@ specification_version: 4
 summary: locked
 test_files:
 - spec/spec_helper.rb
-- spec/lib/Locked/configurations/merger_spec.rb
 - spec/lib/Locked/review_spec.rb
 - spec/lib/Locked/client_spec.rb
 - spec/lib/Locked/context/default_spec.rb

data/lib/locked/configurations/merger.rb

@@ -1,15 +0,0 @@
-# frozen_string_literal: true
-
-module Locked
-  module Configurations
-    class Merger
-      class << self
-        def call(options)
-          return options if Locked.config.custom_verification.empty?
-
-          options.merge(custom_verification: Locked.config.custom_verification)
-        end
-      end
-    end
-  end
-end

data/spec/lib/Locked/configurations/merger_spec.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-describe Locked::Configurations::Merger do
-  describe '.call' do
-    context '正常系' do
-      let(:options) do
-        {
-          event: '$login.success',
-          user_id: 1234,
-          user_ip: '1.1.1.1',
-          user_agent: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Edge/15.15063',
-          email: 'example@locked.jp',
-          callback_url: 'https://locked.jp/login/result'
-        }
-      end
-
-      context 'configでcustom_verificationが設定されていない場合' do
-        it '引数で投げられたoptionsが返ること' do
-          expect(Locked::Configurations::Merger.call(options)).to eq options
-        end
-      end
-
-      context 'configでcustom_verificationが設定されている場合' do
-        before do
-          Locked.config.custom_verification = [:email]
-        end
-
-        it '引数で投げられたoptionsにcustom verificationがマージされて返ること' do
-          expect(Locked::Configurations::Merger.call(options)).to include custom_verification: [:email]
-        end
-      end
-    end
-  end
-end