lock_diff 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 40bb372ad385170936087d91ee3530cc75afb6c6
-  data.tar.gz: ce08c865a51232770c210585ff789e98e95e843f
+  metadata.gz: be2e92ea138be9c068f1c4a90a4a62d0684643de
+  data.tar.gz: f1717a0ec899c42cbc9d33697e065c9ee63d23a7
 SHA512:
-  metadata.gz: 89509ad3d40bc26f45206f999d323ccf20dc76ebbc4dbfdc46a865beb572c8c6c9426f6c954a06fb90e1a60f7ea8e174ca8d960d596f9e3768bb170347eb4098
-  data.tar.gz: 416e18c67a7cf82ea5ea59fae3c3f393461b1fbe0ff3fd3920bb7e9bcffacfaa3aafff3a01819b64ad7d77d19d52e532a6e2e68891483261e31382c7829943bd
+  metadata.gz: b91f6b0a99c4382817b63de18d26a446ba644204b6994b5df522336f12581197bf3c5ed47f3941624845c62da56d67b4bc69e7627ba8dd89025a705cbe5de3e2
+  data.tar.gz: 58b34be40b17940180f05e3930255a00047c32830622581f51885f2a1788380ca7e8acc4c287bbbaf78f822b83719cd3de15c6cb412b73d208c448dafb31b4f6

data/.travis.yml

@@ -1,6 +1,9 @@
 language: ruby
 rvm:
-  - 2.3.4
-  - 2.4.1
+- 2.3.4
+- 2.4.1
 script:
-  - bundle exec rspec
+- bundle exec rspec
+notifications:
+  slack:
+    secure: DKSdr5uEtNXGpAARGV+Q694eNv9IGi30RjSIjk8lRZrmLxE0WJbk/17FkmjgVF2w1onO/knFWgCiPBoIncihy4hh6nfAJZDaRI8AwXqYGGi10KeUBu4309r/7SL60KnFUFsQ9o47tar09TY6HS55IesNjN2/mKIEJlpw2c7McPz58rIzlFizTW5OPShsfWQnuLAz9iUYjknZfrntirav+mwkqVKqDZoMM7MRzedk1KjlkRbun/EVrgMEYPqsbpmhfYV0DZkcymorhH6d/FBsrWeqB7QMT6KwROMBHDZGeGzYgaN3KgjZV35gw6pK2VlsETm7E/Fk9Imrjalq87Q28aqX5nq/MR6Llo9yfE4J7PkGOTxcvZlXqp/W+2xT/8Ne6Dy29gb/7TeJY9K4nmkbkrmkanKBBmvIjbhwT46BOPjn1Sz4kbceoZNgihI2hMMPypH61+U6v0eUcGLuxRyDaUsyrgRnBEDHFZHMpfZ1eE7uXnCO9IvqGm5Tn4goP0s67H98CFhP+j3cIM2HKdns6ZyGsAHVakw7bnB90mKc9bIaaPSKEyZZD4MpkJxnMxR453OlSwJZIXesIkbBJMZA4wdOAsPQSBaSCY2w566LsUs4izRVLpdeILa/NOaxb+l1OvmejGyiihUjSUfH7fiIhoD5E0+SgOsDIdd0TV17rb4=

data/README.md

@@ -3,6 +3,7 @@
 [![Gem Version](https://badge.fury.io/rb/lock_diff.svg)](https://badge.fury.io/rb/lock_diff)
 [![GitHub tag](https://img.shields.io/github/tag/vividmuimui/lock_diff.svg)](https://github.com/vividmuimui/lock_diff/tags)
 [![Build Status](https://travis-ci.org/vividmuimui/lock_diff.svg?branch=master)](https://travis-ci.org/vividmuimui/lock_diff)
+[![Codacy Badge](https://api.codacy.com/project/badge/Grade/d05b439bc5064e30ad84ecfa8e57b448)](https://www.codacy.com/app/vividmuimui/lock_diff?utm_source=github.com&utm_medium=referral&utm_content=vividmuimui/lock_diff&utm_campaign=badger)
 [![Dependency Status](https://gemnasium.com/badges/github.com/vividmuimui/lock_diff.svg)](https://gemnasium.com/github.com/vividmuimui/lock_diff)
 [![Code Climate](https://codeclimate.com/github/vividmuimui/lock_diff/badges/gpa.svg)](https://codeclimate.com/github/vividmuimui/lock_diff)
 [![Issue Count](https://codeclimate.com/github/vividmuimui/lock_diff/badges/issue_count.svg)](https://codeclimate.com/github/vividmuimui/lock_diff)

data/Rakefile

@@ -3,4 +3,4 @@ require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/lib/lock_diff/cli/option_parser.rb

@@ -37,7 +37,7 @@ module LockDiff
         end
         opt.parse!(args)
 
-        if @require_flags.all? { |flag| options.has_key?(flag) }
+        if @require_flags.all? { |flag| options.key?(flag) }
           options
         else
           $stdout.puts opt.help

data/lib/lock_diff/diff_info.rb

@@ -23,7 +23,7 @@ module LockDiff
     def status
       case
       when @old_package.version && @new_package.version
-        if @old_package.version < @new_package.version
+        if @old_package.version <= @new_package.version
           UPGRADE
         else
           DOWNGRADE
@@ -83,7 +83,7 @@ module LockDiff
       return unless package.repository_url
       old_ref = @old_package.ref
       new_ref = @new_package.ref
-      commits_url =
+      compare_path =
         case status
         when UPGRADE
           "compare/#{old_ref}...#{new_ref}" if old_ref && new_ref
@@ -95,7 +95,7 @@ module LockDiff
           "commits/#{new_ref}" if new_ref
         end
 
-      "#{package.repository_url}/#{commits_url}" if commits_url
+      "#{package.repository_url}/#{compare_path}" if compare_path
     end
 
     def commits_url_text

data/lib/lock_diff/formatter/github_markdown.rb

@@ -9,7 +9,6 @@ module LockDiff
         @diff_infos = diff_infos
       end
 
-
       def call
         (headers + body).join("\n")
       end

data/lib/lock_diff/gem/lockfile_comparator.rb

@@ -7,8 +7,8 @@ module LockDiff
       end
 
       def call
-        old_specs_by_name = Spec.new(@old_lockfile).map { |spec| [spec.name, spec] }.to_h
-        new_specs_by_name = Spec.new(@new_lockfile).map { |spec| [spec.name, spec] }.to_h
+        old_specs_by_name = Spec.parse(@old_lockfile).map { |spec| [spec.name, spec] }.to_h
+        new_specs_by_name = Spec.parse(@new_lockfile).map { |spec| [spec.name, spec] }.to_h
         names = (old_specs_by_name.keys + new_specs_by_name.keys).uniq
 
         names.map { |name|

data/lib/lock_diff/gem/package.rb

@@ -19,7 +19,7 @@ module LockDiff
       end
 
       def different?(other)
-        revision != other.revision || version != other.version
+        name != other.name || revision != other.revision || version != other.version
       end
 
       def repository

data/lib/lock_diff/gem/ruby_gem.rb

@@ -13,11 +13,7 @@ module LockDiff
       end
 
       def repository_url
-        @repository_url ||= Github::UrlDetector.new([source_code_url, homepage_url]).call
-      end
-
-      def homepage_url
-        @ruby_gem.homepage_uri
+        @repository_url ||= Github::UrlDetector.new([source_code_url, @ruby_gem.homepage_uri]).call
       end
 
       def url

data/lib/lock_diff/gem/spec.rb

@@ -4,8 +4,8 @@ module LockDiff
     module Spec
       class UnSupportSource < StandardError; end
 
-      def self.new(lockfile)
-        Bundler::LockfileParser.new(lockfile).specs.map do |lazy_specification|
+      class << self
+        def new(lazy_specification)
           case lazy_specification.source
           when Bundler::Source::Rubygems
             RubyGemSpec.new(lazy_specification)
@@ -17,6 +17,13 @@ module LockDiff
             raise UnSupportSource, "#{lazy_specification.source.class} source by #{lazy_specification.name} is not supported"
           end
         end
+
+        def parse(lockfile)
+          Bundler::LockfileParser.new(lockfile).specs.map do |lazy_specification|
+            new(lazy_specification)
+          end
+        end
+
       end
 
       class Base
@@ -37,12 +44,11 @@ module LockDiff
         end
 
         def repository_url; end
-        def homepage_url; end
         def ruby_gem_url; end
       end
 
       class RubyGemSpec < Base
-        def_delegators :ruby_gem, :repository_url, :homepage_url
+        def_delegators :ruby_gem, :repository_url
         def_delegator :ruby_gem, :url, :ruby_gem_url
 
         private
@@ -77,7 +83,6 @@ module LockDiff
       end
 
       def repository_url; end
-      def homepage_url; end
       def ruby_gem_url; end
 
       def to_package

data/lib/lock_diff/github/repository_name_detector.rb

@@ -9,9 +9,9 @@ module LockDiff
 
       def call
         return unless @url
-        @url.match(REGEXP).to_a.last.
-          split("/").first(2).
-          join("/")
+        path = @url.match(REGEXP).to_a.last
+        return unless path
+        path.split("/").first(2).join("/")
       end
 
     end

data/lib/lock_diff/github/tag_finder.rb

@@ -40,7 +40,7 @@ module LockDiff
           def find(repo_name, options = {})
             key = "#{repo_name}-#{options[:page]}"
             ruby_gem = repository[key]
-            return ruby_gem if repository.has_key?(key)
+            return ruby_gem if repository.key?(key)
             repository[key] = fetch(repo_name, options)
           end
 

data/lib/lock_diff/github/url_detector.rb

@@ -11,7 +11,7 @@ module LockDiff
       end
 
       def call
-        url = @urls.find { |url| url.include?("github.com") }
+        url = @urls.find { |_url| _url.include?("github") }
         return unless url
 
         begin

data/lib/lock_diff/lockfile_comparator.rb

@@ -3,7 +3,7 @@ module LockDiff
     class << self
       def compare_by(pull_request)
         file_path = pull_request.find_content_path(lockfile_name)
-        raise NotChangedLockfile unless !!file_path
+        raise NotChangedLockfile if file_path.nil?
 
         LockDiff.config.strategy.lockfile_comparator.new(
           old_lockfile: pull_request.base_file(file_path),

data/lib/lock_diff/version.rb

@@ -1,3 +1,3 @@
 module LockDiff
-  VERSION = "0.3.3"
+  VERSION = "0.3.4"
 end

data/lock_diff.gemspec

@@ -31,4 +31,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "codacy-coverage"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lock_diff
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - vividmuimui
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-23 00:00:00.000000000 Z
+date: 2017-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: codacy-coverage
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: This gem detects changes to your package manager (e.g. Gemfile) and generates
   a Markdown-formatted diff.
 email: