locations_ng 1.0.1 → 1.0.2

data/lib/locations_ng/state.rb

@@ -1,46 +1,52 @@
 module LocationsNg
   class State
-    def self.all
-      load_states.map{ |s| {name: s['name'], capital: s['capital']} }
-    end
+    class << self
+      def all
+        load_states.map{ |s| {name: s['name'], capital: s['capital']} }
+      end
 
-    def self.details(state)
-      state = state.downcase.gsub(' ', '_')
-      all_states = load_states
+      def details(state)
+        state_query = format_query(state)
+        all_states = load_states
 
-      state_index = all_states.index{|s| s['alias'] == state}
+        state_index = all_states.index{|s| s['alias'] == state_query}
 
-      if state_index.nil?
-        {message: "No state found for '#{state}'", status: 404}
-      else
-        res = all_states[state_index].with_indifferent_access
-        res['cities'] = LocationsNg::City.cities(state)
-        res['lgas'] = LocationsNg::Lga.lgas(state)
-        res
+        if state_index.nil?
+          {message: "No state found for '#{state}'", status: 404}
+        else
+          res = all_states[state_index].with_indifferent_access
+          res['cities'] = LocationsNg::City.cities(state)
+          res['lgas'] = LocationsNg::Lga.lgas(state)
+          res
+        end
       end
-    end
 
-    def self.capital(state)
-      state = state.downcase.gsub(' ', '_')
-      all_states = load_states
+      def capital(state)
+        state_query = format_query(state)
+        all_states = load_states
 
-      state_index = all_states.index{|s| s['alias'] == state}
+        state_index = all_states.index{|s| s['alias'] == state_query}
 
-      if state_index.nil?
-        {message: "No state found for '#{state}'", status: 404}
-      else
-        all_states[state_index]['capital']
+        if state_index.nil?
+          {message: "No state found for '#{state}'", status: 404}
+        else
+          all_states[state_index]['capital']
+        end
       end
-    end
 
-    private
+      private
 
-    def self.load_states
-      YAML.load(File.read(files_location 'states'))
-    end
+      def load_states
+        YAML.load(File.read(files_location 'states'))
+      end
+
+      def files_location(file)
+        File.expand_path("../locations/#{file}.yml", __FILE__)
+      end
 
-    def self.files_location(file)
-      File.expand_path("../locations/#{file}.yml", __FILE__)
+      def format_query(query)
+        query ? query.downcase.gsub(' ', '_') : query
+      end
     end
   end
 end

data/lib/locations_ng/version.rb

@@ -1,3 +1,3 @@
 module LocationsNg
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end

data/spec/locations_ng/city_spec.rb

@@ -15,7 +15,7 @@ module LocationsNg
     describe '.cities' do
       context 'when state is not found' do
         it 'returns error message' do
-          expect(city.cities('Invalid State')).to eq({message: "No cities found for 'invalid_state'", status: 404})
+          expect(city.cities('Invalid State')).to eq({message: "No cities found for 'Invalid State'", status: 404})
         end
       end
 

data/spec/locations_ng/lga_spec.rb

@@ -15,18 +15,56 @@ module LocationsNg
     describe '.lgas' do
       context 'when lgas for a state is not found' do
         it 'returns an error message' do
-          expect(lga.lgas('Unknown State')).to eq({message: "No lgas found for 'unknown_state'", status: 404})
+          expect(lga.lgas('Unknown State')).to eq({message: "No lgas found for 'Unknown State'", status: 404})
         end
       end
 
       context 'when state is found' do
         it 'returns the lgas for state' do
-          expect(lga.lgas('Lagos')).to eq(['Agege', 'Ajeromi-Ifelodun', 'Alimosho',
-                                           'Amuwo-Odofin', 'Badagry', 'Apapa', 'Epe',
-                                           'Eti Osa', 'Ibeju-Lekki', 'Ifako-Ijaiye',
-                                           'Ikeja', 'Ikorodu', 'Kosofe', 'Lagos Island',
-                                           'Mushin', 'Lagos Mainland', 'Ojo', 'Oshodi-Isolo',
-                                           'Shomolu', 'Surulere Lagos State'])
+          expect(lga.lgas('lagos').count).to eq(20)
+          expect(lga.lgas('Lagos')).to eq(['Agege', 'Ajeromi/ifelodun', 'Alimosho', 'Amuwo-odofin', 'Apapa',
+                                           'Badagry', 'Epe', 'Eti-osa', 'Ibeju/lekki', 'Ifako/ijaiye',
+                                           'Ikeja', 'Ikorodu', 'Kosofe', 'Lagos Island', 'Lagos Mainland',
+                                           'Mushin', 'Ojo', 'Oshodi/isolo', 'Shomolu', 'Surulere'
+                                          ])
+        end
+      end
+    end
+
+    describe '.localities' do
+      context 'when no query is passed' do
+        it 'returns 500' do
+          expect(lga.localities(nil, nil)).to eq({message: 'You must enter a state and lga.', status: 500})
+        end
+
+        it 'returns 500' do
+          expect(lga.localities('Kano', nil)).to eq({message: 'You must enter a state and lga.', status: 500})
+        end
+
+        it 'returns 500' do
+          expect(lga.localities(nil, 'Aba South')).to eq({message: 'You must enter a state and lga.', status: 500})
+        end
+      end
+
+      context 'when state is not found' do
+        it 'returns an error message' do
+          expect(lga.localities('logos', 'South West')).to eq({message: "'logos' state not found.", status: 404})
+        end
+      end
+
+      context 'when lgas for a state is not found' do
+        it 'returns an error message' do
+          expect(lga.localities('Abia', 'Isiala Ngwa')).to eq({message: "'Isiala Ngwa' LGA not found for 'Abia' state.", status: 404})
+        end
+      end
+
+      context 'when localities are found for lga' do
+        it 'returns localities for LGAs in a state' do
+          expect(lga.localities('Abia', 'Aba North')).to eq(['Ariaria', 'Asaokpoja', 'Asaokpulor',
+                                                             'Eziama  ward', 'Industrial', 'Ogbor 1',
+                                                             'Ogbor 2', 'Old GRA', 'Osusu 1', 'Osusu 2',
+                                                             'St. Eugene', 'Umuogor', 'Umuola', 'Uratta'
+                                                            ])
         end
       end
     end

data/spec/locations_ng/state_spec.rb

@@ -19,7 +19,7 @@ module LocationsNg
     describe '.details' do
       context 'when state is not found' do
         it 'returns status with message' do
-          expect(state.details('AbIja')).to eq({message: "No state found for 'abija'", status: 404})
+          expect(state.details('AbIja')).to eq({message: "No state found for 'AbIja'", status: 404})
         end
       end
 
@@ -35,12 +35,12 @@ module LocationsNg
                                              'maxLong'=>3.696727799999999,
                                              'alias'=>'lagos',
                                              'cities'=>%w(Agege Ikeja),
-                                             'lgas'=>['Agege', 'Ajeromi-Ifelodun', 'Alimosho',
-                                                      'Amuwo-Odofin', 'Badagry', 'Apapa', 'Epe',
-                                                      'Eti Osa', 'Ibeju-Lekki', 'Ifako-Ijaiye',
+                                             'lgas'=>['Agege', 'Ajeromi/ifelodun', 'Alimosho',
+                                                      'Amuwo-odofin', 'Apapa', 'Badagry', 'Epe',
+                                                      'Eti-osa', 'Ibeju/lekki', 'Ifako/ijaiye',
                                                       'Ikeja', 'Ikorodu', 'Kosofe', 'Lagos Island',
-                                                      'Mushin', 'Lagos Mainland', 'Ojo', 'Oshodi-Isolo',
-                                                      'Shomolu', 'Surulere Lagos State']
+                                                      'Lagos Mainland', 'Mushin', 'Ojo', 'Oshodi/isolo',
+                                                      'Shomolu', 'Surulere']
                                             })
         end
       end
@@ -49,7 +49,7 @@ module LocationsNg
     describe '.capital' do
       context 'when state is not found' do
         it 'returns status with message' do
-          expect(state.details('AbIja')).to eq({message: "No state found for 'abija'", status: 404})
+          expect(state.details('AbIja')).to eq({message: "No state found for 'AbIja'", status: 404})
         end
       end