locasms 0.5.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39596e51a28908193ac0455bf97fb1c703becaedc33c569fe509e1ce450a6e70
-  data.tar.gz: f4a5d880167d667f952ebd75f68116b4dcfda9da03579d9a2b4bca87f735b1ac
+  metadata.gz: c77f667632cbccd85f567f099b9bcef15815dcae6ad9726ef243ed632e983529
+  data.tar.gz: b20250459c3bcbff6777655dc0e03a5f109b40129bff4ff4291683dba55895b4
 SHA512:
-  metadata.gz: '028885bb02e34a3f5bb918e805795e24e62a1f7d9bd18acc81bafb53e824502b263128b159c75af90d06d5764b210cd0fc01968d865cfed31a89bf1041fbdbd6'
-  data.tar.gz: 56ca283b83035314141fadcf0b48cedbf875176822c5ca159c99c7a70857260cfe9c3a8284f0ddcd8fe9b147edd4f4a3f91542df4107c683a1f1d2e1a87f3422
+  metadata.gz: fbc9a23ee178d5572bc3ffed4722a27db9a3dc614f92b57d674859bd030fce05e9e37b3af6e7de7d14c90ba8d96e522271360a856585f4e53a29503615df03f8
+  data.tar.gz: f3569d9edf7307a17fe914e77ce94906241db9ef19a58fcce7b4c0fbcf96d1400da53cfea238b9c6694fd96f64b0d92715b1ded5ecb2adb7bfb05d90b7efad1f

data/.github/workflows/test.yml

@@ -0,0 +1,27 @@
+name: test
+on: [pull_request]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7
+          bundler-cache: true
+      - run: bundle exec rubocop
+
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [2.6, 2.7, "3.0", "3.1", jruby, jruby-head]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - run: bundle exec rspec

data/.rubocop.yml

@@ -1,6 +1,10 @@
 inherit_from: .rubocop_todo.yml
 
-require: rubocop-rspec
+require:
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-rspec
 
 AllCops:
+  TargetRubyVersion: 2.6
   NewCops: enable

data/.rubocop_todo.yml

@@ -16,15 +16,3 @@ Metrics/BlockLength:
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
 Metrics/MethodLength:
   Max: 27
-
-# Offense count: 1
-# Configuration parameters: CountKeywordArgs.
-Metrics/ParameterLists:
-  Max: 13
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Layout/LineLength:
-  Max: 179

data/README.md

@@ -1,5 +1,5 @@
 # locasms
-[![Gem Version](https://badge.fury.io/rb/locasms.svg)](http://badge.fury.io/rb/locasms) [![Build Status](https://travis-ci.org/mcorp/locasms.png?branch=master)](https://travis-ci.org/mcorp/locasms) [![Code Climate](https://api.codeclimate.com/v1/badges/4187ea939aabd3b66bf7/maintainability)](https://codeclimate.com/github/mcorp/locasms) [![CC Coverage](https://api.codeclimate.com/v1/badges/4187ea939aabd3b66bf7/test_coverage)](https://codeclimate.com/github/mcorp/locasms/test_coverage) [![Inline docs](http://inch-ci.org/github/mcorp/locasms.svg?branch=master)](http://inch-ci.org/github/mcorp/locasms)
+[![Gem Version](https://badge.fury.io/rb/locasms.svg)](http://badge.fury.io/rb/locasms) [![Code Climate](https://api.codeclimate.com/v1/badges/4187ea939aabd3b66bf7/maintainability)](https://codeclimate.com/github/mcorp/locasms) [![CC Coverage](https://api.codeclimate.com/v1/badges/4187ea939aabd3b66bf7/test_coverage)](https://codeclimate.com/github/mcorp/locasms/test_coverage) [![Inline docs](http://inch-ci.org/github/mcorp/locasms.svg?branch=master)](http://inch-ci.org/github/mcorp/locasms)
 
 > :warning: After `February, 10, 2018` the base IP of the service will change as noticed on this [issue](https://github.com/mcorp/locasms/issues/21). If you don't upgrade to version `0.3.1` your app will stop delivering SMS.
 

data/lib/locasms/client.rb

@@ -73,7 +73,9 @@ module LocaSMS
     def campaign_status(id)
       response = rest.get(:getstatus, id: id)
       begin
-        CSV.new(response['data'] || '', col_sep: ';', quote_char: '"').map do |delivery_id, _, enqueue_time, _, delivery_time, _, status, _, _, carrier, mobile_number, _, message|
+        CSV.new(
+          response['data'] || '', col_sep: ';', quote_char: '"'
+        ).map do |delivery_id, _, enqueue_time, _, delivery_time, _, status, _, _, carrier, mobile_number, _, message| # rubocop:disable Metrics/ParameterLists
           status = case status
                    when /aguardando envio/i
                      waiting
@@ -86,14 +88,9 @@ module LocaSMS
                    end
 
           {
-            campaign_id: id,
-            delivery_id: delivery_id,
-            enqueue_time: enqueue_time,
-            delivery_time: delivery_time,
-            status: status,
-            carrier: carrier,
-            mobile_number: mobile_number,
-            message: message
+            campaign_id: id, delivery_id: delivery_id, enqueue_time: enqueue_time,
+            delivery_time: delivery_time, status: status, carrier: carrier,
+            mobile_number: mobile_number, message: message
           }
         end
       rescue StandardError

data/lib/locasms/helpers/date_time_helper.rb

@@ -36,7 +36,7 @@ module LocaSMS
       #     # => ['14/03/1977', '14:12']
       #
       def self.split(date)
-        parse(date).strftime('%d/%m/%Y %H:%M').split(' ')
+        parse(date).strftime('%d/%m/%Y %H:%M').split
       end
     end
   end

data/lib/locasms/rest_client.rb

@@ -75,7 +75,7 @@ module LocaSMS
     # @raise [LocaSMS::InvalidOperation] when asked for an invalid operation
     # @raise [LocaSMS::InvalidLogin] when the given credentials are invalid
     def parse_response(action, response)
-      raise InvalidOperation.new(action: action) if response =~ /^0:OPERACAO INVALIDA$/i
+      raise InvalidOperation.new(action: action) if response.match?(/^0:OPERACAO INVALIDA$/i)
 
       j = begin
         MultiJson.load(response)
@@ -85,7 +85,7 @@ module LocaSMS
 
       return j if (j['status'] == 1) || (action == :getstatus)
 
-      raise InvalidLogin.new(action: action) if j['msg'] =~ /^falha ao realizar login$/i
+      raise InvalidLogin.new(action: action) if j['msg'].match?(/^falha ao realizar login$/i)
 
       raise LocaSMS::Exception.new(message: j['msg'], raw: response, action: action)
     end

data/lib/locasms/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module LocaSMS
-  VERSION = '0.5.0'
+  VERSION = '1.1.0'
 end

data/locasms.gemspec

@@ -14,13 +14,13 @@ Gem::Specification.new do |spec|
   spec.summary       = 'Cliente para disparo de SMS, regular e Short Code, através da LocaSMS/SMS Plataforma'
   spec.homepage      = 'https://github.com/mcorp/locasms'
   spec.license       = 'MIT'
+  spec.metadata      = { 'rubygems_mfa_required' => 'true' }
 
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '~> 2.4'
+  spec.required_ruby_version = '>= 2.6'
 
   spec.add_dependency 'multi_json', '~> 1.13'
 
@@ -28,17 +28,18 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake',      '~> 13.0'
 
   # test stuff
-  spec.add_development_dependency 'rspec',     '~> 3.9'
+  spec.add_development_dependency 'rspec',     '~> 3.11'
   spec.add_development_dependency 'timecop',   '~> 0.9'
 
   # for documentation
-  spec.add_development_dependency 'redcarpet', '~> 3.5'
   spec.add_development_dependency 'yard',      '~> 0.9'
 
   # for code coverage
-  spec.add_development_dependency 'simplecov', '~> 0.18'
+  spec.add_development_dependency 'simplecov', '~> 0.21'
 
   # for code quality
-  spec.add_development_dependency 'rubocop',       '~> 0.93'
-  spec.add_development_dependency 'rubocop-rspec', '~> 1.43'
+  spec.add_development_dependency 'rubocop', '~> 1.36'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.15'
+  spec.add_development_dependency 'rubocop-rake', '~> 0.6'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.13'
 end

data/spec/lib/locasms/client_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe LocaSMS::Client do # rubocop:disable RSpec/FilePath
   subject(:client) { described_class.new :login, :password, rest_client: rest_client, callback: nil }
 
-  let(:rest_client) { instance_double 'RestClient' }
+  let(:rest_client) { instance_double LocaSMS::RestClient }
   let(:base_args) { { msg: 'given message', numbers: '11988889991,11988889992,11988889993' } }
   let(:default_callback_args) { base_args.merge(url_callback: 'default') }
   let(:some_callback_args) { base_args.merge(url_callback: 'something') }
@@ -115,7 +115,8 @@ describe LocaSMS::Client do # rubocop:disable RSpec/FilePath
       it 'when callback given as arg to #deliver' do
         allow(rest_client).to receive(:get).and_return({})
 
-        client.deliver_at 'given message', '2020-10-10 10:10', '11988889991', '11988889992', '11988889993', url_callback: 'something'
+        client.deliver_at 'given message', '2020-10-10 10:10', '11988889991', '11988889992', '11988889993',
+                          url_callback: 'something'
 
         expect(rest_client).to have_received(:get).once.with(:sendsms, some_callback_args)
       end
@@ -143,23 +144,25 @@ describe LocaSMS::Client do # rubocop:disable RSpec/FilePath
   end
 
   context 'when receive all campaign based methods' do
-    def check_for(method)
-      rest_method = {
-        campaign_status: :getstatus,
-        campaign_hold: :holdsms,
-        campaign_release: :releasesms
-      }[method]
+    before { allow(rest_client).to receive(:get).and_return({}) }
 
-      allow(rest_client).to receive(:get).and_return({})
+    it '#campaign_status' do
+      client.campaign_status '12345'
+
+      expect(rest_client).to have_received(:get).once.with(:getstatus, id: '12345')
+    end
 
-      client.send method, '12345'
+    it '#campaign_hold' do
+      client.campaign_hold '12345'
 
-      expect(rest_client).to have_received(:get).once.with(rest_method, id: '12345')
+      expect(rest_client).to have_received(:get).once.with(:holdsms, id: '12345')
     end
 
-    it { check_for :campaign_status  }
-    it { check_for :campaign_hold    }
-    it { check_for :campaign_release }
+    it '#campaign_release' do
+      client.campaign_release '12345'
+
+      expect(rest_client).to have_received(:get).once.with(:releasesms, id: '12345')
+    end
 
     it 'has tests to cover campaign_status csv result'
   end

data/spec/lib/locasms/helpers/date_time_helper_spec.rb

@@ -6,16 +6,33 @@ describe LocaSMS::Helpers::DateTimeHelper do # rubocop:disable RSpec/FilePath
   subject(:helper) { described_class }
 
   describe '.parse' do
+    subject { described_class.parse(value) }
+
     let(:expected) { Time.parse '1977-03-14 14:12:00' }
 
-    def try_for(value)
-      helper.parse(value) == expected
+    context 'when is a date time' do
+      let(:value) { DateTime.parse '1977-03-14 14:12:00' }
+
+      it { is_expected.to eq expected }
+    end
+
+    context 'when is a time' do
+      let(:value) { Time.parse '1977-03-14 14:12:00' }
+
+      it { is_expected.to eq expected }
     end
 
-    it { try_for DateTime.parse('1977-03-14 14:12:00') }
-    it { try_for Time.parse('1977-03-14 14:12:00') }
-    it { try_for '1977-03-14 14:12:00' }
-    it { try_for 227_207_520 }
+    context 'when is a string' do
+      let(:value) { '1977-03-14 14:12:00' }
+
+      it { is_expected.to eq expected }
+    end
+
+    context 'when is a number' do
+      let(:value) { 227_196_720 }
+
+      it { is_expected.to eq expected }
+    end
   end
 
   describe '.split' do

data/spec/lib/locasms/rest_client_spec.rb

@@ -26,7 +26,7 @@ describe LocaSMS::RestClient do # rubocop:disable RSpec/FilePath
     it 'performs get request to url with parameters' do
       allow(Net::HTTP)
         .to receive(:get_response)
-        .and_return(OpenStruct.new(body: body))
+        .and_return(instance_double(Net::HTTPOK, body: body))
 
       rest_client.get(action, params)
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: locasms
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Adilson Carvalho
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-29 00:00:00.000000000 Z
+date: 2022-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -60,14 +60,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.11'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -83,75 +83,89 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: redcarpet
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: '0.21'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '1.36'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.18'
+        version: '1.36'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.15'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.93'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.93'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.43'
+        version: '2.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.43'
+        version: '2.13'
 description: |-
   Cliente para o serviço de disparo de SMS da LocaSMS e de sua
                             versão para Short Code SMS (SMS Plataforma)
@@ -164,10 +178,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - ".yardopts"
 - Gemfile
 - Guardfile
@@ -192,31 +206,26 @@ files:
 homepage: https://github.com/mcorp/locasms
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "~>"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: Cliente para disparo de SMS, regular e Short Code, através da LocaSMS/SMS
   Plataforma
-test_files:
-- spec/lib/locasms/client_spec.rb
-- spec/lib/locasms/helpers/date_time_helper_spec.rb
-- spec/lib/locasms/numbers_spec.rb
-- spec/lib/locasms/rest_client_spec.rb
-- spec/spec.opts
-- spec/spec_helper.rb
+test_files: []

data/.travis.yml

@@ -1,17 +0,0 @@
-language: ruby
-rvm:
-  - 2.7
-  - 2.6
-  - 2.5
-  - 2.4
-env:
-  - TRAVIS=true
-before_script:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-script:
-  - bundle exec rspec
-  - bundle exec rubocop
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT