locasms 0.1.7 → 0.5.0

data/spec/lib/locasms/helpers/date_time_helper_spec.rb

@@ -1,50 +1,26 @@
-require 'spec_helper'
-
-describe LocaSMS::Helpers::DateTimeHelper do
-  subject { LocaSMS::Helpers::DateTimeHelper }
-
-  describe '#parse' do
-    it 'Should call the class method' do
-      expect(subject).to receive(:parse)
-        .once
-        .with(:value)
-
-      subject.new.parse(:value)
-    end
-  end
+# frozen_string_literal: true
 
-  describe '#split' do
-    it 'Should call the class method' do
-      expect(subject).to receive(:split)
-        .once
-        .with(:value)
+require 'spec_helper'
 
-      subject.new.split(:value)
-    end
-  end
+describe LocaSMS::Helpers::DateTimeHelper do # rubocop:disable RSpec/FilePath
+  subject(:helper) { described_class }
 
   describe '.parse' do
     let(:expected) { Time.parse '1977-03-14 14:12:00' }
 
     def try_for(value)
-      subject.parse(value) == expected
+      helper.parse(value) == expected
     end
 
     it { try_for DateTime.parse('1977-03-14 14:12:00') }
-    it { try_for Time.parse('1977-03-14 14:12:00')     }
-    it { try_for '1977-03-14 14:12:00'                 }
-    it { try_for 227207520                             }
+    it { try_for Time.parse('1977-03-14 14:12:00') }
+    it { try_for '1977-03-14 14:12:00' }
+    it { try_for 227_207_520 }
   end
 
   describe '.split' do
-    it 'Should break a date into date and time' do
-      expect(subject).to receive(:parse)
-        .once
-        .with(:datetime)
-        .and_return(Time.parse('1977-03-14 14:12:00'))
-
-      expect(subject.split(:datetime)).to eq(%w(14/03/1977 14:12))
+    it 'breaks a date into date and time' do
+      expect(helper.split('1977-03-14 14:12:00')).to eq(%w[14/03/1977 14:12])
     end
   end
-
-end
+end

data/spec/lib/locasms/numbers_spec.rb

@@ -1,106 +1,92 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe LocaSMS::Numbers do
-  subject { LocaSMS::Numbers.new }
-
-  describe '.initialize' do
-    subject do
-      expect_any_instance_of(LocaSMS::Numbers).
-        to receive(:evaluate).
-        once.
-        with([:numbers]).
-        and_return(good: [1, 3], bad: [2, 4])
-      LocaSMS::Numbers.new :numbers
-    end
+describe LocaSMS::Numbers do # rubocop:disable RSpec/FilePath
+  subject(:number_sanitizer) { described_class.new numbers }
 
-    it { expect(subject.good).to eq([1, 3]) }
-    it { expect(subject.bad).to eq([2, 4]) }
-  end
+  let(:numbers) { '1188889999' }
 
   describe '#normalize' do
-    it do 
-      expect(subject.normalize('+55 (11) 8888-9999')).to(
-        eq(%w(551188889999))
+    it do
+      expect(number_sanitizer.normalize('+55 (11) 8888-9999')).to(
+        eq(%w[551188889999])
       )
     end
+
     it do
-      expect(subject.normalize('55', ['11', '22'])).to(
-        eq(%w(55 11 22))
+      expect(number_sanitizer.normalize('55', %w[11 22])).to(
+        eq(%w[55 11 22])
       )
     end
+
     it do
-      expect(subject.normalize(['55', 'ZZ', '22'])).to(
-        eq(%w(55 ZZ 22))
+      expect(number_sanitizer.normalize(%w[55 ZZ 22])).to(
+        eq(%w[55 ZZ 22])
       )
     end
+
     it do
-      expect(subject.normalize('55,44,33', ['ZZ', '22,11'])).to(
-        eq(%w(55 44 33 ZZ 22 11))
+      expect(number_sanitizer.normalize('55,44,33', ['ZZ', '22,11'])).to(
+        eq(%w[55 44 33 ZZ 22 11])
       )
     end
-    it do 
-      expect(subject.normalize(55, [11, 22])).to(
-        eq(%w(55 11 22))
+
+    it do
+      expect(number_sanitizer.normalize(55, [11, 22])).to(
+        eq(%w[55 11 22])
       )
     end
-    it { expect(subject.normalize('Z')).to eq(['Z']) }
-    it { expect(subject.normalize(nil)).to eq([]) }
+
+    it { expect(number_sanitizer.normalize('Z')).to eq(['Z']) }
+    it { expect(number_sanitizer.normalize(nil)).to eq([]) }
   end
 
   describe '#valid_number?' do
-    it { expect(subject.valid_number?('+55 (11) 8888-9999')).to be_falsey }
-    it { expect(subject.valid_number?('88889999')).to be_falsey }
-    it { expect(subject.valid_number?('988889999')).to be_falsey }
-    it { expect(subject.valid_number?('ABC')).to be_falsey }
-    it { expect(subject.valid_number?('')).to be_falsey }
-    it { expect(subject.valid_number?(nil)).to be_falsey }
-
-    it { expect(subject.valid_number?('1188889999')).to be_truthy }
-    it { expect(subject.valid_number?('11988889999')).to be_truthy }
+    it { is_expected.not_to be_valid_number('+55 (11) 8888-9999') }
+    it { is_expected.not_to be_valid_number('88889999') }
+    it { is_expected.not_to be_valid_number('988889999') }
+    it { is_expected.not_to be_valid_number('ABC') }
+    it { is_expected.not_to be_valid_number('') }
+    it { is_expected.not_to be_valid_number(nil) }
+
+    it { is_expected.to be_valid_number('1188889999') }
+    it { is_expected.to be_valid_number('11988889999') }
   end
 
   describe '#evaluate' do
-    it 'Should separate numbers in good and bad' do
-      expect(subject).to receive(:normalize).
-        once.
-        with([:numbers]).
-        and_return([:good, :bad])
-      expect(subject).to receive(:valid_number?).
-        once.
-        with(:good).
-        and_return(true)
-      expect(subject).to receive(:valid_number?).
-        once.
-        with(:bad).
-        and_return(false)
-      expect(subject.evaluate(:numbers)).to(
-        eq(good: [:good], bad: [:bad])
-      )
+    it 'separates numbers in good and bad' do
+      expect(number_sanitizer.evaluate('11988889999', 'abc')).to eq(good: ['11988889999'], bad: ['abc'])
     end
   end
 
   describe '#bad?' do
-    it do
-      expect(subject).to receive(:bad).once.and_return([ ])
-      expect(subject.bad?).to be_falsey
+    subject(:number_sanitizer) { described_class.new numbers }
+
+    context 'when bad is empty' do
+      let(:numbers) { '11988889999' }
+
+      it { expect(number_sanitizer).not_to be_bad }
     end
-    it do
-      expect(subject).to receive(:bad).once.and_return([1])
-      expect(subject.bad?).to be_truthy
+
+    context 'when bad has items' do
+      let(:numbers) { 'ABC' }
+
+      it { expect(number_sanitizer).to be_bad }
     end
   end
 
   describe '#to_s' do
-    it 'Should return and empty string' do
-      expect(subject.to_s).to eq('')
+    context 'when is empty returns empty string' do
+      let(:numbers) { '' }
+
+      it { expect(number_sanitizer.to_s).to eq('') }
     end
 
-    it 'Should return all good numbers in a string comma separated' do
-      expect(subject).to receive(:good).
-        once.
-        and_return([1, 2, 3, 4])
-      expect(subject.to_s).to eq('1,2,3,4')
+    context 'when all good numbers returns in a string comma separated' do
+      let(:numbers) { %w[11988889991 11988889992 11988889993] }
+
+      it { expect(number_sanitizer.to_s).to eq('11988889991,11988889992,11988889993') }
     end
   end
-
 end

data/spec/lib/locasms/rest_client_spec.rb

@@ -1,47 +1,79 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-describe LocaSMS::RestClient do
+describe LocaSMS::RestClient do # rubocop:disable RSpec/FilePath
+  subject(:rest_client) { described_class.new(action, params) }
+
+  let(:action) { :url }
+  let(:callback) { 'http://example.com/callback' }
+  let(:params) { { lgn: 'LOGIN', pwd: 'PASSWORD', url_callback: callback } }
+
   describe '.initialize' do
-    context 'When giving proper initialization parameters' do
-      subject { LocaSMS::RestClient.new :url, :params }
-      it { expect(subject.base_url).to be(:url) }
-      it { expect(subject.base_params).to be(:params) }
+    context 'when giving proper initialization parameters' do
+      let(:action) { :url }
+      let(:params) { :params }
+
+      it { expect(rest_client.base_url).to be(:url) }
+      it { expect(rest_client.base_params).to be(:params) }
     end
   end
 
   describe '#get' do
-    it 'Is missing tests for get'
+    let(:action) { 'sendsms' }
+    let(:body) { '{"status":1,"data":28,"msg":null}' }
+
+    it 'performs get request to url with parameters' do
+      allow(Net::HTTP)
+        .to receive(:get_response)
+        .and_return(OpenStruct.new(body: body))
+
+      rest_client.get(action, params)
+
+      expect(Net::HTTP).to have_received(:get_response)
+    end
   end
 
   describe '#params_for' do
-    subject { LocaSMS::RestClient.new :url, { b1: 'X' } }
+    it { expect(rest_client.params_for(:action)).to eq({ action: :action }.merge(params)) }
+    it { expect(rest_client.params_for(:action, p1: 10)).to eq({ action: :action, p1: 10 }.merge(params)) }
 
-    it { expect(subject.params_for(:action)).to eq({action: :action, b1: 'X'}) }
-    it { expect(subject.params_for(:action, p1: 10)).to eq({action: :action, b1: 'X', p1: 10}) }
+    context 'when callback is nil' do
+      let(:callback) { nil }
+
+      it 'is not in params' do
+        expect(rest_client.params_for(:action)).to eq({ action: :action, lgn: 'LOGIN', pwd: 'PASSWORD' })
+      end
+    end
   end
 
   describe '#parse_response' do
-    subject { LocaSMS::RestClient.new :url, :params }
-
-    it 'Should raise exception on invalid operation' do
-      expect { subject.parse_response(:action, '0:OPERACAO INVALIDA') }.to raise_error(LocaSMS::InvalidOperation)
+    it 'raises exception on invalid operation' do
+      expect { rest_client.parse_response(:action, '0:OPERACAO INVALIDA') }.to raise_error(LocaSMS::InvalidOperation)
     end
 
-    it 'Should raise exception on a failed response' do
-      expect { subject.parse_response(:action, '{"status":0,"data":null,"msg":"FALHA EPICA"}') }.to raise_error(LocaSMS::Exception, 'FALHA EPICA')
+    it 'raises exception on a failed response' do
+      response = '{"status":0,"data":null,"msg":"FALHA EPICA"}'
+
+      expect { rest_client.parse_response(:action, response) }.to raise_error(LocaSMS::Exception, 'FALHA EPICA')
     end
 
-    it 'Should raise exception on a failed login attempt' do
-      expect { subject.parse_response(:action, '{"status":0,"data":null,"msg":"FALHA AO REALIZAR LOGIN"}') }.to raise_error(LocaSMS::InvalidLogin)
+    it 'raises exception on a failed login attempt' do
+      response = '{"status":0,"data":null,"msg":"FALHA AO REALIZAR LOGIN"}'
+
+      expect { rest_client.parse_response(:action, response) }.to raise_error(LocaSMS::InvalidLogin)
     end
 
-    it 'Should return the non-json value as a json' do
-      expect(subject.parse_response(:action, 'non-json return')).to eq({'status' => 1, 'data' => 'non-json return', "msg" => nil})
+    it 'returns the non-json value as a json' do
+      response = { 'status' => 1, 'data' => 'non-json return', 'msg' => nil }
+
+      expect(rest_client.parse_response(:action, 'non-json return')).to eq(response)
     end
 
-    it 'Should return a parsed json return' do
-      expect(subject.parse_response(:action, '{"status":1,"data":28,"msg":null}')).to eq({'status' => 1, 'data' => 28, "msg" => nil})
+    it 'returns a parsed json return' do
+      response = { 'status' => 1, 'data' => 28, 'msg' => nil }
+
+      expect(rest_client.parse_response(:action, '{"status":1,"data":28,"msg":null}')).to eq(response)
     end
   end
-
-end
+end

data/spec/spec.opts

@@ -1,3 +1,2 @@
 --colour
---format Fuubar
---backtrace
+--backtrace

data/spec/spec_helper.rb

@@ -1,12 +1,13 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 
-# require 'coveralls'
-# require 'simplecov'
+require 'simplecov'
 
-# SimpleCov.start
+SimpleCov.start
 
 require 'locasms'
 require 'rspec'
@@ -16,4 +17,4 @@ Timecop.safe_mode = true
 
 RSpec.configure do |config|
   # see spec.opts
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: locasms
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.5.0
 platform: ruby
 authors:
 - Adilson Carvalho
@@ -10,188 +10,163 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-29 00:00:00.000000000 Z
+date: 2020-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
+        version: '1.13'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.13'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 10.4.2
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: fuubar
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: growl
+  name: redcarpet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.9'
 - !ruby/object:Gem::Dependency
-  name: redcarpet
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.18'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.18'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.93'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.93'
 - !ruby/object:Gem::Dependency
-  name: rest-client
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
-  type: :runtime
+        version: '1.43'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
-description: Cliente para o serviço de disparo de SMS da LocaSMS
+        version: '1.43'
+description: |-
+  Cliente para o serviço de disparo de SMS da LocaSMS e de sua
+                            versão para Short Code SMS (SMS Plataforma)
 email:
 - lc.adilson@gmail.com
 - vyper@maneh.org
 - marco.carvalho.swasthya@gmail.com
-executables: []
+executables:
+- console
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".hound.yml"
-- ".ruby-style.yml"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - ".yardopts"
 - Gemfile
@@ -199,6 +174,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/console
 - lib/locasms.rb
 - lib/locasms/client.rb
 - lib/locasms/exception.rb
@@ -223,20 +199,20 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: Cliente para o serviço de disparo de SMS da LocaSMS
+summary: Cliente para disparo de SMS, regular e Short Code, através da LocaSMS/SMS
+  Plataforma
 test_files:
 - spec/lib/locasms/client_spec.rb
 - spec/lib/locasms/helpers/date_time_helper_spec.rb
@@ -244,4 +220,3 @@ test_files:
 - spec/lib/locasms/rest_client_spec.rb
 - spec/spec.opts
 - spec/spec_helper.rb
-has_rdoc: