localtower 1.0.0 → 2.0.0

data/spec/dummy/tmp/cache/sessions/localtower/77E/121/_session_id%3A2%3A%3A0b3c1fe7154461ba023ba6c81dd1b999348757880b505f4b082faed263a627f9

@@ -0,0 +1 @@
+o: ActiveSupport::Cache::Entry	:@value{I"_csrf_token:EFI"0lL8I-pyCH1r3SMdncWhwIduEyks4pBVc7-soI0k1EZk;F:

data/spec/dummy/tmp/local_secret.txt

@@ -0,0 +1 @@
+02af762a06facc66792a9b636fb7ee0c226fc6f337031fc08634b19ff73059ca9e3fb637fd3ce0595d39367e6d40f714ea56a3723bc6418f78978c788472f683

data/spec/dummy/tmp/pids/server.pid

@@ -1 +1 @@
-67242
+19068

data/spec/factories/migration.rb

@@ -4,33 +4,42 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "add_column",
+          action_name: "add_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "title",
+          column_name: "title",
           column_type: "string",
           nullable: true,
         },
         {
-          action: "add_column",
+          action_name: "add_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "content",
+          column_name: "content",
           column_type: "text",
           nullable: true,
         },
         {
-          action: "add_column",
+          action_name: "add_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "views",
+          column_name: "views",
           column_type: "integer",
           index: true,
-          default: 0,
+          default: '0',
           nullable: false,
         },
         {
-          action: "add_column",
+          action_name: "add_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "tags",
+          column_name: "tags",
           column_type: "array",
+          default: '[]',
           index: true,
           nullable: true,
         }
@@ -43,9 +52,11 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "rename_column",
+          action_name: "rename_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "content",
+          column_name: "content",
           new_column_name: "content_new",
         }
       ]
@@ -57,14 +68,18 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "remove_column",
+          action_name: "remove_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "title",
+          column_name: "title",
         },
         {
-          action: "rename_column",
+          action_name: "rename_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "views",
+          column_name: "views",
           new_column_name: "views_by_users",
         }
       ]
@@ -76,15 +91,20 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "change_column_type",
+          action_name: "change_column_type",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "content_new",
+          column_name: "content_new",
           new_column_type: "string",
         },
         {
-          action: "add_index_to_column",
+          action_name: "add_index_to_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "views_by_users",
+          column_name: "views_by_users",
+          index: "default"
         }
       ]
     end
@@ -95,33 +115,40 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "add_column",
+          action_name: "add_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "content",
+          column_name: "content",
           column_type: "text",
         },
         {
-          action: "add_index_to_column",
+          action_name: "add_index_to_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "content",
+          column_name: "content",
+          index: "default"
         },
         {
-          action: "add_index_to_column",
+          action_name: "add_index_to_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "content_second",
-          index: {
-            using: 'default',
-            unique: true,
-          }
+          column_name: "content_second",
+          index: "default",
+          index_algorithm: '',
+          unique: true
         },
         {
-          action: "add_index_to_column",
+          action_name: "add_index_to_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "content_third",
-          index: {
-            using: 'gin',
-            algorithm: 'concurrently',
-          }
+          column_name: "content_third",
+          index: "gin",
+          index_algorithm: 'concurrently',
+          unique: false
         }
       ]
     end
@@ -132,9 +159,13 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "belongs_to",
+          action_name: "belongs_to",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          belongs_to: "users",
+          column_name: "user",
+          foreign_key: true,
+          index: "default"
         }
       ]
     end
@@ -145,9 +176,13 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "remove_index_to_column",
+          action_name: "remove_index_to_column",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
-          column: "views_by_users",
+          column_name: "views_by_users",
+          index_name: "index_posts_on_views_by_users"
+
         }
       ]
     end
@@ -158,7 +193,9 @@ FactoryBot.define do
     migrations do
       [
         {
-          action: "drop_table",
+          action_name: "drop_table",
+          model_name: "Post",
+          model_underscore: "post",
           table_name: "posts",
         }
       ]

data/spec/factories/model.rb

@@ -4,51 +4,71 @@ FactoryBot.define do
     attributes do
       [
         {
-          'attribute_name' => 'title',
-          'attribute_type' => 'string',
-          'index' => {
-            'using' => 'default',
-            'unique' => true,
-            'algorithm' => 'default',
-          }
+          'column_name' => 'title',
+          'column_type' => 'string',
+          'unique' => true,
+          'index' => 'default',
+          'index_algorithm' => 'default'
         },
         {
-          'attribute_name' => 'tags',
-          'attribute_type' => 'array',
+          'column_name' => 'tags',
+          'column_type' => 'array',
           'nullable' => false,
           'default' => '[]',
-          'index' => {
-            'using' => 'gin',
-            'unique' => true,
-            'algorithm' => 'concurrently',
-          }
+          'index' => 'gin',
+          'index_algorithm' => 'concurrently',
+          'unique' => true
         },
         {
-          'attribute_name' => 'content',
-          'attribute_type' => 'text',
+          'column_name' => 'content',
+          'column_type' => 'text',
           'nullable' => false,
-          'index' => {
-            'using' => 'gist',
-            'algorithm' => 'default',
-          }
+          "index" => "gist",
+          "index_algorithm" => "default"
         },
         {
-          'attribute_name' => 'likes_count',
-          'attribute_type' => 'integer',
+          'column_name' => 'likes_count',
+          'column_type' => 'integer',
           'nullable' => true,
           'default' => '0',
         },
         {
-          'attribute_name' => 'score',
-          'attribute_type' => 'float',
+          'column_name' => 'score',
+          'column_type' => 'float',
         },
         {
-          'attribute_name' => 'metadata',
-          'attribute_type' => 'jsonb',
+          'column_name' => 'metadata',
+          'column_type' => 'jsonb',
           'nullable' => false,
           'default' => '{}',
         },
       ]
     end
   end
+
+  factory :post_two, class: "Hash" do
+    model_name { 'Post' }
+    attributes do
+      [
+        {
+          'column_name' => 'user',
+          'column_type' => 'references',
+          'foreign_key' => true
+        }
+      ]
+    end
+  end
+
+  factory :post_three, class: "Hash" do
+    model_name { 'Post' }
+    attributes do
+      [
+        {
+          'column_name' => 'user',
+          'column_type' => 'references',
+          'foreign_key' => false
+        }
+      ]
+    end
+  end
 end

data/spec/lib/localtower/generators/migration_spec.rb

@@ -8,10 +8,10 @@ module Localtower
 
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(last_migration, /add_column :posts, :tags, :string, default: \[\], array: true/)).to eq(true)
-        expect(word_in_file?(last_migration, /add_column :posts, :views, :integer, default: 0, null: false/)).to eq(true)
-        expect(word_in_file?(last_migration, /add_column :posts, :content, :text/)).to eq(true)
-        expect(word_in_file?(last_migration, /add_column :posts, :title, :string/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_column :posts, :title, :string/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_column :posts, :content, :text/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_column :posts, :views, :integer, default: 0, null: false/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_column :posts, :tags, :string, default: \[\], array: true/)).to eq(true)
       end
 
       it 'remove_column' do
@@ -19,8 +19,8 @@ module Localtower
 
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(last_migration, /remove_column :posts, :title/)).to eq(true)
-        expect(word_in_file?(last_migration, /rename_column :posts, :views, :views_by_users/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /remove_column :posts, :title/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /rename_column :posts, :views, :views_by_users/)).to eq(true)
       end
 
       it 'rename_column' do
@@ -28,7 +28,7 @@ module Localtower
 
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(last_migration, /rename_column :posts, :content, :content_new/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /rename_column :posts, :content, :content_new/)).to eq(true)
       end
 
       it 'change_column_type' do
@@ -36,8 +36,8 @@ module Localtower
 
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(last_migration, /add_index :posts, :views_by_users/)).to eq(true)
-        expect(word_in_file?(last_migration, /change_column :posts, :content_new, :string/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_index :posts, :views_by_users/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /change_column :posts, :content_new, :string/)).to eq(true)
       end
 
       it 'add_index_to_column' do
@@ -45,26 +45,18 @@ module Localtower
 
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(last_migration, /disable_ddl_transaction!/)).to eq(true)
-        expect(word_in_file?(last_migration, /add_index :posts, :content/)).to eq(true)
-        expect(word_in_file?(last_migration, /add_index :posts, :content_second, unique: true/)).to eq(true)
-        expect(word_in_file?(last_migration, /add_index :posts, :content_third, using: :gin, algorithm: :concurrently/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /disable_ddl_transaction!/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_index :posts, :content/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_index :posts, :content_second, unique: true/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_index :posts, :content_third, using: :gin, algorithm: :concurrently/)).to eq(true)
       end
 
       it 'belongs_to' do
         data = attributes_for(:belongs_to)[:migrations]
 
-        model_post = "#{Rails.root}/app/models/post.rb"
-        model_user = "#{Rails.root}/app/models/user.rb"
-
-        File.open(model_post, 'w') { |f| f.write("class Post < ApplicationRecord\nend")}
-        File.open(model_user, 'w') { |f| f.write("class User < ApplicationRecord\nend")}
-
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(model_post, /# belongs_to :user/)).to eq(true)
-        expect(word_in_file?(model_user, /# has_many :posts/)).to eq(true)
-        expect(word_in_file?(last_migration, /add_reference :posts, :user, foreign_key: true, index: true/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /add_reference :posts, :user, foreign_key: true, index: true/)).to eq(true)
       end
 
       it 'remove_index_to_column' do
@@ -72,7 +64,7 @@ module Localtower
 
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(last_migration, /remove_index :posts, :views_by_users/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /remove_index :posts, name: :index_posts_on_views_by_users/)).to eq(true)
       end
 
       it 'drop_table' do
@@ -80,7 +72,7 @@ module Localtower
 
         generator = ::Localtower::Generators::Migration.new(data).run
 
-        expect(word_in_file?(last_migration, /drop_table :posts/)).to eq(true)
+        expect(word_in_file?(last_migration_pending, /drop_table :posts/)).to eq(true)
       end
     end
   end

data/spec/lib/localtower/generators/model_spec.rb

@@ -6,26 +6,23 @@ module Localtower
       context 'model 1' do
         let(:expected_migration) do
           <<-TEXT_MULTILINE.strip_heredoc
-          class CreatePosts < ActiveRecord::Migration[5.2]
+          class CreatePosts < ActiveRecord::Migration[7.2]
             disable_ddl_transaction!
 
             def change
               create_table :posts do |t|
                 t.string :title
-                t.string :tags, array: true, default: [], null: false
+                t.string :tags, null: false, default: [], array: true
                 t.text :content, null: false
                 t.integer :likes_count, default: 0
                 t.float :score
-                t.jsonb :metadata, default: {}, null: false
+                t.jsonb :metadata, null: false, default: {}
 
                 t.timestamps
               end
               add_index :posts, :title, unique: true
-              add_index :posts, :tags, using: :gin, unique: true, algorithm: :concurrently
+              add_index :posts, :tags, using: :gin, algorithm: :concurrently, unique: true
               add_index :posts, :content, using: :gist
-              add_index :posts, :likes_count
-              add_index :posts, :score
-              add_index :posts, :metadata
             end
           end
           TEXT_MULTILINE
@@ -44,7 +41,73 @@ module Localtower
           ::Localtower::Generators::Model.new(attributes).run
 
           expect(File.read("#{Rails.root}/app/models/post.rb")).to eq(expected_model)
-          expect(File.read(last_migration)).to eq(expected_migration)
+          expect(File.read(last_migration_pending)).to eq(expected_migration)
+        end
+      end
+
+      context 'model 2' do
+        let(:expected_migration) do
+          <<-TEXT_MULTILINE.strip_heredoc
+          class CreatePosts < ActiveRecord::Migration[7.2]
+            def change
+              create_table :posts do |t|
+                t.references :user, null: false, foreign_key: true
+
+                t.timestamps
+              end
+            end
+          end
+          TEXT_MULTILINE
+        end
+
+        let(:expected_model) do
+          <<-TEXT_MULTILINE.strip_heredoc
+          class Post < ApplicationRecord
+            belongs_to :user
+          end
+          TEXT_MULTILINE
+        end
+
+        let(:attributes) { attributes_for(:post_two).deep_stringify_keys }
+
+        it 'create a post' do
+          ::Localtower::Generators::Model.new(attributes).run
+
+          expect(File.read("#{Rails.root}/app/models/post.rb")).to eq(expected_model)
+          expect(File.read(last_migration_pending)).to eq(expected_migration)
+        end
+      end
+
+      context 'model 3' do
+        let(:expected_migration) do
+          <<-TEXT_MULTILINE.strip_heredoc
+          class CreatePosts < ActiveRecord::Migration[7.2]
+            def change
+              create_table :posts do |t|
+                t.references :user, null: false
+
+                t.timestamps
+              end
+            end
+          end
+          TEXT_MULTILINE
+        end
+
+        let(:expected_model) do
+          <<-TEXT_MULTILINE.strip_heredoc
+          class Post < ApplicationRecord
+            belongs_to :user
+          end
+          TEXT_MULTILINE
+        end
+
+        let(:attributes) { attributes_for(:post_three).deep_stringify_keys }
+
+        it 'create a post' do
+          ::Localtower::Generators::Model.new(attributes).run
+
+          expect(File.read("#{Rails.root}/app/models/post.rb")).to eq(expected_model)
+          expect(File.read(last_migration_pending)).to eq(expected_migration)
         end
       end
     end

data/spec/lib/localtower/generators/service_objects/insert_array_spec.rb

@@ -42,6 +42,6 @@ describe ::Localtower::Generators::ServiceObjects::InsertArray do
   it 'works' do
     service.call
 
-    expect(File.read(last_migration)).to eq(expected_file_content)
+    expect(File.read(last_migration_pending)).to eq(expected_file_content)
   end
 end

data/spec/lib/localtower/generators/service_objects/insert_defaults_spec.rb

@@ -60,6 +60,6 @@ describe ::Localtower::Generators::ServiceObjects::InsertDefaults do
   it 'works' do
     service.call
 
-    expect(File.read(last_migration)).to eq(expected_file_content)
+    expect(File.read(last_migration_pending)).to eq(expected_file_content)
   end
 end

data/spec/lib/localtower/generators/service_objects/insert_foreign_keys_spec.rb

@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe ::Localtower::Generators::ServiceObjects::InsertForeignKeys do
+  let(:service) { described_class.new(attributes) }
+
+  before do
+    File.open("#{Rails.root}/db/migrate/0_migration_name_.rb", 'w') { |f| f.write(base_file_content) }
+  end
+
+  context "when foreign_key is true" do
+    let(:attributes) {
+      [
+        { 'user'  =>
+          {
+            'foreign_key' => true,
+          }
+        },
+      ]
+    }
+
+    let(:base_file_content) {
+      <<-MIGRATION.strip_heredoc
+      class CreatePosts < ActiveRecord::Migration[7.2]
+        def change
+          create_table :posts do |t|
+            t.references :user, null: false
+
+            t.timestamps
+          end
+        end
+      end
+      MIGRATION
+    }
+
+    let(:expected_file_content) {
+      <<-MIGRATION.strip_heredoc
+      class CreatePosts < ActiveRecord::Migration[7.2]
+        def change
+          create_table :posts do |t|
+            t.references :user, null: false, foreign_key: true
+
+            t.timestamps
+          end
+        end
+      end
+      MIGRATION
+    }
+
+    it 'works' do
+      service.call
+
+      expect(File.read(last_migration_pending)).to eq(expected_file_content)
+    end
+  end
+
+  context "when foreign_key is false" do
+    let(:attributes) {
+      [
+        { 'user'  =>
+          {
+            'foreign_key' => false,
+          }
+        },
+      ]
+    }
+
+    let(:base_file_content) {
+      <<-MIGRATION.strip_heredoc
+      class CreatePosts < ActiveRecord::Migration[7.2]
+        def change
+          create_table :posts do |t|
+            t.references :user, null: false, foreign_key: true
+
+            t.timestamps
+          end
+        end
+      end
+      MIGRATION
+    }
+
+    let(:expected_file_content) {
+      <<-MIGRATION.strip_heredoc
+      class CreatePosts < ActiveRecord::Migration[7.2]
+        def change
+          create_table :posts do |t|
+            t.references :user, null: false
+
+            t.timestamps
+          end
+        end
+      end
+      MIGRATION
+    }
+
+    it 'works' do
+      service.call
+
+      expect(File.read(last_migration_pending)).to eq(expected_file_content)
+    end
+  end
+end

data/spec/lib/localtower/generators/service_objects/insert_indexes_spec.rb

@@ -85,6 +85,6 @@ describe ::Localtower::Generators::ServiceObjects::InsertIndexes do
   it 'works' do
     service.call
 
-    expect(File.read(last_migration)).to eq(expected_file_content)
+    expect(File.read(last_migration_pending)).to eq(expected_file_content)
   end
 end

data/spec/lib/localtower/generators/service_objects/insert_nullable_spec.rb

@@ -38,7 +38,7 @@ describe ::Localtower::Generators::ServiceObjects::InsertNullable do
             t.string  :first, null: false
             t.integer :second
             t.string  :third, null: false
-            t.string  :fourth, null: false, default: 'foo'
+            t.string  :fourth, default: 'foo', null: false
             t.integer :fifth
 
             t.timestamps
@@ -56,6 +56,6 @@ describe ::Localtower::Generators::ServiceObjects::InsertNullable do
   it 'works' do
     service.call
 
-    expect(File.read(last_migration)).to eq(expected_file_content)
+    expect(File.read(last_migration_pending)).to eq(expected_file_content)
   end
 end