loan_creator 0.9.1 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e207b2a1a30e9f07b773f9d3071c8df1cb815e17602661efb72d4315ead65dba
-  data.tar.gz: c6760d02448a8a9bd6f40fa992aa09f1d716a06b94e2ce5afa8b54eddfeeddf6
+  metadata.gz: 838d0d280c585125b013b8ea6d7e8b58e94c2234fffe3d49d1c97f39a67b254f
+  data.tar.gz: 7a607035130b53af6678bdec2a91b9d99fcace0a1710db1ef83333a4b15133b0
 SHA512:
-  metadata.gz: 75d786838e61c1f342da8a3ebf3e0264e42f0e80909bc22ffe63f5c76acf4a1c36e1130ebcbcb4f8c72d87f7a99735c8e3d70f634889935dd57849f92bcdf98d
-  data.tar.gz: 768182d707c17e9f5b1f8f748f6dcaf1277e1a1bf0b68c33ed28a178464117272e8dfe294585baeac3fa1d9fb3f28945e1224b7e158fffea66bda89c5cb25dff
+  metadata.gz: 06c8e0dfa135c8a80f9969f60db83a8bc3630161fea4f208dff6480ab9142635d196aaa729fdb32fd89e38e87804cbc76fcc1f10ec464c680c10219ef7aec23c
+  data.tar.gz: c710e04d68debd3d7f63569586aed46ac1426aabf9ed995fa762a18745916d1f31339f93b173159ddd61dcf23b145527471dbc7ff873a1bdfc46169e310f4322

data/README.md

@@ -187,7 +187,7 @@ Default: `false`.
 The default behaviour is to use the `period` in relation to the number of months in a year (ie: for a monthly timetable annual_interests_rate * 1/12, for quarter annual_interests_rate * 3/12, etc.)
 
 
-`term_dates`: Optional. Implemented for `LoanCreator::Bullet`, `LoanCreator::InFine` and `LoanCreator::Linear`. Can be used if you want to implement custom due dates for terms. Terms will be compute from date to date. Must be an array with following dates.
+`term_dates`: Optional. Implemented for `LoanCreator::Bullet`, `LoanCreator::InFine` and `LoanCreator::Linear`. Can be used if you want to implement custom due dates for terms. Terms will be computed from date to date. Must be an array with following dates. Must contain duration + 1 dates. The first element of the array is the first period start_date and last is the last period pay day.
 
 ## Calculation
 

data/lib/loan_creator/common.rb

@@ -291,10 +291,11 @@ module LoanCreator
 
     def prepare_custom_term_dates
       term_dates = @options[:term_dates].each_with_index.with_object({}) do |(term_date, index), obj|
-        obj[index + 1] = term_date
+        obj[index + @starting_index - 1] = term_date
       end
 
-      term_dates[0] = starts_on
+      # if starting_index > 1 term_dates[0] is not set
+      term_dates[0] ||= starts_on
       @_timetable_term_dates = term_dates
       @realistic_durations = true
     end

data/lib/loan_creator/term_dates_validator.rb

@@ -17,8 +17,10 @@ module LoanCreator
     end
 
     def self.matches_duration(term_dates, duration_in_periods)
-      unless term_dates.size == duration_in_periods
-        raise ArgumentError, "the size of :term_dates (#{term_dates.size}) do not match the :duration_in_periods (#{duration_in_periods})"
+      unless term_dates.size == duration_in_periods + 1
+        error_message = "the size of :term_dates (#{term_dates.size}) do not match the :duration_in_periods (#{duration_in_periods})."
+        advice = "You must pass the previous term date (or start_on if starting_index == 1) as the first term date"
+        raise ArgumentError, "#{error_message} #{advice}"
       end
     end
 
@@ -64,7 +66,7 @@ module LoanCreator
           raise ArgumentError, "term dates can't be more than 1 year apart. #{error_description}"
         end
       end
-    end      
+    end
 
     def self.bullet?(loan_class)
       loan_class == "LoanCreator::Bullet"

data/lib/loan_creator/version.rb

@@ -1,3 +1,3 @@
 module LoanCreator
-  VERSION = '0.9.1'.freeze
+  VERSION = '0.10.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: loan_creator
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.10.0
 platform: ruby
 authors:
 - thibaulth
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-11 00:00:00.000000000 Z
+date: 2021-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler