loan_creator 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb6c8e7e02bc1349e47dcb07602828d051cfa63ac7fc3e16394604f8dda05e27
-  data.tar.gz: d103c1e0524641e73b307702eec5bd1cf43029236a3d791805e4d62e7e0732d3
+  metadata.gz: e207b2a1a30e9f07b773f9d3071c8df1cb815e17602661efb72d4315ead65dba
+  data.tar.gz: c6760d02448a8a9bd6f40fa992aa09f1d716a06b94e2ce5afa8b54eddfeeddf6
 SHA512:
-  metadata.gz: c201e2a5fb2a5aaa54b1870b635e11c08b90d35f45258852f4cf61e5faa99756272b54db5a85c470123b5baaf5dedd5a9be79af8577796595997540cad4662b9
-  data.tar.gz: 00556c176b2e27765ca5112878495c7982cdaeb75abfe3b3956b57c6be57dfcf6c8cf89136bbfa0c94c40e7d43927ff2eafa8c0518f99d0be914e1bd7df1b70d
+  metadata.gz: 75d786838e61c1f342da8a3ebf3e0264e42f0e80909bc22ffe63f5c76acf4a1c36e1130ebcbcb4f8c72d87f7a99735c8e3d70f634889935dd57849f92bcdf98d
+  data.tar.gz: 768182d707c17e9f5b1f8f748f6dcaf1277e1a1bf0b68c33ed28a178464117272e8dfe294585baeac3fa1d9fb3f28945e1224b7e158fffea66bda89c5cb25dff

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+v0.9.1
+-------------------------
+- add spec importer `scripts/convert_export_to_spec.rb {csv_url}`
+- fix period interests rate for realistic duration period overlapping leap & non leap years
+
 v0.9.0
 -------------------------
 - add possibility to pass the argument `term_dates` for `LoanCreator::Bullet`, `LoanCreator::InFine` and `LoanCreator::Linear`

data/README.md

@@ -180,8 +180,12 @@ additional term with only interests for the time difference.
 For example, with a `start_at` in january 2020 and a `interests_start_date` in october 2019, the timetable will include a
 first term corresponding to 3 months of interests.
 
-`realistic_durations`: Optional. A boolean tha specifies whether or not to use the real number of days in each month when calculating the periodic interests rate. Note that leap years are taken into account. Default: `false`.
-The default behaviour is to use the `period` in relation to the number of months in a year (ie: 12)
+`realistic_durations`: Optional. A boolean that specifies whether or not to use the real number of days in each month when calculating the periodic interests rate (ie: for a period between January 1st 2021 and February 1st 2021 the period rate is annual_interests_rate * 31/355).
+Note that leap years are taken into account (ie: for a period between January 1st 2020 and February 1st 2020 the period rate is annual_interests_rate * 31/356). Also, an overlaping period
+take each parts into account (ie: for a period between December 1st 2020 and February 1st 2021, the period rate is (annual_interests_rate * (31/355) + annual_interests_rate * (31/356)))
+Default: `false`.
+The default behaviour is to use the `period` in relation to the number of months in a year (ie: for a monthly timetable annual_interests_rate * 1/12, for quarter annual_interests_rate * 3/12, etc.)
+
 
 `term_dates`: Optional. Implemented for `LoanCreator::Bullet`, `LoanCreator::InFine` and `LoanCreator::Linear`. Can be used if you want to implement custom due dates for terms. Terms will be compute from date to date. Must be an array with following dates.
 

data/lib/loan_creator/common.rb

@@ -236,12 +236,41 @@ module LoanCreator
       (interests_start_date && interests_start_date < term_zero_date) && !term_dates?
     end
 
-    def compute_realistic_periodic_interests_rate_percentage_for(date, relative_to_date:)
-      realistic_days = 365
-      realistic_days += 1 if date.leap?
-      realistic_days_in_period = (date - relative_to_date).to_i
+    def leap_days_count(date, relative_to_date:)
+      start_year = relative_to_date.year
+      end_year = date.year
+
+      (start_year..end_year).sum do |year|
+        next 0 unless Date.gregorian_leap?(year)
 
-      annual_interests_rate.div(bigd(realistic_days) / bigd(realistic_days_in_period), BIG_DECIMAL_DIGITS)
+        start_date =
+          if start_year == year
+            relative_to_date
+          else
+            Date.new(year - 1, 12, 31)
+          end
+
+        end_date =
+          if end_year == year
+            date
+          else
+            Date.new(year, 12, 31)
+          end
+
+        end_date - start_date
+      end
+    end
+
+    def compute_realistic_periodic_interests_rate_percentage_for(date, relative_to_date:)
+      total_days = date - relative_to_date
+      leap_days = bigd(leap_days_count(date, relative_to_date: relative_to_date))
+      non_leap_days = bigd(total_days - leap_days)
+
+      annual_interests_rate.mult(
+        leap_days.div(366, BIG_DECIMAL_DIGITS) +
+        non_leap_days.div(365, BIG_DECIMAL_DIGITS),
+        BIG_DECIMAL_DIGITS
+      )
     end
 
     def realistic_durations?

data/lib/loan_creator/version.rb

@@ -1,3 +1,3 @@
 module LoanCreator
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.9.1'.freeze
 end

data/scripts/convert_export_to_spec.rb

@@ -0,0 +1,51 @@
+#!/usr/bin/env ruby
+require 'csv'
+require 'open-uri'
+require 'pry'
+require 'securerandom'
+
+csv_url = ARGV[0]
+
+spec_order = %i[
+  index
+  due_on
+  crd_beginning_of_period
+  crd_end_of_period
+  period_theoric_interests
+  delta_interests
+  accrued_delta_interests
+  amount_to_add
+  period_interests
+  period_capital
+  total_paid_capital_end_of_period
+  total_paid_interests_end_of_period
+  period_amount_to_pay
+  due_interests_beginning_of_period
+  due_interests_end_of_period
+]
+
+column_getter = {
+  index: proc { |r| r['t'].to_i },
+  due_on: proc { |r| r['date'] },
+  crd_beginning_of_period: proc { |r| r['crd_start'].gsub(',', '.').to_f },
+  crd_end_of_period: proc { |r| r['crd_end'].gsub(',', '.').to_f },
+  period_theoric_interests: proc { |r| r['period_theoric_interests'].gsub(',', '.').to_f },
+  delta_interests: proc { |r| r['delta_interests'].gsub(',', '.').to_f },
+  accrued_delta_interests: proc { |r| r['cumulated_delta_interests'].gsub(',', '.').to_f },
+  amount_to_add: proc { |r| r['amount_to_add'].gsub(',', '.').to_f },
+  period_interests: proc { |r| r['period_interests'].gsub(',', '.').to_f },
+  period_capital: proc { |r| r['period_capital'].gsub(',', '.').to_f },
+  total_paid_capital_end_of_period: proc { |r| r['total_capital_paid'].gsub(',', '.').to_f },
+  total_paid_interests_end_of_period: proc { |r| r['total_interests_paid'].gsub(',', '.').to_f },
+  period_amount_to_pay: proc { |r| r['period_total'].gsub(',', '.').to_f },
+  due_interests_beginning_of_period: proc { |r| r['due_interests_beginning_of_period'].gsub(',', '.').to_f },
+  due_interests_end_of_period: proc { |r| r['due_interests_end_of_period'].gsub(',', '.').to_f }
+}
+
+data = CSV.parse(URI.open(csv_url), headers: true).map(&:to_hash)
+
+CSV.open("./spec/fixtures/new/#{SecureRandom.alphanumeric}.csv", 'w') do |csv|
+  data.each do |row|
+    csv << spec_order.map { |column| column_getter[column].call(row) }
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: loan_creator
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - thibaulth
@@ -12,7 +12,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-07 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -182,6 +182,7 @@ files:
 - lib/loan_creator/uncapitalized_bullet.rb
 - lib/loan_creator/version.rb
 - loan_creator.gemspec
+- scripts/convert_export_to_spec.rb
 homepage: https://github.com/CapSens/loan-creator
 licenses:
 - MIT