loaf 0.2.0 → 0.2.1

data/CHANGELOG.md

@@ -1,4 +1,9 @@
-0.2.0 (February  , 2012)
+0.2.1 (February 22, 2012)
+
+* Add more integration tests and fixed bug with adding breadcrumbs inside view
+* Add specs for controller extensions
+
+0.2.0 (February 18, 2012)
 
 * Change gemspec with new gem dependencies, use git
 * Setup testing environment with dummy rails app

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    loaf (0.1.1)
+    loaf (0.2.0)
       rails
 
 GEM

data/lib/loaf/controller_extensions.rb

@@ -32,9 +32,7 @@ module Loaf
         end
       end
 
-      def _process_url(url)
-      end
-    end
+    end # ClassMethods
 
     module InstanceMethods
 
@@ -64,7 +62,7 @@ module Loaf
         @_breadcrumbs ||= []
       end
 
-      def clear_crumbs
+      def clear_breadcrumbs
         _breadcrumbs.clear
       end
 

data/lib/loaf/version.rb

@@ -4,7 +4,7 @@ module Loaf
   module Version
     MAJOR = 0
     MINOR = 2
-    PATCH = 0
+    PATCH = 1
     BUILD = nil
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.');

data/lib/loaf/view_extensions.rb

@@ -9,7 +9,7 @@ module Loaf
     # Adds breadcrumbs in a view.
     #
     def add_breadcrumb(name, url)
-      _breadcrumbs.push(name, url)
+      _breadcrumbs.push Loaf::Crumb.new(name, url)
     end
 
     # Renders breadcrumbs inside view.

data/spec/integration/crumbs_routing_spec.rb

@@ -22,7 +22,7 @@ describe "crumbs routing" do
       end
     end
 
-    it 'should' do
+    it 'should inherit and add new action specific breadcrumb' do
       visit new_post_path
       within '#breadcrumbs' do
         page.should have_content 'All Posts'
@@ -30,4 +30,14 @@ describe "crumbs routing" do
       end
     end
   end
+
+  context 'adding breadcrumbs within view' do
+    it 'should append view specified breadcrumb' do
+      visit posts_path
+      within '#breadcrumbs' do
+        page.should have_content 'All Posts'
+        page.should have_content 'View Post'
+      end
+    end
+  end
 end

data/spec/loaf/controller_extensions_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+describe Loaf::ControllerExtensions do
+
+  class Controller
+    def self.helper_method(*args); end
+    include Loaf::ControllerExtensions
+  end
+
+  let(:name) { stub }
+  let(:url) { stub }
+  let(:options) { stub }
+
+  context 'classes extending controller_extensions' do
+    subject { Controller }
+    specify { should respond_to(:add_breadcrumb) }
+    specify { subject.new.should respond_to(:add_breadcrumb) }
+    specify { subject.new.should respond_to(:add_breadcrumbs) }
+    specify { subject.new.should respond_to(:clear_breadcrumbs) }
+  end
+
+  context 'class methods' do
+    let(:controller) { Controller }
+    let(:instance) { Class.new(Controller) }
+
+    it 'invokes before_filter' do
+      controller.should_receive(:before_filter)
+      controller.add_breadcrumb('name', 'url_path')
+    end
+
+    it 'delegates to instance' do
+      controller.stub(:before_filter).and_yield instance
+      instance.should_receive(:send).with(:add_breadcrumb, name, url, options)
+      controller.add_breadcrumb(name, url, options)
+    end
+  end
+
+  context 'instance methods' do
+    let(:controller) { Controller }
+    let(:instance) { Controller.new }
+
+    it 'instantiates breadcrumbs container' do
+      Loaf::Crumb.should_receive(:new).with(name, url)
+      instance.add_breadcrumb(name,url)
+    end
+
+    it 'adds breadcrumb to collection' do
+      expect do
+        instance.add_breadcrumb(name, url)
+      end.to change { instance._breadcrumbs.size }.by(1)
+    end
+  end
+end # Loaf::ControllerExtensions

data/spec/rails_app/app/views/posts/index.html.erb

@@ -1 +1,3 @@
+<% add_breadcrumb 'View Post', :posts_path %>
+
 <h1>Posts:index</h1>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: loaf
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-18 00:00:00.000000000 Z
+date: 2012-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2152648740 !ruby/object:Gem::Requirement
+  requirement: &2152603000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152648740
+  version_requirements: *2152603000
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2152647200 !ruby/object:Gem::Requirement
+  requirement: &2152602060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '3.1'
   type: :development
   prerelease: false
-  version_requirements: *2152647200
+  version_requirements: *2152602060
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2152646320 !ruby/object:Gem::Requirement
+  requirement: &2152600360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152646320
+  version_requirements: *2152600360
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &2152644360 !ruby/object:Gem::Requirement
+  requirement: &2152598720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152644360
+  version_requirements: *2152598720
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &2152642680 !ruby/object:Gem::Requirement
+  requirement: &2152595720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152642680
+  version_requirements: *2152595720
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2152641740 !ruby/object:Gem::Requirement
+  requirement: &2152594960 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,7 +76,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152641740
+  version_requirements: *2152594960
 description: Loaf helps you manage breadcrumbs in your rails app. It aims to handle
   crumb data through easy dsl and expose it through view helpers without any assumptions
   about markup.
@@ -112,6 +112,7 @@ files:
 - spec/integration/configuration_spec.rb
 - spec/integration/crumbs_routing_spec.rb
 - spec/integration/nested_crumbs_spec.rb
+- spec/loaf/controller_extensions_spec.rb
 - spec/loaf/crumb_formatter_spec.rb
 - spec/loaf/translation_spec.rb
 - spec/loaf_spec.rb
@@ -188,6 +189,7 @@ test_files:
 - spec/integration/configuration_spec.rb
 - spec/integration/crumbs_routing_spec.rb
 - spec/integration/nested_crumbs_spec.rb
+- spec/loaf/controller_extensions_spec.rb
 - spec/loaf/crumb_formatter_spec.rb
 - spec/loaf/translation_spec.rb
 - spec/loaf_spec.rb