llm_meta_client 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 95bb1f421088cc0c287b4f79e961455a1a5275b860b372fb23523ddc8781d37a
-  data.tar.gz: d4f92a150de0d9996d3ea6c54e69fe24989763f4bd359ce46a6b7ff69d36ecb7
+  metadata.gz: 5dde8e658e36a04b651c91bfcbd34d23b639449c4781529cd5c061e49e52cc53
+  data.tar.gz: 56d464e06df9afb9a92ef5dcafee8d806158fb1c333dc5a44800a1737095e68b
 SHA512:
-  metadata.gz: 480919bad702190fec4166d8a2659121ff62b1880123e6db168d9a1c8a8b7f80f23ca175e2e6f4a31b96e6bde97fd0723d95caa71439845a5017c351c18e373e
-  data.tar.gz: c2600201eccae124c9929eabcd8b7d755b7dbac4092cd5441c55d1caf79c839af8f0b41b49d7bf1c2e6a324e33c6bd1957d29a1ac3e837a7ab6924d727e8ae91
+  metadata.gz: 3a5442c238211a0432a26e54cd7923c1782d11178679a694cb2ac60ddb3bbd02365431bf0bbba61c9f505e65d1c3b8f60303a23dbb4752813fda580bfb997a4f
+  data.tar.gz: 955f0bb38816e24504041962e6b2a4cd9531ea89ad805c503624de927c9339383276c146dad1b346f64521f0cd3dfed985d2b5707676efdad27e998eb3441f60

data/CHANGELOG.md

@@ -5,6 +5,23 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.2] - 2026-03-27
+
+### Added
+
+- Add client-side validation for Generation Settings JSON
+
+## [1.0.1] - 2026-03-25
+
+### Fixed
+
+- Fix: normalize Ollama llm_type in server resource options
+- Fix: update branch_from_uuid after LLM response
+
+### Changed
+
+- Refactor: move llm_uuid and model from Chat to PromptExecution
+
 ## [1.0.0] - 2026-03-25
 
 ### Changed

data/app/assets/stylesheets/llm_meta_client/generation_settings.css

@@ -62,6 +62,21 @@
   }
 }
 
+.generation-settings-json-input--invalid {
+  border-color: #ef4444;
+
+  &:focus {
+    border-color: #ef4444;
+    box-shadow: 0 0 0 3px rgba(239, 68, 68, 0.1);
+  }
+}
+
+.generation-settings-error {
+  font-size: 12px;
+  color: #ef4444;
+  margin-top: 4px;
+}
+
 .generation-settings-hint {
   font-size: 11px;
   color: #9ca3af;

data/lib/generators/llm_meta_client/scaffold/templates/app/javascript/controllers/chats_form_controller.js

@@ -13,7 +13,15 @@ export default class extends Controller {
   }
 
   // Handle form submission to show user message immediately
-  submit() {
+  submit(event) {
+    // Check generation settings validity before submitting
+    const gsController = this.#generationSettingsController()
+    if (gsController && !gsController.isValid) {
+      event.preventDefault()
+      gsController.validate()
+      return
+    }
+
     // Don't prevent default - let Turbo handle the form submission
     // Just add the user message to the DOM immediately
     const messageContent = this.promptTarget.value.trim()
@@ -64,6 +72,12 @@ export default class extends Controller {
     }
   }
 
+  #generationSettingsController() {
+    const el = this.element.querySelector('[data-controller*="generation-settings"]')
+    if (!el) return null
+    return this.application.getControllerForElementAndIdentifier(el, "generation-settings")
+  }
+
   #canSubmit() {
     // Text field and prompt field can be validated using HTML5's required attribute,
     // so we delegate to checkValidity() to utilize standard validation

data/lib/generators/llm_meta_client/scaffold/templates/app/javascript/controllers/generation_settings_controller.js

@@ -1,5 +1,7 @@
 import { Controller } from "@hotwired/stimulus"
 
+const ALLOWED_KEYS = ["temperature", "top_k", "top_p", "max_tokens", "repeat_penalty"]
+
 // Connects to data-controller="generation-settings"
 export default class extends Controller {
   static targets = [
@@ -7,6 +9,7 @@ export default class extends Controller {
     "toggleIcon",
     "panel",
     "jsonInput",
+    "error",
   ]
 
   connect() {
@@ -24,4 +27,72 @@ export default class extends Controller {
       this.toggleIconTarget.classList.toggle("bi-chevron-up", this.expanded)
     }
   }
+
+  validate() {
+    const input = this.jsonInputTarget.value.trim()
+
+    if (!input) {
+      this.#clearError()
+      return
+    }
+
+    let parsed
+    try {
+      parsed = JSON.parse(input)
+    } catch (e) {
+      this.#showError("Invalid JSON syntax")
+      return
+    }
+
+    if (typeof parsed !== "object" || Array.isArray(parsed) || parsed === null) {
+      this.#showError("Must be a JSON object (e.g. {\"temperature\": 0.7})")
+      return
+    }
+
+    const unknownKeys = Object.keys(parsed).filter(k => !ALLOWED_KEYS.includes(k))
+    if (unknownKeys.length > 0) {
+      this.#showError(`Unknown keys: ${unknownKeys.join(", ")}`)
+      return
+    }
+
+    const nonNumeric = Object.entries(parsed).filter(([, v]) => typeof v !== "number")
+    if (nonNumeric.length > 0) {
+      this.#showError(`Values must be numeric: ${nonNumeric.map(([k]) => k).join(", ")}`)
+      return
+    }
+
+    this.#clearError()
+  }
+
+  get isValid() {
+    if (!this.hasJsonInputTarget) return true
+    const input = this.jsonInputTarget.value.trim()
+    if (!input) return true
+
+    try {
+      const parsed = JSON.parse(input)
+      if (typeof parsed !== "object" || Array.isArray(parsed) || parsed === null) return false
+      if (Object.keys(parsed).some(k => !ALLOWED_KEYS.includes(k))) return false
+      if (Object.values(parsed).some(v => typeof v !== "number")) return false
+      return true
+    } catch {
+      return false
+    }
+  }
+
+  #showError(message) {
+    if (this.hasErrorTarget) {
+      this.errorTarget.textContent = message
+      this.errorTarget.style.display = "block"
+    }
+    this.jsonInputTarget.classList.add("generation-settings-json-input--invalid")
+  }
+
+  #clearError() {
+    if (this.hasErrorTarget) {
+      this.errorTarget.textContent = ""
+      this.errorTarget.style.display = "none"
+    }
+    this.jsonInputTarget.classList.remove("generation-settings-json-input--invalid")
+  }
 }

data/lib/generators/llm_meta_client/scaffold/templates/app/views/shared/_generation_settings_field.html.erb

@@ -20,7 +20,9 @@
               class="generation-settings-json-input"
               rows="8"
               placeholder='{"temperature": 0.7, "top_k": 40, "top_p": 0.9, "max_tokens": 4096, "repeat_penalty": 1.1}'
-              data-<%%= stimulus_controller %>-target="jsonInput"></textarea>
+              data-<%%= stimulus_controller %>-target="jsonInput"
+              data-action="input-><%%= stimulus_controller %>#validate"></textarea>
+    <div class="generation-settings-error" data-<%%= stimulus_controller %>-target="error" style="display: none;"></div>
     <div class="generation-settings-hint">
       Available keys: temperature, top_k, top_p, max_tokens, repeat_penalty
     </div>

data/lib/llm_meta_client/version.rb

@@ -1,3 +1,3 @@
 module LlmMetaClient
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: llm_meta_client
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - dhq_boiler