live_record 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd7810b1566eda128b77c0d451fedf5056c006b1
-  data.tar.gz: ac200f664f84fb987e563a6dbbed7b186fdcf5f1
+  metadata.gz: 941011b728166d7c1dc7853bcf5f1fc0b02d77da
+  data.tar.gz: ae38164516a9cb42fe726350ca1e816d34f727b7
 SHA512:
-  metadata.gz: 181ef9c74581d40fb9e4cd9f9992f25dc798370467fc93c67b6934e305c02a463390fc505210b04dc68c1a2efd2a92f32e5586d828978af897ae1eaf958ac0f5
-  data.tar.gz: d6c549d59bad9e84abc80d734abc39c093dd62fd673886abe8c98953ade0c5d66d327c8dc75aecd9b371573bb3f81ae0d1321232d86176f14912678d8e5fbc32
+  metadata.gz: 65e3f6082c3b48bd2ce8f96d2c05eeefcbba020dba309229baae94926a8c5df916a3d59e9551fb32dc0ce9a557952fa2303f9363bb6c6b058411d5a2130950e5
+  data.tar.gz: 456403469aa4f8b2c53e374e2cd621a13f9b45a20b1f317381e6d98d2e7c83cb1e0b6c9374215500ab7f62a05a80779dcdbafdfb27a75c7837db5f75a8ada012

data/README.md

@@ -117,7 +117,7 @@
 1. Add the following to your `Gemfile`:
 
     ```ruby
-    gem 'live_record', '~> 0.2.4'
+    gem 'live_record', '~> 0.2.5'
     ```
 
 2. Run:
@@ -284,7 +284,7 @@
         * `"forbidden"` - Current User is not authorized to sync record changes. Happens when Model's `live_record_whitelisted_attributes` method returns empty array.
         * `"bad_request"` - Happens when `LiveRecord.Model.create({modelName: 'INCORRECTMODELNAME'})`
 
-8. Load the records into the JS Model-store through JSON REST (i.e.):
+8. Load the records into the JS Model-store:
 
     * Any record created/loaded in the JS-store is automatically synced whenever it is updated from the backend
     * When reconnected after losing connection, the records in the store are synced automatically.
@@ -610,6 +610,8 @@
 * MIT
 
 ## Changelog
+* 0.2.5
+  * fixed a major bug where same-model record instances were all sharing the same `@_callbacks` object, which then effectively calling also callbacks not specifically defined just for a specific record instance.
 * 0.2.4
   * you can now pass in `{reload: true}` to `subscribe()` like the folowing:
     * `MODEL.subscribe({reload: true})` to immediately load all records from backend, and not just the new ones

data/app/assets/javascripts/live_record/model/create.coffee

@@ -11,6 +11,19 @@ LiveRecord.Model.create = (config) ->
       if Model.prototype[attribute_key] == undefined
         Model.prototype[attribute_key] = ->
           @attributes[attribute_key]
+
+    @_callbacks = {
+      'on:connect': [],
+      'on:disconnect': [],
+      'on:responseError': [],
+      'before:create': [],
+      'after:create': [],
+      'before:update': [],
+      'after:update': [],
+      'before:destroy': [],
+      'after:destroy': []
+    }
+
     this
 
   Model.modelName = config.modelName
@@ -248,18 +261,6 @@ LiveRecord.Model.create = (config) ->
     'after:destroy': []
   }
 
-  Model.prototype._callbacks = {
-    'on:connect': [],
-    'on:disconnect': [],
-    'on:responseError': [],
-    'before:create': [],
-    'after:create': [],
-    'before:update': [],
-    'after:update': [],
-    'before:destroy': [],
-    'after:destroy': []
-  }
-
   # adding new callbackd to the list
   Model.prototype.addCallback = Model.addCallback = (callbackKey, callbackFunction) ->
     index = @_callbacks[callbackKey].indexOf(callbackFunction)

data/lib/live_record/version.rb

@@ -1,3 +1,3 @@
 module LiveRecord
-  VERSION = '0.2.4'.freeze
+  VERSION = '0.2.5'.freeze
 end

data/spec/features/live_record_syncing_spec.rb

@@ -215,5 +215,22 @@ RSpec.feature 'LiveRecord Syncing', type: :feature do
       wait before: -> { evaluate_script("LiveRecord.Model.all.Post.all[#{post_created_before_disconnection.id}] == undefined") }, becomes: -> (value) { value == false }
       expect(evaluate_script("LiveRecord.Model.all.Post.all[#{post_created_before_disconnection.id}] == undefined")).to be true
     end
+
+    scenario 'JS-Client should not have shared callbacks for those callbacks defined only for a particular post record', js: true do
+      visit '/posts'
+
+      wait before: -> { evaluate_script("Object.keys( LiveRecord.Model.all.Post.all ).length") }, becomes: -> (value) { value == posts.count }, duration: 10.seconds
+      expect(evaluate_script("Object.keys( LiveRecord.Model.all.Post.all ).length")).to be posts.count
+
+      execute_script(
+        <<-eos
+        var post1 = LiveRecord.Model.all.Post.all[#{post1.id}];
+        var someCallbackFunction = function() {};
+        post1.addCallback('after:create', someCallbackFunction);
+        eos
+      )
+
+      expect(evaluate_script("LiveRecord.Model.all.Post.all[#{post2.id}]._callbacks['after:create'].length")).to eq 0
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: live_record
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Jules Roman B. Polidario
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-09 00:00:00.000000000 Z
+date: 2017-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails