litestack 0.3.0 → 0.4.2

data/lib/sequel/adapters/shared/litedb.rb

@@ -1,7 +1,7 @@
 # frozen-string-literal: true
 
-require_relative '../utils/replace'
-require_relative '../utils/unmodified_identifiers'
+require_relative "../utils/replace"
+require_relative "../utils/unmodified_identifiers"
 
 module Sequel
   module Litedb
@@ -17,7 +17,7 @@ module Sequel
         singleton_class.send(:private, :schema_parse_table)
       end
     end
-    
+
     # No matter how you connect to SQLite, the following Database options
     # can be used to set PRAGMAs on connections in a thread-safe manner:
     # :auto_vacuum, :foreign_keys, :synchronous, and :temp_store.
@@ -28,10 +28,10 @@ module Sequel
       SYNCHRONOUS = [:off, :normal, :full].freeze
       TEMP_STORE = [:default, :file, :memory].freeze
       TRANSACTION_MODE = {
-        :deferred => "BEGIN DEFERRED TRANSACTION".freeze,
-        :immediate => "BEGIN IMMEDIATE TRANSACTION".freeze,
-        :exclusive => "BEGIN EXCLUSIVE TRANSACTION".freeze,
-        nil => "BEGIN".freeze
+        :deferred => "BEGIN DEFERRED TRANSACTION",
+        :immediate => "BEGIN IMMEDIATE TRANSACTION",
+        :exclusive => "BEGIN EXCLUSIVE TRANSACTION",
+        nil => "BEGIN"
       }.freeze
 
       # Whether to use integers for booleans in the database.  SQLite recommends
@@ -58,7 +58,7 @@ module Sequel
       def database_type
         :litedb
       end
-      
+
       # Set the integer_booleans option using the passed in :integer_boolean option.
       def set_integer_booleans
         @integer_booleans = @opts.has_key?(:integer_booleans) ? typecast_value_boolean(@opts[:integer_booleans]) : true
@@ -66,15 +66,15 @@ module Sequel
 
       # Return the array of foreign key info hashes using the foreign_key_list PRAGMA,
       # including information for the :on_update and :on_delete entries.
-      def foreign_key_list(table, opts=OPTS)
+      def foreign_key_list(table, opts = OPTS)
         m = output_identifier_meth
         h = {}
         _foreign_key_list_ds(table).each do |row|
-          if r = h[row[:id]]
+          if (r = h[row[:id]])
             r[:columns] << m.call(row[:from])
             r[:key] << m.call(row[:to]) if r[:key]
           else
-            h[row[:id]] = {:columns=>[m.call(row[:from])], :table=>m.call(row[:table]), :key=>([m.call(row[:to])] if row[:to]), :on_update=>on_delete_sql_to_sym(row[:on_update]), :on_delete=>on_delete_sql_to_sym(row[:on_delete])}
+            h[row[:id]] = {columns: [m.call(row[:from])], table: m.call(row[:table]), key: ([m.call(row[:to])] if row[:to]), on_update: on_delete_sql_to_sym(row[:on_update]), on_delete: on_delete_sql_to_sym(row[:on_delete])}
           end
         end
         h.values
@@ -87,7 +87,7 @@ module Sequel
       end
 
       # Use the index_list and index_info PRAGMAs to determine the indexes on the table.
-      def indexes(table, opts=OPTS)
+      def indexes(table, opts = OPTS)
         m = output_identifier_meth
         im = input_identifier_meth
         indexes = {}
@@ -95,20 +95,20 @@ module Sequel
         metadata_dataset.with_sql("PRAGMA index_list(?)", im.call(table)).each do |r|
           if opts[:only_autocreated]
             # If specifically asked for only autocreated indexes, then return those an only those
-            next unless r[:name] =~ /\Asqlite_autoindex_/
+            next unless r[:name].start_with?("sqlite_autoindex_")
           elsif r.has_key?(:origin)
             # If origin is set, then only exclude primary key indexes and partial indexes
-            next if r[:origin] == 'pk'
+            next if r[:origin] == "pk"
             next if r[:partial].to_i == 1
-          else
-            # When :origin key not present, assume any autoindex could be a primary key one and exclude it
-            next if r[:name] =~ /\Asqlite_autoindex_/
+          elsif r[:name].start_with?("sqlite_autoindex_")
+            next
           end
+          # When :origin key not present, assume any autoindex could be a primary key one and exclude it
 
-          indexes[m.call(r[:name])] = {:unique=>r[:unique].to_i==1}
+          indexes[m.call(r[:name])] = {unique: r[:unique].to_i == 1}
         end
         indexes.each do |k, v|
-          v[:columns] = metadata_dataset.with_sql("PRAGMA index_info(?)", im.call(k)).map(:name).map{|x| m.call(x)}
+          v[:columns] = metadata_dataset.with_sql("PRAGMA index_info(?)", im.call(k)).map(:name).map { |x| m.call(x) }
         end
         indexes
       end
@@ -118,18 +118,18 @@ module Sequel
       def sqlite_version
         return @sqlite_version if defined?(@sqlite_version)
         @sqlite_version = begin
-          v = fetch('SELECT sqlite_version()').single_value
-          [10000, 100, 1].zip(v.split('.')).inject(0){|a, m| a + m[0] * Integer(m[1])}
+          v = fetch("SELECT sqlite_version()").single_value
+          [10000, 100, 1].zip(v.split(".")).inject(0) { |a, m| a + m[0] * Integer(m[1]) }
         rescue
           0
         end
       end
-      
+
       # SQLite supports CREATE TABLE IF NOT EXISTS syntax since 3.3.0.
       def supports_create_table_if_not_exists?
         sqlite_version >= 30300
       end
-      
+
       # SQLite 3.6.19+ supports deferrable foreign key constraints.
       def supports_deferrable_foreign_key_constraints?
         sqlite_version >= 30619
@@ -140,7 +140,7 @@ module Sequel
         sqlite_version >= 30800
       end
 
-      # SQLite 3.6.8+ supports savepoints. 
+      # SQLite 3.6.8+ supports savepoints.
       def supports_savepoints?
         sqlite_version >= 30608
       end
@@ -160,25 +160,25 @@ module Sequel
       #
       # Options:
       # :server :: Set the server to use.
-      def tables(opts=OPTS)
-        tables_and_views(Sequel.~(:name=>'sqlite_sequence') & {:type => 'table'}, opts)
+      def tables(opts = OPTS)
+        tables_and_views(Sequel.~(name: "sqlite_sequence") & {type: "table"}, opts)
       end
-      
+
       # Creates a dataset that uses the VALUES clause:
       #
       #   DB.values([[1, 2], [3, 4]])
       #   # VALUES ((1, 2), (3, 4))
       def values(v)
         raise Error, "Cannot provide an empty array for values" if v.empty?
-        @default_dataset.clone(:values=>v)
+        @default_dataset.clone(values: v)
       end
 
       # Array of symbols specifying the view names in the current database.
       #
       # Options:
       # :server :: Set the server to use.
-      def views(opts=OPTS)
-        tables_and_views({:type => 'view'}, opts)
+      def views(opts = OPTS)
+        tables_and_views({type: "view"}, opts)
       end
 
       private
@@ -190,7 +190,7 @@ module Sequel
 
       # Dataset used for parsing schema
       def _parse_pragma_ds(table_name, opts)
-        metadata_dataset.with_sql("PRAGMA table_#{'x' if sqlite_version > 33100}info(?)", input_identifier_meth(opts[:dataset]).call(table_name))
+        metadata_dataset.with_sql("PRAGMA table_#{"x" if sqlite_version > 33100}info(?)", input_identifier_meth(opts[:dataset]).call(table_name))
       end
 
       # Run all alter_table commands in a transaction.  This is technically only
@@ -201,20 +201,20 @@ module Sequel
           run "PRAGMA foreign_keys = 0"
           run "PRAGMA legacy_alter_table = 1" if sqlite_version >= 32600
         end
-        transaction do 
-          if ops.length > 1 && ops.all?{|op| op[:op] == :add_constraint || op[:op] == :set_column_null}
-            null_ops, ops = ops.partition{|op| op[:op] == :set_column_null}
+        transaction do
+          if ops.length > 1 && ops.all? { |op| op[:op] == :add_constraint || op[:op] == :set_column_null }
+            null_ops, ops = ops.partition { |op| op[:op] == :set_column_null }
 
             # Apply NULL/NOT NULL ops first, since those should be purely idependent of the constraints.
-            null_ops.each{|op| alter_table_sql_list(table, [op]).flatten.each{|sql| execute_ddl(sql)}}
+            null_ops.each { |op| alter_table_sql_list(table, [op]).flatten.each { |sql| execute_ddl(sql) } }
 
             # If you are just doing constraints, apply all of them at the same time,
             # as otherwise all but the last one get lost.
-            alter_table_sql_list(table, [{:op=>:add_constraints, :ops=>ops}]).flatten.each{|sql| execute_ddl(sql)}
+            alter_table_sql_list(table, [{op: :add_constraints, ops: ops}]).flatten.each { |sql| execute_ddl(sql) }
           else
             # Run each operation separately, as later operations may depend on the
             # results of earlier operations.
-            ops.each{|op| alter_table_sql_list(table, [op]).flatten.each{|sql| execute_ddl(sql)}}
+            ops.each { |op| alter_table_sql_list(table, [op]).flatten.each { |sql| execute_ddl(sql) } }
           end
         end
         remove_cached_schema(table)
@@ -235,7 +235,7 @@ module Sequel
           super
         when :add_column
           if op[:unique] || op[:primary_key]
-            duplicate_table(table){|columns| columns.push(op)}
+            duplicate_table(table) { |columns| columns.push(op) }
           else
             super
           end
@@ -243,22 +243,22 @@ module Sequel
           if sqlite_version >= 33500
             super
           else
-            ocp = lambda{|oc| oc.delete_if{|c| c.to_s == op[:name].to_s}}
-            duplicate_table(table, :old_columns_proc=>ocp){|columns| columns.delete_if{|s| s[:name].to_s == op[:name].to_s}}
+            ocp = lambda { |oc| oc.delete_if { |c| c.to_s == op[:name].to_s } }
+            duplicate_table(table, old_columns_proc: ocp) { |columns| columns.delete_if { |s| s[:name].to_s == op[:name].to_s } }
           end
         when :rename_column
           if sqlite_version >= 32500
             super
           else
-            ncp = lambda{|nc| nc.map!{|c| c.to_s == op[:name].to_s ? op[:new_name] : c}}
-            duplicate_table(table, :new_columns_proc=>ncp){|columns| columns.each{|s| s[:name] = op[:new_name] if s[:name].to_s == op[:name].to_s}}
+            ncp = lambda { |nc| nc.map! { |c| (c.to_s == op[:name].to_s) ? op[:new_name] : c } }
+            duplicate_table(table, new_columns_proc: ncp) { |columns| columns.each { |s| s[:name] = op[:new_name] if s[:name].to_s == op[:name].to_s } }
           end
         when :set_column_default
-          duplicate_table(table){|columns| columns.each{|s| s[:default] = op[:default] if s[:name].to_s == op[:name].to_s}}
+          duplicate_table(table) { |columns| columns.each { |s| s[:default] = op[:default] if s[:name].to_s == op[:name].to_s } }
         when :set_column_null
-          duplicate_table(table){|columns| columns.each{|s| s[:null] = op[:null] if s[:name].to_s == op[:name].to_s}}
+          duplicate_table(table) { |columns| columns.each { |s| s[:null] = op[:null] if s[:name].to_s == op[:name].to_s } }
         when :set_column_type
-          duplicate_table(table){|columns| columns.each{|s| s.merge!(op) if s[:name].to_s == op[:name].to_s}}
+          duplicate_table(table) { |columns| columns.each { |s| s.merge!(op) if s[:name].to_s == op[:name].to_s } }
         when :drop_constraint
           case op[:type]
           when :primary_key
@@ -270,19 +270,19 @@ module Sequel
             end
           when :foreign_key
             if op[:columns]
-              duplicate_table(table, :skip_foreign_key_columns=>op[:columns])
+              duplicate_table(table, skip_foreign_key_columns: op[:columns])
             else
-              duplicate_table(table, :no_foreign_keys=>true)
+              duplicate_table(table, no_foreign_keys: true)
             end
           when :unique
-            duplicate_table(table, :no_unique=>true)
+            duplicate_table(table, no_unique: true)
           else
             duplicate_table(table)
           end
         when :add_constraint
-          duplicate_table(table, :constraints=>[op])
+          duplicate_table(table, constraints: [op])
         when :add_constraints
-          duplicate_table(table, :constraints=>op[:ops])
+          duplicate_table(table, constraints: op[:ops])
         else
           raise Error, "Unsupported ALTER TABLE operation: #{op[:op].inspect}"
         end
@@ -296,9 +296,9 @@ module Sequel
       end
 
       # A name to use for the backup table
-      def backup_table_name(table, opts=OPTS)
-        table = table.gsub('`', '')
-        (opts[:times]||1000).times do |i|
+      def backup_table_name(table, opts = OPTS)
+        table = table.delete("`")
+        (opts[:times] || 1000).times do |i|
           table_name = "#{table}_backup#{i}"
           return table_name unless table_exists?(table_name)
         end
@@ -320,12 +320,12 @@ module Sequel
           sql << " GENERATED ALWAYS AS (#{literal(generated)}) #{generated_type}"
         end
       end
-    
+
       # SQLite does not restrict the integer or decimal type to a specific range.
       def column_schema_integer_min_max_values(column)
         nil
       end
-      alias column_schema_decimal_min_max_values column_schema_integer_min_max_values
+      alias_method :column_schema_decimal_min_max_values, :column_schema_integer_min_max_values
 
       # Array of PRAGMA SQL statements based on the Database options that should be applied to
       # new connections.
@@ -336,8 +336,8 @@ module Sequel
         v = typecast_value_boolean(opts.fetch(:case_sensitive_like, 1))
         ps << "PRAGMA case_sensitive_like = #{v ? 1 : 0}"
         [[:auto_vacuum, AUTO_VACUUM], [:synchronous, SYNCHRONOUS], [:temp_store, TEMP_STORE]].each do |prag, con|
-          if v = opts[prag]
-            raise(Error, "Value for PRAGMA #{prag} not supported, should be one of #{con.join(', ')}") unless v = con.index(v.to_sym)
+          if (v = opts[prag])
+            raise(Error, "Value for PRAGMA #{prag} not supported, should be one of #{con.join(", ")}") unless (v = con.index(v.to_sym))
             ps << "PRAGMA #{prag} = #{v}"
           end
         end
@@ -346,12 +346,12 @@ module Sequel
 
       # Support creating STRICT tables via :strict option
       def create_table_sql(name, generator, options)
-        "#{super}#{' STRICT' if options[:strict]}"
+        "#{super}#{" STRICT" if options[:strict]}"
       end
 
       # SQLite support creating temporary views.
       def create_view_prefix_sql(name, options)
-        create_view_sql_append_columns("CREATE #{'TEMPORARY 'if options[:temp]}VIEW #{quote_schema_table(name)}", options[:columns])
+        create_view_sql_append_columns("CREATE #{"TEMPORARY " if options[:temp]}VIEW #{quote_schema_table(name)}", options[:columns])
       end
 
       DATABASE_ERROR_REGEXPS = {
@@ -401,20 +401,20 @@ module Sequel
       # Duplicate an existing table by creating a new table, copying all records
       # from the existing table into the new table, deleting the existing table
       # and renaming the new table to the existing table's name.
-      def duplicate_table(table, opts=OPTS)
+      def duplicate_table(table, opts = OPTS)
         remove_cached_schema(table)
         def_columns = defined_columns_for(table)
-        old_columns = def_columns.map{|c| c[:name]}
-        opts[:old_columns_proc].call(old_columns) if opts[:old_columns_proc]
+        old_columns = def_columns.map { |c| c[:name] }
+        opts[:old_columns_proc]&.call(old_columns)
 
         yield def_columns if defined?(yield)
 
         constraints = (opts[:constraints] || []).dup
         pks = []
-        def_columns.each{|c| pks << c[:name] if c[:primary_key]}
+        def_columns.each { |c| pks << c[:name] if c[:primary_key] }
         if pks.length > 1
-          constraints << {:type=>:primary_key, :columns=>pks}
-          def_columns.each{|c| c[:primary_key] = false if c[:primary_key]}
+          constraints << {type: :primary_key, columns: pks}
+          def_columns.each { |c| c[:primary_key] = false if c[:primary_key] }
         end
 
         # If dropping a foreign key constraint, drop all foreign key constraints,
@@ -424,56 +424,56 @@ module Sequel
 
           # If dropping a column, if there is a foreign key with that
           # column, don't include it when building a copy of the table.
-          if ocp = opts[:old_columns_proc]
-            fks.delete_if{|c| ocp.call(c[:columns].dup) != c[:columns]}
+          if (ocp = opts[:old_columns_proc])
+            fks.delete_if { |c| ocp.call(c[:columns].dup) != c[:columns] }
           end
-          
+
           # Skip any foreign key columns where a constraint for those
           # foreign keys is being dropped.
-          if sfkc = opts[:skip_foreign_key_columns]
-            fks.delete_if{|c| c[:columns] == sfkc}
+          if (sfkc = opts[:skip_foreign_key_columns])
+            fks.delete_if { |c| c[:columns] == sfkc }
           end
 
-          constraints.concat(fks.each{|h| h[:type] = :foreign_key})
+          constraints.concat(fks.each { |h| h[:type] = :foreign_key })
         end
 
         # Determine unique constraints and make sure the new columns have them
         unique_columns = []
         skip_indexes = []
-        indexes(table, :only_autocreated=>true).each do |name, h|
+        indexes(table, only_autocreated: true).each do |name, h|
           skip_indexes << name
           if h[:unique] && !opts[:no_unique]
             if h[:columns].length == 1
               unique_columns.concat(h[:columns])
             elsif h[:columns].map(&:to_s) != pks
-              constraints << {:type=>:unique, :columns=>h[:columns]}
+              constraints << {type: :unique, columns: h[:columns]}
             end
           end
         end
         unique_columns -= pks
         unless unique_columns.empty?
-          unique_columns.map!{|c| quote_identifier(c)}
+          unique_columns.map! { |c| quote_identifier(c) }
           def_columns.each do |c|
             c[:unique] = true if unique_columns.include?(quote_identifier(c[:name])) && c[:unique] != false
           end
         end
-        
-        def_columns_str = (def_columns.map{|c| column_definition_sql(c)} + constraints.map{|c| constraint_definition_sql(c)}).join(', ')
+
+        def_columns_str = (def_columns.map { |c| column_definition_sql(c) } + constraints.map { |c| constraint_definition_sql(c) }).join(", ")
         new_columns = old_columns.dup
-        opts[:new_columns_proc].call(new_columns) if opts[:new_columns_proc]
+        opts[:new_columns_proc]&.call(new_columns)
 
         qt = quote_schema_table(table)
         bt = quote_identifier(backup_table_name(qt))
         a = [
-           "ALTER TABLE #{qt} RENAME TO #{bt}",
-           "CREATE TABLE #{qt}(#{def_columns_str})",
-           "INSERT INTO #{qt}(#{dataset.send(:identifier_list, new_columns)}) SELECT #{dataset.send(:identifier_list, old_columns)} FROM #{bt}",
-           "DROP TABLE #{bt}"
+          "ALTER TABLE #{qt} RENAME TO #{bt}",
+          "CREATE TABLE #{qt}(#{def_columns_str})",
+          "INSERT INTO #{qt}(#{dataset.send(:identifier_list, new_columns)}) SELECT #{dataset.send(:identifier_list, old_columns)} FROM #{bt}",
+          "DROP TABLE #{bt}"
         ]
         indexes(table).each do |name, h|
           next if skip_indexes.include?(name)
           if (h[:columns].map(&:to_s) - new_columns).empty?
-            a << alter_table_sql(table, h.merge(:op=>:add_index, :name=>name))
+            a << alter_table_sql(table, h.merge(op: :add_index, name: name))
           end
         end
         a
@@ -483,15 +483,15 @@ module Sequel
       # to symbols +:set_null+.
       def on_delete_sql_to_sym(str)
         case str
-        when 'RESTRICT'
+        when "RESTRICT"
           :restrict
-        when 'CASCADE'
+        when "CASCADE"
           :cascade
-        when 'SET NULL'
+        when "SET NULL"
           :set_null
-        when 'SET DEFAULT'
+        when "SET DEFAULT"
           :set_default
-        when 'NO ACTION'
+        when "NO ACTION"
           :no_action
         end
       end
@@ -503,23 +503,23 @@ module Sequel
           if sqlite_version > 33100
             # table_xinfo PRAGMA used, remove hidden columns
             # that are not generated columns
-            if row[:generated] = (row.delete(:hidden) != 0)
-              next unless row[:type].end_with?(' GENERATED ALWAYS')
-              row[:type] = row[:type].sub(' GENERATED ALWAYS', '')
+            if row[:generated] == (row.delete(:hidden) != 0)
+              next unless row[:type].end_with?(" GENERATED ALWAYS")
+              row[:type] = row[:type].sub(" GENERATED ALWAYS", "")
             end
           end
 
           row.delete(:cid)
           row[:allow_null] = row.delete(:notnull).to_i == 0
           row[:default] = row.delete(:dflt_value)
-          row[:default] = nil if blank_object?(row[:default]) || row[:default] == 'NULL'
+          row[:default] = nil if blank_object?(row[:default]) || row[:default] == "NULL"
           row[:db_type] = row.delete(:type)
-          if row[:primary_key] = row.delete(:pk).to_i > 0
+          if row[:primary_key] == row.delete(:pk).to_i > 0
             pks += 1
             # Guess that an integer primary key uses auto increment,
             # since that is Sequel's default and SQLite does not provide
             # a way to introspect whether it is actually autoincrementing.
-            row[:auto_increment] = row[:db_type].downcase == 'integer'
+            row[:auto_increment] = row[:db_type].downcase == "integer"
           end
           row[:type] = schema_column_type(row[:db_type])
           row
@@ -531,12 +531,12 @@ module Sequel
           # SQLite does not allow use of auto increment for tables
           # with composite primary keys, so remove auto_increment
           # if composite primary keys are detected.
-          sch.each{|r| r.delete(:auto_increment)}
+          sch.each { |r| r.delete(:auto_increment) }
         end
 
         sch
       end
-      
+
       # SQLite supports schema parsing using the table_info PRAGMA, so
       # parse the output of that into the format Sequel expects.
       def schema_parse_table(table_name, opts)
@@ -545,7 +545,7 @@ module Sequel
           [m.call(row.delete(:name)), row]
         end
       end
-      
+
       # Don't support SQLite error codes for exceptions by default.
       def sqlite_error_code(exception)
         nil
@@ -554,7 +554,7 @@ module Sequel
       # Backbone of the tables and views support.
       def tables_and_views(filter, opts)
         m = output_identifier_meth
-        metadata_dataset.from(:sqlite_master).server(opts[:server]).where(filter).map{|r| m.call(r[:name])}
+        metadata_dataset.from(:sqlite_master).server(opts[:server]).where(filter).map { |r| m.call(r[:name]) }
       end
 
       # SQLite only supports AUTOINCREMENT on integer columns, not
@@ -564,32 +564,32 @@ module Sequel
         column[:auto_increment] ? :integer : super
       end
     end
-    
+
     module DatasetMethods
       include Dataset::Replace
       include UnmodifiedIdentifiers::DatasetMethods
 
       # The allowed values for insert_conflict
-      INSERT_CONFLICT_RESOLUTIONS = %w'ROLLBACK ABORT FAIL IGNORE REPLACE'.each(&:freeze).freeze
+      INSERT_CONFLICT_RESOLUTIONS = %w[ROLLBACK ABORT FAIL IGNORE REPLACE].each(&:freeze).freeze
 
-      CONSTANT_MAP = {:CURRENT_DATE=>"date(CURRENT_TIMESTAMP, 'localtime')".freeze, :CURRENT_TIMESTAMP=>"datetime(CURRENT_TIMESTAMP, 'localtime')".freeze, :CURRENT_TIME=>"time(CURRENT_TIMESTAMP, 'localtime')".freeze}.freeze
-      EXTRACT_MAP = {:year=>"'%Y'", :month=>"'%m'", :day=>"'%d'", :hour=>"'%H'", :minute=>"'%M'", :second=>"'%f'"}.freeze
+      CONSTANT_MAP = {CURRENT_DATE: "date(CURRENT_TIMESTAMP, 'localtime')", CURRENT_TIMESTAMP: "datetime(CURRENT_TIMESTAMP, 'localtime')", CURRENT_TIME: "time(CURRENT_TIMESTAMP, 'localtime')"}.freeze
+      EXTRACT_MAP = {year: "'%Y'", month: "'%m'", day: "'%d'", hour: "'%H'", minute: "'%M'", second: "'%f'"}.freeze
       EXTRACT_MAP.each_value(&:freeze)
 
-      Dataset.def_sql_method(self, :delete, [['if db.sqlite_version >= 33500', %w'with delete from where returning'], ['elsif db.sqlite_version >= 30803', %w'with delete from where'], ["else", %w'delete from where']])
-      Dataset.def_sql_method(self, :insert, [['if db.sqlite_version >= 33500', %w'with insert conflict into columns values on_conflict returning'], ['elsif db.sqlite_version >= 30803', %w'with insert conflict into columns values on_conflict'], ["else", %w'insert conflict into columns values']])
-      Dataset.def_sql_method(self, :select, [['if opts[:values]', %w'with values compounds'], ['else', %w'with select distinct columns from join where group having window compounds order limit lock']])
-      Dataset.def_sql_method(self, :update, [['if db.sqlite_version >= 33500', %w'with update table set from where returning'], ['elsif db.sqlite_version >= 33300', %w'with update table set from where'], ['elsif db.sqlite_version >= 30803', %w'with update table set where'], ["else", %w'update table set where']])
+      Dataset.def_sql_method(self, :delete, [["if db.sqlite_version >= 33500", %w[with delete from where returning]], ["elsif db.sqlite_version >= 30803", %w[with delete from where]], ["else", %w[delete from where]]])
+      Dataset.def_sql_method(self, :insert, [["if db.sqlite_version >= 33500", %w[with insert conflict into columns values on_conflict returning]], ["elsif db.sqlite_version >= 30803", %w[with insert conflict into columns values on_conflict]], ["else", %w[insert conflict into columns values]]])
+      Dataset.def_sql_method(self, :select, [["if opts[:values]", %w[with values compounds]], ["else", %w[with select distinct columns from join where group having window compounds order limit lock]]])
+      Dataset.def_sql_method(self, :update, [["if db.sqlite_version >= 33500", %w[with update table set from where returning]], ["elsif db.sqlite_version >= 33300", %w[with update table set from where]], ["elsif db.sqlite_version >= 30803", %w[with update table set where]], ["else", %w[update table set where]]])
 
       def cast_sql_append(sql, expr, type)
-        if type == Time or type == DateTime
+        if type == Time || type == DateTime
           sql << "datetime("
           literal_append(sql, expr)
-          sql << ')'
+          sql << ")"
         elsif type == Date
           sql << "date("
           literal_append(sql, expr)
-          sql << ')'
+          sql << ")"
         else
           super
         end
@@ -600,46 +600,46 @@ module Sequel
       def complex_expression_sql_append(sql, op, args)
         case op
         when :"NOT LIKE", :"NOT ILIKE"
-          sql << 'NOT '
-          complex_expression_sql_append(sql, (op == :"NOT ILIKE" ? :ILIKE : :LIKE), args)
+          sql << "NOT "
+          complex_expression_sql_append(sql, ((op == :"NOT ILIKE") ? :ILIKE : :LIKE), args)
         when :^
-          complex_expression_arg_pairs_append(sql, args){|a, b| Sequel.lit(["((~(", " & ", ")) & (", " | ", "))"], a, b, a, b)}
+          complex_expression_arg_pairs_append(sql, args) { |a, b| Sequel.lit(["((~(", " & ", ")) & (", " | ", "))"], a, b, a, b) }
         when :**
           unless (exp = args[1]).is_a?(Integer)
             raise(Sequel::Error, "can only emulate exponentiation on SQLite if exponent is an integer, given #{exp.inspect}")
           end
           case exp
           when 0
-            sql << '1'
+            sql << "1"
           else
-            sql << '('
+            sql << "("
             arg = args[0]
             if exp < 0
               invert = true
               exp = exp.abs
-              sql << '(1.0 / ('
+              sql << "(1.0 / ("
             end
-            (exp - 1).times do 
+            (exp - 1).times do
               literal_append(sql, arg)
               sql << " * "
             end
             literal_append(sql, arg)
-            sql << ')'
+            sql << ")"
             if invert
               sql << "))"
             end
           end
         when :extract
           part = args[0]
-          raise(Sequel::Error, "unsupported extract argument: #{part.inspect}") unless format = EXTRACT_MAP[part]
-          sql << "CAST(strftime(" << format << ', '
+          raise(Sequel::Error, "unsupported extract argument: #{part.inspect}") unless (format = EXTRACT_MAP[part])
+          sql << "CAST(strftime(" << format << ", "
           literal_append(sql, args[1])
-          sql << ') AS ' << (part == :second ? 'NUMERIC' : 'INTEGER') << ')'
+          sql << ") AS " << ((part == :second) ? "NUMERIC" : "INTEGER") << ")"
         else
           super
         end
       end
-      
+
       # SQLite has CURRENT_TIMESTAMP and related constants in UTC instead
       # of in localtime, so convert those constants to local time.
       def constant_sql_append(sql, constant)
@@ -649,14 +649,14 @@ module Sequel
           super
         end
       end
-      
+
       # SQLite performs a TRUNCATE style DELETE if no filter is specified.
       # Since we want to always return the count of records, add a condition
       # that is always true and then delete.
       def delete(&block)
-        @opts[:where] ? super : where(1=>1).delete(&block)
+        @opts[:where] ? super : where(1 => 1).delete(&block)
       end
-      
+
       # Always return false when using VALUES
       def empty?
         return false if @opts[:values]
@@ -666,21 +666,21 @@ module Sequel
       # Return an array of strings specifying a query explanation for a SELECT of the
       # current dataset. Currently, the options are ignored, but it accepts options
       # to be compatible with other adapters.
-      def explain(opts=nil)
+      def explain(opts = nil)
         # Load the PrettyTable class, needed for explain output
         Sequel.extension(:_pretty_table) unless defined?(Sequel::PrettyTable)
 
-        ds = db.send(:metadata_dataset).clone(:sql=>"EXPLAIN #{select_sql}")
+        ds = db.send(:metadata_dataset).clone(sql: "EXPLAIN #{select_sql}")
         rows = ds.all
         Sequel::PrettyTable.string(rows, ds.columns)
       end
-      
+
       # HAVING requires GROUP BY on SQLite
       def having(*cond)
         raise(InvalidOperation, "Can only specify a HAVING clause on a grouped dataset") if !@opts[:group] && db.sqlite_version < 33900
         super
       end
-      
+
       # Support insert select for associations, so that the model code can use
       # returning instead of a separate query.
       def insert_select(*values)
@@ -698,16 +698,16 @@ module Sequel
 
       # SQLite uses the nonstandard ` (backtick) for quoting identifiers.
       def quoted_identifier_append(sql, c)
-        sql << '`' << c.to_s.gsub('`', '``') << '`'
+        sql << "`" << c.to_s.gsub("`", "``") << "`"
       end
-      
+
       # When a qualified column is selected on SQLite and the qualifier
       # is a subselect, the column name used is the full qualified name
       # (including the qualifier) instead of just the column name.  To
       # get correct column names, you must use an alias.
       def select(*cols)
-        if ((f = @opts[:from]) && f.any?{|t| t.is_a?(Dataset) || (t.is_a?(SQL::AliasedExpression) && t.expression.is_a?(Dataset))}) || ((j = @opts[:join]) && j.any?{|t| t.table.is_a?(Dataset)})
-          super(*cols.map{|c| alias_qualified_column(c)})
+        if ((f = @opts[:from]) && f.any? { |t| t.is_a?(Dataset) || (t.is_a?(SQL::AliasedExpression) && t.expression.is_a?(Dataset)) }) || ((j = @opts[:join]) && j.any? { |t| t.table.is_a?(Dataset) })
+          super(*cols.map { |c| alias_qualified_column(c) })
         else
           super
         end
@@ -737,7 +737,7 @@ module Sequel
       #   DB[:table].insert_conflict({}).insert(a: 1, b: 2)
       #   # INSERT INTO TABLE (a, b) VALUES (1, 2)
       #   # ON CONFLICT DO NOTHING
-      #   
+      #
       #   DB[:table].insert_conflict(target: :a).insert(a: 1, b: 2)
       #   # INSERT INTO TABLE (a, b) VALUES (1, 2)
       #   # ON CONFLICT (a) DO NOTHING
@@ -745,11 +745,11 @@ module Sequel
       #   DB[:table].insert_conflict(target: :a, conflict_where: {c: true}).insert(a: 1, b: 2)
       #   # INSERT INTO TABLE (a, b) VALUES (1, 2)
       #   # ON CONFLICT (a) WHERE (c IS TRUE) DO NOTHING
-      #   
+      #
       #   DB[:table].insert_conflict(target: :a, update: {b: Sequel[:excluded][:b]}).insert(a: 1, b: 2)
       #   # INSERT INTO TABLE (a, b) VALUES (1, 2)
       #   # ON CONFLICT (a) DO UPDATE SET b = excluded.b
-      #   
+      #
       #   DB[:table].insert_conflict(target: :a,
       #     update: {b: Sequel[:excluded][:b]}, update_where: {Sequel[:table][:status_id] => 1}).insert(a: 1, b: 2)
       #   # INSERT INTO TABLE (a, b) VALUES (1, 2)
@@ -760,9 +760,9 @@ module Sequel
           unless INSERT_CONFLICT_RESOLUTIONS.include?(opts.to_s.upcase)
             raise Error, "Invalid symbol or string passed to Dataset#insert_conflict: #{opts.inspect}.  The allowed values are: :rollback, :abort, :fail, :ignore, or :replace"
           end
-          clone(:insert_conflict => opts)
+          clone(insert_conflict: opts)
         when Hash
-          clone(:insert_on_conflict => opts)
+          clone(insert_on_conflict: opts)
         else
           raise Error, "Invalid value passed to Dataset#insert_conflict: #{opts.inspect}, should use a symbol or a hash"
         end
@@ -781,11 +781,11 @@ module Sequel
       def returning(*values)
         return super if values.empty?
         raise Error, "RETURNING is not supported on #{db.database_type}" unless supports_returning?(:insert)
-        clone(:returning=>_returning_values(values).freeze)
+        clone(returning: _returning_values(values).freeze)
       end
 
       # SQLite 3.8.3+ supports common table expressions.
-      def supports_cte?(type=:select)
+      def supports_cte?(type = :select)
         db.sqlite_version >= 30803
       end
 
@@ -813,7 +813,7 @@ module Sequel
       def supports_is_true?
         false
       end
-      
+
       # SQLite 3.33.0 supports modifying joined datasets
       def supports_modifying_joins?
         db.sqlite_version >= 33300
@@ -823,7 +823,7 @@ module Sequel
       def supports_multiple_column_in?
         false
       end
-      
+
       # SQLite 3.35.0 supports RETURNING on INSERT/UPDATE/DELETE.
       def supports_returning?(_)
         db.sqlite_version >= 33500
@@ -845,7 +845,7 @@ module Sequel
       def supports_window_clause?
         db.sqlite_version >= 32800
       end
-      
+
       # SQLite 3.25+ supports window functions.  However, support is only enabled
       # on SQLite 3.26.0+ because internal Sequel usage of window functions
       # to implement eager loading of limited associations triggers
@@ -853,14 +853,14 @@ module Sequel
       def supports_window_functions?
         db.sqlite_version >= 32600
       end
-    
+
       # SQLite 3.28.0+ supports all window frame options that Sequel supports
       def supports_window_function_frame_option?(option)
-        db.sqlite_version >= 32800 ? true : super
+        (db.sqlite_version >= 32800) ? true : super
       end
 
       private
-      
+
       # Add aliases to symbols and identifiers to work around SQLite bug.
       def _returning_values(values)
         values.map do |v|
@@ -880,12 +880,12 @@ module Sequel
       def aggreate_dataset_use_from_self?
         super || @opts[:values]
       end
-      
+
       # SQLite uses string literals instead of identifiers in AS clauses.
-      def as_sql_append(sql, aliaz, column_aliases=nil)
+      def as_sql_append(sql, aliaz, column_aliases = nil)
         raise Error, "sqlite does not support derived column lists" if column_aliases
         aliaz = aliaz.value if aliaz.is_a?(SQL::Identifier)
-        sql << ' AS '
+        sql << " AS "
         literal_append(sql, aliaz.to_s)
       end
 
@@ -911,7 +911,7 @@ module Sequel
         raise(InvalidOperation, "Grouped datasets cannot be modified") if opts[:group]
         raise(InvalidOperation, "Joined datasets cannot be modified") if joined_dataset?
       end
-      alias check_delete_allowed! check_insert_allowed!
+      alias_method :check_delete_allowed!, :check_insert_allowed!
 
       # SQLite supports a maximum of 500 rows in a VALUES clause.
       def default_import_slice
@@ -920,37 +920,37 @@ module Sequel
 
       # SQL fragment specifying a list of identifiers
       def identifier_list(columns)
-        columns.map{|i| quote_identifier(i)}.join(', ')
+        columns.map { |i| quote_identifier(i) }.join(", ")
       end
-    
+
       # Add OR clauses to SQLite INSERT statements
       def insert_conflict_sql(sql)
-        if resolution = @opts[:insert_conflict]
+        if (resolution = @opts[:insert_conflict])
           sql << " OR " << resolution.to_s.upcase
         end
       end
 
       # Add ON CONFLICT clause if it should be used
       def insert_on_conflict_sql(sql)
-        if opts = @opts[:insert_on_conflict]
+        if (opts = @opts[:insert_on_conflict])
           sql << " ON CONFLICT"
 
-          if target = opts[:constraint] 
+          if (target = opts[:constraint])
             sql << " ON CONSTRAINT "
             identifier_append(sql, target)
-          elsif target = opts[:target]
-            sql << ' '
+          elsif (target = opts[:target])
+            sql << " "
             identifier_append(sql, Array(target))
-            if conflict_where = opts[:conflict_where]
+            if (conflict_where = opts[:conflict_where])
               sql << " WHERE "
               literal_append(sql, conflict_where)
             end
           end
 
-          if values = opts[:update]
+          if (values = opts[:update])
             sql << " DO UPDATE SET "
             update_sql_values_hash(sql, values)
-            if update_where = opts[:update_where]
+            if (update_where = opts[:update_where])
               sql << " WHERE "
               literal_append(sql, update_where)
             end
@@ -962,29 +962,29 @@ module Sequel
 
       # SQLite uses a preceding X for hex escaping strings
       def literal_blob_append(sql, v)
-        sql <<  "X'" << v.unpack("H*").first << "'"
+        sql << "X'" << v.unpack1("H*") << "'"
       end
 
       # Respect the database integer_booleans setting, using 0 or 'f'.
       def literal_false
-        @db.integer_booleans ? '0' : "'f'"
+        @db.integer_booleans ? "0" : "'f'"
       end
 
       # Respect the database integer_booleans setting, using 1 or 't'.
       def literal_true
-        @db.integer_booleans ? '1' : "'t'"
+        @db.integer_booleans ? "1" : "'t'"
       end
 
       # SQLite only supporting multiple rows in the VALUES clause
       # starting in 3.7.11.  On older versions, fallback to using a UNION.
       def multi_insert_sql_strategy
-        db.sqlite_version >= 30711 ? :values : :union
+        (db.sqlite_version >= 30711) ? :values : :union
       end
 
       # Emulate the char_length function with length
       def native_function_name(emulated_function)
         if emulated_function == :char_length
-          'length'
+          "length"
         else
           super
         end
@@ -1006,7 +1006,7 @@ module Sequel
         sql << " LIMIT -1 OFFSET "
         literal_append(sql, @opts[:offset])
       end
-  
+
       # Support VALUES clause instead of the SELECT clause to return rows.
       def select_values_sql(sql)
         sql << "VALUES "
@@ -1035,10 +1035,10 @@ module Sequel
 
       # Use FROM to specify additional tables in an update query
       def update_from_sql(sql)
-        if(from = @opts[:from][1..-1]).empty?
-          raise(Error, 'Need multiple FROM tables if updating/deleting a dataset with JOINs') if @opts[:join]
+        if (from = @opts[:from][1..]).empty?
+          raise(Error, "Need multiple FROM tables if updating/deleting a dataset with JOINs") if @opts[:join]
         else
-          sql << ' FROM '
+          sql << " FROM "
           source_list_append(sql, from)
           select_join_sql(sql)
         end
@@ -1046,7 +1046,7 @@ module Sequel
 
       # Only include the primary table in the main update clause
       def update_table_sql(sql)
-        sql << ' '
+        sql << " "
         source_list_append(sql, @opts[:from][0..0])
       end
     end