lite-command 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ecfaebe941a3ed585e42a5a43b361d60de38076b6a4254125722b13d57294885
-  data.tar.gz: da15660c9410a9c8797d6c322ab79797f800f5233319a7a39d6476bba10504ec
+  metadata.gz: 31f3a9216f2a7d081892c19b6e01cdd3a276583ccbe205950c8843621f9b4dcf
+  data.tar.gz: 4aca9ff7ac7e2d4ed7bcee96faa7605f71ccf37758034035a5fe3e6e26f38e7a
 SHA512:
-  metadata.gz: b91f356964b41577a7e274a5cc5cf46c74b60a088ffa781e7c5f3cbf0f7bd7713accf16ddf8bee16e99342e04a0040ea8dab2fb8c5ff7eb3132d7e3000596ca0
-  data.tar.gz: d905466a1fe16049f5af3877c2488120eb581070fe85a9bf20654cf09127bcccc8e6e9a79c436f16164e3104d5fc7d1bd6bbb7b839069250d29cc4b551e8c47e
+  metadata.gz: e9f04fe907b9858f547ad748b86b5828456e077440f4a253c3d1c8fee61e2be9f452a6b77db7c8ebebacd623f57e6fda2d63c57f030041926691b5738619e250
+  data.tar.gz: a40de6560f56ab977c8e48e9a1ca2f3f16afbd6d7df59aa24df0239e23cfbc51b6f6a5d65d9aa6e879261e731562c5aba2d0ad95cac3ab55f6dde5789735cfb1

data/CHANGELOG.md

@@ -6,6 +6,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.3.0] - 2024-11-01
+### Changed
+- Prefixed util method with `cmd_`
+- Improve monotonic clock handling
+- Improve order of hook calls
+
+## [3.2.1] - 2024-10-29
+### Changed
+- Allow if and unless evaluations to happen at the same time
+
 ## [3.2.0] - 2024-10-29
 ### Changed
 - Move callbacks to hooks instead of try methods

data/Gemfile.lock

@@ -1,16 +1,16 @@
 PATH
   remote: .
   specs:
-    lite-command (3.2.0)
+    lite-command (3.3.0)
       activemodel
       ostruct
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (7.2.1.2)
-      actionview (= 7.2.1.2)
-      activesupport (= 7.2.1.2)
+    actionpack (7.2.2)
+      actionview (= 7.2.2)
+      activesupport (= 7.2.2)
       nokogiri (>= 1.8.5)
       racc
       rack (>= 2.2.4, < 3.2)
@@ -19,16 +19,17 @@ GEM
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
       useragent (~> 0.16)
-    actionview (7.2.1.2)
-      activesupport (= 7.2.1.2)
+    actionview (7.2.2)
+      activesupport (= 7.2.2)
       builder (~> 3.1)
       erubi (~> 1.11)
       rails-dom-testing (~> 2.2)
       rails-html-sanitizer (~> 1.6)
-    activemodel (7.2.1.2)
-      activesupport (= 7.2.1.2)
-    activesupport (7.2.1.2)
+    activemodel (7.2.2)
+      activesupport (= 7.2.2)
+    activesupport (7.2.2)
       base64
+      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
@@ -40,6 +41,7 @@ GEM
       tzinfo (~> 2.0, >= 2.0.5)
     ast (2.4.2)
     base64 (0.2.0)
+    benchmark (0.3.0)
     bigdecimal (3.1.8)
     builder (3.3.0)
     concurrent-ruby (1.3.4)
@@ -57,7 +59,7 @@ GEM
     irb (1.14.1)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.7.4)
+    json (2.7.5)
     language_server-protocol (3.17.0.3)
     logger (1.6.1)
     loofah (2.23.1)
@@ -70,7 +72,7 @@ GEM
       racc (~> 1.4)
     ostruct (0.6.0)
     parallel (1.26.3)
-    parser (3.3.5.0)
+    parser (3.3.5.1)
       ast (~> 2.4.1)
       racc
     psych (5.1.2)
@@ -91,9 +93,9 @@ GEM
     rails-html-sanitizer (1.6.0)
       loofah (~> 2.21)
       nokogiri (~> 1.14)
-    railties (7.2.1.2)
-      actionpack (= 7.2.1.2)
-      activesupport (= 7.2.1.2)
+    railties (7.2.2)
+      actionpack (= 7.2.2)
+      activesupport (= 7.2.2)
       irb (~> 1.13)
       rackup (>= 1.0.0)
       rake (>= 12.2)
@@ -119,7 +121,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.1)
-    rubocop (1.67.0)
+    rubocop (1.68.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
@@ -129,7 +131,7 @@ GEM
       rubocop-ast (>= 1.32.2, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.32.3)
+    rubocop-ast (1.33.0)
       parser (>= 3.3.1.0)
     rubocop-performance (1.22.1)
       rubocop (>= 1.48.1, < 2.0)
@@ -140,7 +142,7 @@ GEM
       rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     securerandom (0.3.1)
-    sqlite3 (2.1.1)
+    sqlite3 (2.2.0)
       mini_portile2 (~> 2.8.0)
     stringio (3.1.1)
     thor (1.3.2)
@@ -148,7 +150,7 @@ GEM
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.6.0)
     useragent (0.16.10)
-    webrick (1.8.2)
+    webrick (1.9.0)
     zeitwerk (2.7.1)
 
 PLATFORMS

data/README.md

@@ -289,10 +289,10 @@ cmd.context.decrypted_message #=> "Hola Mundo"
 # With invalid options:
 cmd = DecryptSecretMessage.call(encrypted_message: "idk", version: "v23")
 cmd.status   #=> "invalid"
-cmd.reason   #=> "Encrypted message is too short (minimum is 10 character). Version is not included in list..."
+cmd.reason   #=> "Encrypted message is too short (minimum is 10 character). Encrypted message has invalid magic numbers. Version is not included in list."
 cmd.metadata #=> {
              #=>   user: ["is not included in list"],
-             #=>   encrypted_message: ["is too short (minimum is 10 character)"]
+             #=>   encrypted_message: ["is too short (minimum is 10 character)", "has invalid magic numbers"]
              #=> }
 ```
 
@@ -388,28 +388,17 @@ cmd.bad?("Other reason") #=> false
 
 Use hooks to run arbituary code at transition points and on finalized internals.
 All hooks are ran in the order they are defined. Hooks types can be defined
-multiple times. The following is an example of the hooks called for a failed
-command with a successful child command.
+multiple times. Hooks are ran in the following order:
 
 ```ruby
--> 1. FooCommand.after_initialize
--> 2. FooCommand.on_pending
--> 3. FooCommand.before_validation
--> 4. FooCommand.after_validation
--> 5. FooCommand.before_execution
--> 6. FooCommand.on_executing
----> 6a. BarCommand.after_initialize
----> 6b. BarCommand.on_pending
----> 6c. BarCommand.before_validation
----> 6d. BarCommand.after_validation
----> 6e. BarCommand.before_execution
----> 6f. BarCommand.on_executing
----> 6g. BarCommand.after_execution
----> 6h. BarCommand.on_failure
----> 6i. BarCommand.on_interrupted
--> 7. FooCommand.after_execution
--> 8. FooCommand.on_failure
--> 9. FooCommand.on_interrupted
+1. after_initialize
+2. before_execution
+3. before_validation
+4. after_validation
+5. on_executing
+6. on_[success, noop, invalid, failure, error]
+7. on_[complete, interrupted]
+8. after_execution
 ```
 
 ### Lifecycle Hooks

data/lib/lite/command/fault_streamer.rb

@@ -22,17 +22,17 @@ module Lite
       end
 
       def metadata
-        Utils.try(object, :metadata) || command.metadata
+        Utils.cmd_try(object, :metadata) || command.metadata
       end
 
       def caused_by
-        Utils.try(object, :caused_by) || command
+        Utils.cmd_try(object, :caused_by) || command
       end
 
       def thrown_by
-        return object if Utils.try(object, :executed?)
+        return object if Utils.cmd_try(object, :executed?)
 
-        Utils.try(object, :thrown_by) || command.caused_by
+        Utils.cmd_try(object, :thrown_by) || command.caused_by
       end
 
       def command_exception

data/lib/lite/command/internals/attributes.rb

@@ -36,7 +36,7 @@ module Lite
               define_method(method_name) do
                 return unless respond_to?(from)
 
-                Utils.try(send(from), method_name)
+                Utils.cmd_try(send(from), method_name)
               end
             end
           end
@@ -44,7 +44,7 @@ module Lite
         end
 
         def read_attribute_for_validation(method_name)
-          Utils.try(self, method_name)
+          Utils.cmd_try(self, method_name)
         rescue NameError
           # Do nothing, fallback to :undefined error
         end

data/lib/lite/command/internals/executions.rb

@@ -50,18 +50,19 @@ module Lite
           increment_execution_index
           assign_execution_cmd_id
           start_monotonic_time
-          run_hooks(:on_pending)
-          validate_context_attributes
+
           run_hooks(:before_execution)
           executing!
+          validate_context_attributes
           run_hooks(:on_executing)
         end
 
         def after_execution
           send(:"#{success? ? COMPLETE : INTERRUPTED}!")
-          run_hooks(:after_execution)
           run_hooks(:"on_#{status}")
           run_hooks(:"on_#{state}")
+          run_hooks(:after_execution)
+
           stop_monotonic_time
           append_execution_result
           freeze_execution_objects
@@ -82,7 +83,7 @@ module Lite
         def execute!
           around_execution { call }
         rescue StandardError => e
-          fault(e, Utils.try(e, :type) || ERROR, metadata, exception: e)
+          fault(e, Utils.cmd_try(e, :type) || ERROR, metadata, exception: e)
           after_execution
           raise(e)
         end

data/lib/lite/command/internals/hooks.rb

@@ -23,7 +23,7 @@ module Lite
         module ClassMethods
 
           def hooks
-            @hooks ||= Utils.try(superclass, :hooks).dup || {}
+            @hooks ||= Utils.cmd_try(superclass, :hooks).dup || {}
           end
 
           HOOKS.each do |h|
@@ -41,7 +41,7 @@ module Lite
           hooks = self.class.hooks[hook]
           return if hooks.nil?
 
-          hooks.each { |h| Utils.call(self, h) }
+          hooks.each { |h| Utils.cmd_call(self, h) }
         end
 
       end

data/lib/lite/command/internals/runtimes.rb

@@ -34,6 +34,8 @@ module Lite
         end
 
         def runtime
+          return unless executed?
+
           stop_monotonic_time - start_monotonic_time
         end
 

data/lib/lite/command/step.rb

@@ -12,7 +12,7 @@ module Lite
       end
 
       def run?(cmd)
-        Utils.evaluate(cmd, options)
+        Utils.cmd_eval(cmd, options)
       end
 
     end

data/lib/lite/command/utils.rb

@@ -23,13 +23,13 @@ module Lite
         !!(object_class <= other_class)
       end
 
-      def try(object, method_name, *args, include_private: true)
+      def cmd_try(object, method_name, *args, include_private: true)
         return unless object.respond_to?(method_name, include_private)
 
         object.send(method_name, *args)
       end
 
-      def call(object, argument)
+      def cmd_call(object, argument)
         if argument.is_a?(Symbol) || argument.is_a?(String)
           object.send(argument)
         elsif argument.is_a?(Proc)
@@ -39,11 +39,13 @@ module Lite
         end
       end
 
-      def evaluate(object, options = {})
-        if options[:if]
-          call(object, options[:if])
+      def cmd_eval(object, options = {})
+        if options[:if] && options[:unless]
+          cmd_call(object, options[:if]) && !cmd_call(object, options[:unless])
+        elsif options[:if]
+          cmd_call(object, options[:if])
         elsif options[:unless]
-          !call(object, options[:unless])
+          !cmd_call(object, options[:unless])
         else
           options.fetch(:default, true)
         end

data/lib/lite/command/version.rb

@@ -3,7 +3,7 @@
 module Lite
   module Command
 
-    VERSION = "3.2.0"
+    VERSION = "3.3.0"
 
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lite-command
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Juan Gomez
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-29 00:00:00.000000000 Z
+date: 2024-11-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -229,7 +229,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.21
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Ruby Command based framework (aka service objects)