lite-command 3.1.1 → 3.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6239fda55d099d36d3fc4c171ecf6eff2cd56bb5ffc4536dde420da339d0b5c9
-  data.tar.gz: a7c3949c9313a479f16f4cf709730f8262576f4d899069240073c52923c9aac3
+  metadata.gz: 6eb09ff348ac355723d82848c69c1673d7ffa2782b3bb0061b16ccbe205b9529
+  data.tar.gz: 514ffc0ce29de277bd0969c29a51884d2509fd46b69e5cc6f85ded44fba4e827
 SHA512:
-  metadata.gz: 6330c34c333948919685049c4eaefc5913ab364b09f28322ea6283aa73b3906715cc063b1b61192e231d5582206e0ae91be506fba09035317711dd56ad7f7ae2
-  data.tar.gz: 69a682501448fb31fd0ad5709fc23f5f8b5dabc3c9a01486c4848a1d01f887523ab3fee3e7c2acdf6861b181bc1347dbee9bdccd6af3f1dc21321a6585a0a0f4
+  metadata.gz: 00d47aa6fc59fa96895311bd78be8dcf3b283da16197f6973eb5db4100b61ef6303ab65673b695dfd51cfbc64ae63eca9b70adc0eba46763a25597fa1c1e6ba0
+  data.tar.gz: 2e60eaa36e8b86cec861bc67bfa3bee12292c8edf8c92503e4339128f69f467421f94a4b53ee1a8a96a467cb25617cb6918d553419bbb6b1fbd23c817b2227dd

data/CHANGELOG.md

@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [3.1.2] - 2024-10-26
+### Changed
+- Make state set methods private
+- Add returns for invalid state and status transitions
+
 ## [3.1.1] - 2024-10-25
 ### Changed
 - Add option to raise original or fault exception

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lite-command (3.1.1)
+    lite-command (3.1.2)
       activemodel
       ostruct
 
@@ -136,7 +136,7 @@ GEM
       rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (3.1.0)
+    rubocop-rspec (3.2.0)
       rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     securerandom (0.3.1)

data/lib/lite/command/internals/calls.rb

@@ -59,7 +59,7 @@ module Lite
         end
 
         def bad?(reason = nil)
-          ![SUCCESS, NOOP].include?(status) && reason?(reason)
+          !ok?(reason)
         end
 
         FAULTS.each do |f|
@@ -75,22 +75,25 @@ module Lite
           str.nil? || str == reason
         end
 
-        def fault(object, status, metadata)
-          @status   = status
-          @metadata = metadata
+        def fault(object, s, m) # rubocop:disable Naming/MethodParameterName
+          return if s == SUCCESS || status != SUCCESS
 
-          down_stream = Lite::Command::FaultStreamer.new(self, object)
-          @reason    ||= down_stream.reason
-          @metadata  ||= down_stream.metadata
-          @caused_by ||= down_stream.caused_by
-          @thrown_by ||= down_stream.thrown_by
+          @status   = s
+          @metadata = m
 
-          @fault_exception ||= down_stream.fault_exception
+          fault_streamer = Lite::Command::FaultStreamer.new(self, object)
+          @reason    ||= fault_streamer.reason
+          @metadata  ||= fault_streamer.metadata
+          @caused_by ||= fault_streamer.caused_by
+          @thrown_by ||= fault_streamer.thrown_by
+          @fault_exception ||= fault_streamer.fault_exception
         end
 
         FAULTS.each do |f|
           # eg: invalid!("idk") or failure!(fault) or error!("idk", { error_key: "some.error" })
           define_method(:"#{f}!") do |object, metadata = nil|
+            return unless success?
+
             fault(object, f, metadata)
             raise(fault_exception)
           end

data/lib/lite/command/internals/executions.rb

@@ -24,13 +24,28 @@ module Lite
         STATES.each do |s|
           # eg: executing?
           define_method(:"#{s}?") { state == s }
-
-          # eg: interrupted!
-          define_method(:"#{s}!") { @state = s }
         end
 
         private
 
+        def executing!
+          return unless pending?
+
+          @state = EXECUTING
+        end
+
+        def complete!
+          return if executed?
+
+          @state = COMPLETE
+        end
+
+        def interrupted!
+          return if executed?
+
+          @state = INTERRUPTED
+        end
+
         def before_execution
           increment_execution_index
           assign_execution_cmd_id
@@ -61,7 +76,7 @@ module Lite
           Utils.try(self, :on_success)
         rescue StandardError => e
           @original_exception = e
-          fault(e, ERROR, metadata) unless e.is_a?(Lite::Command::Fault)
+          fault(e, ERROR, metadata)
           after_execution
           Utils.try(self, :"on_#{status}", e)
         ensure
@@ -73,7 +88,7 @@ module Lite
           Utils.try(self, :on_success)
         rescue StandardError => e
           @original_exception = e
-          fault(e, ERROR, metadata) unless e.is_a?(Lite::Command::Fault)
+          fault(e, ERROR, metadata)
           after_execution
           Utils.try(self, :"on_#{status}", e)
           raise(e)

data/lib/lite/command/internals/faults.rb

@@ -35,7 +35,9 @@ module Lite
 
         def raise!(original: false)
           exception = (fault_exception unless original) || original_exception
-          raise(exception) unless exception.nil?
+          return if exception.nil?
+
+          raise(exception)
         end
 
         private

data/lib/lite/command/version.rb

@@ -3,7 +3,7 @@
 module Lite
   module Command
 
-    VERSION = "3.1.1"
+    VERSION = "3.1.2"
 
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lite-command
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.2
 platform: ruby
 authors:
 - Juan Gomez