lite-command 3.0.1 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ca95adc16c60158c9a6b826dc9b87f826dc0a81574fd85b996147bbc9ba7c7f2
-  data.tar.gz: 26d5c68abb7572aa5c887f324fe138c4eb282eb00308dcda83059ace331d2c1b
+  metadata.gz: 6239fda55d099d36d3fc4c171ecf6eff2cd56bb5ffc4536dde420da339d0b5c9
+  data.tar.gz: a7c3949c9313a479f16f4cf709730f8262576f4d899069240073c52923c9aac3
 SHA512:
-  metadata.gz: 73217979c23fff74cf8a9f4965627e3c69bb3d6b74b3b815cb70af3ad766a4ecd412acfb11e96dfc777427eca9dd113c1782e0e407838836d165e1f716f0e241
-  data.tar.gz: ec3f313e195d97d5c22f8187d78dc0b328288eaa4f2c57de72edce22949b4c75825f63842df7a8141059161efefb1ab45f6457c2b47d2e33efe6fa136b8e7ed7
+  metadata.gz: 6330c34c333948919685049c4eaefc5913ab364b09f28322ea6283aa73b3906715cc063b1b61192e231d5582206e0ae91be506fba09035317711dd56ad7f7ae2
+  data.tar.gz: 69a682501448fb31fd0ad5709fc23f5f8b5dabc3c9a01486c4848a1d01f887523ab3fee3e7c2acdf6861b181bc1347dbee9bdccd6af3f1dc21321a6585a0a0f4

data/.rubocop.yml

@@ -42,8 +42,6 @@ Metrics/PerceivedComplexity:
   Enabled: false
 Naming/MemoizedInstanceVariableName:
   Enabled: false
-Performance/AncestorsInclude:
-  Enabled: false
 RSpec/AnyInstance:
   Enabled: false
 RSpec/DescribedClass:

data/CHANGELOG.md

@@ -6,9 +6,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [3.0.1] - 2024-10-25
+## [3.1.1] - 2024-10-25
+### Changed
+- Add option to raise original or fault exception
+
+## [3.1.0] - 2024-10-25
 ### Added
-- Added improved equality check
+- Added `raise!` method to reraise soft call errors
+### Changed
+- Fixed leakage of configuration option changes in spec
+
+## [3.0.1] - 2024-10-25
+### Changed
+- Changed equality check for better matching
 
 ## [3.0.0] - 2024-10-15
 ### Added

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lite-command (3.0.1)
+    lite-command (3.1.1)
       activemodel
       ostruct
 

data/README.md

@@ -26,6 +26,7 @@ Or install it yourself as:
 * [Usage](#usage)
 * [Execution](#execution)
   * [Dynamic Faults](#dynamic-faults)
+  * [Raising Faults](#raising-faults)
 * [Context](#context)
   * [Attributes](#attributes)
   * [Validations](#validations)
@@ -95,7 +96,7 @@ DecryptSecretMessage.call(...)
 # - or -
 DecryptSecretMessage.new(...).call
 
-# On success, fault and exception:
+# On success, fault or exception:
 #=> <DecryptSecretMessage ...>
 ```
 
@@ -121,6 +122,29 @@ DecryptSecretMessage.new(...).call!
 #=> raises StandardError
 ```
 
+### Raising Faults
+
+Sometimes its suitable to raise the offending soft call command fault later
+in a call stack. Use the `raise!` method to reraise the fault or original
+error (if they differ). `original: false` is the default.
+
+```ruby
+cmd = DecryptSecretMessage.call(...)
+Apm.track_stat("DecryptSecretMessage.called")
+# other stuff...
+
+# On success:
+cmd.raise! #=> nil
+
+# On fault:
+cmd.raise!(original: false) #=> raises Lite::Command::Fault
+cmd.raise!(original: true)  #=> raises Lite::Command::Fault
+
+# On exception:
+cmd.raise!(original: false) #=> raises Lite::Command::Error
+cmd.raise!(original: true)  #=> raises StandardError
+```
+
 ### Dynamic Faults
 
 Dynamic faults are custom faults named after your command. This is especially

data/lib/lite/command/fault.rb

@@ -30,11 +30,7 @@ module Lite
       end
 
       def self.===(item)
-        klass0 = respond_to?(:new) ? self : self.class
-        klass1 = item.respond_to?(:new) ? item : item.class
-        return true if klass0 == klass1
-
-        klass0.ancestors.include?(klass1) || klass1.ancestors.include?(klass0)
+        Utils.descendant_of?(self, item) || Utils.descendant_of?(item, self)
       end
 
       def type
@@ -42,8 +38,7 @@ module Lite
       end
 
       def ===(item)
-        klass = item.respond_to?(:new) ? item : item.class
-        is_a?(klass)
+        Utils.descendant_of?(self, item)
       end
 
     end

data/lib/lite/command/fault_streamer.rb

@@ -11,6 +11,20 @@ module Lite
         @object = object
       end
 
+      def reason
+        if object.respond_to?(:reason)
+          object.reason
+        elsif object.is_a?(StandardError)
+          "[#{object.class.name}] #{object.message}".chomp(".")
+        else
+          object
+        end
+      end
+
+      def metadata
+        Utils.try(object, :metadata) || command.metadata
+      end
+
       def caused_by
         Utils.try(object, :caused_by) || command
       end
@@ -21,18 +35,15 @@ module Lite
         Utils.try(object, :thrown_by) || command.caused_by
       end
 
-      def metadata
-        Utils.try(object, :metadata) || command.metadata
-      end
+      def fault_exception
+        return if command.success?
 
-      def reason
-        if object.respond_to?(:reason)
-          object.reason
-        elsif object.is_a?(StandardError)
-          "[#{object.class.name}] #{object.message}".chomp(".")
-        else
-          object
-        end
+        Fault.build(
+          command.status.capitalize,
+          command,
+          object,
+          dynamic: command.send(:raise_dynamic_faults?)
+        )
       end
 
     end

data/lib/lite/command/internals/calls.rb

@@ -84,13 +84,15 @@ module Lite
           @metadata  ||= down_stream.metadata
           @caused_by ||= down_stream.caused_by
           @thrown_by ||= down_stream.thrown_by
+
+          @fault_exception ||= down_stream.fault_exception
         end
 
         FAULTS.each do |f|
           # eg: invalid!("idk") or failure!(fault) or error!("idk", { error_key: "some.error" })
           define_method(:"#{f}!") do |object, metadata = nil|
             fault(object, f, metadata)
-            raise Lite::Command::Fault.build(f.capitalize, self, object, dynamic: raise_dynamic_faults?)
+            raise(fault_exception)
           end
         end
 

data/lib/lite/command/internals/executions.rb

@@ -60,6 +60,7 @@ module Lite
           around_execution { call }
           Utils.try(self, :on_success)
         rescue StandardError => e
+          @original_exception = e
           fault(e, ERROR, metadata) unless e.is_a?(Lite::Command::Fault)
           after_execution
           Utils.try(self, :"on_#{status}", e)
@@ -71,6 +72,7 @@ module Lite
           around_execution { call }
           Utils.try(self, :on_success)
         rescue StandardError => e
+          @original_exception = e
           fault(e, ERROR, metadata) unless e.is_a?(Lite::Command::Fault)
           after_execution
           Utils.try(self, :"on_#{status}", e)

data/lib/lite/command/internals/faults.rb

@@ -5,6 +5,10 @@ module Lite
     module Internals
       module Faults
 
+        def self.included(base)
+          base.class_eval { attr_reader :fault_exception, :original_exception }
+        end
+
         def caused_by
           return if success?
 
@@ -29,6 +33,11 @@ module Lite
           fault? && !caused_fault?
         end
 
+        def raise!(original: false)
+          exception = (fault_exception unless original) || original_exception
+          raise(exception) unless exception.nil?
+        end
+
         private
 
         def throw!(command)

data/lib/lite/command/utils.rb

@@ -6,6 +6,13 @@ module Lite
 
       module_function
 
+      def descendant_of?(object, other)
+        object_class = object.respond_to?(:new) ? object : object.class
+        other_class = other.respond_to?(:new) ? other : other.class
+
+        !!(object_class <= other_class)
+      end
+
       def try(object, method_name, *args, include_private: true)
         return unless object.respond_to?(method_name, include_private)
 

data/lib/lite/command/version.rb

@@ -3,7 +3,7 @@
 module Lite
   module Command
 
-    VERSION = "3.0.1"
+    VERSION = "3.1.1"
 
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lite-command
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.1.1
 platform: ruby
 authors:
 - Juan Gomez
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-10-25 00:00:00.000000000 Z
+date: 2024-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel