lita 4.0.4 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b2fd77c82dffdb6d152eb1376f3868be921d97b
-  data.tar.gz: 4bef398d354e621af17bbff01fee340c4eb98d71
+  metadata.gz: 8f7cb3c5b605c35c60bdff103c47df2488814712
+  data.tar.gz: 22be31cadc4608c676923ea7253a9a3b6456e5ad
 SHA512:
-  metadata.gz: aa9adeded2fa7941d30bd875e5540603eddae8e210bd86a61eec4ef1778972122678ce952c873d28e0bdb9cb2348e9074f76c71dd58fa58f5cb1812edac80126
-  data.tar.gz: 1d1ac3b548b681b8c22fd0804eb306fe10f23756629a15b215a71e3e276f82855c41108fb57a1247aa57090435e1ec4e375f10fd6b6a4100864a13c79601e296
+  metadata.gz: 5f11b1e00ff16c75e0a5c56a7c96b6d658d27ef207444deb2808265471409f5fc5d6c2d3c585b3c56434e8097515ce5eee85f7d02de983979e005a47435e415b
+  data.tar.gz: 2bb7b4fd5497735d4e4a78559b26878f4de79e016901bf1c123c56b78fa37bc6d3c1e7b430875fd7fd820f55026b5f66e3d54ac1ee7be13a96c74a7941304eb3

data/.rubocop.yml

@@ -1,3 +1,5 @@
+AbcSize:
+  Enabled: false
 AlignParameters:
   Enabled: false
 AndOr:
@@ -10,8 +12,12 @@ Documentation:
   Enabled: false
 DoubleNegation:
   Enabled: false
+EachWithObject:
+  Enabled: false
 EndAlignment:
   AlignWith: variable
+GuardClause:
+  Enabled: false
 IndentHash:
   Enabled: false
 LineLength:
@@ -20,6 +26,8 @@ MethodLength:
   Enabled: false
 NonNilCheck:
   Enabled: false
+ParameterLists:
+  Max: 6
 RegexpLiteral:
   Enabled: false
 RescueException:

data/Rakefile

@@ -3,6 +3,6 @@ require "rspec/core/rake_task"
 require "rubocop/rake_task"
 
 RSpec::Core::RakeTask.new
-Rubocop::RakeTask.new
+RuboCop::RakeTask.new
 
 task default: [:spec, :rubocop]

data/lib/lita.rb

@@ -117,4 +117,5 @@ require_relative "lita/handlers/authorization"
 require_relative "lita/handlers/help"
 require_relative "lita/handlers/info"
 require_relative "lita/handlers/room"
+require_relative "lita/handlers/users"
 require_relative "lita/handlers/deprecation_check"

data/lib/lita/adapters/shell.rb

@@ -24,7 +24,7 @@ module Lita
       # @return [void]
       def send_messages(_target, strings)
         strings = Array(strings)
-        strings.reject! { |string| string.empty? }
+        strings.reject!(&:empty?)
         unless RbConfig::CONFIG["host_os"] =~ /mswin|mingw/ || !$stdout.tty?
           strings.map! { |string| "\e[32m#{string}\e[0m" }
         end

data/lib/lita/cli.rb

@@ -121,7 +121,7 @@ module Lita
 
     def generate_config(name, plugin_type)
       name, gem_name = normalize_names(name)
-      constant_name = name.split(/_/).map { |p| p.capitalize }.join
+      constant_name = name.split(/_/).map(&:capitalize).join
       namespace = "#{plugin_type}s"
       constant_namespace = namespace.capitalize
       spec_type = plugin_type == "handler" ? "lita_handler" : "lita"

data/lib/lita/configurable.rb

@@ -12,9 +12,9 @@ module Lita
     # @return [void]
     # @since 4.0.0
     # @see Lita::ConfigurationBuilder#config
-    def config(*args, **kwargs)
-      if block_given?
-        configuration_builder.config(*args, **kwargs, &proc)
+    def config(*args, **kwargs, &block)
+      if block
+        configuration_builder.config(*args, **kwargs, &block)
       else
         configuration_builder.config(*args, **kwargs)
       end

data/lib/lita/configuration_builder.rb

@@ -106,13 +106,13 @@ module Lita
     # @yield A block to be evaluated in the context of the new attribute. Used for
     #   defining nested configuration attributes and validators.
     # @return [void]
-    def config(name, types: nil, type: nil, required: false, default: nil)
+    def config(name, types: nil, type: nil, required: false, default: nil, &block)
       attribute = self.class.new
       attribute.name = name
       attribute.types = types || type
       attribute.required = required
       attribute.value = default
-      attribute.instance_exec(&proc) if block_given?
+      attribute.instance_exec(&block) if block
 
       children << attribute
     end
@@ -129,15 +129,15 @@ module Lita
     # validation passed.
     # @yield The code that performs validation.
     # @return [void]
-    def validate
-      validator = proc
+    def validate(&block)
+      validator = block
 
       unless value.nil?
         error = validator.call(value)
         raise ValidationError, error if error
       end
 
-      @validator = proc
+      @validator = block
     end
 
     # Sets the value of the attribute, raising an error if it is not among the valid types.

data/lib/lita/default_configuration.rb

@@ -134,7 +134,7 @@ module Lita
         config :log_level, types: [String, Symbol], default: :info do
           validate do |value|
             unless LOG_LEVELS.include?(value.to_s.downcase.strip)
-              "must be one of: #{LOG_LEVELS.join(", ")}"
+              "must be one of: #{LOG_LEVELS.join(', ')}"
             end
           end
         end

data/lib/lita/handler/chat_router.rb

@@ -41,12 +41,12 @@ module Lita
       #   @yield The body of the route's callback.
       #   @return [void]
       #   @since 4.0.0
-      def route(pattern, method_name = nil, **options)
+      def route(pattern, method_name = nil, **options, &block)
         options = default_route_options.merge(options)
         options[:restrict_to] = options[:restrict_to].nil? ? nil : Array(options[:restrict_to])
         routes << Route.new(
           pattern,
-          Callback.new(method_name || (proc if block_given?)),
+          Callback.new(method_name || block),
           options.delete(:command),
           options.delete(:restrict_to),
           options.delete(:help),

data/lib/lita/handler/common.rb

@@ -73,11 +73,11 @@ module Lita
       # @param options [Hash] A set of options passed on to Faraday.
       # @yield [builder] A Faraday builder object for adding middleware.
       # @return [Faraday::Connection] The new connection object.
-      def http(options = {})
+      def http(options = {}, &block)
         options = default_faraday_options.merge(options)
 
-        if block_given?
-          Faraday::Connection.new(nil, options, &proc)
+        if block
+          Faraday::Connection.new(nil, options, &block)
         else
           Faraday::Connection.new(nil, options)
         end

data/lib/lita/handler/event_router.rb

@@ -35,9 +35,9 @@ module Lita
       #   @yield The body of the event callback.
       #   @return [void]
       #   @since 4.0.0
-      def on(event_name, method_name_or_callable = nil)
+      def on(event_name, method_name_or_callable = nil, &block)
         event_subscriptions[normalize_event(event_name)] << Callback.new(
-          method_name_or_callable || (proc if block_given?)
+          method_name_or_callable || block
         )
       end
 

data/lib/lita/handlers/authorization.rb

@@ -66,7 +66,7 @@ module Lita
           groups_with_users.select! { |group, _| group == requested_group }
         end
         groups_with_users.map do |group, users|
-          user_names = users.map { |u| u.name }.join(", ")
+          user_names = users.map(&:name).join(", ")
           "#{group}: #{user_names}"
         end
       end
@@ -83,7 +83,7 @@ module Lita
 
       def valid_group?(response, identifier)
         unless identifier && @group
-          response.reply "#{t("format")}: #{robot.name} auth add USER GROUP"
+          response.reply "#{t('format')}: #{robot.name} auth add USER GROUP"
           return
         end
 

data/lib/lita/handlers/deprecation_check.rb

@@ -10,11 +10,10 @@ module Lita
       # Warns about handlers using the old +default_config+ method.
       def check_handlers_for_default_config(_payload)
         robot.registry.handlers.each do |handler|
-          if handler.respond_to?(:default_config)
-            Lita.logger.warn(
-              I18n.t("lita.config.handler_default_config_deprecated", name: handler.namespace)
-            )
-          end
+          next unless handler.respond_to?(:default_config)
+          Lita.logger.warn(
+            I18n.t("lita.config.handler_default_config_deprecated", name: handler.namespace)
+          )
         end
       end
     end

data/lib/lita/handlers/users.rb

@@ -0,0 +1,35 @@
+module Lita
+  module Handlers
+    # Provides information on Lita users.
+    # @since 4.1.0
+    class Users
+      extend Lita::Handler::ChatRouter
+
+      route(/^users\s+find\s+(.+)/i, :find, command: true, help: {
+        t("help.find_key") => t("help.find_value")
+      })
+
+      # Outputs the name, ID, and mention name of a user matching the search query.
+      # @param response [Lita::Response] The response object.
+      # @return [void]
+      def find(response)
+        user = Lita::User.fuzzy_find(response.args[1])
+
+        if user
+          response.reply(formatted_user(user))
+        else
+          response.reply(t("find_empty_state"))
+        end
+      end
+
+      private
+
+      # Extract and label the relevant user information.
+      def formatted_user(user)
+        "#{user.name} (ID: #{user.id}, Mention name: #{user.mention_name})"
+      end
+    end
+
+    Lita.register_handler(Users)
+  end
+end

data/lib/lita/middleware_registry.rb

@@ -28,8 +28,8 @@ module Lita
     # @param args [Array] Arbitrary initialization arguments for the middleware.
     # @yield An optional block to be passed to the constructor of the middleware.
     # @return [void]
-    def use(middleware, *args)
-      @registry << MiddlewareWrapper.new(middleware, args, (proc if block_given?))
+    def use(middleware, *args, &block)
+      @registry << MiddlewareWrapper.new(middleware, args, block)
     end
   end
 end

data/lib/lita/registry.rb

@@ -47,8 +47,8 @@ module Lita
       #   @yield The body of the adapter class.
       #   @return [void]
       #   @since 4.0.0
-      def register_adapter(key, adapter = nil)
-        adapter = PluginBuilder.new(key, &proc).build_adapter if block_given?
+      def register_adapter(key, adapter = nil, &block)
+        adapter = PluginBuilder.new(key, &block).build_adapter if block
 
         unless adapter.is_a?(Class)
           raise ArgumentError, I18n.t("lita.core.register_adapter.block_or_class_required")
@@ -67,9 +67,9 @@ module Lita
       #   @yield The body of the handler class.
       #   @return [void]
       #   @since 4.0.0
-      def register_handler(handler_or_key)
-        if block_given?
-          handler = PluginBuilder.new(handler_or_key, &proc).build_handler
+      def register_handler(handler_or_key, &block)
+        if block
+          handler = PluginBuilder.new(handler_or_key, &block).build_handler
         else
           handler = handler_or_key
 

data/lib/lita/robot.rb

@@ -181,12 +181,12 @@ module Lita
         begin
           @server.add_tcp_listener(http_config.host, http_config.port.to_i)
         rescue Errno::EADDRINUSE, Errno::EACCES => e
-            Lita.logger.fatal I18n.t(
-              "lita.http.exception",
-              message: e.message,
-              backtrace: e.backtrace.join("\n")
-            )
-            abort
+          Lita.logger.fatal I18n.t(
+            "lita.http.exception",
+            message: e.message,
+            backtrace: e.backtrace.join("\n")
+          )
+          abort
         end
         @server.min_threads = http_config.min_threads
         @server.max_threads = http_config.max_threads

data/lib/lita/version.rb

@@ -1,4 +1,4 @@
 module Lita
   # The current version of Lita.
-  VERSION = "4.0.4"
+  VERSION = "4.1.0"
 end

data/lita.gemspec

@@ -8,8 +8,8 @@ Gem::Specification.new do |spec|
   spec.version       = Lita::VERSION
   spec.authors       = ["Jimmy Cuadra"]
   spec.email         = ["jimmy@jimmycuadra.com"]
-  spec.description   = %q(A multi-service chat bot with extendable behavior.)
-  spec.summary       = %q(A multi-service chat bot with extendable behavior.)
+  spec.description   = "ChatOps for Ruby."
+  spec.summary       = "ChatOps framework for Ruby. Lita is a robot companion for your chat room."
   spec.homepage      = "https://github.com/jimmycuadra/lita"
   spec.license       = "MIT"
 
@@ -38,5 +38,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "coveralls"
   spec.add_development_dependency "pry"
-  spec.add_development_dependency "rubocop", "~> 0.21.0"
+  spec.add_development_dependency "rubocop", "~> 0.28.0"
 end

data/spec/lita/handlers/users_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+
+describe Lita::Handlers::Users, lita_handler: true do
+  it { is_expected.to route_command("users find carl").to(:find) }
+
+  describe "#find" do
+    it "finds users by ID" do
+      send_command("users find 1")
+
+      expect(replies.first).to eq("Test User (ID: 1, Mention name: Test User)")
+    end
+
+    it "finds users by name" do
+      send_command("users find 'Test User'")
+
+      expect(replies.first).to eq("Test User (ID: 1, Mention name: Test User)")
+    end
+
+    it "finds users by mention name" do
+      Lita::User.create(2, name: "Mr. Pug", mention_name: "carl")
+
+      send_command("users find carl")
+
+      expect(replies.first).to eq("Mr. Pug (ID: 2, Mention name: carl)")
+    end
+
+    it "replies with a message when no matches are found" do
+      send_command("users find nobody")
+
+      expect(replies.first).to eq("No matching users found.")
+    end
+  end
+end

data/templates/locales/en.yml

@@ -46,6 +46,11 @@ en:
           join_value: Makes the robot join the room with room ID ROOM_ID.
           part_key: part ROOM_ID
           part_value: Makes the robot part from the room with room ID ROOM_ID.
+      users:
+        find_empty_state: No matching users found.
+        help:
+          find_key: users find SEARCH_TERM
+          find_value: Find a Lita user by ID, name, or mention name.
     adapter:
       method_not_implemented: "This adapter has not implemented #%{method}."
       missing_configs: "The following keys are required on config.adapter: %{configs}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita
 version: !ruby/object:Gem::Version
-  version: 4.0.4
+  version: 4.1.0
 platform: ruby
 authors:
 - Jimmy Cuadra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-09 00:00:00.000000000 Z
+date: 2015-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -254,15 +254,15 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
+        version: 0.28.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.0
-description: A multi-service chat bot with extendable behavior.
+        version: 0.28.0
+description: ChatOps for Ruby.
 email:
 - jimmy@jimmycuadra.com
 executables:
@@ -303,6 +303,7 @@ files:
 - lib/lita/handlers/help.rb
 - lib/lita/handlers/info.rb
 - lib/lita/handlers/room.rb
+- lib/lita/handlers/users.rb
 - lib/lita/http_callback.rb
 - lib/lita/http_route.rb
 - lib/lita/logger.rb
@@ -345,6 +346,7 @@ files:
 - spec/lita/handlers/help_spec.rb
 - spec/lita/handlers/info_spec.rb
 - spec/lita/handlers/room_spec.rb
+- spec/lita/handlers/users_spec.rb
 - spec/lita/logger_spec.rb
 - spec/lita/message_spec.rb
 - spec/lita/plugin_builder_spec.rb
@@ -392,10 +394,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
-summary: A multi-service chat bot with extendable behavior.
+summary: ChatOps framework for Ruby. Lita is a robot companion for your chat room.
 test_files:
 - spec/lita/adapter_spec.rb
 - spec/lita/adapters/shell_spec.rb
@@ -415,6 +417,7 @@ test_files:
 - spec/lita/handlers/help_spec.rb
 - spec/lita/handlers/info_spec.rb
 - spec/lita/handlers/room_spec.rb
+- spec/lita/handlers/users_spec.rb
 - spec/lita/logger_spec.rb
 - spec/lita/message_spec.rb
 - spec/lita/plugin_builder_spec.rb