lita 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73a99962e90c5ed2aa41e8d8a728abdd0a707051
-  data.tar.gz: 1b9026e1e1d32e693d67d13a40fe1fa412982930
+  metadata.gz: d9bd8c0df22178884dc917ba0160f0eb1bc3b2dc
+  data.tar.gz: 79089bd4df8880b869b444b7dc98e9bb492fde20
 SHA512:
-  metadata.gz: 5abc300962d3cdfbe95a1d2882acc8c79cdd4b259819badc7d396ca8b2a83aed37176a4c8c92721926810706bb3cd9a27cbf4d3cf2613aa3f166d53e5420e34b
-  data.tar.gz: b48afb57c7cb94f560ebb4ff0a7a88ba390759720020c8085868d6a748e541c338317bbb0837902183f61a95c1a4ca9e7c50677ce3478511bee80204bc97723a
+  metadata.gz: 4de9444af3c84c039b113a5f3a5a0659cfb91f4438b607f61f5e3030b03cd90cd950403f855dc0e9e208a8324c535f85fba61628d7ac46f346947190b7d0eea5
+  data.tar.gz: 5bca9f0a44ac91b26e3519f02f9add4bb0569624d12f76b99102e5ae40057975744c7b0dc46b9c2a0fe26c0865697a69e83360c38b1c0a3ed0e91d2732693e30

data/lib/lita/handler.rb

@@ -67,6 +67,7 @@ LOG
 #{e.message}
 #{e.backtrace.join("\n")}
 ERROR
+              raise e if rspec_loaded?
             end
           end
         end
@@ -116,6 +117,12 @@ ERROR
 
         true
       end
+
+      # Checks if RSpec is loaded. If so, assume we are testing and let handler
+      # exceptions bubble up.
+      def rspec_loaded?
+        defined?(::RSpec)
+      end
     end
 
     # @param robot [Lita::Robot] The currently running robot.

data/lib/lita/version.rb

@@ -1,4 +1,4 @@
 module Lita
   # The current version of Lita.
-  VERSION = "2.1.0"
+  VERSION = "2.1.1"
 end

data/spec/lita/handler_spec.rb

@@ -93,11 +93,17 @@ describe Lita::Handler, lita: true do
 
     it "logs exceptions but doesn't crash the bot" do
       allow(message).to receive(:body).and_return("#{robot.name}: danger")
+      allow(handler_class).to receive(:rspec_loaded?).and_return(false)
       expect(Lita.logger).to receive(:error).with(
         %r{Lita::Handlers::Test crashed}
       )
       expect { handler_class.dispatch(robot, message) }.not_to raise_error
     end
+
+    it "re-raises exceptions when testing with RSpec" do
+      allow(message).to receive(:body).and_return("#{robot.name}: danger")
+      expect { handler_class.dispatch(robot, message) }.to raise_error
+    end
   end
 
   describe ".namespace" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: lita
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Jimmy Cuadra