lita-wordnik 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ce8bb942f982996203a905a3212e4ee5d162c39c
-  data.tar.gz: 20134edd81a00fde12234f006d47bb7568972a4f
+  metadata.gz: 7b47ef9632471408cb9aa52ec8374e0674895d2f
+  data.tar.gz: b91b0e980447702325965872652b0f7b84c5761a
 SHA512:
-  metadata.gz: 7df229ffa08cc6fd6eca44c445896614d20f68d466f9bd31c5ec323e4e2807e97086122f806ac890cef6a0ea043a8cf4c9e6e2f83241f8dd8cd17d409b98c8f9
-  data.tar.gz: dee4b9ebd3ce0a0567480d153d18dcbd2f73aa112dfb6d8512da9ceaffddf652a6badf3c0a7f58d1f33401645f95a3ed6f77621bc0fe7ef4a7486bb84fa1bb79
+  metadata.gz: 6fe78f6d45a6b911796844e563ed1a932fc7d51b59afcede6acaeca730cb8fcf4d2e20baaf33a2423560ef38d672faecb08ee7045ce304acde1d1ab2d93dabc0
+  data.tar.gz: ba85702a5b6c1a5956a36b2bcd2e31ce379ea3cb4a13b62bcee585af825652c3fbd53a93ece4f3ac6b406959334219b29b35239724b59ec206596f4744b75d9d

data/README.md

@@ -18,7 +18,7 @@ gem "lita-wordnik"
 
 ### Required attributes
 
-* `api_key` - Your API key for Wordnik. Register for one at the [Wordnik Developer](http://developer.wordnik.com/) page.
+* `api_key` (String) - Your API key for Wordnik. Register for one at the [Wordnik Developer](http://developer.wordnik.com/) page.
 
 ### Example
 

data/lib/lita/handlers/wordnik.rb

@@ -5,9 +5,7 @@ module Lita
     class Wordnik < Handler
       NO_RESULTS = "Wordnik doesn't have any results for that."
 
-      def self.default_config(config)
-        config.api_key = nil
-      end
+      config :api_key, type: String, required: true
 
       route(/define\s+(.+)/i, :define, command: true, help: {
         "define WORD" => "Get the definition for WORD."
@@ -28,7 +26,6 @@ module Lita
       class << self
         def define_wordnik_method(name, getter_name)
           define_method(name) do |response|
-            return unless validate(response)
             word = encode_word(response.matches[0][0])
             result = send(getter_name, word)
             response.reply(result)
@@ -115,15 +112,6 @@ module Lita
         end
       end
 
-      def validate(response)
-        if Lita.config.handlers.wordnik.api_key.nil?
-          response.reply "Wordnik API key required."
-          return
-        end
-
-        true
-      end
-
       Lita.register_handler(Wordnik)
     end
   end

data/lita-wordnik.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-wordnik"
-  spec.version       = "0.1.0"
+  spec.version       = "1.0.0"
   spec.authors       = ["Jimmy Cuadra"]
   spec.email         = ["jimmy@jimmycuadra.com"]
   spec.description   = %q{A Lita handler for dictionary functionality backed by Wordnik.}
@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "lita", ">= 2.1"
+  spec.add_runtime_dependency "lita", ">= 4.0"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/spec/lita/handlers/wordnik_spec.rb

@@ -3,17 +3,13 @@ require "spec_helper"
 describe Lita::Handlers::Wordnik, lita_handler: true do
   let(:response) { double("Faraday::Response", status: 200, body: body) }
 
-  it { routes_command("define computer").to(:define) }
-  it { routes_command("synonyms cold").to(:synonyms) }
-  it { routes_command("syn cold").to(:synonyms) }
-  it { routes_command("words like cold").to(:synonyms) }
-  it { routes_command("antonyms cold").to(:antonyms) }
-  it { routes_command("ant cold").to(:antonyms) }
-  it { routes_command("words unlike cold").to(:antonyms) }
-
-  it "sets the API key to nil by default" do
-    expect(Lita.config.handlers.wordnik.api_key).to be_nil
-  end
+  it { is_expected.to route_command("define computer").to(:define) }
+  it { is_expected.to route_command("synonyms cold").to(:synonyms) }
+  it { is_expected.to route_command("syn cold").to(:synonyms) }
+  it { is_expected.to route_command("words like cold").to(:synonyms) }
+  it { is_expected.to route_command("antonyms cold").to(:antonyms) }
+  it { is_expected.to route_command("ant cold").to(:antonyms) }
+  it { is_expected.to route_command("words unlike cold").to(:antonyms) }
 
   context "with Faraday stubbing" do
     before do
@@ -35,13 +31,8 @@ assembles, stores, correlates, or otherwise processes information.",
 BODY
       end
 
-      it "replies that the API key is required" do
-        send_command("define computer")
-        expect(replies.last).to include("API key required")
-      end
-
       context "when the API key is set" do
-        before { Lita.config.handlers.wordnik.api_key = "abc123" }
+        before { registry.config.handlers.wordnik.api_key = "abc123" }
 
         it "replies with the definition" do
           send_command("define computer")
@@ -101,7 +92,7 @@ BODY
 BODY
       end
 
-      before { Lita.config.handlers.wordnik.api_key = "abc123" }
+      before { registry.config.handlers.wordnik.api_key = "abc123" }
 
       it "replies with synonyms" do
         send_command("synonyms cold")
@@ -123,7 +114,7 @@ BODY
 BODY
       end
 
-      before { Lita.config.handlers.wordnik.api_key = "abc123" }
+      before { registry.config.handlers.wordnik.api_key = "abc123" }
 
       it "replies with antonyms" do
         send_command("antonyms cold")

data/spec/spec_helper.rb

@@ -8,3 +8,5 @@ SimpleCov.start { add_filter "/spec/" }
 
 require "lita-wordnik"
 require "lita/rspec"
+
+Lita.version_3_compatibility_mode = false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-wordnik
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Jimmy Cuadra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-05 00:00:00.000000000 Z
+date: 2014-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement