lita-web-title 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 421821f95299273f112b22efbf11ba11f7846fd2
-  data.tar.gz: cdb924a05cacf32e8432aafec93fef50100f5ea2
+  metadata.gz: 60f05b4eff1085a1af11eb524681cbd79716e9ae
+  data.tar.gz: 1a529fdcf37a9ee1bf254cd25b46da3723729342
 SHA512:
-  metadata.gz: c1033c20e127de648c9465ce82a5f03cd61bc1266adf527330f0b899803a47a4e778822eabcc2198ddf3b83ef5d28c4a0bf12accf5cef9cdb8d6fdf803f9aed7
-  data.tar.gz: 9b94cc38e257cf844e83022c253b94cbe220c888160c93fc3128191a90a0c2bfd5a8170fd255caf5fed7ecffffb4a636f7fd17b9e5b985ef5ab7adaa71cbe2a6
+  metadata.gz: 8b148d683874d8194cba52441b190ca891b4f0a07d8986703b6863bbd28aadc3f1c1b2dfc8ff03f161f7897c2951799eb75378fc3390bae9047f78f320e904b0
+  data.tar.gz: 9c96a3fa27c4a975259ecd918c17280eb5f2e5c0f507e7f751d7594828024e543d0179ad97d5a1aca3ae2e7fb560efa7743e463d19b3a185c7c38260a4161da0

data/README.md

@@ -10,6 +10,14 @@ Add lita-web-title to your Lita instance's Gemfile:
 gem "lita-web-title"
 ```
 
+## Configuration
+
+### Required attributes
+None
+
+### Optional attributes
+* ```ignore_patterns``` (String or Array) - A pattern or list of patterns.  When a URL matches any of these patterns, Lita will silently ignore it.  Default: ```nil```.  Example: ```config.handlers.web_title.ignore_patterns = ["rpm.newrelic.com","example.com","my(dev|stg|prd).com"]```
+
 ## Usage
 
 ``` no-hilight

data/lib/lita/handlers/web_title.rb

@@ -12,11 +12,14 @@ module Lita
 
       def parse_uri_request(request)
         requestUri = URI::extract(request.message.body, URI_PROTOCOLS).first
-        if config.ignore_patterns.kind_of?(String) then
-          Array(config.ignore_patterns)
+        if config.ignore_patterns then
+          if config.ignore_patterns.kind_of?(String) then
+            Array(config.ignore_patterns)
+          end
+          config.ignore_patterns.each do |pattern|
+            return if requestUri.match(%r{#{pattern}})
+          end
         end
-        re = Regexp.union(%r(#{config.ignore_patterns}))
-        return if requestUri.match(re)
         result = parse_uri(requestUri)
         request.reply(result.delete("\n").strip) unless result.nil?
       end

data/lita-web-title.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name          = "lita-web-title"
-  spec.version       = "1.0.5"
+  spec.version       = "1.0.6"
   spec.authors       = ["Chris Baker"]
   spec.email         = ["dosman711@gmail.com"]
   spec.description   = "A Lita plugin to parse URIs and post the <title> of the page"

data/spec/lita/handlers/web_title_spec.rb

@@ -1,6 +1,12 @@
 require 'spec_helper'
 
 describe Lita::Handlers::WebTitle, lita_handler: true do
+  before :each do
+    registry.config.handlers.web_title.tap do |config|
+      config.ignore_patterns = ["example.com","github.com"]
+    end
+  end
+
   let(:robot) { Lita::Robot.new(registry) }
   subject(:handler) { described_class.new(robot) }
 
@@ -24,7 +30,13 @@ describe Lita::Handlers::WebTitle, lita_handler: true do
       send_command('This is the logo https://www.google.com/images/srpr/logo11w.png')
       expect(replies.last).to be_nil
     end
-  end
+
+    it 'ignores example.com links' do
+      send_command('I hate http://www.example.com/')
+      expect(replies.last).to be_nil
+    end
+
+   end
 
   describe '.parse_uri' do
     it 'returns the title' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: lita-web-title
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Chris Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-29 00:00:00.000000000 Z
+date: 2015-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lita